July 2019 - Linux-stable-mirror

[PATCH v4 0/5] Fixes for HiSilicon LPC driver and logical PIO code

by John Garry

As reported in [1], the hisi-lpc driver has certain issues in handling logical PIO regions, specifically unregistering regions. This series add a method to unregister a logical PIO region, and fixes up the driver to use them. RCU usage in logical PIO code looks to always have been broken, so that is fixed also. This is not a major fix as the list which RCU protects would be rarely modified. At this point, there are still separate ongoing discussions about how to stop the logical PIO and PCI host bridge code leaking ranges, as in [2], which I haven't had a chance to look at recently. Hopefully this series can go through the arm soc tree and the maintainers have no issue with that. I'm talking specifically about the logical PIO code, which went through PCI tree on only previous upstreaming. [1] https://lore.kernel.org/lkml/1560770148-57960-1-git-send-email-john.garry@h… [2] https://lore.kernel.org/lkml/4b24fd36-e716-7c5e-31cc-13da727802e7@huawei.co… Changes since v3: https://lore.kernel.org/lkml/1561566418-22714-1-git-send-email-john.garry@h… - drop optimisation patch (lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at registration) Not a fix - rebase to v5.3-rc2 - cc stable Change since v2: - Add hisi_lpc_acpi_remove() stub to fix build for !CONFIG_ACPI Changes since v1: - Add more reasoning in RCU fix patch - Create separate patch to change LOGIC_PIO_CPU_MMIO registration to accomodate unregistration John Garry (5): lib: logic_pio: Fix RCU usage lib: logic_pio: Avoid possible overlap for unregistering regions lib: logic_pio: Add logic_pio_unregister_range() bus: hisi_lpc: Unregister logical PIO range to avoid potential use-after-free bus: hisi_lpc: Add .remove method to avoid driver unbind crash drivers/bus/hisi_lpc.c | 47 +++++++++++++++++++++---- include/linux/logic_pio.h | 1 + lib/logic_pio.c | 73 +++++++++++++++++++++++++++++---------- 3 files changed, 96 insertions(+), 25 deletions(-) -- 2.17.1

5 years, 4 months

2
6
0 0

[PATCH v3 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

by Jian-Hong Pan

Testing with RTL8822BE hardware, when available memory is low, we frequently see a kernel panic and system freeze. First, rtw_pci_rx_isr encounters a memory allocation failure (trimmed): rx routine starvation WARNING: CPU: 7 PID: 9871 at drivers/net/wireless/realtek/rtw88/pci.c:822 rtw_pci_rx_isr.constprop.25+0x35a/0x370 [rtwpci] [ 2356.580313] RIP: 0010:rtw_pci_rx_isr.constprop.25+0x35a/0x370 [rtwpci] Then we see a variety of different error conditions and kernel panics, such as this one (trimmed): rtw_pci 0000:02:00.0: pci bus timeout, check dma status skbuff: skb_over_panic: text:00000000091b6e66 len:415 put:415 head:00000000d2880c6f data:000000007a02b1ea tail:0x1df end:0xc0 dev:<NULL> ------------[ cut here ]------------ kernel BUG at net/core/skbuff.c:105! invalid opcode: 0000 [#1] SMP NOPTI RIP: 0010:skb_panic+0x43/0x45 When skb allocation fails and the "rx routine starvation" is hit, the function returns immediately without updating the RX ring. At this point, the RX ring may continue referencing an old skb which was already handed off to ieee80211_rx_irqsafe(). When it comes to be used again, bad things happen. This patch allocates a new, data-sized skb first in RX ISR. After copying the data in, we pass it to the upper layers. However, if skb allocation fails, we effectively drop the frame. In both cases, the original, full size ring skb is reused. In addition, by fixing the kernel crash, the RX routine should now generally behave better under low memory conditions. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053 Signed-off-by: Jian-Hong Pan <jian-hong(a)endlessm.com> Cc: <stable(a)vger.kernel.org> --- v2: - Allocate new data-sized skb and put data into it, then pass it to mac80211. Reuse the original skb in RX ring by DMA sync. - Modify the commit message. - Introduce following [PATCH v3 2/2] rtw88: pci: Use DMA sync instead of remapping in RX ISR. v3: - Same as v2. drivers/net/wireless/realtek/rtw88/pci.c | 49 +++++++++++------------- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c index cfe05ba7280d..e9fe3ad896c8 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.c +++ b/drivers/net/wireless/realtek/rtw88/pci.c @@ -763,6 +763,7 @@ static void rtw_pci_rx_isr(struct rtw_dev *rtwdev, struct rtw_pci *rtwpci, u32 pkt_offset; u32 pkt_desc_sz = chip->rx_pkt_desc_sz; u32 buf_desc_sz = chip->rx_buf_desc_sz; + u32 new_len; u8 *rx_desc; dma_addr_t dma; @@ -790,40 +791,34 @@ static void rtw_pci_rx_isr(struct rtw_dev *rtwdev, struct rtw_pci *rtwpci, pkt_offset = pkt_desc_sz + pkt_stat.drv_info_sz + pkt_stat.shift; - if (pkt_stat.is_c2h) { - /* keep rx_desc, halmac needs it */ - skb_put(skb, pkt_stat.pkt_len + pkt_offset); + /* discard current skb if the new skb cannot be allocated as a + * new one in rx ring later + */ + new_len = pkt_stat.pkt_len + pkt_offset; + new = dev_alloc_skb(new_len); + if (WARN_ONCE(!new, "rx routine starvation\n")) + goto next_rp; + + /* put the DMA data including rx_desc from phy to new skb */ + skb_put_data(new, skb->data, new_len); - /* pass offset for further operation */ - *((u32 *)skb->cb) = pkt_offset; - skb_queue_tail(&rtwdev->c2h_queue, skb); + if (pkt_stat.is_c2h) { + /* pass rx_desc & offset for further operation */ + *((u32 *)new->cb) = pkt_offset; + skb_queue_tail(&rtwdev->c2h_queue, new); ieee80211_queue_work(rtwdev->hw, &rtwdev->c2h_work); } else { - /* remove rx_desc, maybe use skb_pull? */ - skb_put(skb, pkt_stat.pkt_len); - skb_reserve(skb, pkt_offset); - - /* alloc a smaller skb to mac80211 */ - new = dev_alloc_skb(pkt_stat.pkt_len); - if (!new) { - new = skb; - } else { - skb_put_data(new, skb->data, skb->len); - dev_kfree_skb_any(skb); - } - /* TODO: merge into rx.c */ - rtw_rx_stats(rtwdev, pkt_stat.vif, skb); + /* remove rx_desc */ + skb_pull(new, pkt_offset); + + rtw_rx_stats(rtwdev, pkt_stat.vif, new); memcpy(new->cb, &rx_status, sizeof(rx_status)); ieee80211_rx_irqsafe(rtwdev->hw, new); } - /* skb delivered to mac80211, alloc a new one in rx ring */ - new = dev_alloc_skb(RTK_PCI_RX_BUF_SIZE); - if (WARN(!new, "rx routine starvation\n")) - return; - - ring->buf[cur_rp] = new; - rtw_pci_reset_rx_desc(rtwdev, new, ring, cur_rp, buf_desc_sz); +next_rp: + /* new skb delivered to mac80211, re-enable original skb DMA */ + rtw_pci_reset_rx_desc(rtwdev, skb, ring, cur_rp, buf_desc_sz); /* host read next element in ring */ if (++cur_rp >= ring->r.len) -- 2.22.0

5 years, 4 months

4
9
0 0

[PATCH 4.19 000/113] 4.19.63-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.63 release. There are 113 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed 31 Jul 2019 07:05:01 PM UTC. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.63-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.63-rc1 Linus Torvalds <torvalds(a)linux-foundation.org> access: avoid the RCU grace period for the temporary subjective credentials Dan Williams <dan.j.williams(a)intel.com> libnvdimm/bus: Stop holding nvdimm_bus_list_mutex over __nd_ioctl() Michael Neuling <mikey(a)neuling.org> powerpc/tm: Fix oops on sigreturn on systems without TM Gautham R. Shenoy <ego(a)linux.vnet.ibm.com> powerpc/xive: Fix loop exit-condition in xive_find_target_in_mask() Hui Wang <hui.wang(a)canonical.com> ALSA: hda - Add a conexant codec entry to let mute led work Kai-Heng Feng <kai.heng.feng(a)canonical.com> ALSA: line6: Fix wrong altsetting for LINE6_PODHD500_1 Ding Xiang <dingxiang(a)cmss.chinamobile.com> ALSA: ac97: Fix double free of ac97_codec_device Kefeng Wang <wangkefeng.wang(a)huawei.com> hpet: Fix division by zero in hpet_time_div() Alexander Usyskin <alexander.usyskin(a)intel.com> mei: me: add mule creek canyon (EHL) device ids YueHaibing <yuehaibing(a)huawei.com> fpga-manager: altera-ps-spi: Fix build error Hridya Valsaraju <hridya(a)google.com> binder: prevent transactions to context manager from its own process. Zhenzhong Duan <zhenzhong.duan(a)oracle.com> x86/speculation/mds: Apply more accurate check on hypervisor platform Hans de Goede <hdegoede(a)redhat.com> x86/sysfb_efi: Add quirks for some devices with swapped width and height Qu Wenruo <wqu(a)suse.com> btrfs: inode: Don't compress if NODATASUM or NODATACOW set Ryan Kennedy <ryan5544(a)gmail.com> usb: pci-quirks: Correct AMD PLL quirk detection Phong Tran <tranmanphong(a)gmail.com> usb: wusbcore: fix unbalanced get/put cluster_id Arnd Bergmann <arnd(a)arndb.de> locking/lockdep: Hide unused 'class' variable Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> mm: use down_read_killable for locking mmap_sem in access_remote_vm Yuyang Du <duyuyang(a)gmail.com> locking/lockdep: Fix lock used or unused stats error Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> proc: use down_read_killable mmap_sem for /proc/pid/maps Arnd Bergmann <arnd(a)arndb.de> cxgb4: reduce kernel stack usage in cudbg_collect_mem_region() Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> proc: use down_read_killable mmap_sem for /proc/pid/map_files Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> proc: use down_read_killable mmap_sem for /proc/pid/clear_refs Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> proc: use down_read_killable mmap_sem for /proc/pid/pagemap Konstantin Khlebnikov <khlebnikov(a)yandex-team.ru> proc: use down_read_killable mmap_sem for /proc/pid/smaps_rollup Jean-Philippe Brucker <jean-philippe.brucker(a)arm.com> mm/mmu_notifier: use hlist_add_head_rcu() Shakeel Butt <shakeelb(a)google.com> memcg, fsnotify: no oom-kill for remote memcg charging Andy Lutomirski <luto(a)kernel.org> mm/gup.c: remove some BUG_ONs from get_gate_page() Guenter Roeck <linux(a)roeck-us.net> mm/gup.c: mark undo_dev_pagemap as __maybe_unused Christoph Hellwig <hch(a)lst.de> 9p: pass the correct prototype to read_cache_page Dmitry Vyukov <dvyukov(a)google.com> mm/kmemleak.c: fix check for softirq context Sam Ravnborg <sam(a)ravnborg.org> sh: prevent warnings when using iounmap Wenwen Wang <wenwen(a)cs.uga.edu> block/bio-integrity: fix a memory leak bug Oliver O'Halloran <oohall(a)gmail.com> powerpc/eeh: Handle hugepages in ioremap space David Windsor <dwindsor(a)redhat.com> dlm: check if workqueues are NULL before flushing/destroying morten petersen <morten_bp(a)live.dk> mailbox: handle failed named mailbox channel request Ocean Chen <oceanchen(a)google.com> f2fs: avoid out-of-range memory access Josef Bacik <josef(a)toxicpanda.com> block: init flush rq ref count to 1 Masahiro Yamada <yamada.masahiro(a)socionext.com> powerpc/boot: add {get, put}_unaligned_be32 to xz_config.h YueHaibing <yuehaibing(a)huawei.com> PCI: dwc: pci-dra7xx: Fix compilation when !CONFIG_GPIOLIB Konstantin Taranov <konstantin.taranov(a)inf.ethz.ch> RDMA/rxe: Fill in wc byte_len with IB_WC_RECV_RDMA_WITH_IMM Leo Yan <leo.yan(a)linaro.org> perf hists browser: Fix potential NULL pointer dereference found by the smatch tool Leo Yan <leo.yan(a)linaro.org> perf annotate: Fix dereferencing freed memory found by the smatch tool Leo Yan <leo.yan(a)linaro.org> perf session: Fix potential NULL pointer dereference found by the smatch tool Leo Yan <leo.yan(a)linaro.org> perf top: Fix potential NULL pointer dereference detected by the smatch tool Leo Yan <leo.yan(a)linaro.org> perf stat: Fix use-after-freed pointer detected by the smatch tool Numfor Mbiziwo-Tiapo <nums(a)google.com> perf test mmap-thread-lookup: Initialize variable to suppress memory sanitizer warning Hou Zhiqiang <Zhiqiang.Hou(a)nxp.com> PCI: mobiveil: Use the 1st inbound window for MEM inbound transactions Hou Zhiqiang <Zhiqiang.Hou(a)nxp.com> PCI: mobiveil: Initialize Primary/Secondary/Subordinate bus numbers Vasily Gorbik <gor(a)linux.ibm.com> kallsyms: exclude kasan local symbols on s390 Hou Zhiqiang <Zhiqiang.Hou(a)nxp.com> PCI: mobiveil: Fix the Class Code field Hou Zhiqiang <Zhiqiang.Hou(a)nxp.com> PCI: mobiveil: Fix PCI base address in MEM/IO outbound windows James Morse <james.morse(a)arm.com> arm64: assembler: Switch ESB-instruction with a vanilla nop if !ARM64_HAS_RAS Valentine Fatiev <valentinef(a)mellanox.com> IB/ipoib: Add child to parent list only if device initialized Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> powerpc/mm: Handle page table allocation failures Parav Pandit <parav(a)mellanox.com> IB/mlx5: Fixed reporting counters on 2nd port for Dual port RoCE Geert Uytterhoeven <geert+renesas(a)glider.be> serial: sh-sci: Fix TX DMA buffer flushing and workqueue races Geert Uytterhoeven <geert+renesas(a)glider.be> serial: sh-sci: Terminate TX DMA during buffer flushing Liu, Changcheng <changcheng.liu(a)intel.com> RDMA/i40iw: Set queue pair state when being queried Christian Lamparter <chunkeey(a)gmail.com> powerpc/4xx/uic: clear pending interrupt after irq type/pol change Johannes Berg <johannes.berg(a)intel.com> um: Silence lockdep complaint about mmap_sem Ira Weiny <ira.weiny(a)intel.com> mm/swap: fix release_pages() when releasing devmap pages Axel Lin <axel.lin(a)ingics.com> mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Arnd Bergmann <arnd(a)arndb.de> mfd: arizona: Fix undefined behavior Robert Hancock <hancock(a)sedsystems.ca> mfd: core: Set fwnode for created devices Daniel Gomez <dagmcr(a)gmail.com> mfd: madera: Add missing of table registration Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com> recordmcount: Fix spurious mcount entries on powerpc Naveen N. Rao <naveen.n.rao(a)linux.vnet.ibm.com> powerpc/xmon: Fix disabling tracing while in xmon Qian Cai <cai(a)lca.pw> powerpc/cacheflush: fix variable set but not used Bastien Nocera <hadess(a)hadess.net> iio: iio-utils: Fix possible incorrect mask calculation Bharat Kumar Gogada <bharat.kumar.gogada(a)xilinx.com> PCI: xilinx-nwl: Fix Multi MSI data programming Will Deacon <will.deacon(a)arm.com> genksyms: Teach parser about 128-bit built-in types Nathan Chancellor <natechancellor(a)gmail.com> kbuild: Add -Werror=unknown-warning-option to CLANG_FLAGS Fabrice Gasnier <fabrice.gasnier(a)st.com> i2c: stm32f7: fix the get_irq error cases Marek Vasut <marek.vasut+renesas(a)gmail.com> PCI: sysfs: Ignore lockdep for remove attribute Stefan Roese <sr(a)denx.de> serial: mctrl_gpio: Check if GPIO property exisits before requesting it Sean Paul <seanpaul(a)chromium.org> drm/msm: Depopulate platform on probe failure Alexey Kardashevskiy <aik(a)ozlabs.ru> powerpc/pci/of: Fix OF flags parsing for 64bit BARs Raul E Rangel <rrangel(a)chromium.org> mmc: sdhci: sdhci-pci-o2micro: Check if controller supports 8-bit width Andrzej Pietrasiewicz <andrzej.p(a)collabora.com> usb: gadget: Zero ffs_io_data Serge Semin <fancer.lancer(a)gmail.com> tty: serial_core: Set port active bit in uart_port_activate Sergey Organov <sorganov(a)gmail.com> serial: imx: fix locking in set_termios() Douglas Anderson <dianders(a)chromium.org> drm/rockchip: Properly adjust to a true clock in adjusted_mode Nathan Lynch <nathanl(a)linux.ibm.com> powerpc/pseries/mobility: prevent cpu hotplug during DT update Hariprasad Kelam <hariprasad.kelam(a)gmail.com> drm/amd/display: fix compilation error Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> phy: renesas: rcar-gen2: Fix memory leak at error paths David Riley <davidriley(a)chromium.org> drm/virtio: Add memory barriers for capset cache. Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> drm/amd/display: Always allocate initial connector state state Rautkoski Kimmo EXT <ext-kimmo.rautkoski(a)vaisala.com> serial: 8250: Fix TX interrupt handling condition Jorge Ramirez-Ortiz <jorge.ramirez-ortiz(a)linaro.org> tty: serial: msm_serial: avoid system lockup condition Kefeng Wang <wangkefeng.wang(a)huawei.com> tty/serial: digicolor: Fix digicolor-usart already registered warning Wang Hai <wanghai26(a)huawei.com> memstick: Fix error cleanup path of memstick_init Daniel Vetter <daniel.vetter(a)ffwll.ch> drm/crc-debugfs: Also sprinkle irqrestore over early exits Daniel Vetter <daniel.vetter(a)ffwll.ch> drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry Thierry Reding <treding(a)nvidia.com> gpu: host1x: Increase maximum DMA segment size Jyri Sarha <jsarha(a)ti.com> drm/bridge: sii902x: pixel clock unit is 10kHz instead of 1kHz Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/bridge: tc358767: read display_props in get_modes() Alex Williamson <alex.williamson(a)redhat.com> PCI: Return error if cannot probe VF Gen Zhang <blackgod016574(a)gmail.com> drm/edid: Fix a missing-check bug in drm_load_edid_firmware() Oak Zeng <Oak.Zeng(a)amd.com> drm/amdkfd: Fix sdma queue map issue Oak Zeng <ozeng(a)amd.com> drm/amdkfd: Fix a potential memory leak Paul Hsieh <paul.hsieh(a)amd.com> drm/amd/display: Disable ABM before destroy ABM struct Tiecheng Zhou <Tiecheng.Zhou(a)amd.com> drm/amdgpu/sriov: Need to initialize the HDP_NONSURFACE_BAStE Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> drm/amd/display: Fill prescale_params->scale for RGB565 Christophe Leroy <christophe.leroy(a)c-s.fr> tty: serial: cpm_uart - fix init when SMC is relocated Wen Yang <wen.yang99(a)zte.com.cn> pinctrl: rockchip: fix leaked of_node references Serge Semin <fancer.lancer(a)gmail.com> tty: max310x: Fix invalid baudrate divisors calculator Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: core: hub: Disable hub-initiated U1/U2 Quentin Deslandes <quentin.deslandes(a)itdev.co.uk> staging: vt6656: use meaningful error code during buffer allocation Fabien Dessenne <fabien.dessenne(a)st.com> iio: adc: stm32-dfsdm: missing error case during probe Fabien Dessenne <fabien.dessenne(a)st.com> iio: adc: stm32-dfsdm: manage the get_irq error case Peter Ujfalusi <peter.ujfalusi(a)ti.com> drm/panel: simple: Fix panel_simple_dsi_probe Sunil Muthuswamy <sunilmut(a)microsoft.com> hvsock: fix epollout hang from race condition ------------- Diffstat: Makefile | 5 +- arch/arm64/include/asm/assembler.h | 4 + arch/powerpc/boot/xz_config.h | 20 +++++ arch/powerpc/include/asm/cacheflush.h | 7 +- arch/powerpc/kernel/eeh.c | 15 +++- arch/powerpc/kernel/pci_of_scan.c | 2 + arch/powerpc/kernel/signal_32.c | 3 + arch/powerpc/kernel/signal_64.c | 5 ++ arch/powerpc/mm/hugetlbpage.c | 8 ++ arch/powerpc/platforms/4xx/uic.c | 1 + arch/powerpc/platforms/pseries/mobility.c | 9 ++ arch/powerpc/sysdev/xive/common.c | 7 +- arch/powerpc/xmon/xmon.c | 6 +- arch/sh/include/asm/io.h | 6 +- arch/um/include/asm/mmu_context.h | 2 +- arch/x86/kernel/cpu/bugs.c | 2 +- arch/x86/kernel/sysfb_efi.c | 46 +++++++++++ block/bio-integrity.c | 8 +- block/blk-core.c | 1 + drivers/android/binder.c | 2 +- drivers/char/hpet.c | 3 +- drivers/fpga/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 + .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 21 +++-- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v9.c | 5 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++- drivers/gpu/drm/amd/display/dc/dce/dce_abm.c | 2 + .../amd/display/dc/dce110/dce110_hw_sequencer.c | 3 + .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + drivers/gpu/drm/bridge/sii902x.c | 5 +- drivers/gpu/drm/bridge/tc358767.c | 7 ++ drivers/gpu/drm/drm_debugfs_crc.c | 9 +- drivers/gpu/drm/drm_edid_load.c | 2 + drivers/gpu/drm/msm/msm_drv.c | 14 +++- drivers/gpu/drm/panel/panel-simple.c | 9 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 3 + drivers/gpu/drm/virtio/virtgpu_vq.c | 2 + drivers/gpu/host1x/bus.c | 3 + drivers/i2c/busses/i2c-stm32f7.c | 26 +++--- drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++ drivers/iio/adc/stm32-dfsdm-core.c | 8 +- drivers/infiniband/hw/i40iw/i40iw_verbs.c | 2 + drivers/infiniband/hw/mlx5/mad.c | 60 ++++++++------ drivers/infiniband/sw/rxe/rxe_resp.c | 5 +- drivers/infiniband/sw/rxe/rxe_verbs.h | 1 + drivers/infiniband/ulp/ipoib/ipoib_main.c | 34 ++++---- drivers/mailbox/mailbox.c | 6 +- drivers/memstick/core/memstick.c | 13 ++- drivers/mfd/arizona-core.c | 2 +- drivers/mfd/hi655x-pmic.c | 2 + drivers/mfd/madera-core.c | 1 + drivers/mfd/mfd-core.c | 1 + drivers/misc/mei/hw-me-regs.h | 3 + drivers/misc/mei/pci-me.c | 3 + drivers/mmc/host/sdhci-pci-o2micro.c | 12 ++- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 19 +++-- drivers/nvdimm/bus.c | 96 +++++++++++++--------- drivers/nvdimm/nd-core.h | 3 +- drivers/pci/controller/dwc/pci-dra7xx.c | 1 + drivers/pci/controller/pcie-mobiveil.c | 22 +++-- drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++- drivers/pci/pci-driver.c | 13 +-- drivers/pci/pci-sysfs.c | 2 +- drivers/phy/renesas/phy-rcar-gen2.c | 2 + drivers/pinctrl/pinctrl-rockchip.c | 1 + drivers/staging/vt6656/main_usb.c | 42 ++++++---- drivers/tty/serial/8250/8250_port.c | 3 +- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 17 ++-- drivers/tty/serial/digicolor-usart.c | 6 +- drivers/tty/serial/imx.c | 23 +++--- drivers/tty/serial/max310x.c | 51 +++++++----- drivers/tty/serial/msm_serial.c | 4 + drivers/tty/serial/serial_core.c | 7 +- drivers/tty/serial/serial_mctrl_gpio.c | 14 ++++ drivers/tty/serial/sh-sci.c | 33 ++++++-- drivers/usb/core/hub.c | 28 ++++--- drivers/usb/gadget/function/f_fs.c | 6 +- drivers/usb/host/hwa-hc.c | 2 +- drivers/usb/host/pci-quirks.c | 31 ++++--- fs/9p/vfs_addr.c | 6 +- fs/btrfs/inode.c | 24 +++++- fs/dlm/lowcomms.c | 18 ++-- fs/f2fs/segment.c | 5 ++ fs/notify/fanotify/fanotify.c | 5 +- fs/notify/inotify/inotify_fsnotify.c | 8 +- fs/open.c | 19 +++++ fs/proc/base.c | 28 +++++-- fs/proc/task_mmu.c | 23 ++++-- fs/proc/task_nommu.c | 6 +- include/linux/cred.h | 7 +- include/linux/host1x.h | 2 + kernel/cred.c | 21 ++++- kernel/locking/lockdep_proc.c | 8 +- mm/gup.c | 12 ++- mm/kmemleak.c | 2 +- mm/memory.c | 4 +- mm/mmu_notifier.c | 2 +- mm/nommu.c | 3 +- mm/swap.c | 13 ++- net/vmw_vsock/hyperv_transport.c | 44 +++------- scripts/genksyms/keywords.c | 4 + scripts/genksyms/parse.y | 2 + scripts/kallsyms.c | 3 + scripts/recordmcount.h | 3 +- sound/ac97/bus.c | 13 +-- sound/pci/hda/patch_conexant.c | 1 + sound/usb/line6/podhd.c | 2 +- tools/iio/iio_utils.c | 4 +- tools/perf/builtin-stat.c | 2 +- tools/perf/builtin-top.c | 8 +- tools/perf/tests/mmap-thread-lookup.c | 2 +- tools/perf/ui/browsers/hists.c | 15 +++- tools/perf/util/annotate.c | 6 +- tools/perf/util/session.c | 3 + 115 files changed, 856 insertions(+), 359 deletions(-)

5 years, 4 months

10
126
0 0

[PATCH] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

by Yoshihiro Shimoda

Since the role_store() uses strncmp(), it's possible to refer out-of-memory if the sysfs data size is smaller than strlen("host"). This patch fixes it by using sysfs_streq() instead of strncmp(). Reported-by: Pavel Machek <pavel(a)denx.de> Fixes: 9bb86777fb71 ("phy: rcar-gen3-usb2: add sysfs for usb role swap") Cc: <stable(a)vger.kernel.org> # v4.10+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> --- Just a record. The role_store() doesn't need to check the count because the sysfs_streq() checks the first argument is NULL or not. On "if (sysfs_streq(buf, "host"))" Example 1: echo ho > role --> In this case, the count is 3 and the buf has "ho" + NULL. So, the third character differs between NULL and 's'. Example 2: echo host-is-not-used > role --> In this case, the count is 17 and the buf has "host-is-not-used" + NULL. So, the fifth character differs between '-' and NULL. drivers/phy/renesas/phy-rcar-gen3-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 1322185..cc18970 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -20,6 +20,7 @@ #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/regulator/consumer.h> +#include <linux/string.h> #include <linux/usb/of.h> #include <linux/workqueue.h> @@ -317,9 +318,9 @@ static ssize_t role_store(struct device *dev, struct device_attribute *attr, if (!ch->is_otg_channel || !rcar_gen3_is_any_rphy_initialized(ch)) return -EIO; - if (!strncmp(buf, "host", strlen("host"))) + if (sysfs_streq(buf, "host")) new_mode = PHY_MODE_USB_HOST; - else if (!strncmp(buf, "peripheral", strlen("peripheral"))) + else if (sysfs_streq(buf, "peripheral")) new_mode = PHY_MODE_USB_DEVICE; else return -EINVAL; -- 2.7.4

5 years, 4 months

3
4
0 0

[PATCH] mmc: core: Prevent processing SDIO IRQs when the card is suspended

by Ulf Hansson

Processing of SDIO IRQs must obviously be prevented while the card is system suspended, otherwise we may end up trying to communicate with an uninitialized SDIO card. Reports throughout the years shows that this is not only a theoretical problem, but a real issue. So, let's finally fix this problem, by keeping track of the state for the card and bail out before processing the SDIO IRQ, in case the card is suspended. Cc: stable(a)vger.kernel.org Reported-by: Douglas Anderson <dianders(a)chromium.org> Signed-off-by: Ulf Hansson <ulf.hansson(a)linaro.org> --- This has only been compile tested so far, any help for real test on HW is greatly appreciated. Note that, this is only the initial part of what is needed to make power management of SDIO card more robust, but let's start somewhere and continue to improve things. The next step I am looking at right now, is to make sure the SDIO IRQ is turned off during system suspend, unless it's supported as a system wakeup (and enabled to be used). --- drivers/mmc/core/sdio.c | 7 +++++++ drivers/mmc/core/sdio_irq.c | 4 ++++ 2 files changed, 11 insertions(+) diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c index d1aa1c7577bb..9951295d3220 100644 --- a/drivers/mmc/core/sdio.c +++ b/drivers/mmc/core/sdio.c @@ -937,6 +937,10 @@ static int mmc_sdio_pre_suspend(struct mmc_host *host) */ static int mmc_sdio_suspend(struct mmc_host *host) { + /* Prevent processing of SDIO IRQs in suspended state. */ + mmc_card_set_suspended(host->card); + cancel_delayed_work_sync(&host->sdio_irq_work); + mmc_claim_host(host); if (mmc_card_keep_power(host) && mmc_card_wake_sdio_irq(host)) @@ -985,6 +989,9 @@ static int mmc_sdio_resume(struct mmc_host *host) err = sdio_enable_4bit_bus(host->card); } + /* Allow SDIO IRQs to be processed again. */ + mmc_card_clr_suspended(host->card); + if (!err && host->sdio_irqs) { if (!(host->caps2 & MMC_CAP2_SDIO_IRQ_NOTHREAD)) wake_up_process(host->sdio_irq_thread); diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c index 931e6226c0b3..9f54a259a1b3 100644 --- a/drivers/mmc/core/sdio_irq.c +++ b/drivers/mmc/core/sdio_irq.c @@ -34,6 +34,10 @@ static int process_sdio_pending_irqs(struct mmc_host *host) unsigned char pending; struct sdio_func *func; + /* Don't process SDIO IRQs if the card is suspended. */ + if (mmc_card_suspended(card)) + return 0; + /* * Optimization, if there is only 1 function interrupt registered * and we know an IRQ was signaled then call irq handler directly. -- 2.17.1

5 years, 4 months

3
7
0 0

[PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

by Andrew Donnellan

Currently the OPAL symbol map is globally readable, which seems bad as it contains physical addresses. Restrict it to root. Suggested-by: Michael Ellerman <mpe(a)ellerman.id.au> Cc: Jordan Niethe <jniethe5(a)gmail.com> Cc: Stewart Smith <stewart(a)linux.ibm.com> Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") Cc: stable(a)vger.kernel.org Signed-off-by: Andrew Donnellan <ajd(a)linux.ibm.com> --- v1->v2: - fix tabs vs spaces (Greg) --- arch/powerpc/platforms/powernv/opal.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c index 2b0eca104f86..0582a02623d0 100644 --- a/arch/powerpc/platforms/powernv/opal.c +++ b/arch/powerpc/platforms/powernv/opal.c @@ -681,7 +681,10 @@ static ssize_t symbol_map_read(struct file *fp, struct kobject *kobj, bin_attr->size); } -static BIN_ATTR_RO(symbol_map, 0); +static struct bin_attribute symbol_map_attr = { + .attr = {.name = "symbol_map", .mode = 0400}, + .read = symbol_map_read +}; static void opal_export_symmap(void) { @@ -698,10 +701,10 @@ static void opal_export_symmap(void) return; /* Setup attributes */ - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0])); - bin_attr_symbol_map.size = be64_to_cpu(syms[1]); + symbol_map_attr.private = __va(be64_to_cpu(syms[0])); + symbol_map_attr.size = be64_to_cpu(syms[1]); - rc = sysfs_create_bin_file(opal_kobj, &bin_attr_symbol_map); + rc = sysfs_create_bin_file(opal_kobj, &symbol_map_attr); if (rc) pr_warn("Error %d creating OPAL symbols file\n", rc); } -- 2.20.1

5 years, 4 months

4
7
0 0

[PATCH 1/2] perf/record: Fix module size on s390

by Thomas Richter

On s390 the modules loaded in memory have the text segment located after the GOT and Relocation table. This can be seen with this output: [root@m35lp76 perf]# fgrep qeth /proc/modules qeth 151552 1 qeth_l2, Live 0x000003ff800b2000 ... [root@m35lp76 perf]# cat /sys/module/qeth/sections/.text 0x000003ff800b3990 [root@m35lp76 perf]# There is an offset of 0x1990 bytes. The size of the qeth module is 151552 bytes (0x25000 in hex). The location of the GOT/relocation table at the beginning of a module is unique to s390. commit 203d8a4aa6ed ("perf s390: Fix 'start' address of module's map") adjusts the start address of a module in the map structures, but does not adjust the size of the modules. This leads to overlapping of module maps as this example shows: [root@m35lp76 perf] # ./perf report -D 0 0 0xfb0 [0xa0]: PERF_RECORD_MMAP -1/0: [0x3ff800b3990(0x25000) @ 0]: x /lib/modules/.../qeth.ko.xz 0 0 0x1050 [0xb0]: PERF_RECORD_MMAP -1/0: [0x3ff800d85a0(0x8000) @ 0]: x /lib/modules/.../ip6_tables.ko.xz The module qeth.ko has an adjusted start address modified to b3990, but its size is unchanged and the module ends at 0x3ff800d8990. This end address overlaps with the next modules start address of 0x3ff800d85a0. When the size of the leading GOT/Relocation table stored in the beginning of the text segment (0x1990 bytes) is subtracted from module qeth end address, there are no overlaps anymore: 0x3ff800d8990 - 0x1990 = 0x0x3ff800d7000 which is the same as 0x3ff800b2000 + 0x25000 = 0x0x3ff800d7000. To fix this issue, also adjust the modules size in function arch__fix_module_text_start(). Add another function parameter named size and reduce the size of the module when the text segment start address is changed. Output after: 0 0 0xfb0 [0xa0]: PERF_RECORD_MMAP -1/0: [0x3ff800b3990(0x23670) @ 0]: x /lib/modules/.../qeth.ko.xz 0 0 0x1050 [0xb0]: PERF_RECORD_MMAP -1/0: [0x3ff800d85a0(0x7a60) @ 0]: x /lib/modules/.../ip6_tables.ko.xz Fixes: 203d8a4aa6ed ("perf s390: Fix 'start' address of module's map") Cc: <stable(a)vger.kernel.org> # v4.9+ Reported-by: Stefan Liebler <stli(a)linux.ibm.com> Signed-off-by: Thomas Richter <tmricht(a)linux.ibm.com> Acked-by: Heiko Carstens <heiko.carstens(a)de.ibm.com> --- tools/perf/arch/s390/util/machine.c | 14 +++++++++++++- tools/perf/util/machine.c | 3 ++- tools/perf/util/machine.h | 2 +- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/perf/arch/s390/util/machine.c b/tools/perf/arch/s390/util/machine.c index a19690a17291..de26b1441a48 100644 --- a/tools/perf/arch/s390/util/machine.c +++ b/tools/perf/arch/s390/util/machine.c @@ -7,7 +7,7 @@ #include "api/fs/fs.h" #include "debug.h" -int arch__fix_module_text_start(u64 *start, const char *name) +int arch__fix_module_text_start(u64 *start, u64 *size, const char *name) { u64 m_start = *start; char path[PATH_MAX]; @@ -17,6 +17,18 @@ int arch__fix_module_text_start(u64 *start, const char *name) if (sysfs__read_ull(path, (unsigned long long *)start) < 0) { pr_debug2("Using module %s start:%#lx\n", path, m_start); *start = m_start; + } else { + /* Successful read of the modules segment text start address. + * Calculate difference between module start address + * in memory and module text segment start address. + * For example module load address is 0x3ff8011b000 + * (from /proc/modules) and module text segment start + * address is 0x3ff8011b870 (from file above). + * + * Adjust the module size and subtract the GOT table + * size located at the beginning of the module. + */ + *size -= (*start - m_start); } return 0; diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index dc7aafe45a2b..081fe4bdebaa 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1365,6 +1365,7 @@ static int machine__set_modules_path(struct machine *machine) return map_groups__set_modules_path_dir(&machine->kmaps, modules_path, 0); } int __weak arch__fix_module_text_start(u64 *start __maybe_unused, + u64 *size __maybe_unused, const char *name __maybe_unused) { return 0; @@ -1376,7 +1377,7 @@ static int machine__create_module(void *arg, const char *name, u64 start, struct machine *machine = arg; struct map *map; - if (arch__fix_module_text_start(&start, name) < 0) + if (arch__fix_module_text_start(&start, &size, name) < 0) return -1; map = machine__findnew_module_map(machine, start, name); diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h index f70ab98a7bde..7aa38da26427 100644 --- a/tools/perf/util/machine.h +++ b/tools/perf/util/machine.h @@ -222,7 +222,7 @@ struct symbol *machine__find_kernel_symbol_by_name(struct machine *machine, struct map *machine__findnew_module_map(struct machine *machine, u64 start, const char *filename); -int arch__fix_module_text_start(u64 *start, const char *name); +int arch__fix_module_text_start(u64 *start, u64 *size, const char *name); int machine__load_kallsyms(struct machine *machine, const char *filename); -- 2.21.0

5 years, 4 months

2
3
0 0

[PATCH v3] usb: dwc3: gadget: trb_dequeue is not updated properly

by fei.yang＠intel.com

From: Fei Yang <fei.yang(a)intel.com> If scatter-gather operation is allowed, a large USB request is split into multiple TRBs. These TRBs are chained up by setting DWC3_TRB_CTRL_CHN bit except the last one which has DWC3_TRB_CTRL_IOC bit set instead. Since only the last TRB has IOC set for the whole USB request, the dwc3_gadget_ep_reclaim_trb_sg() gets called only once after the last TRB completes and all the TRBs allocated for this request are supposed to be reclaimed. However that is not what the current code does. dwc3_gadget_ep_reclaim_trb_sg() is trying to reclaim all the TRBs in the following for-loop, for_each_sg(sg, s, pending, i) { trb = &dep->trb_pool[dep->trb_dequeue]; if (trb->ctrl & DWC3_TRB_CTRL_HWO) break; req->sg = sg_next(s); req->num_pending_sgs--; ret = dwc3_gadget_ep_reclaim_completed_trb(dep, req, trb, event, status, chain); if (ret) break; } but since the interrupt comes only after the last TRB completes, the event->status has DEPEVT_STATUS_IOC bit set, so that the for-loop ends for the first TRB due to dwc3_gadget_ep_reclaim_completed_trb() returns 1. if (event->status & DEPEVT_STATUS_IOC) return 1; This patch addresses the issue by checking each TRB in function dwc3_gadget_ep_reclaim_trb_sg() and maing sure the chained ones are properly reclaimed. dwc3_gadget_ep_reclaim_completed_trb() will return 1 Only for the last TRB. Signed-off-by: Fei Yang <fei.yang(a)intel.com> Cc: stable <stable(a)vger.kernel.org> --- v2: Better solution is to reclaim chained TRBs in dwc3_gadget_ep_reclaim_trb_sg() and leave the last TRB to the dwc3_gadget_ep_reclaim_completed_trb(). v3: Checking DWC3_TRB_CTRL_CHN bit for each TRB instead, and making sure that dwc3_gadget_ep_reclaim_completed_trb() returns 1 only for the last TRB. --- drivers/usb/dwc3/gadget.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 173f532..88eed49 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2394,7 +2394,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep, if (event->status & DEPEVT_STATUS_SHORT && !chain) return 1; - if (event->status & DEPEVT_STATUS_IOC) + if (event->status & DEPEVT_STATUS_IOC && !chain) return 1; return 0; @@ -2404,11 +2404,12 @@ static int dwc3_gadget_ep_reclaim_trb_sg(struct dwc3_ep *dep, struct dwc3_request *req, const struct dwc3_event_depevt *event, int status) { - struct dwc3_trb *trb = &dep->trb_pool[dep->trb_dequeue]; + struct dwc3_trb *trb; struct scatterlist *sg = req->sg; struct scatterlist *s; unsigned int pending = req->num_pending_sgs; unsigned int i; + int chain = false; int ret = 0; for_each_sg(sg, s, pending, i) { @@ -2419,9 +2420,13 @@ static int dwc3_gadget_ep_reclaim_trb_sg(struct dwc3_ep *dep, req->sg = sg_next(s); req->num_pending_sgs--; + if (trb->ctrl & DWC3_TRB_CTRL_CHN) + chain = true; + else + chain = false; ret = dwc3_gadget_ep_reclaim_completed_trb(dep, req, - trb, event, status, true); + trb, event, status, chain); if (ret) break; } -- 2.7.4

5 years, 4 months

5
7
0 0

[PATCH V2] PCI: set BAR size bits correctly in Resize BAR control register

by Sumit Saxena

In Resize BAR control register, bits[8:12] represents size of BAR. As per PCIe specification, below is encoded values in register bits to actual BAR size table: Bits BAR size 0 1 MB 1 2 MB 2 4 MB 3 8 MB -- For 1 MB BAR size, BAR size bits should be set to 0 but incorrectly these bits are set to "1f". Latest megaraid_sas and mpt3sas adapters which support Resizable BAR with 1 MB BAR size fails to initialize during system resume from S3 sleep. Fix: Correctly calculate BAR size bits for Resize BAR control register. V2: -Simplified calculation of BAR size bits as suggested by Christian Koenig. CC: stable(a)vger.kernel.org # v4.16+ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203939 Fixes: d3252ace0bc652a1a244455556b6a549f969bf99 ("PCI: Restore resized BAR state on resume") Signed-off-by: Sumit Saxena <sumit.saxena(a)broadcom.com> --- drivers/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 29ed5ec1ac27..e59921296125 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1438,7 +1438,7 @@ static void pci_restore_rebar_state(struct pci_dev *pdev) pci_read_config_dword(pdev, pos + PCI_REBAR_CTRL, &ctrl); bar_idx = ctrl & PCI_REBAR_CTRL_BAR_IDX; res = pdev->resource + bar_idx; - size = order_base_2((resource_size(res) >> 20) | 1) - 1; + size = order_base_2(resource_size(res) >> 20); ctrl &= ~PCI_REBAR_CTRL_BAR_SIZE; ctrl |= size << PCI_REBAR_CTRL_BAR_SHIFT; pci_write_config_dword(pdev, pos + PCI_REBAR_CTRL, ctrl); -- 2.18.1

5 years, 4 months

3
6
0 0

NULL ptr deref in wq_worker_sleeping on 4.19

by Sasha Levin

Hi folks, We're seeing a rare panic on boot in wq_worker_sleeping() on boot in 4.19 kernels. I wasn't able to reproduce this with 5.2, but I'm not sure whether it's because the issue is fixed, or I was just unlucky. The panic looks like this: [ 0.852791] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 [ 0.853260] PGD 0 P4D 0 [ 0.853260] Oops: 0000 [#1] SMP PTI [ 0.853260] CPU: 7 PID: 49 Comm: Not tainted 4.19.52-9858d02fd940 #1 [ 0.853260] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS 090007 06/02/2017 [ 0.853260] RIP: 0010:kthread_data+0x12/0x30 [ 0.853260] Code: 83 7f 58 00 74 02 0f 0b e9 bb 2d 19 00 0f 0b eb e2 0f 1f 80 00 00 00 00 0f 1f 44 00 00 f6 47 26 20 74 0c 48 8b 87 98 05 00 00 <48> 8b 40 10 c3 0f 0b 48 8b 87 98 05 00 00 48 8b 40 10 c3 90 66 2e [ 0.853260] RSP: 0000:ffffc900036abe38 EFLAGS: 00010002 [ 0.853260] RAX: 0000000000000000 RBX: ffff8887bfbe17c0 RCX: 0000000000000000 [ 0.853260] RDX: 0000000000000001 RSI: 000000000000000a RDI: ffff8887bbb4bb00 [ 0.853260] RBP: ffffc900036abea0 R08: 0000000000000000 R09: 0000000000000000 [ 0.853260] R10: ffffc9000368bd90 R11: 0000000000000000 R12: ffff8887bbb4bb00 [ 0.853260] R13: 0000000000000000 R14: ffffc900036abe60 R15: 0000000000000000 [ 0.853260] FS: 0000000000000000(0000) GS:ffff8887bfbc0000(0000) knlGS:0000000000000000 [ 0.853260] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.853260] CR2: 0000000000000068 CR3: 00000007df40a000 CR4: 00000000001406e0 [ 0.853260] Call Trace: [ 0.853260] wq_worker_sleeping+0xa/0x60 [ 0.853260] __schedule+0x571/0x8c0 [ 0.853260] schedule+0x32/0x80 [ 0.853260] worker_thread+0xc7/0x440 [ 0.853260] kthread+0xf8/0x130 [ 0.853260] ret_from_fork+0x35/0x40 [ 0.853260] Modules linked in: [ 0.853260] CR2: 0000000000000010 [ 0.853260] ---[ end trace 160fda44361ab977 ]--- I see that this area was recently touched by 6d25be5782e4 ("sched/core, workqueues: Distangle worker accounting from rq lock") but I'm not sure if it's related. -- Thanks, Sasha

5 years, 4 months

4
5
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror July 2019