June 2019 - Linux-stable-mirror

by Greg KH

I'm announcing the release of the 4.9.182 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/networking/ip-sysctl.txt | 8 ++++++++ Makefile | 2 +- include/linux/tcp.h | 3 +++ include/net/netns/ipv4.h | 1 + include/net/tcp.h | 2 ++ include/uapi/linux/snmp.h | 1 + net/ipv4/proc.c | 1 + net/ipv4/sysctl_net_ipv4.c | 11 +++++++++++ net/ipv4/tcp.c | 1 + net/ipv4/tcp_input.c | 32 ++++++++++++++++++++++++-------- net/ipv4/tcp_ipv4.c | 1 + net/ipv4/tcp_output.c | 8 ++++++-- net/ipv4/tcp_timer.c | 1 + 13 files changed, 61 insertions(+), 11 deletions(-) Eric Dumazet (5): tcp: reduce tcp_fastretrans_alert() verbosity tcp: limit payload size of sacked skbs tcp: tcp_fragment() should apply sane memory limits tcp: add tcp_min_snd_mss sysctl tcp: enforce tcp_min_snd_mss in tcp_mtu_probing() Greg Kroah-Hartman (1): Linux 4.9.182

5 years, 11 months

1
1
0 0

Linux 4.4.182

by Greg KH

I'm announcing the release of the 4.4.182 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Documentation/networking/ip-sysctl.txt | 8 ++++++++ Makefile | 2 +- include/linux/tcp.h | 3 +++ include/net/netns/ipv4.h | 1 + include/net/tcp.h | 2 ++ include/uapi/linux/snmp.h | 1 + net/ipv4/proc.c | 1 + net/ipv4/sysctl_net_ipv4.c | 11 +++++++++++ net/ipv4/tcp.c | 1 + net/ipv4/tcp_input.c | 28 ++++++++++++++++++++++------ net/ipv4/tcp_ipv4.c | 1 + net/ipv4/tcp_output.c | 8 ++++++-- net/ipv4/tcp_timer.c | 1 + 13 files changed, 59 insertions(+), 9 deletions(-) Eric Dumazet (4): tcp: limit payload size of sacked skbs tcp: tcp_fragment() should apply sane memory limits tcp: add tcp_min_snd_mss sysctl tcp: enforce tcp_min_snd_mss in tcp_mtu_probing() Greg Kroah-Hartman (1): Linux 4.4.182

5 years, 11 months

1
1
0 0

❎ FAIL: Stable queue: queue-4.19

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6500aa436df4 - Linux 4.19.52 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: FAILED When we attempted to merge the patchset, we received an error: Patch is empty. We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6500aa436df4 - Linux 4.19.52 We then merged the patchset with `git am`: drm-nouveau-add-kconfig-option-to-turn-off-nouveau-legacy-contexts.-v3.patch

5 years, 11 months

1
0
0 0

[PATCH v5 5/5] brcmfmac: sdio: Don't tune while the card is off

by Douglas Anderson

When Broadcom SDIO cards are idled they go to sleep and a whole separate subsystem takes over their SDIO communication. This is the Always-On-Subsystem (AOS) and it can't handle tuning requests. Specifically, as tested on rk3288-veyron-minnie (which reports having BCM4354/1 in dmesg), if I force a retune in brcmf_sdio_kso_control() when "on = 1" (aka we're transition from sleep to wake) by whacking: bus->sdiodev->func1->card->host->need_retune = 1 ...then I can often see tuning fail. In this case dw_mmc reports "All phases bad!"). Note that I don't get 100% failure, presumably because sometimes the card itself has already transitioned away from the AOS itself by the time we try to wake it up. If I force retuning when "on = 0" (AKA force retuning right before sending the command to go to sleep) then retuning is always OK. NOTE: we need _both_ this patch and the patch to avoid triggering tuning due to CRC errors in the sleep/wake transition, AKA ("brcmfmac: sdio: Disable auto-tuning around commands expected to fail"). Though both patches handle issues with Broadcom's AOS, the problems are distinct: 1. We want to defer (but not ignore) asynchronous (like timer-requested) tuning requests till the card is awake. However, we want to ignore CRC errors during the transition, we don't want to queue deferred tuning request. 2. You could imagine that the AOS could implement retuning but we could still get errors while transitioning in and out of the AOS. Similarly you could imagine a seamless transition into and out of the AOS (with no CRC errors) even if the AOS couldn't handle tuning. ALSO NOTE: presumably there is never a desperate need to retune in order to wake up the card, since doing so is impossible. Luckily the only way the card can get into sleep state is if we had a good enough tuning to send it the command to put it into sleep, so presumably that "good enough" tuning is enough to wake us up, at least with a few retries. Cc: stable(a)vger.kernel.org Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Acked-by: Adrian Hunter <adrian.hunter(a)intel.com> Reviewed-by: Arend van Spriel <arend.vanspriel(a)broadcom.com> --- Patches #2 - #5 will go through Ulf's tree. This patch is still lacking Kalle Valo's Ack, which should probably be received before landing in Ulf's tree. I've CCed stable@ here without a version tag. As per Adrian Hunter this patch applies cleanly to 4.18+ so that would be an easy first target. However, if someone were so inclined they could provide further backports. As per Adrian [1] the root problem has existed for ~4 years. [1] https://lkml.kernel.org/r/4f39e152-04ba-a64e-985a-df93e6d15ff8@intel.com Changes in v5: - Rewording of "sleep command" in commit message (Arend). Changes in v4: - Adjust to API rename (Adrian). Changes in v3: - ("brcmfmac: sdio: Don't tune while the card is off") new for v3. Changes in v2: None drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index ee76593259a7..629140b6d7e2 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -669,6 +669,10 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on) sdio_retune_crc_disable(bus->sdiodev->func1); + /* Cannot re-tune if device is asleep; defer till we're awake */ + if (on) + sdio_retune_hold_now(bus->sdiodev->func1); + wr_val = (on << SBSDIO_FUNC1_SLEEPCSR_KSO_SHIFT); /* 1st KSO write goes to AOS wake up core if device is asleep */ brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_SLEEPCSR, wr_val, &err); @@ -729,6 +733,9 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on) if (try_cnt > MAX_KSO_ATTEMPTS) brcmf_err("max tries: rd_val=0x%x err=%d\n", rd_val, err); + if (on) + sdio_retune_release(bus->sdiodev->func1); + sdio_retune_crc_enable(bus->sdiodev->func1); return err; -- 2.22.0.410.gd8fdbe21b5-goog

5 years, 11 months

1
0
0 0

[PATCH v5 4/5] mmc: core: Add sdio_retune_hold_now() and sdio_retune_release()

by Douglas Anderson

We want SDIO drivers to be able to temporarily stop retuning when the driver knows that the SDIO card is not in a state where retuning will work (maybe because the card is asleep). We'll move the relevant functions to a place where drivers can call them. Cc: stable(a)vger.kernel.org Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Acked-by: Adrian Hunter <adrian.hunter(a)intel.com> --- Patches #2 - #5 will go through Ulf's tree. I've CCed stable@ here without a version tag. As per Adrian Hunter this patch applies cleanly to 4.18+ so that would be an easy first target. However, if someone were so inclined they could provide further backports. As per Adrian [1] the root problem has existed for ~4 years. [1] https://lkml.kernel.org/r/4f39e152-04ba-a64e-985a-df93e6d15ff8@intel.com Changes in v5: None Changes in v4: - Moved retune hold/release to SDIO API (Adrian). Changes in v3: - ("mmc: core: Export mmc_retune_hold_now() mmc_retune_release()") new for v3. Changes in v2: None drivers/mmc/core/sdio_io.c | 40 +++++++++++++++++++++++++++++++++++ include/linux/mmc/sdio_func.h | 3 +++ 2 files changed, 43 insertions(+) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index 0acb1a29c968..2ba00acf64e6 100644 --- a/drivers/mmc/core/sdio_io.c +++ b/drivers/mmc/core/sdio_io.c @@ -15,6 +15,7 @@ #include "sdio_ops.h" #include "core.h" #include "card.h" +#include "host.h" /** * sdio_claim_host - exclusively claim a bus for a certain SDIO function @@ -771,3 +772,42 @@ void sdio_retune_crc_enable(struct sdio_func *func) func->card->host->retune_crc_disable = false; } EXPORT_SYMBOL_GPL(sdio_retune_crc_enable); + +/** + * sdio_retune_hold_now - start deferring retuning requests till release + * @func: SDIO function attached to host + * + * This function can be called if it's currently a bad time to do + * a retune of the SDIO card. Retune requests made during this time + * will be held and we'll actually do the retune sometime after the + * release. + * + * This function could be useful if an SDIO card is in a power state + * where it can respond to a small subset of commands that doesn't + * include the retuning command. Care should be taken when using + * this function since (presumably) the retuning request we might be + * deferring was made for a good reason. + * + * This function should be called while the host is claimed. + */ +void sdio_retune_hold_now(struct sdio_func *func) +{ + mmc_retune_hold_now(func->card->host); +} +EXPORT_SYMBOL_GPL(sdio_retune_hold_now); + +/** + * sdio_retune_release - signal that it's OK to retune now + * @func: SDIO function attached to host + * + * This is the complement to sdio_retune_hold_now(). Calling this + * function won't make a retune happen right away but will allow + * them to be scheduled normally. + * + * This function should be called while the host is claimed. + */ +void sdio_retune_release(struct sdio_func *func) +{ + mmc_retune_release(func->card->host); +} +EXPORT_SYMBOL_GPL(sdio_retune_release); diff --git a/include/linux/mmc/sdio_func.h b/include/linux/mmc/sdio_func.h index 4820e6d09dac..5a177f7a83c3 100644 --- a/include/linux/mmc/sdio_func.h +++ b/include/linux/mmc/sdio_func.h @@ -170,4 +170,7 @@ extern int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags); extern void sdio_retune_crc_disable(struct sdio_func *func); extern void sdio_retune_crc_enable(struct sdio_func *func); +extern void sdio_retune_hold_now(struct sdio_func *func); +extern void sdio_retune_release(struct sdio_func *func); + #endif /* LINUX_MMC_SDIO_FUNC_H */ -- 2.22.0.410.gd8fdbe21b5-goog

5 years, 11 months

1
0
0 0

[PATCH v5 3/5] brcmfmac: sdio: Disable auto-tuning around commands expected to fail

by Douglas Anderson

There are certain cases, notably when transitioning between sleep and active state, when Broadcom SDIO WiFi cards will produce errors on the SDIO bus. This is evident from the source code where you can see that we try commands in a loop until we either get success or we've tried too many times. The comment in the code reinforces this by saying "just one write attempt may fail" Unfortunately these failures sometimes end up causing an "-EILSEQ" back to the core which triggers a retuning of the SDIO card and that blocks all traffic to the card until it's done. Let's disable retuning around the commands we expect might fail. Commit notes: Patches #2 - #5 will go through Ulf's tree. This patch is still lacking Kalle Valo's Ack, which should probably be received before landing in Ulf's tree. END Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Cc: stable(a)vger.kernel.org Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Acked-by: Adrian Hunter <adrian.hunter(a)intel.com> Reviewed-by: Arend van Spriel <arend.vanspriel(a)broadcom.com> --- Changes in v5: None Changes in v4: - Adjust to API rename (Adrian, Ulf). Changes in v3: - Expect errors for all of brcmf_sdio_kso_control() (Adrian). Changes in v2: None drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 4a750838d8cd..ee76593259a7 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -667,6 +667,8 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on) brcmf_dbg(TRACE, "Enter: on=%d\n", on); + sdio_retune_crc_disable(bus->sdiodev->func1); + wr_val = (on << SBSDIO_FUNC1_SLEEPCSR_KSO_SHIFT); /* 1st KSO write goes to AOS wake up core if device is asleep */ brcmf_sdiod_writeb(bus->sdiodev, SBSDIO_FUNC1_SLEEPCSR, wr_val, &err); @@ -727,6 +729,8 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on) if (try_cnt > MAX_KSO_ATTEMPTS) brcmf_err("max tries: rd_val=0x%x err=%d\n", rd_val, err); + sdio_retune_crc_enable(bus->sdiodev->func1); + return err; } -- 2.22.0.410.gd8fdbe21b5-goog

5 years, 11 months

1
0
0 0

[PATCH v5 2/5] mmc: core: API to temporarily disable retuning for SDIO CRC errors

by Douglas Anderson

Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card. This is generally a good idea. However, if a command is expected to sometimes cause transfer errors then these transfer errors shouldn't cause a re-tuning. This re-tuning will be a needless waste of time. One example case where a transfer is expected to cause errors is when transitioning between idle (sometimes referred to as "sleep" in Broadcom code) and active state on certain Broadcom WiFi SDIO cards. Specifically if the card was already transitioning between states when the command was sent it could cause an error on the SDIO bus. Let's add an API that the SDIO function drivers can call that will temporarily disable the auto-tuning functionality. Then we can add a call to this in the Broadcom WiFi driver and any other driver that might have similar needs. NOTE: this makes the assumption that the card is already tuned well enough that it's OK to disable the auto-retuning during one of these error-prone situations. Presumably the driver code performing the error-prone transfer knows how to recover / retry from errors. ...and after we can get back to a state where transfers are no longer error-prone then we can enable the auto-retuning again. If we truly find ourselves in a case where the card needs to be retuned sometimes to handle one of these error-prone transfers then we can always try a few transfers first without auto-retuning and then re-try with auto-retuning if the first few fail. Without this change on rk3288-veyron-minnie I periodically see this in the logs of a machine just sitting there idle: dwmmc_rockchip ff0d0000.dwmmc: Successfully tuned phase to XYZ Commit notes: Patches #2 - #5 will go through Ulf's tree. END Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") Cc: stable(a)vger.kernel.org Signed-off-by: Douglas Anderson <dianders(a)chromium.org> Acked-by: Adrian Hunter <adrian.hunter(a)intel.com> --- Changes in v5: - Add missing sdio_retune_crc_enable() in comments (Ulf). - /s/reneable/re-enable (Ulf). - Remove leftover prototypes: mmc_expect_errors_begin() / end() (Ulf). Changes in v4: - Moved to SDIO API only (Adrian, Ulf). - Renamed to make it less generic, now retune_crc_disable (Ulf). - Function header makes it clear host must be claimed (Ulf). - No more WARN_ON (Ulf). Changes in v3: - Took out the spinlock since I believe this is all in one context. Changes in v2: - Updated commit message to clarify based on discussion of v1. drivers/mmc/core/core.c | 5 +++-- drivers/mmc/core/sdio_io.c | 37 +++++++++++++++++++++++++++++++++++ include/linux/mmc/host.h | 1 + include/linux/mmc/sdio_func.h | 3 +++ 4 files changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 6db36dc870b5..9020cb2490f7 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -144,8 +144,9 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq) int err = cmd->error; /* Flag re-tuning needed on CRC errors */ - if ((cmd->opcode != MMC_SEND_TUNING_BLOCK && - cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) && + if (cmd->opcode != MMC_SEND_TUNING_BLOCK && + cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200 && + !host->retune_crc_disable && (err == -EILSEQ || (mrq->sbc && mrq->sbc->error == -EILSEQ) || (mrq->data && mrq->data->error == -EILSEQ) || (mrq->stop && mrq->stop->error == -EILSEQ))) diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c index f79f0b0caab8..0acb1a29c968 100644 --- a/drivers/mmc/core/sdio_io.c +++ b/drivers/mmc/core/sdio_io.c @@ -734,3 +734,40 @@ int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags) return 0; } EXPORT_SYMBOL_GPL(sdio_set_host_pm_flags); + +/** + * sdio_retune_crc_disable - temporarily disable retuning on CRC errors + * @func: SDIO function attached to host + * + * If the SDIO card is known to be in a state where it might produce + * CRC errors on the bus in response to commands (like if we know it is + * transitioning between power states), an SDIO function driver can + * call this function to temporarily disable the SD/MMC core behavior of + * triggering an automatic retuning. + * + * This function should be called while the host is claimed and the host + * should remain claimed until sdio_retune_crc_enable() is called. + * Specifically, the expected sequence of calls is: + * - sdio_claim_host() + * - sdio_retune_crc_disable() + * - some number of calls like sdio_writeb() and sdio_readb() + * - sdio_retune_crc_enable() + * - sdio_release_host() + */ +void sdio_retune_crc_disable(struct sdio_func *func) +{ + func->card->host->retune_crc_disable = true; +} +EXPORT_SYMBOL_GPL(sdio_retune_crc_disable); + +/** + * sdio_retune_crc_enable - re-enable retuning on CRC errors + * @func: SDIO function attached to host + * + * This is the compement to sdio_retune_crc_disable(). + */ +void sdio_retune_crc_enable(struct sdio_func *func) +{ + func->card->host->retune_crc_disable = false; +} +EXPORT_SYMBOL_GPL(sdio_retune_crc_enable); diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index 43d0f0c496f6..ecb7972e2423 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -398,6 +398,7 @@ struct mmc_host { unsigned int retune_now:1; /* do re-tuning at next req */ unsigned int retune_paused:1; /* re-tuning is temporarily disabled */ unsigned int use_blk_mq:1; /* use blk-mq */ + unsigned int retune_crc_disable:1; /* don't trigger retune upon crc */ int rescan_disable; /* disable card detection */ int rescan_entered; /* used with nonremovable devices */ diff --git a/include/linux/mmc/sdio_func.h b/include/linux/mmc/sdio_func.h index e9dfdd501cd1..4820e6d09dac 100644 --- a/include/linux/mmc/sdio_func.h +++ b/include/linux/mmc/sdio_func.h @@ -167,4 +167,7 @@ extern void sdio_f0_writeb(struct sdio_func *func, unsigned char b, extern mmc_pm_flag_t sdio_get_host_pm_caps(struct sdio_func *func); extern int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags); +extern void sdio_retune_crc_disable(struct sdio_func *func); +extern void sdio_retune_crc_enable(struct sdio_func *func); + #endif /* LINUX_MMC_SDIO_FUNC_H */ -- 2.22.0.410.gd8fdbe21b5-goog

5 years, 11 months

1
0
0 0

✅ PASS: Stable queue: queue-4.19

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 7aa823a959e1 - Linux 4.19.51 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 7aa823a959e1 - Linux 4.19.51 We then merged the patchset with `git am`: drm-nouveau-add-kconfig-option-to-turn-off-nouveau-legacy-contexts.-v3.patch nouveau-fix-build-with-config_nouveau_legacy_ctx_support-disabled.patch hid-multitouch-handle-faulty-elo-touch-device.patch hid-wacom-don-t-set-tool-type-until-we-re-in-range.patch hid-wacom-don-t-report-anything-prior-to-the-tool-entering-range.patch hid-wacom-send-btn_touch-in-response-to-intuosp2_bt-eraser-contact.patch hid-wacom-correct-button-numbering-2nd-gen-intuos-pro-over-bluetooth.patch hid-wacom-sync-intuosp2_bt-touch-state-after-each-frame-if-necessary.patch revert-alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch alsa-oxfw-allow-pcm-capture-for-stanton-scs.1m.patch alsa-hda-realtek-update-headset-mode-for-alc256.patch alsa-firewire-motu-fix-destruction-of-data-for-isochronous-resources.patch libata-extend-quirks-for-the-st1000lm024-drives-with-nolpm-quirk.patch mm-list_lru.c-fix-memory-leak-in-__memcg_init_list_lru_node.patch fs-ocfs2-fix-race-in-ocfs2_dentry_attach_lock.patch mm-vmscan.c-fix-trying-to-reclaim-unevictable-lru-page.patch signal-ptrace-don-t-leak-unitialized-kernel-memory-with-ptrace_peek_siginfo.patch ptrace-restore-smp_rmb-in-__ptrace_may_access.patch iommu-arm-smmu-avoid-constant-zero-in-tlbi-writes.patch i2c-acorn-fix-i2c-warning.patch bcache-fix-stack-corruption-by-preceding_key.patch bcache-only-set-bcache_dev_wb_running-when-cached-device-attached.patch cgroup-use-css_tryget-instead-of-css_tryget_online-in-task_get_css.patch asoc-cs42xx8-add-regcache-mask-dirty.patch asoc-fsl_asrc-fix-the-issue-about-unsupported-rate.patch drm-i915-sdvo-implement-proper-hdmi-audio-support-for-sdvo.patch x86-uaccess-kcov-disable-stack-protector.patch alsa-seq-protect-in-kernel-ioctl-calls-with-mutex.patch alsa-seq-fix-race-of-get-subscription-call-vs-port-d.patch revert-alsa-seq-protect-in-kernel-ioctl-calls-with-m.patch s390-kasan-fix-strncpy_from_user-kasan-checks.patch drivers-misc-fix-out-of-bounds-access-in-function-pa.patch f2fs-fix-to-avoid-accessing-xattr-across-the-boundar.patch scsi-qedi-remove-memset-memcpy-to-nfunc-and-use-func.patch scsi-qedi-remove-set-but-not-used-variables-cdev-and.patch scsi-lpfc-correct-rcu-unlock-issue-in-lpfc_nvme_info.patch scsi-lpfc-add-check-for-loss-of-ndlp-when-sending-rr.patch arm64-mm-inhibit-huge-vmap-with-ptdump.patch nvme-fix-srcu-locking-on-error-return-in-nvme_get_ns.patch nvme-remove-the-ifdef-around-nvme_nvm_ioctl.patch nvme-merge-nvme_ns_ioctl-into-nvme_ioctl.patch nvme-release-namespace-srcu-protection-before-perfor.patch nvme-fix-memory-leak-for-power-latency-tolerance.patch platform-x86-pmc_atom-add-lex-3i380d-industrial-pc-t.patch platform-x86-pmc_atom-add-several-beckhoff-automatio.patch scsi-bnx2fc-fix-incorrect-cast-to-u64-on-shift-opera.patch libnvdimm-fix-compilation-warnings-with-w-1.patch selftests-fib_rule_tests-fix-local-ipv4-address-typo.patch selftests-timers-add-missing-fflush-stdout-calls.patch tracing-prevent-hist_field_var_ref-from-accessing-nu.patch usbnet-ipheth-fix-racing-condition.patch kvm-arm-arm64-move-cc-it-checks-under-hyp-s-makefile.patch kvm-x86-pmu-mask-the-result-of-rdpmc-according-to-th.patch kvm-x86-pmu-do-not-mask-the-value-that-is-written-to.patch kvm-s390-fix-memory-slot-handling-for-kvm_set_user_m.patch tools-kvm_stat-fix-fields-filter-for-child-events.patch drm-vmwgfx-integer-underflow-in-vmw_cmd_dx_set_shader-leading-to-an-invalid-read.patch drm-vmwgfx-null-pointer-dereference-from-vmw_cmd_dx_view_define.patch usb-dwc2-fix-dma-cache-alignment-issues.patch usb-dwc2-host-fix-wmaxpacketsize-handling-fix-webcam-regression.patch usb-fix-chipmunk-like-voice-when-using-logitech-c270-for-recording-audio.patch usb-usb-storage-add-new-id-to-ums-realtek.patch usb-serial-pl2303-add-allied-telesis-vt-kit3.patch usb-serial-option-add-support-for-simcom-sim7500-sim7600-rndis-mode.patch usb-serial-option-add-telit-0x1260-and-0x1261-compositions.patch timekeeping-repair-ktime_get_coarse-granularity.patch ras-cec-convert-the-timer-callback-to-a-workqueue.patch ras-cec-fix-binary-search-function.patch x86-microcode-cpuhotplug-add-a-microcode-loader-cpu-hotplug-callback.patch x86-kasan-fix-boot-with-5-level-paging-and-kasan.patch x86-mm-kaslr-compute-the-size-of-the-vmemmap-section-properly.patch x86-resctrl-prevent-null-pointer-dereference-when-local-mbm-is-disabled.patch drm-edid-abstract-override-firmware-edid-retrieval.patch drm-add-fallback-override-firmware-edid-modes-workaround.patch rtc-pcf8523-don-t-return-invalid-date-when-battery-is-low.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… ppc64le: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… s390x: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… x86_64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ Usex - version 1.9-29 [7] 🚧 ✅ tuned: tune-processes-through-perf [8] 🚧 ✅ storage: SCSI VPD [9] 🚧 ✅ storage: software RAID testing [10] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [11] ppc64le: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [11] Host 2: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ Usex - version 1.9-29 [7] 🚧 ✅ tuned: tune-processes-through-perf [8] 🚧 ✅ storage: software RAID testing [10] s390x: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [11] Host 2: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] 🚧 ✅ tuned: tune-processes-through-perf [8] 🚧 ✅ storage: software RAID testing [10] x86_64: Host 1: ✅ Boot test [0] 🚧 ✅ Storage SAN device stress [12] Host 2: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ Usex - version 1.9-29 [7] 🚧 ✅ tuned: tune-processes-through-perf [8] 🚧 ✅ storage: SCSI VPD [9] 🚧 ✅ storage: software RAID testing [10] Host 3: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [11] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/hba/… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 11 months

1
0
0 0

Re: [PATCH 3/3] resource: Introduce resource cache

by Nadav Amit

> On Jun 15, 2019, at 3:16 PM, Sasha Levin <sashal(a)kernel.org> wrote: > > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: ff3cc952d3f0 resource: Add remove_resource interface. This commit (Patch 3/3) does not have the “Fixes:” tag (and it is a performance enhancement), so I don’t know why it was processed. IOW: please do not backport it. > The bot has tested the following trees: v5.1.9, v4.19.50, v4.14.125, v4.9.181. > > v5.1.9: Build OK! > v4.19.50: Failed to apply! Possible dependencies: > 010a93bf97c7 ("resource: Fix find_next_iomem_res() iteration issue") > 7a53bb309eb3 ("resource: Fix locking in find_next_iomem_res()") > a98959fdbda1 ("resource: Include resource end in walk_*() interfaces") > > v4.14.125: Failed to apply! Possible dependencies: > 010a93bf97c7 ("resource: Fix find_next_iomem_res() iteration issue") > 0e4c12b45aa8 ("x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages") > 1d2e733b13b4 ("resource: Provide resource struct in resource walk callback") > 4ac2aed837cb ("resource: Consolidate resource walking code") > 7a53bb309eb3 ("resource: Fix locking in find_next_iomem_res()") > a98959fdbda1 ("resource: Include resource end in walk_*() interfaces") > > v4.9.181: Failed to apply! Possible dependencies: > 010a93bf97c7 ("resource: Fix find_next_iomem_res() iteration issue") > 0e4c12b45aa8 ("x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages") > 1d2e733b13b4 ("resource: Provide resource struct in resource walk callback") > 4ac2aed837cb ("resource: Consolidate resource walking code") > 60fe3910bb02 ("kexec_file: Allow arch-specific memory walking for kexec_add_buffer") > 7a53bb309eb3 ("resource: Fix locking in find_next_iomem_res()") > a0458284f062 ("powerpc: Add support code for kexec_file_load()") > a98959fdbda1 ("resource: Include resource end in walk_*() interfaces") > da6658859b9c ("powerpc: Change places using CONFIG_KEXEC to use CONFIG_KEXEC_CORE instead.") > ec2b9bfaac44 ("kexec_file: Change kexec_add_buffer to take kexec_buf as argument.") > > > How should we proceed with this patch? > > -- > Thanks, > Sasha

5 years, 11 months

1
0
0 0

[PATCH AUTOSEL 5.1 001/375] gfs2: Fix lru_count going negative

by Sasha Levin

From: Ross Lagerwall <ross.lagerwall(a)citrix.com> [ Upstream commit 7881ef3f33bb80f459ea6020d1e021fc524a6348 ] Under certain conditions, lru_count may drop below zero resulting in a large amount of log spam like this: vmscan: shrink_slab: gfs2_dump_glock+0x3b0/0x630 [gfs2] \ negative objects to delete nr=-1 This happens as follows: 1) A glock is moved from lru_list to the dispose list and lru_count is decremented. 2) The dispose function calls cond_resched() and drops the lru lock. 3) Another thread takes the lru lock and tries to add the same glock to lru_list, checking if the glock is on an lru list. 4) It is on a list (actually the dispose list) and so it avoids incrementing lru_count. 5) The glock is moved to lru_list. 5) The original thread doesn't dispose it because it has been re-added to the lru list but the lru_count has still decreased by one. Fix by checking if the LRU flag is set on the glock rather than checking if the glock is on some list and rearrange the code so that the LRU flag is added/removed precisely when the glock is added/removed from lru_list. Signed-off-by: Ross Lagerwall <ross.lagerwall(a)citrix.com> Signed-off-by: Andreas Gruenbacher <agruenba(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/gfs2/glock.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index d32964cd11176..e4f6d39500bcc 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -183,15 +183,19 @@ static int demote_ok(const struct gfs2_glock *gl) void gfs2_glock_add_to_lru(struct gfs2_glock *gl) { + if (!(gl->gl_ops->go_flags & GLOF_LRU)) + return; + spin_lock(&lru_lock); - if (!list_empty(&gl->gl_lru)) - list_del_init(&gl->gl_lru); - else + list_del(&gl->gl_lru); + list_add_tail(&gl->gl_lru, &lru_list); + + if (!test_bit(GLF_LRU, &gl->gl_flags)) { + set_bit(GLF_LRU, &gl->gl_flags); atomic_inc(&lru_count); + } - list_add_tail(&gl->gl_lru, &lru_list); - set_bit(GLF_LRU, &gl->gl_flags); spin_unlock(&lru_lock); } @@ -201,7 +205,7 @@ static void gfs2_glock_remove_from_lru(struct gfs2_glock *gl) return; spin_lock(&lru_lock); - if (!list_empty(&gl->gl_lru)) { + if (test_bit(GLF_LRU, &gl->gl_flags)) { list_del_init(&gl->gl_lru); atomic_dec(&lru_count); clear_bit(GLF_LRU, &gl->gl_flags); @@ -1159,8 +1163,7 @@ void gfs2_glock_dq(struct gfs2_holder *gh) !test_bit(GLF_DEMOTE, &gl->gl_flags)) fast_path = 1; } - if (!test_bit(GLF_LFLUSH, &gl->gl_flags) && demote_ok(gl) && - (glops->go_flags & GLOF_LRU)) + if (!test_bit(GLF_LFLUSH, &gl->gl_flags) && demote_ok(gl)) gfs2_glock_add_to_lru(gl); trace_gfs2_glock_queue(gh, 0); @@ -1456,6 +1459,7 @@ __acquires(&lru_lock) if (!spin_trylock(&gl->gl_lockref.lock)) { add_back_to_lru: list_add(&gl->gl_lru, &lru_list); + set_bit(GLF_LRU, &gl->gl_flags); atomic_inc(&lru_count); continue; } @@ -1463,7 +1467,6 @@ __acquires(&lru_lock) spin_unlock(&gl->gl_lockref.lock); goto add_back_to_lru; } - clear_bit(GLF_LRU, &gl->gl_flags); gl->gl_lockref.count++; if (demote_ok(gl)) handle_callback(gl, LM_ST_UNLOCKED, 0, false); @@ -1498,6 +1501,7 @@ static long gfs2_scan_glock_lru(int nr) if (!test_bit(GLF_LOCK, &gl->gl_flags)) { list_move(&gl->gl_lru, &dispose); atomic_dec(&lru_count); + clear_bit(GLF_LRU, &gl->gl_flags); freed++; continue; } -- 2.20.1

5 years, 11 months

6
87
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2019