June 2019 - Linux-stable-mirror

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 2f7d9d47575e - Linux 5.1.7 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 2f7d9d47575e - Linux 5.1.7 We then merged the patchset with `git am`: sparc64-fix-regression-in-non-hypervisor-tlb-flush-xcall.patch include-linux-bitops.h-sanitize-rotate-primitives.patch xhci-update-bounce-buffer-with-correct-sg-num.patch xhci-use-zu-for-printing-size_t-type.patch xhci-convert-xhci_handshake-to-use-readl_poll_timeout_atomic.patch usb-xhci-avoid-null-pointer-deref-when-bos-field-is-null.patch usbip-usbip_host-fix-bug-sleeping-function-called-from-invalid-context.patch usbip-usbip_host-fix-stub_dev-lock-context-imbalance-regression.patch usb-fix-slab-out-of-bounds-write-in-usb_get_bos_descriptor.patch usb-sisusbvga-fix-oops-in-error-path-of-sisusb_probe.patch usb-add-lpm-quirk-for-surface-dock-gige-adapter.patch usb-rio500-refuse-more-than-one-device-at-a-time.patch usb-rio500-fix-memory-leak-in-close-after-disconnect.patch media-usb-siano-fix-general-protection-fault-in-smsusb.patch media-usb-siano-fix-false-positive-uninitialized-variable-warning.patch media-smsusb-better-handle-optional-alignment.patch brcmfmac-fix-null-pointer-derefence-during-usb-disconnect.patch scsi-zfcp-fix-missing-zfcp_port-reference-put-on-ebusy-from-port_remove.patch scsi-zfcp-fix-to-prevent-port_remove-with-pure-auto-scan-luns-only-sdevs.patch tracing-avoid-memory-leak-in-predicate_parse.patch btrfs-fix-wrong-ctime-and-mtime-of-a-directory-after-log-replay.patch btrfs-fix-race-updating-log-root-item-during-fsync.patch btrfs-fix-fsync-not-persisting-changed-attributes-of-a-directory.patch btrfs-correct-zstd-workspace-manager-lock-to-use-spin_lock_bh.patch btrfs-qgroup-check-bg-while-resuming-relocation-to-avoid-null-pointer-dereference.patch btrfs-incremental-send-fix-file-corruption-when-no-holes-feature-is-enabled.patch btrfs-reloc-also-queue-orphan-reloc-tree-for-cleanup-to-avoid-bug_on.patch iio-dac-ds4422-ds4424-fix-chip-verification.patch iio-adc-ads124-avoid-buffer-overflow.patch iio-adc-modify-npcm-adc-read-reference-voltage.patch iio-adc-ti-ads8688-fix-timestamp-is-not-updated-in-buffer.patch s390-crypto-fix-gcm-aes-s390-selftest-failures.patch s390-crypto-fix-possible-sleep-during-spinlock-aquired.patch kvm-ppc-book3s-hv-xive-do-not-clear-irq-data-of-passthrough-interrupts.patch kvm-ppc-book3s-hv-fix-lockdep-warning-when-entering-guest-on-power9.patch kvm-ppc-book3s-hv-restore-sprg3-in-kvmhv_p9_guest_entry.patch powerpc-perf-fix-mmcra-corruption-by-bhrb_filter.patch powerpc-kexec-fix-loading-of-kernel-initramfs-with-kexec_file_load.patch alsa-line6-assure-canceling-delayed-work-at-disconnection.patch alsa-hda-realtek-set-default-power-save-node-to-0.patch alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch kvm-s390-do-not-report-unusabled-ids-via-kvm_cap_max_vcpu_id.patch drm-nouveau-i2c-disable-i2c-bus-access-after-fini.patch i2c-mlxcpld-fix-wrong-initialization-order-in-probe.patch i2c-synquacer-fix-synquacer_i2c_doxfer-return-value.patch tty-serial-msm_serial-fix-xon-xoff.patch tty-max310x-fix-external-crystal-register-setup.patch mm-memcg-consider-subtrees-in-memory.events.patch memcg-make-it-work-on-sparse-non-0-node-systems.patch kasan-initialize-tag-to-0xff-in-__kasan_kmalloc.patch kernel-signal.c-trace_signal_deliver-when-signal_group_exit.patch signal-arm64-use-force_sig-not-force_sig_fault-for-sigkill.patch mm-compaction-make-sure-we-isolate-a-valid-pfn.patch arm64-fix-the-arm64_personality-syscall-wrapper-redirection.patch docs-fix-conf.py-for-sphinx-2.0.patch doc-cope-with-the-deprecation-of-autoreporter.patch doc-cope-with-sphinx-logging-deprecations.patch x86-ima-check-efi_runtime_services-before-using.patch ima-fix-wrong-signed-policy-requirement-when-not-appraising.patch ima-show-rules-with-ima_inmask-correctly.patch evm-check-hash-algorithm-passed-to-init_desc.patch clk-imx-imx8mm-fix-int-pll-clk-gate.patch vt-fbcon-deinitialize-resources-in-visual_init-after-failed-memory-allocation.patch serial-sh-sci-disable-dma-for-uart_console.patch staging-vc04_services-prevent-integer-overflow-in-create_pagelist.patch staging-wlan-ng-fix-adapter-initialization-failure.patch cifs-fix-memory-leak-of-pneg_inbuf-on-eopnotsupp-ioctl-case.patch cifs-cifs_read_allocate_pages-don-t-iterate-through-whole-page-array-on-enomem.patch revert-lockd-show-pid-of-lockd-for-remote-locks.patch gcc-plugins-fix-build-failures-under-darwin-host.patch efi-x86-add-missing-error-handling-to-old_memmap-1-1-mapping-code.patch drm-tegra-gem-fix-cpu-cache-maintenance-for-bo-s-allocated-using-get_pages.patch drm-vmwgfx-fix-user-space-handle-equal-to-zero.patch drm-vmwgfx-fix-compat-mode-shader-operation.patch drm-vmwgfx-don-t-send-drm-sysfs-hotplug-events-on-initial-master-set.patch drm-sun4i-fix-sun8i-hdmi-phy-clock-initialization.patch drm-sun4i-fix-sun8i-hdmi-phy-configuration-for-148.5-mhz.patch drm-imx-ipuv3-plane-fix-atomic-update-status-query-for-non-plus-i.mx6q.patch drm-fb-helper-generic-call-drm_client_add-after-setup-is-done.patch drm-atomic-wire-file_priv-through-for-property-changes.patch drm-expose-fb_damage_clips-property-to-atomic-aware-user-space-only.patch drm-rockchip-shutdown-drm-subsystem-on-shutdown.patch drm-lease-make-sure-implicit-planes-are-leased.patch drm-cma-helper-fix-drm_gem_cma_free_object.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… ppc64le: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… s390x: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… x86_64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] 🚧 ✅ stress: stress-ng [9] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] ppc64le: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] s390x: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] 🚧 ❎ stress: stress-ng [9] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] x86_64: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] 🚧 ✅ stress: stress-ng [9] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 6 months

1
0
0 0

✅ PASS: Stable queue: queue-5.1

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 2f7d9d47575e - Linux 5.1.7 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 2f7d9d47575e - Linux 5.1.7 We then merged the patchset with `git am`: sparc64-fix-regression-in-non-hypervisor-tlb-flush-xcall.patch include-linux-bitops.h-sanitize-rotate-primitives.patch xhci-update-bounce-buffer-with-correct-sg-num.patch xhci-use-zu-for-printing-size_t-type.patch xhci-convert-xhci_handshake-to-use-readl_poll_timeout_atomic.patch usb-xhci-avoid-null-pointer-deref-when-bos-field-is-null.patch usbip-usbip_host-fix-bug-sleeping-function-called-from-invalid-context.patch usbip-usbip_host-fix-stub_dev-lock-context-imbalance-regression.patch usb-fix-slab-out-of-bounds-write-in-usb_get_bos_descriptor.patch usb-sisusbvga-fix-oops-in-error-path-of-sisusb_probe.patch usb-add-lpm-quirk-for-surface-dock-gige-adapter.patch usb-rio500-refuse-more-than-one-device-at-a-time.patch usb-rio500-fix-memory-leak-in-close-after-disconnect.patch media-usb-siano-fix-general-protection-fault-in-smsusb.patch media-usb-siano-fix-false-positive-uninitialized-variable-warning.patch media-smsusb-better-handle-optional-alignment.patch brcmfmac-fix-null-pointer-derefence-during-usb-disconnect.patch scsi-zfcp-fix-missing-zfcp_port-reference-put-on-ebusy-from-port_remove.patch scsi-zfcp-fix-to-prevent-port_remove-with-pure-auto-scan-luns-only-sdevs.patch tracing-avoid-memory-leak-in-predicate_parse.patch btrfs-fix-wrong-ctime-and-mtime-of-a-directory-after-log-replay.patch btrfs-fix-race-updating-log-root-item-during-fsync.patch btrfs-fix-fsync-not-persisting-changed-attributes-of-a-directory.patch btrfs-correct-zstd-workspace-manager-lock-to-use-spin_lock_bh.patch btrfs-qgroup-check-bg-while-resuming-relocation-to-avoid-null-pointer-dereference.patch btrfs-incremental-send-fix-file-corruption-when-no-holes-feature-is-enabled.patch btrfs-reloc-also-queue-orphan-reloc-tree-for-cleanup-to-avoid-bug_on.patch iio-dac-ds4422-ds4424-fix-chip-verification.patch iio-adc-ads124-avoid-buffer-overflow.patch iio-adc-modify-npcm-adc-read-reference-voltage.patch iio-adc-ti-ads8688-fix-timestamp-is-not-updated-in-buffer.patch s390-crypto-fix-gcm-aes-s390-selftest-failures.patch s390-crypto-fix-possible-sleep-during-spinlock-aquired.patch kvm-ppc-book3s-hv-xive-do-not-clear-irq-data-of-passthrough-interrupts.patch kvm-ppc-book3s-hv-fix-lockdep-warning-when-entering-guest-on-power9.patch kvm-ppc-book3s-hv-restore-sprg3-in-kvmhv_p9_guest_entry.patch powerpc-perf-fix-mmcra-corruption-by-bhrb_filter.patch powerpc-kexec-fix-loading-of-kernel-initramfs-with-kexec_file_load.patch alsa-line6-assure-canceling-delayed-work-at-disconnection.patch alsa-hda-realtek-set-default-power-save-node-to-0.patch alsa-hda-realtek-improve-the-headset-mic-for-acer-aspire-laptops.patch kvm-s390-do-not-report-unusabled-ids-via-kvm_cap_max_vcpu_id.patch drm-nouveau-i2c-disable-i2c-bus-access-after-fini.patch i2c-mlxcpld-fix-wrong-initialization-order-in-probe.patch i2c-synquacer-fix-synquacer_i2c_doxfer-return-value.patch tty-serial-msm_serial-fix-xon-xoff.patch tty-max310x-fix-external-crystal-register-setup.patch mm-memcg-consider-subtrees-in-memory.events.patch memcg-make-it-work-on-sparse-non-0-node-systems.patch kasan-initialize-tag-to-0xff-in-__kasan_kmalloc.patch kernel-signal.c-trace_signal_deliver-when-signal_group_exit.patch signal-arm64-use-force_sig-not-force_sig_fault-for-sigkill.patch mm-compaction-make-sure-we-isolate-a-valid-pfn.patch arm64-fix-the-arm64_personality-syscall-wrapper-redirection.patch docs-fix-conf.py-for-sphinx-2.0.patch doc-cope-with-the-deprecation-of-autoreporter.patch doc-cope-with-sphinx-logging-deprecations.patch x86-ima-check-efi_runtime_services-before-using.patch ima-fix-wrong-signed-policy-requirement-when-not-appraising.patch ima-show-rules-with-ima_inmask-correctly.patch evm-check-hash-algorithm-passed-to-init_desc.patch clk-imx-imx8mm-fix-int-pll-clk-gate.patch vt-fbcon-deinitialize-resources-in-visual_init-after-failed-memory-allocation.patch serial-sh-sci-disable-dma-for-uart_console.patch staging-vc04_services-prevent-integer-overflow-in-create_pagelist.patch staging-wlan-ng-fix-adapter-initialization-failure.patch cifs-fix-memory-leak-of-pneg_inbuf-on-eopnotsupp-ioctl-case.patch cifs-cifs_read_allocate_pages-don-t-iterate-through-whole-page-array-on-enomem.patch revert-lockd-show-pid-of-lockd-for-remote-locks.patch gcc-plugins-fix-build-failures-under-darwin-host.patch drm-tegra-gem-fix-cpu-cache-maintenance-for-bo-s-allocated-using-get_pages.patch drm-vmwgfx-fix-user-space-handle-equal-to-zero.patch drm-vmwgfx-fix-compat-mode-shader-operation.patch drm-vmwgfx-don-t-send-drm-sysfs-hotplug-events-on-initial-master-set.patch drm-sun4i-fix-sun8i-hdmi-phy-clock-initialization.patch drm-sun4i-fix-sun8i-hdmi-phy-configuration-for-148.5-mhz.patch drm-imx-ipuv3-plane-fix-atomic-update-status-query-for-non-plus-i.mx6q.patch drm-fb-helper-generic-call-drm_client_add-after-setup-is-done.patch drm-atomic-wire-file_priv-through-for-property-changes.patch drm-expose-fb_damage_clips-property-to-atomic-aware-user-space-only.patch drm-rockchip-shutdown-drm-subsystem-on-shutdown.patch drm-lease-make-sure-implicit-planes-are-leased.patch drm-cma-helper-fix-drm_gem_cma_free_object.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… ppc64le: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… s390x: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… x86_64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] 🚧 ✅ stress: stress-ng [9] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] ppc64le: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] s390x: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] Host 2: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] 🚧 ✅ stress: stress-ng [9] x86_64: Host 1: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ audit: audit testsuite test [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] 🚧 ✅ stress: stress-ng [9] Host 2: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [10] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 6 months

1
0
0 0

[PATCH 16/18] bcache: only set BCACHE_DEV_WB_RUNNING when cached device attached

by Coly Li

When people set a writeback percent via sysfs file, /sys/block/bcache<N>/bcache/writeback_percent current code directly sets BCACHE_DEV_WB_RUNNING to dc->disk.flags and schedules kworker dc->writeback_rate_update. If there is no cache set attached to, the writebac kernel thread is not running indeed, running dc->writeback_rate_update does not make sense and may cause NULL pointer deference when reference cache set pointer inside update_writeback_rate(). This patch checks whether the cache set point (dc->disk.c) is NULL in sysfs interface handler, and only set BCACHE_DEV_WB_RUNNING and schedule dc->writeback_rate_update when dc->disk.c is not NULL (it means the cache device is attached to a cache set). This problem might be introduced from initial bcache commit, but commit 3fd47bfe55b0 ("bcache: stop dc->writeback_rate_update properly") changes part of the orignal code piece, so I add 'Fixes: 3fd47bfe55b0' to indicate from which commit this patch can be applied. Fixes: 3fd47bfe55b0 ("bcache: stop dc->writeback_rate_update properly") Reported-by: Bjørn Forsman <bjorn.forsman(a)gmail.com> Signed-off-by: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org --- drivers/md/bcache/sysfs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 129031663cc8..eb678e43ac00 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -430,8 +430,13 @@ STORE(bch_cached_dev) bch_writeback_queue(dc); } + /* + * Only set BCACHE_DEV_WB_RUNNING when cached device attached to + * a cache set, otherwise it doesn't make sense. + */ if (attr == &sysfs_writeback_percent) - if (!test_and_set_bit(BCACHE_DEV_WB_RUNNING, &dc->disk.flags)) + if ((dc->disk.c != NULL) && + (!test_and_set_bit(BCACHE_DEV_WB_RUNNING, &dc->disk.flags))) schedule_delayed_work(&dc->writeback_rate_update, dc->writeback_rate_update_seconds * HZ); -- 2.16.4

5 years, 6 months

1
0
0 0

[PATCH] include/linux/bitops.h: sanitize rotate primitives

by Matthias Kaehlcke

From: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> commit ef4d6f6b275c498f8e5626c99dbeefdc5027f843 upstream. The ror32 implementation (word >> shift) | (word << (32 - shift) has undefined behaviour if shift is outside the [1, 31] range. Similarly for the 64 bit variants. Most callers pass a compile-time constant (naturally in that range), but there's an UBSAN report that these may actually be called with a shift count of 0. Instead of special-casing that, we can make them DTRT for all values of shift while also avoiding UB. For some reason, this was already partly done for rol32 (which was well-defined for [0, 31]). gcc 8 recognizes these patterns as rotates, so for example __u32 rol32(__u32 word, unsigned int shift) { return (word << (shift & 31)) | (word >> ((-shift) & 31)); } compiles to 0000000000000020 <rol32>: 20: 89 f8 mov %edi,%eax 22: 89 f1 mov %esi,%ecx 24: d3 c0 rol %cl,%eax 26: c3 retq Older compilers unfortunately do not do as well, but this only affects the small minority of users that don't pass constants. Due to integer promotions, ro[lr]8 were already well-defined for shifts in [0, 8], and ro[lr]16 were mostly well-defined for shifts in [0, 16] (only mostly - u16 gets promoted to _signed_ int, so if bit 15 is set, word << 16 is undefined). For consistency, update those as well. Link: http://lkml.kernel.org/r/20190410211906.2190-1-linux@rasmusvillemoes.dk Signed-off-by: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> Reported-by: Ido Schimmel <idosch(a)mellanox.com> Tested-by: Ido Schimmel <idosch(a)mellanox.com> Reviewed-by: Will Deacon <will.deacon(a)arm.com> Cc: Vadim Pasternak <vadimp(a)mellanox.com> Cc: Andrey Ryabinin <aryabinin(a)virtuozzo.com> Cc: Jacek Anaszewski <jacek.anaszewski(a)gmail.com> Cc: Pavel Machek <pavel(a)ucw.cz> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- Hi Greg and Sasha, Please pick this patch for 4.19. It fixes (at least) crashes due to undefined instructions in BPF code on arm32 when building with clang: [ 4.271668] Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP ARM [ 4.271675] Modules linked in: [ 4.284143] joydev [ 4.284155] CPU: 2 PID: 279 Comm: udevd Not tainted 4.19.44 #95 [ 4.284157] Hardware name: Rockchip (Device Tree) [ 4.284167] PC is at 0xbf017de8 [ 4.284176] LR is at sk_filter_trim_cap+0xfc/0x244 [ 4.284181] pc : [<bf017de8>] lr : [<c0890c34>] psr: 60070013 [ 4.323863] sp : ed36fcd8 ip : 00000000 fp : ed36fd28 [ 4.329698] r10: c100b608 r9 : 00000000 r8 : ed2d6600 [ 4.335531] r7 : 00000000 r6 : 00000071 r5 : 00000000 r4 : ed59c180 [ 4.342812] r3 : 00000000 r2 : ed59c180 r1 : 00000000 r0 : 2a1884a1 [ 4.350105] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 4.358075] Control: 30c5387d Table: 2d22b880 DAC: 44541fd3 [ 4.364495] Process udevd (pid: 279, stack limit = 0xb5b8ffdf) [ 4.371009] Stack: (0xed36fcd8 to 0xed370000) [ 4.375864] fcc0: bf017a9c 60070013 [ 4.385001] fce0: 00000000 00000000 ed36fcd8 00000000 00000089 00000000 ed2d6600 00000000 [ 4.394137] fd00: 00000000 00000000 ed59c180 f0c12000 00000000 ed289000 ed59c1a0 00000001 [ 4.403274] fd20: 00000071 00000000 ed59c180 f0c12000 00000000 ed289000 ed59c1a0 00000001 ... [ 4.613384] [<c0890c34>] (sk_filter_trim_cap) from [<00000001>] (0x1) [ 4.620580] Code: aa000002 e0200000 e3a01000 ea000045 (f7e6c179) Thanks Matthias --- include/linux/bitops.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/bitops.h b/include/linux/bitops.h index 7ddb1349394d..7ac2e46112b7 100644 --- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -60,7 +60,7 @@ static __always_inline unsigned long hweight_long(unsigned long w) */ static inline __u64 rol64(__u64 word, unsigned int shift) { - return (word << shift) | (word >> (64 - shift)); + return (word << (shift & 63)) | (word >> ((-shift) & 63)); } /** @@ -70,7 +70,7 @@ static inline __u64 rol64(__u64 word, unsigned int shift) */ static inline __u64 ror64(__u64 word, unsigned int shift) { - return (word >> shift) | (word << (64 - shift)); + return (word >> (shift & 63)) | (word << ((-shift) & 63)); } /** @@ -80,7 +80,7 @@ static inline __u64 ror64(__u64 word, unsigned int shift) */ static inline __u32 rol32(__u32 word, unsigned int shift) { - return (word << shift) | (word >> ((-shift) & 31)); + return (word << (shift & 31)) | (word >> ((-shift) & 31)); } /** @@ -90,7 +90,7 @@ static inline __u32 rol32(__u32 word, unsigned int shift) */ static inline __u32 ror32(__u32 word, unsigned int shift) { - return (word >> shift) | (word << (32 - shift)); + return (word >> (shift & 31)) | (word << ((-shift) & 31)); } /** @@ -100,7 +100,7 @@ static inline __u32 ror32(__u32 word, unsigned int shift) */ static inline __u16 rol16(__u16 word, unsigned int shift) { - return (word << shift) | (word >> (16 - shift)); + return (word << (shift & 15)) | (word >> ((-shift) & 15)); } /** @@ -110,7 +110,7 @@ static inline __u16 rol16(__u16 word, unsigned int shift) */ static inline __u16 ror16(__u16 word, unsigned int shift) { - return (word >> shift) | (word << (16 - shift)); + return (word >> (shift & 15)) | (word << ((-shift) & 15)); } /** @@ -120,7 +120,7 @@ static inline __u16 ror16(__u16 word, unsigned int shift) */ static inline __u8 rol8(__u8 word, unsigned int shift) { - return (word << shift) | (word >> (8 - shift)); + return (word << (shift & 7)) | (word >> ((-shift) & 7)); } /** @@ -130,7 +130,7 @@ static inline __u8 rol8(__u8 word, unsigned int shift) */ static inline __u8 ror8(__u8 word, unsigned int shift) { - return (word >> shift) | (word << (8 - shift)); + return (word >> (shift & 7)) | (word << ((-shift) & 7)); } /** -- 2.22.0.rc1.311.g5d7573a151-goog

5 years, 6 months

2
2
0 0

[PATCH 03/15] bcache: ignore read-ahead request failure on backing device

by Coly Li

When md raid device (e.g. raid456) is used as backing device, read-ahead requests on a degrading and recovering md raid device might be failured immediately by md raid code, but indeed this md raid array can still be read or write for normal I/O requests. Therefore such failed read-ahead request are not real hardware failure. Further more, after degrading and recovering accomplished, read-ahead requests will be handled by md raid array again. For such condition, I/O failures of read-ahead requests don't indicate real health status (because normal I/O still be served), they should not be counted into I/O error counter dc->io_errors. Since there is no simple way to detect whether the backing divice is a md raid device, this patch simply ignores I/O failures for read-ahead bios on backing device, to avoid bogus backing device failure on a degrading md raid array. Suggested-and-tested-by: Thorsten Knabe <linux(a)thorsten-knabe.de> Signed-off-by: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org --- drivers/md/bcache/io.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c index c25097968319..4d93f07f63e5 100644 --- a/drivers/md/bcache/io.c +++ b/drivers/md/bcache/io.c @@ -58,6 +58,18 @@ void bch_count_backing_io_errors(struct cached_dev *dc, struct bio *bio) WARN_ONCE(!dc, "NULL pointer of struct cached_dev"); + /* + * Read-ahead requests on a degrading and recovering md raid + * (e.g. raid6) device might be failured immediately by md + * raid code, which is not a real hardware media failure. So + * we shouldn't count failed REQ_RAHEAD bio to dc->io_errors. + */ + if (bio->bi_opf & REQ_RAHEAD) { + pr_warn_ratelimited("%s: Read-ahead I/O failed on backing device, ignore", + dc->backing_dev_name); + return; + } + errors = atomic_add_return(1, &dc->io_errors); if (errors < dc->error_limit) pr_err("%s: IO error on backing device, unrecoverable", -- 2.16.4

5 years, 6 months

1
0
0 0

[PATCH 01/15] Revert "bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error()"

by Coly Li

This reverts commit 6147305c73e4511ca1a975b766b97a779d442567. Although this patch helps the failed bcache device to stop faster when too many I/O errors detected on corresponding cached device, setting CACHE_SET_IO_DISABLE bit to cache set c->flags was not a good idea. This operation will disable all I/Os on cache set, which means other attached bcache devices won't work neither. Without this patch, the failed bcache device can also be stopped eventually if internal I/O accomplished (e.g. writeback). Therefore here I revert it. Fixes: 6147305c73e4 ("bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error()") Reported-by: Yong Li <mr.liyong(a)qq.com> Signed-off-by: Coly Li <colyli(a)suse.de> Cc: stable(a)vger.kernel.org --- drivers/md/bcache/super.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 1b63ac876169..eaaa046fd95d 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1437,8 +1437,6 @@ int bch_flash_dev_create(struct cache_set *c, uint64_t size) bool bch_cached_dev_error(struct cached_dev *dc) { - struct cache_set *c; - if (!dc || test_bit(BCACHE_DEV_CLOSING, &dc->disk.flags)) return false; @@ -1449,21 +1447,6 @@ bool bch_cached_dev_error(struct cached_dev *dc) pr_err("stop %s: too many IO errors on backing device %s\n", dc->disk.disk->disk_name, dc->backing_dev_name); - /* - * If the cached device is still attached to a cache set, - * even dc->io_disable is true and no more I/O requests - * accepted, cache device internal I/O (writeback scan or - * garbage collection) may still prevent bcache device from - * being stopped. So here CACHE_SET_IO_DISABLE should be - * set to c->flags too, to make the internal I/O to cache - * device rejected and stopped immediately. - * If c is NULL, that means the bcache device is not attached - * to any cache set, then no CACHE_SET_IO_DISABLE bit to set. - */ - c = dc->disk.c; - if (c && test_and_set_bit(CACHE_SET_IO_DISABLE, &c->flags)) - pr_info("CACHE_SET_IO_DISABLE already set"); - bcache_device_stop(&dc->disk); return true; } -- 2.16.4

5 years, 6 months

1
0
0 0

stable/linux-5.0.y boot: 67 boots: 0 failed, 67 passed (v5.0.21)

by kernelci.org bot

stable/linux-5.0.y boot: 67 boots: 0 failed, 67 passed (v5.0.21) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-5.0.y/kernel/v5.0.21/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.0.y/kernel/v5.0.21/ Tree: stable Branch: linux-5.0.y Git Describe: v5.0.21 Git Commit: fd1594eb706427cc0d88fdfc2c1dbecd5abe7a83 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 35 unique boards, 16 SoC families, 11 builds out of 208 --- For more info write to <info(a)kernelci.org>

5 years, 6 months

1
0
0 0

[4.4] Security fixes

by Ben Hutchings

I've attached the following fixes to 4.4, as an mbox: - binder: Replace "%p" with "%pK" for stable - binder: replace "%p" with "%pK" - net: create skb_gso_validate_mac_len() - bnx2x: disable GSO where gso_size is too big for hardware - brcmfmac: Add length checks on firmware events - brcmfmac: screening firmware event packet - brcmfmac: revise handling events in receive path - brcmfmac: fix incorrect event channel deduction - brcmfmac: add length checks in scheduled scan result handler - brcmfmac: add subtype check for event handling in data path - userfaultfd: don't pin the user memory in userfaultfd_file_create() - coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping The userfaultfd commit might not be a security fix but the next one depends on it. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom

5 years, 6 months

2
1
0 0

[4.9] Security fixes

by Ben Hutchings

I've attached the following fixes to 4.9, as an mbox: - brcmfmac: add length checks in scheduled scan result handler - brcmfmac: assure SSID length from firmware is limited - brcmfmac: add subtype check for event handling in data path - binder: Replace "%p" with "%pK" for stable - binder: replace "%p" with "%pK" - fs: prevent page refcount overflow in pipe_buf_get - mm, gup: remove broken VM_BUG_ON_PAGE compound check for hugepages - mm, gup: ensure real head page is ref-counted when using hugepages - mm: prevent get_user_pages() from overflowing page refcount - mm: make page ref count overflow check tighter and more explicit - coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping The first two "mm, gup" commits might not be strictly security fixes but the next one depends on them. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom

5 years, 6 months

2
2
0 0

[PATCH BACKPORT 4.19 1/2] Compiler Attributes: add support for __copy (gcc >= 9)

by Stefan Agner

From: Miguel Ojeda <miguel.ojeda.sandonis(a)gmail.com> [ Upstream commit c0d9782f5b6d7157635ae2fd782a4b27d55a6013 ] >From the GCC manual: copy copy(function) The copy attribute applies the set of attributes with which function has been declared to the declaration of the function to which the attribute is applied. The attribute is designed for libraries that define aliases or function resolvers that are expected to specify the same set of attributes as their targets. The copy attribute can be used with functions, variables, or types. However, the kind of symbol to which the attribute is applied (either function or variable) must match the kind of symbol to which the argument refers. The copy attribute copies only syntactic and semantic attributes but not attributes that affect a symbol’s linkage or visibility such as alias, visibility, or weak. The deprecated attribute is also not copied. https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html The upcoming GCC 9 release extends the -Wmissing-attributes warnings (enabled by -Wall) to C and aliases: it warns when particular function attributes are missing in the aliases but not in their target, e.g.: void __cold f(void) {} void __alias("f") g(void); diagnoses: warning: 'g' specifies less restrictive attribute than its target 'f': 'cold' [-Wmissing-attributes] Using __copy(f) we can copy the __cold attribute from f to g: void __cold f(void) {} void __copy(f) __alias("f") g(void); This attribute is most useful to deal with situations where an alias is declared but we don't know the exact attributes the target has. For instance, in the kernel, the widely used module_init/exit macros define the init/cleanup_module aliases, but those cannot be marked always as __init/__exit since some modules do not have their functions marked as such. Cc: <stable(a)vger.kernel.org> # 4.14+ Suggested-by: Martin Sebor <msebor(a)gcc.gnu.org> Reviewed-by: Nick Desaulniers <ndesaulniers(a)google.com> Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis(a)gmail.com> Signed-off-by: Stefan Agner <stefan(a)agner.ch> --- include/linux/compiler-gcc.h | 4 ++++ include/linux/compiler_types.h | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index a8ff0ca0c321..3ebee1ce6f98 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -201,6 +201,10 @@ #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1 #endif +#if GCC_VERSION >= 90100 +#define __copy(symbol) __attribute__((__copy__(symbol))) +#endif + #if !defined(__noclone) #define __noclone /* not needed */ #endif diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index c2ded31a4cec..2b8ed70c4c77 100644 --- a/include/linux/compiler_types.h +++ b/include/linux/compiler_types.h @@ -180,6 +180,10 @@ struct ftrace_likely_data { #define __diag_GCC(version, severity, string) #endif +#ifndef __copy +# define __copy(symbol) +#endif + #define __diag_push() __diag(push) #define __diag_pop() __diag(pop) -- 2.21.0

5 years, 6 months

2
2
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror June 2019