May 2019 - Linux-stable-mirror

[for-next][PATCH 11/13] tracing: Fix partial reading of trace events id file

by Steven Rostedt

From: Elazar Leibovich <elazar(a)lightbitslabs.com> When reading only part of the id file, the ppos isn't tracked correctly. This is taken care by simple_read_from_buffer. Reading a single byte, and then the next byte would result EOF. While this seems like not a big deal, this breaks abstractions that reads information from files unbuffered. See for example https://github.com/golang/go/issues/29399 This code was mentioned as problematic in commit cd458ba9d5a5 ("tracing: Do not (ab)use trace_seq in event_id_read()") An example C code that show this bug is: #include <stdio.h> #include <stdint.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> #include <unistd.h> int main(int argc, char **argv) { if (argc < 2) return 1; int fd = open(argv[1], O_RDONLY); char c; read(fd, &c, 1); printf("First %c\n", c); read(fd, &c, 1); printf("Second %c\n", c); } Then run with, e.g. sudo ./a.out /sys/kernel/debug/tracing/events/tcp/tcp_set_state/id You'll notice you're getting the first character twice, instead of the first two characters in the id file. Link: http://lkml.kernel.org/r/20181231115837.4932-1-elazar@lightbitslabs.com Cc: Orit Wasserman <orit.was(a)gmail.com> Cc: Oleg Nesterov <oleg(a)redhat.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: stable(a)vger.kernel.org Fixes: 23725aeeab10b ("ftrace: provide an id file for each event") Signed-off-by: Elazar Leibovich <elazar(a)lightbitslabs.com> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- kernel/trace/trace_events.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 81c038ed6cee..0ce3db67f556 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1319,9 +1319,6 @@ event_id_read(struct file *filp, char __user *ubuf, size_t cnt, loff_t *ppos) char buf[32]; int len; - if (*ppos) - return 0; - if (unlikely(!id)) return -ENODEV; -- 2.20.1

5 years, 11 months

1
0
0 0

[for-next][PATCH 06/13] tracing: probeevent: Fix to make the type of $comm string

by Steven Rostedt

From: Masami Hiramatsu <mhiramat(a)kernel.org> Fix to make the type of $comm "string". If we set the other type to $comm argument, it shows meaningless value or wrong data. Currently probe events allow us to set string array type (e.g. ":string[2]"), or other digit types like x8 on $comm. But since clearly $comm is just a string data, it should not be fetched by other types including array. Link: http://lkml.kernel.org/r/155723736241.9149.14582064184468574539.stgit@devno… Cc: Andreas Ziegler <andreas.ziegler(a)fau.de> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: stable(a)vger.kernel.org Fixes: 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code") Signed-off-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- kernel/trace/trace_probe.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 4cc2d467d34c..e0d1d5353464 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -533,13 +533,14 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size, } } } - /* - * The default type of $comm should be "string", and it can't be - * dereferenced. - */ - if (!t && strcmp(arg, "$comm") == 0) + + /* Since $comm can not be dereferred, we can find $comm by strcmp */ + if (strcmp(arg, "$comm") == 0) { + /* The type of $comm must be "string", and not an array. */ + if (parg->count || (t && strcmp(t, "string"))) + return -EINVAL; parg->type = find_fetch_type("string"); - else + } else parg->type = find_fetch_type(t); if (!parg->type) { trace_probe_log_err(offset + (t ? (t - arg) : 0), BAD_TYPE); -- 2.20.1

5 years, 11 months

1
0
0 0

[for-next][PATCH 03/13] ftrace/x86_64: Emulate call function while updating in breakpoint handler

by Steven Rostedt

From: Peter Zijlstra <peterz(a)infradead.org> Nicolai Stange discovered[1] that if live kernel patching is enabled, and the function tracer started tracing the same function that was patched, the conversion of the fentry call site during the translation of going from calling the live kernel patch trampoline to the iterator trampoline, would have as slight window where it didn't call anything. As live kernel patching depends on ftrace to always call its code (to prevent the function being traced from being called, as it will redirect it). This small window would allow the old buggy function to be called, and this can cause undesirable results. Nicolai submitted new patches[2] but these were controversial. As this is similar to the static call emulation issues that came up a while ago[3]. But after some debate[4][5] adding a gap in the stack when entering the breakpoint handler allows for pushing the return address onto the stack to easily emulate a call. [1] http://lkml.kernel.org/r/20180726104029.7736-1-nstange@suse.de [2] http://lkml.kernel.org/r/20190427100639.15074-1-nstange@suse.de [3] http://lkml.kernel.org/r/3cf04e113d71c9f8e4be95fb84a510f085aa4afa.154171145… [4] http://lkml.kernel.org/r/CAHk-=wh5OpheSU8Em_Q3Hg8qw_JtoijxOdPtHru6d+5K8TWM=… [5] http://lkml.kernel.org/r/CAHk-=wjvQxY4DvPrJ6haPgAa6b906h=MwZXO6G8OtiTGe=N7_… [ Live kernel patching is not implemented on x86_32, thus the emulate calls are only for x86_64. ] Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Nicolai Stange <nstange(a)suse.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Borislav Petkov <bp(a)alien8.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: the arch/x86 maintainers <x86(a)kernel.org> Cc: Josh Poimboeuf <jpoimboe(a)redhat.com> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Miroslav Benes <mbenes(a)suse.cz> Cc: Petr Mladek <pmladek(a)suse.com> Cc: Joe Lawrence <joe.lawrence(a)redhat.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> Cc: Tim Chen <tim.c.chen(a)linux.intel.com> Cc: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Cc: Mimi Zohar <zohar(a)linux.ibm.com> Cc: Juergen Gross <jgross(a)suse.com> Cc: Nick Desaulniers <ndesaulniers(a)google.com> Cc: Nayna Jain <nayna(a)linux.ibm.com> Cc: Masahiro Yamada <yamada.masahiro(a)socionext.com> Cc: Joerg Roedel <jroedel(a)suse.de> Cc: "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest(a)vger.kernel.org> Cc: stable(a)vger.kernel.org Fixes: b700e7f03df5 ("livepatch: kernel: add support for live patching") Tested-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> [ Changed to only implement emulated calls for x86_64 ] Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- arch/x86/kernel/ftrace.c | 32 +++++++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index ef49517f6bb2..bd553b3af22e 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c @@ -29,6 +29,7 @@ #include <asm/kprobes.h> #include <asm/ftrace.h> #include <asm/nops.h> +#include <asm/text-patching.h> #ifdef CONFIG_DYNAMIC_FTRACE @@ -231,6 +232,7 @@ int ftrace_modify_call(struct dyn_ftrace *rec, unsigned long old_addr, } static unsigned long ftrace_update_func; +static unsigned long ftrace_update_func_call; static int update_ftrace_func(unsigned long ip, void *new) { @@ -259,6 +261,8 @@ int ftrace_update_ftrace_func(ftrace_func_t func) unsigned char *new; int ret; + ftrace_update_func_call = (unsigned long)func; + new = ftrace_call_replace(ip, (unsigned long)func); ret = update_ftrace_func(ip, new); @@ -294,13 +298,28 @@ int ftrace_int3_handler(struct pt_regs *regs) if (WARN_ON_ONCE(!regs)) return 0; - ip = regs->ip - 1; - if (!ftrace_location(ip) && !is_ftrace_caller(ip)) - return 0; + ip = regs->ip - INT3_INSN_SIZE; - regs->ip += MCOUNT_INSN_SIZE - 1; +#ifdef CONFIG_X86_64 + if (ftrace_location(ip)) { + int3_emulate_call(regs, (unsigned long)ftrace_regs_caller); + return 1; + } else if (is_ftrace_caller(ip)) { + if (!ftrace_update_func_call) { + int3_emulate_jmp(regs, ip + CALL_INSN_SIZE); + return 1; + } + int3_emulate_call(regs, ftrace_update_func_call); + return 1; + } +#else + if (ftrace_location(ip) || is_ftrace_caller(ip)) { + int3_emulate_jmp(regs, ip + CALL_INSN_SIZE); + return 1; + } +#endif - return 1; + return 0; } NOKPROBE_SYMBOL(ftrace_int3_handler); @@ -859,6 +878,8 @@ void arch_ftrace_update_trampoline(struct ftrace_ops *ops) func = ftrace_ops_get_func(ops); + ftrace_update_func_call = (unsigned long)func; + /* Do a safe modify in case the trampoline is executing */ new = ftrace_call_replace(ip, (unsigned long)func); ret = update_ftrace_func(ip, new); @@ -960,6 +981,7 @@ static int ftrace_mod_jmp(unsigned long ip, void *func) { unsigned char *new; + ftrace_update_func_call = 0UL; new = ftrace_jmp_replace(ip, (unsigned long)func); return update_ftrace_func(ip, new); -- 2.20.1

5 years, 11 months

1
0
0 0

[for-next][PATCH 02/13] x86_64: Allow breakpoints to emulate call instructions

by Steven Rostedt

From: Peter Zijlstra <peterz(a)infradead.org> In order to allow breakpoints to emulate call instructions, they need to push the return address onto the stack. The x86_64 int3 handler adds a small gap to allow the stack to grow some. Use this gap to add the return address to be able to emulate a call instruction at the breakpoint location. These helper functions are added: int3_emulate_jmp(): changes the location of the regs->ip to return there. (The next two are only for x86_64) int3_emulate_push(): to push the address onto the gap in the stack int3_emulate_call(): push the return address and change regs->ip Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Nicolai Stange <nstange(a)suse.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Borislav Petkov <bp(a)alien8.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: the arch/x86 maintainers <x86(a)kernel.org> Cc: Josh Poimboeuf <jpoimboe(a)redhat.com> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Miroslav Benes <mbenes(a)suse.cz> Cc: Petr Mladek <pmladek(a)suse.com> Cc: Joe Lawrence <joe.lawrence(a)redhat.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> Cc: Tim Chen <tim.c.chen(a)linux.intel.com> Cc: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Cc: Mimi Zohar <zohar(a)linux.ibm.com> Cc: Juergen Gross <jgross(a)suse.com> Cc: Nick Desaulniers <ndesaulniers(a)google.com> Cc: Nayna Jain <nayna(a)linux.ibm.com> Cc: Masahiro Yamada <yamada.masahiro(a)socionext.com> Cc: Joerg Roedel <jroedel(a)suse.de> Cc: "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest(a)vger.kernel.org> Cc: stable(a)vger.kernel.org Fixes: b700e7f03df5 ("livepatch: kernel: add support for live patching") Tested-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org> [ Modified to only work for x86_64 and added comment to int3_emulate_push() ] Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- arch/x86/include/asm/text-patching.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/arch/x86/include/asm/text-patching.h b/arch/x86/include/asm/text-patching.h index e85ff65c43c3..05861cc08787 100644 --- a/arch/x86/include/asm/text-patching.h +++ b/arch/x86/include/asm/text-patching.h @@ -39,4 +39,32 @@ extern int poke_int3_handler(struct pt_regs *regs); extern void *text_poke_bp(void *addr, const void *opcode, size_t len, void *handler); extern int after_bootmem; +static inline void int3_emulate_jmp(struct pt_regs *regs, unsigned long ip) +{ + regs->ip = ip; +} + +#define INT3_INSN_SIZE 1 +#define CALL_INSN_SIZE 5 + +#ifdef CONFIG_X86_64 +static inline void int3_emulate_push(struct pt_regs *regs, unsigned long val) +{ + /* + * The int3 handler in entry_64.S adds a gap between the + * stack where the break point happened, and the saving of + * pt_regs. We can extend the original stack because of + * this gap. See the idtentry macro's create_gap option. + */ + regs->sp -= sizeof(unsigned long); + *(unsigned long *)regs->sp = val; +} + +static inline void int3_emulate_call(struct pt_regs *regs, unsigned long func) +{ + int3_emulate_push(regs, regs->ip - INT3_INSN_SIZE + CALL_INSN_SIZE); + int3_emulate_jmp(regs, func); +} +#endif + #endif /* _ASM_X86_TEXT_PATCHING_H */ -- 2.20.1

5 years, 11 months

1
0
0 0

[for-next][PATCH 01/13] x86_64: Add gap to int3 to allow for call emulation

by Steven Rostedt

From: Josh Poimboeuf <jpoimboe(a)redhat.com> To allow an int3 handler to emulate a call instruction, it must be able to push a return address onto the stack. Add a gap to the stack to allow the int3 handler to push the return address and change the return from int3 to jump straight to the emulated called function target. Link: http://lkml.kernel.org/r/20181130183917.hxmti5josgq4clti@treble Link: http://lkml.kernel.org/r/20190502162133.GX2623@hirez.programming.kicks-ass.… [ Note, this is needed to allow Live Kernel Patching to not miss calling a patched function when tracing is enabled. -- Steven Rostedt ] Cc: stable(a)vger.kernel.org Fixes: b700e7f03df5 ("livepatch: kernel: add support for live patching") Tested-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Nicolai Stange <nstange(a)suse.de> Reviewed-by: Masami Hiramatsu <mhiramat(a)kernel.org> Signed-off-by: Josh Poimboeuf <jpoimboe(a)redhat.com> Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- arch/x86/entry/entry_64.S | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 1f0efdb7b629..27fcc6fbdd52 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -879,7 +879,7 @@ apicinterrupt IRQ_WORK_VECTOR irq_work_interrupt smp_irq_work_interrupt * @paranoid == 2 is special: the stub will never switch stacks. This is for * #DF: if the thread stack is somehow unusable, we'll still get a useful OOPS. */ -.macro idtentry sym do_sym has_error_code:req paranoid=0 shift_ist=-1 +.macro idtentry sym do_sym has_error_code:req paranoid=0 shift_ist=-1 create_gap=0 ENTRY(\sym) UNWIND_HINT_IRET_REGS offset=\has_error_code*8 @@ -899,6 +899,20 @@ ENTRY(\sym) jnz .Lfrom_usermode_switch_stack_\@ .endif + .if \create_gap == 1 + /* + * If coming from kernel space, create a 6-word gap to allow the + * int3 handler to emulate a call instruction. + */ + testb $3, CS-ORIG_RAX(%rsp) + jnz .Lfrom_usermode_no_gap_\@ + .rept 6 + pushq 5*8(%rsp) + .endr + UNWIND_HINT_IRET_REGS offset=8 +.Lfrom_usermode_no_gap_\@: + .endif + .if \paranoid call paranoid_entry .else @@ -1130,7 +1144,7 @@ apicinterrupt3 HYPERV_STIMER0_VECTOR \ #endif /* CONFIG_HYPERV */ idtentry debug do_debug has_error_code=0 paranoid=1 shift_ist=DEBUG_STACK -idtentry int3 do_int3 has_error_code=0 +idtentry int3 do_int3 has_error_code=0 create_gap=1 idtentry stack_segment do_stack_segment has_error_code=1 #ifdef CONFIG_XEN_PV -- 2.20.1

5 years, 11 months

1
0
0 0

Re: [PATCH 1/2] NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter

by Yihao Wu

On 2019/5/8 8:24 PM, Jeff Layton wrote: > On Wed, 2019-05-08 at 17:13 +0800, Yihao Wu wrote: >> Commit b7dbcc0e433f ""NFSv4.1: Fix a race where CB_NOTIFY_LOCK fails >> to wake a waiter" found this bug. However it didn't fix it. This can >> be fixed by adding memory barrier pair. >> >> Specifically, if any CB_NOTIFY_LOCK should be handled between unlocking >> the wait queue and freezable_schedule_timeout, only two cases are >> possible. So CB_NOTIFY_LOCK will not be dropped unexpectly. >> >> 1. The callback thread marks the NFS client as waked. Then NFS client >> noticed that itself is waked, so it don't goes to sleep. And it cleans >> its wake mark. >> >> 2. The NFS client noticed that itself is not waked yet, so it goes to >> sleep. No modification will ever happen to the wake mark in between. >> > > It's not clear to me what you mean by "wake mark" here. Do you mean the > "notified" flag? This could use a better description. Yes. I mean "notified flag" by "wake mark". I will clear these ambiguities. Thanks > >> Fixes: a1d617d ("nfs: allow blocking locks to be awoken by lock callbacks") >> Signed-off-by: Yihao Wu <wuyihao(a)linux.alibaba.com> >> --- >> fs/nfs/nfs4proc.c | 21 +++++---------------- >> 1 file changed, 5 insertions(+), 16 deletions(-) >> >> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c >> index 741ff8c..f13ea09 100644 >> --- a/fs/nfs/nfs4proc.c >> +++ b/fs/nfs/nfs4proc.c >> @@ -6867,7 +6867,6 @@ struct nfs4_lock_waiter { >> struct task_struct *task; >> struct inode *inode; >> struct nfs_lowner *owner; >> - bool notified; >> }; >> >> static int >> @@ -6889,13 +6888,13 @@ struct nfs4_lock_waiter { >> /* Make sure it's for the right inode */ >> if (nfs_compare_fh(NFS_FH(waiter->inode), &cbnl->cbnl_fh)) >> return 0; >> - >> - waiter->notified = true; >> } >> >> /* override "private" so we can use default_wake_function */ >> wait->private = waiter->task; >> - ret = autoremove_wake_function(wait, mode, flags, key); >> + ret = woken_wake_function(wait, mode, flags, key); >> + if (ret) >> + list_del_init(&wait->entry); >> wait->private = waiter; >> return ret; >> } >> @@ -6914,8 +6913,7 @@ struct nfs4_lock_waiter { >> .s_dev = server->s_dev }; >> struct nfs4_lock_waiter waiter = { .task = current, >> .inode = state->inode, >> - .owner = &owner, >> - .notified = false }; >> + .owner = &owner}; >> wait_queue_entry_t wait; >> >> /* Don't bother with waitqueue if we don't expect a callback */ >> @@ -6928,21 +6926,12 @@ struct nfs4_lock_waiter { >> add_wait_queue(q, &wait); >> >> while(!signalled()) { >> - waiter.notified = false; >> status = nfs4_proc_setlk(state, cmd, request); >> if ((status != -EAGAIN) || IS_SETLK(cmd)) >> break; >> >> status = -ERESTARTSYS; >> - spin_lock_irqsave(&q->lock, flags); >> - if (waiter.notified) { >> - spin_unlock_irqrestore(&q->lock, flags); >> - continue; >> - } >> - set_current_state(TASK_INTERRUPTIBLE); >> - spin_unlock_irqrestore(&q->lock, flags); >> - >> - freezable_schedule_timeout(NFS4_LOCK_MAXTIMEOUT); >> + wait_woken(&wait, TASK_INTERRUPTIBLE, NFS4_LOCK_MAXTIMEOUT); > > This seems to have dropped the "freezable" part above, such that waiting > on a file lock will prevent (e.g.) a laptop from suspending. I think > that needs to be in here as those waits can be quite long. > You're right. I overlooked this. This will be fixed. Thanks >> } >> >> finish_wait(q, &wait); >

5 years, 11 months

1
0
0 0

Re: [PATCH AUTOSEL 4.19 29/53] drm/amdkfd: Add picasso pci id

by Sasha Levin

On Sat, Apr 27, 2019 at 01:49:27PM +0000, Deucher, Alexander wrote: >NACK. 4.19 did not contain support for picasso. Please drop this patch for 4.19. Dropped, thank you! -- Thanks, Sasha

5 years, 11 months

1
0
0 0

✅ PASS: Stable queue: queue-5.0

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: e5b9547b1aa3 - Linux 5.0.13 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: e5b9547b1aa3 - Linux 5.0.13 We then merged the patchset with `git am`: selftests-seccomp-prepare-for-exclusive-seccomp-flags.patch seccomp-make-new_listener-and-tsync-flags-exclusive.patch arc-memset-fix-build-with-l1_cache_shift-6.patch iwlwifi-fix-driver-operation-for-5350.patch mwifiex-make-resume-actually-do-something-useful-again-on-sdio-cards.patch mtd-rawnand-marvell-clean-the-controller-state-before-each-operation.patch mac80211-don-t-attempt-to-rename-err_ptr-debugfs-dirs.patch i2c-synquacer-fix-enumeration-of-slave-devices.patch i2c-imx-correct-the-method-of-getting-private-data-in-notifier_call.patch i2c-prevent-runtime-suspend-of-adapter-when-host-notify-is-required.patch alsa-hda-realtek-add-new-dell-platform-for-headset-mode.patch alsa-hda-realtek-fixed-dell-aio-speaker-noise.patch alsa-hda-realtek-apply-the-fixup-for-asus-q325uar.patch usb-yurex-fix-protection-fault-after-device-removal.patch usb-w1-ds2490-fix-bug-caused-by-improper-use-of-altsetting-array.patch usb-dummy-hcd-fix-failure-to-give-back-unlinked-urbs.patch usb-usbip-fix-isoc-packet-num-validation-in-get_pipe.patch usb-core-fix-unterminated-string-returned-by-usb_string.patch usb-core-fix-bug-caused-by-duplicate-interface-pm-usage-counter.patch kvm-lapic-disable-timer-advancement-if-adaptive-tuning-goes-haywire.patch kvm-x86-consider-lapic-tsc-deadline-timer-expired-if-deadline-too-short.patch kvm-lapic-track-lapic-timer-advance-per-vcpu.patch kvm-lapic-allow-user-to-disable-adaptive-tuning-of-timer-advancement.patch kvm-lapic-convert-guest-tsc-to-host-time-domain-if-necessary.patch arm64-dts-rockchip-fix-rk3328-roc-cc-gmac2io-tx-rx_d.patch hid-increase-maximum-report-size-allowed-by-hid_fiel.patch hid-logitech-check-the-return-value-of-create_single.patch hid-debug-fix-race-condition-with-between-rdesc_show.patch rtc-cros-ec-fail-suspend-resume-if-wake-irq-can-t-be.patch rtc-sh-fix-invalid-alarm-warning-for-non-enabled-ala.patch arm-omap2-add-missing-of_node_put-after-of_device_is.patch batman-adv-reduce-claim-hash-refcnt-only-for-removed.patch batman-adv-reduce-tt_local-hash-refcnt-only-for-remo.patch batman-adv-reduce-tt_global-hash-refcnt-only-for-rem.patch batman-adv-fix-warning-in-function-batadv_v_elp_get_.patch arm-dts-rockchip-fix-gpu-opp-node-names-for-rk3288.patch reset-meson-audio-arb-fix-missing-.owner-setting-of-.patch arm-dts-fix-dcan-clkctrl-clock-for-am3.patch i40e-fix-i40e_ptp_adjtime-when-given-a-negative-delt.patch igb-fix-warn_once-on-runtime-suspend.patch ixgbe-fix-mdio-bus-registration.patch i40e-fix-wol-support-check.patch riscv-fix-accessing-8-byte-variable-from-rv32.patch hid-quirks-fix-keyboard-touchpad-on-lenovo-miix-630.patch net-hns3-fix-compile-error.patch xdp-fix-cpumap-redirect-skb-creation-bug.patch net-mlx5-e-switch-protect-from-invalid-memory-access.patch net-mlx5-e-switch-fix-esw-manager-vport-indication-f.patch bonding-show-full-hw-address-in-sysfs-for-slave-entr.patch net-stmmac-use-correct-dma-buffer-size-in-the-rx-des.patch net-stmmac-ratelimit-rx-error-logs.patch net-stmmac-don-t-stop-napi-processing-when-dropping-.patch net-stmmac-don-t-overwrite-discard_frame-status.patch net-stmmac-fix-dropping-of-multi-descriptor-rx-frame.patch net-stmmac-don-t-log-oversized-frames.patch jffs2-fix-use-after-free-on-symlink-traversal.patch debugfs-fix-use-after-free-on-symlink-traversal.patch mfd-twl-core-disable-irq-while-suspended.patch block-use-blk_free_flush_queue-to-free-hctx-fq-in-bl.patch rtc-da9063-set-uie_unsupported-when-relevant.patch hid-input-add-mapping-for-assistant-key.patch vfio-pci-use-correct-format-characters.patch scsi-core-add-new-rdac-lenovo-de_series-device.patch scsi-storvsc-fix-calculation-of-sub-channel-count.patch arm-mach-at91-pm-fix-possible-object-reference-leak.patch blk-mq-do-not-reset-plug-rq_count-before-the-list-is.patch arm64-fix-wrong-check-of-on_sdei_stack-in-nmi-contex.patch net-hns-fix-kasan-use-after-free-in-hns_nic_net_xmit.patch net-hns-use-napi_poll_weight-for-hns-driver.patch net-hns-fix-probabilistic-memory-overwrite-when-hns-.patch net-hns-fix-icmp6-neighbor-solicitation-messages-dis.patch net-hns-fix-warning-when-remove-hns-driver-with-smmu.patch libcxgb-fix-incorrect-ppmax-calculation.patch kvm-svm-prevent-dbg_decrypt-and-dbg_encrypt-overflow.patch kmemleak-powerpc-skip-scanning-holes-in-the-.bss-sec.patch hugetlbfs-fix-memory-leak-for-resv_map.patch sh-fix-multiple-function-definition-build-errors.patch null_blk-prevent-crash-from-bad-home_node-value.patch xsysace-fix-error-handling-in-ace_setup.patch fs-stream_open-opener-for-stream-like-files-so-that-.patch arm-orion-don-t-use-using-64-bit-dma-masks.patch arm-iop-don-t-use-using-64-bit-dma-masks.patch perf-x86-amd-update-generic-hardware-cache-events-for-family-17h.patch bluetooth-btusb-request-wake-pin-with-noautoen.patch bluetooth-mediatek-fix-up-an-error-path-to-restore-bdev-tx_state.patch clk-qcom-add-missing-freq-for-usb30_master_clk-on-8998.patch usb-dwc3-reset-num_trbs-after-skipping.patch staging-iio-adt7316-allow-adt751x-to-use-internal-vref-for-all-dacs.patch staging-iio-adt7316-fix-the-dac-read-calculation.patch staging-iio-adt7316-fix-handling-of-dac-high-resolution-option.patch staging-iio-adt7316-fix-the-dac-write-calculation.patch scsi-hisi_sas-fix-to-only-call-scsi_get_prot_op-for-non-null-scsi_cmnd.patch scsi-rdma-srpt-fix-a-credit-leak-for-aborted-commands.patch asoc-intel-bytcr_rt5651-revert-fix-dmic-map-headsetmic-mapping.patch asoc-rsnd-gen-fix-ssi9-4-5-6-7-busif-related-register-address.patch asoc-sunxi-sun50i-codec-analog-rename-hpvcc-regulator-supply-to-cpvdd.patch asoc-wm_adsp-correct-handling-of-compressed-streams-that-restart.patch asoc-dpcm-skip-missing-substream-while-applying-symmetry.patch asoc-stm32-fix-sai-driver-name-initialisation.patch kvm-vmx-save-rsi-to-an-unused-output-in-the-vcpu-run-asm-blob.patch kvm-nvmx-remove-a-rogue-rax-clobber-from-nested_vmx_check_vmentry_hw.patch kvm-vmx-fix-typos-in-vmentry-vmexit-control-setting.patch kvm-lapic-check-for-in-kernel-lapic-before-deferencing-apic-pointer.patch platform-x86-intel_pmc_core-fix-pch-ip-name.patch platform-x86-intel_pmc_core-handle-cfl-regmap-properly.patch ib-core-unregister-notifier-before-freeing-mad-security.patch ib-core-fix-potential-memory-leak-while-creating-mad-agents.patch ib-core-destroy-qp-if-xrc-qp-fails.patch input-snvs_pwrkey-initialize-necessary-driver-data-before-enabling-irq.patch input-stmfts-acknowledge-that-setting-brightness-is-a-blocking-call.patch gpio-mxc-add-check-to-return-defer-probe-if-clock-tree-not-ready.patch selinux-avoid-silent-denials-in-permissive-mode-under-rcu-walk.patch selinux-never-allow-relabeling-on-context-mounts.patch mac80211-honor-sw_crypto_control-for-unicast-keys-in-ap-vlan-mode.patch powerpc-mm-hash-handle-mmap_min_addr-correctly-in-get_unmapped_area-topdown-search.patch x86-mce-improve-error-message-when-kernel-cannot-recover-p2.patch clk-x86-add-system-specific-quirk-to-mark-clocks-as-critical.patch x86-mm-kaslr-fix-the-size-of-the-direct-mapping-section.patch x86-mm-fix-a-crash-with-kmemleak_scan.patch x86-mm-tlb-revert-x86-mm-align-tlb-invalidation-info.patch i2c-i2c-stm32f7-fix-sdadel-minimum-formula.patch media-v4l2-i2c-ov7670-fix-pll-bypass-register-values.patch asoc-wm_adsp-check-for-buffer-in-trigger-stop.patch mm-kmemleak.c-fix-unused-function-warning.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue-aarch6… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue-aarch6… ppc64le: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue-ppc64l… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue-ppc64l… s390x: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue-s390x-b2… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue-s390x-b2… x86_64: build options: -j20 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue-x86_64-… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue-x86_64-… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ AMTU (Abstract Machine Test Utility) [4] ✅ Ethernet drivers sanity [5] ✅ httpd: mod_ssl smoke sanity [6] ✅ iotop: sanity [7] ✅ tuned: tune-processes-through-perf [8] ✅ Usex - version 1.9-29 [9] ✅ lvm thinp sanity [10] 🚧 ✅ selinux-policy: serge-testsuite [11] 🚧 ✅ audit: audit testsuite test [12] 🚧 ✅ stress: stress-ng [13] ppc64le: ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ AMTU (Abstract Machine Test Utility) [4] ✅ Ethernet drivers sanity [5] ✅ httpd: mod_ssl smoke sanity [6] ✅ iotop: sanity [7] ✅ tuned: tune-processes-through-perf [8] ✅ Usex - version 1.9-29 [9] ✅ lvm thinp sanity [10] ✅ Boot test [0] ✅ xfstests: xfs [1] 🚧 ✅ audit: audit testsuite test [12] 🚧 ✅ stress: stress-ng [13] 🚧 ✅ selinux-policy: serge-testsuite [11] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Ethernet drivers sanity [5] ✅ httpd: mod_ssl smoke sanity [6] ✅ iotop: sanity [7] ✅ tuned: tune-processes-through-perf [8] ✅ Usex - version 1.9-29 [9] ✅ lvm thinp sanity [10] 🚧 ✅ selinux-policy: serge-testsuite [11] 🚧 ✅ audit: audit testsuite test [12] 🚧 ✅ stress: stress-ng [13] x86_64: ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ AMTU (Abstract Machine Test Utility) [4] ✅ Ethernet drivers sanity [5] ✅ httpd: mod_ssl smoke sanity [6] ✅ iotop: sanity [7] ✅ tuned: tune-processes-through-perf [8] ✅ Usex - version 1.9-29 [9] ✅ lvm thinp sanity [10] ✅ Boot test [0] ✅ xfstests: xfs [1] 🚧 ✅ audit: audit testsuite test [12] 🚧 ✅ stress: stress-ng [13] 🚧 ✅ selinux-policy: serge-testsuite [11] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 11 months

4
5
0 0

[PATCH v2 1/2] mmc: sdhci-iproc: cygnus: Set NO_HISPD bit to fix HS50 data hold time problem

by Scott Branden

From: Trac Hoang <trac.hoang(a)broadcom.com> The iproc host eMMC/SD controller hold time does not meet the specification in the HS50 mode. This problem can be mitigated by disabling the HISPD bit; thus forcing the controller output data to be driven on the falling clock edges rather than the rising clock edges. This change applies only to the Cygnus platform. Cc: stable(a)vger.kernel.org # v4.12+ Signed-off-by: Trac Hoang <trac.hoang(a)broadcom.com> Signed-off-by: Scott Branden <scott.branden(a)broadcom.com> Acked-by: Adrian Hunter <adrian.hunter(a)intel.com> --- drivers/mmc/host/sdhci-iproc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c index 9d12c06c7fd6..9d4071c41c94 100644 --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -196,7 +196,8 @@ static const struct sdhci_ops sdhci_iproc_32only_ops = { }; static const struct sdhci_pltfm_data sdhci_iproc_cygnus_pltfm_data = { - .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK, + .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | + SDHCI_QUIRK_NO_HISPD_BIT, .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN | SDHCI_QUIRK2_HOST_OFF_CARD_ON, .ops = &sdhci_iproc_32only_ops, }; -- 2.17.1

5 years, 11 months

1
0
0 0

[RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions

by Steven Rostedt

From: Peter Zijlstra <peterz(a)infradead.org> In order to allow breakpoints to emulate call functions, they need to push the return address onto the stack. But because the breakpoint exception frame is added to the stack when the breakpoint is hit, there's no room to add the address onto the stack and return to the address of the emulated called funtion. To handle this, copy the exception frame on entry of the breakpoint handler and have leave a gap that can be used to add a return address to the stack frame and return from the breakpoint to the emulated called function, allowing for that called function to return back to the location after the breakpoint was placed. The helper functions were also added: int3_emulate_push(): to push the address onto the gap in the stack int3_emulate_jmp(): changes the location of the regs->ip to return there. int3_emulate_call(): push the return address and change regs->ip Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Nicolai Stange <nstange(a)suse.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Borislav Petkov <bp(a)alien8.de> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: the arch/x86 maintainers <x86(a)kernel.org> Cc: Josh Poimboeuf <jpoimboe(a)redhat.com> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Miroslav Benes <mbenes(a)suse.cz> Cc: Petr Mladek <pmladek(a)suse.com> Cc: Joe Lawrence <joe.lawrence(a)redhat.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: Konrad Rzeszutek Wilk <konrad.wilk(a)oracle.com> Cc: Tim Chen <tim.c.chen(a)linux.intel.com> Cc: Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> Cc: Mimi Zohar <zohar(a)linux.ibm.com> Cc: Juergen Gross <jgross(a)suse.com> Cc: Nick Desaulniers <ndesaulniers(a)google.com> Cc: Nayna Jain <nayna(a)linux.ibm.com> Cc: Masahiro Yamada <yamada.masahiro(a)socionext.com> Cc: Joerg Roedel <jroedel(a)suse.de> Cc: "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest(a)vger.kernel.org> Cc: stable(a)vger.kernel.org Fixes: b700e7f03df5 ("livepatch: kernel: add support for live patching") Signed-off-by: *** Need Peter Zijlstra's SoB here! *** Signed-off-by: Steven Rostedt (VMware) <rostedt(a)goodmis.org> --- arch/x86/entry/entry_32.S | 11 +++++++++++ arch/x86/entry/entry_64.S | 14 ++++++++++++-- arch/x86/include/asm/text-patching.h | 20 ++++++++++++++++++++ 3 files changed, 43 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index d309f30cf7af..50bbf4035baf 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -1478,6 +1478,17 @@ ENTRY(int3) ASM_CLAC pushl $-1 # mark this as an int +#ifdef CONFIG_VM86 + testl $X86_EFLAGS_VM, PT_EFLAGS(%esp) + jnz .Lfrom_usermode_no_gap +#endif + testl $SEGMENT_RPL_MASK, PT_CS(%esp) + jnz .Lfrom_usermode_no_gap + .rept 6 + pushl 5*4(%esp) + .endr +.Lfrom_usermode_no_gap: + SAVE_ALL switch_stacks=1 ENCODE_FRAME_POINTER TRACE_IRQS_OFF diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 1f0efdb7b629..834ec1397dab 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -879,7 +879,7 @@ apicinterrupt IRQ_WORK_VECTOR irq_work_interrupt smp_irq_work_interrupt * @paranoid == 2 is special: the stub will never switch stacks. This is for * #DF: if the thread stack is somehow unusable, we'll still get a useful OOPS. */ -.macro idtentry sym do_sym has_error_code:req paranoid=0 shift_ist=-1 +.macro idtentry sym do_sym has_error_code:req paranoid=0 shift_ist=-1 create_gap=0 ENTRY(\sym) UNWIND_HINT_IRET_REGS offset=\has_error_code*8 @@ -899,6 +899,16 @@ ENTRY(\sym) jnz .Lfrom_usermode_switch_stack_\@ .endif + .if \create_gap == 1 + testb $3, CS-ORIG_RAX(%rsp) + jnz .Lfrom_usermode_no_gap_\@ + .rept 6 + pushq 5*8(%rsp) + .endr + UNWIND_HINT_IRET_REGS offset=8 +.Lfrom_usermode_no_gap_\@: + .endif + .if \paranoid call paranoid_entry .else @@ -1130,7 +1140,7 @@ apicinterrupt3 HYPERV_STIMER0_VECTOR \ #endif /* CONFIG_HYPERV */ idtentry debug do_debug has_error_code=0 paranoid=1 shift_ist=DEBUG_STACK -idtentry int3 do_int3 has_error_code=0 +idtentry int3 do_int3 has_error_code=0 create_gap=1 idtentry stack_segment do_stack_segment has_error_code=1 #ifdef CONFIG_XEN_PV diff --git a/arch/x86/include/asm/text-patching.h b/arch/x86/include/asm/text-patching.h index e85ff65c43c3..ba275b6292db 100644 --- a/arch/x86/include/asm/text-patching.h +++ b/arch/x86/include/asm/text-patching.h @@ -39,4 +39,24 @@ extern int poke_int3_handler(struct pt_regs *regs); extern void *text_poke_bp(void *addr, const void *opcode, size_t len, void *handler); extern int after_bootmem; +static inline void int3_emulate_push(struct pt_regs *regs, unsigned long val) +{ + regs->sp -= sizeof(unsigned long); + *(unsigned long *)regs->sp = val; +} + +static inline void int3_emulate_jmp(struct pt_regs *regs, unsigned long ip) +{ + regs->ip = ip; +} + +#define INT3_INSN_SIZE 1 +#define CALL_INSN_SIZE 5 + +static inline void int3_emulate_call(struct pt_regs *regs, unsigned long func) +{ + int3_emulate_push(regs, regs->ip - INT3_INSN_SIZE + CALL_INSN_SIZE); + int3_emulate_jmp(regs, func); +} + #endif /* _ASM_X86_TEXT_PATCHING_H */ -- 2.20.1

5 years, 11 months

10
94
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2019