April 2019 - Linux-stable-mirror

[PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

by Vitor Soares

Currently in case of mixed slow bus topologie and all i2c devices support FM+ speed, the i3c subsystem limite the SCL to FM speed. Also in case on mixed slow bus mode the max speed for both i2c or i3c transfers is FM or FM+. This patch fix the definition of i2c and i3c scl rate based on bus topologie and LVR[4] if no user input. In case of mixed slow mode the i3c scl rate is overridden. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Vitor Soares <vitor.soares(a)synopsys.com> Cc: Boris Brezillon <bbrezillon(a)kernel.org> Cc: <stable(a)vger.kernel.org> Cc: <linux-kernel(a)vger.kernel.org> --- drivers/i3c/master.c | 39 +++++++++++++++++++++++++-------------- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 909c2ad..1c4a86a 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -564,20 +564,30 @@ static const struct device_type i3c_masterdev_type = { .groups = i3c_masterdev_groups, }; -int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode) +int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode, + unsigned long i2c_scl_rate) { i3cbus->mode = mode; - if (!i3cbus->scl_rate.i3c) - i3cbus->scl_rate.i3c = I3C_BUS_TYP_I3C_SCL_RATE; - - if (!i3cbus->scl_rate.i2c) { - if (i3cbus->mode == I3C_BUS_MODE_MIXED_SLOW) - i3cbus->scl_rate.i2c = I3C_BUS_I2C_FM_SCL_RATE; - else - i3cbus->scl_rate.i2c = I3C_BUS_I2C_FM_PLUS_SCL_RATE; + switch (i3cbus->mode) { + case I3C_BUS_MODE_PURE: + if (!i3cbus->scl_rate.i3c) + i3cbus->scl_rate.i3c = I3C_BUS_TYP_I3C_SCL_RATE; + break; + case I3C_BUS_MODE_MIXED_FAST: + if (!i3cbus->scl_rate.i3c) + i3cbus->scl_rate.i3c = I3C_BUS_TYP_I3C_SCL_RATE; + if (!i3cbus->scl_rate.i2c) + i3cbus->scl_rate.i2c = i2c_scl_rate; + break; + case I3C_BUS_MODE_MIXED_SLOW: + if (!i3cbus->scl_rate.i2c) + i3cbus->scl_rate.i2c = i2c_scl_rate; + i3cbus->scl_rate.i3c = i3cbus->scl_rate.i2c; + break; + default: + return -EINVAL; } - /* * I3C/I2C frequency may have been overridden, check that user-provided * values are not exceeding max possible frequency. @@ -1980,9 +1990,6 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, /* LVR is encoded in reg[2]. */ boardinfo->lvr = reg[2]; - if (boardinfo->lvr & I3C_LVR_I2C_FM_MODE) - master->bus.scl_rate.i2c = I3C_BUS_I2C_FM_SCL_RATE; - list_add_tail(&boardinfo->node, &master->boardinfo.i2c); of_node_get(node); @@ -2432,6 +2439,7 @@ int i3c_master_register(struct i3c_master_controller *master, const struct i3c_master_controller_ops *ops, bool secondary) { + unsigned long i2c_scl_rate = I3C_BUS_I2C_FM_PLUS_SCL_RATE; struct i3c_bus *i3cbus = i3c_master_get_bus(master); enum i3c_bus_mode mode = I3C_BUS_MODE_PURE; struct i2c_dev_boardinfo *i2cbi; @@ -2481,9 +2489,12 @@ int i3c_master_register(struct i3c_master_controller *master, ret = -EINVAL; goto err_put_dev; } + + if (i2cbi->lvr & I3C_LVR_I2C_FM_MODE) + i2c_scl_rate = I3C_BUS_I2C_FM_SCL_RATE; } - ret = i3c_bus_set_mode(i3cbus, mode); + ret = i3c_bus_set_mode(i3cbus, mode, i2c_scl_rate); if (ret) goto err_put_dev; -- 2.7.4

6 years

3
8
0 0

[PATCH AUTOSEL 3.18 01/15] qlcnic: Avoid potential NULL pointer dereference

by Sasha Levin

From: Aditya Pakki <pakki001(a)umn.edu> [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki <pakki001(a)umn.edu> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin (Microsoft) <sashal(a)kernel.org> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 0a2318cad34d..63ebc491057b 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1038,6 +1038,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1

6 years

1
14
0 0

[PATCH AUTOSEL 4.4 01/21] qlcnic: Avoid potential NULL pointer dereference

by Sasha Levin

From: Aditya Pakki <pakki001(a)umn.edu> [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki <pakki001(a)umn.edu> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin (Microsoft) <sashal(a)kernel.org> --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 0a2318cad34d..63ebc491057b 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1038,6 +1038,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1

6 years

1
20
0 0

[PATCH AUTOSEL 4.9 01/29] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

by Sasha Levin

From: Helen Koike <helen.koike(a)collabora.com> [ Upstream commit 544e784188f1dd7c797c70b213385e67d92005b6 ] Raspberry pi board model B revison 2 have the hot plug detector gpio active high (and not low as it was in the dts). Signed-off-by: Helen Koike <helen.koike(a)collabora.com> Fixes: 49ac67e0c39c ("ARM: bcm2835: Add VC4 to the device tree.") Reviewed-by: Eric Anholt <eric(a)anholt.net> Signed-off-by: Eric Anholt <eric(a)anholt.net> Signed-off-by: Sasha Levin (Microsoft) <sashal(a)kernel.org> --- arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts index 84df85ea6296..7efde03daadd 100644 --- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts +++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts @@ -26,5 +26,5 @@ }; &hdmi { - hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>; + hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>; }; -- 2.19.1

6 years

1
28
0 0

stable-rc/linux-4.19.y boot: 115 boots: 1 failed, 103 passed with 10 offline, 1 untried/unknown (v4.19.36-28-g988d5b39e391)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 115 boots: 1 failed, 103 passed with 10 offline, 1 untried/unknown (v4.19.36-28-g988d5b39e391) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.36-28… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.36-28-g988d5b39e391 Git Commit: 988d5b39e39125d99feb41b9cc1d8e80bd1dcdc4 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 67 unique boards, 24 SoC families, 14 builds out of 206 Boot Regressions Detected: arm64: defconfig: gcc-7: sun50i-a64-pine64-plus: lab-baylibre-seattle: new failure (last pass: v4.19.34-102-ge4f859c2cd83) Boot Failure Detected: arm64: defconfig: gcc-7: sun50i-a64-pine64-plus: 1 failed lab Offline Platforms: arm: davinci_all_defconfig: gcc-7 da850-lcdk: 1 offline lab imx_v6_v7_defconfig: gcc-7 vf610-colibri-eval-v3: 1 offline lab multi_v7_defconfig: gcc-7 meson8b-odroidc1: 1 offline lab vf610-colibri-eval-v3: 1 offline lab arm64: defconfig: gcc-7 meson-gxbb-odroidc2: 1 offline lab meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-nexbox-a95x: 1 offline lab meson-gxl-s905x-p212: 1 offline lab meson-gxm-nexbox-a1: 1 offline lab rk3399-firefly: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

+ signal-trace_signal_deliver-when-signal_group_exit.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: signal: trace_signal_deliver when signal_group_exit has been added to the -mm tree. Its filename is signal-trace_signal_deliver-when-signal_group_exit.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/signal-trace_signal_deliver-when-s… and later at http://ozlabs.org/~akpm/mmotm/broken-out/signal-trace_signal_deliver-when-s… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Zhenliang Wei <weizhenliang(a)huawei.com> Subject: signal: trace_signal_deliver when signal_group_exit In the fixes commit, removing SIGKILL from each thread signal mask and executing "goto fatal" directly will skip the call to "trace_signal_deliver". At this point, the delivery tracking of the SIGKILL signal will be inaccurate. Therefore, we need to add trace_signal_deliver before "goto fatal" after executing sigdelset. Note: The action[SIGKILL] must be SIG_DFL, and SEND_SIG_NOINFO matches the fact that SIGKILL doesn't have any info. Link: http://lkml.kernel.org/r/20190422145950.78056-1-weizhenliang@huawei.com Fixes: cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT") Signed-off-by: Zhenliang Wei <weizhenliang(a)huawei.com> Acked-by: Christian Brauner <christian(a)brauner.io> Reviewed-by: Oleg Nesterov <oleg(a)redhat.com> Cc: Ivan Delalande <colona(a)arista.com> Cc: "Eric W. Biederman" <ebiederm(a)xmission.com> Cc: Arnd Bergmann <arnd(a)arndb.de> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Deepa Dinamani <deepa.kernel(a)gmail.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- kernel/signal.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/signal.c~signal-trace_signal_deliver-when-signal_group_exit +++ a/kernel/signal.c @@ -2441,6 +2441,7 @@ relock: if (signal_group_exit(signal)) { ksig->info.si_signo = signr = SIGKILL; sigdelset(&current->pending.signal, SIGKILL); + trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL); recalc_sigpending(); goto fatal; } _ Patches currently in -mm which might be from weizhenliang(a)huawei.com are signal-trace_signal_deliver-when-signal_group_exit.patch

6 years

1
0
0 0

stable/linux-4.19.y boot: 50 boots: 0 failed, 50 passed (v4.19.36)

by kernelci.org bot

stable/linux-4.19.y boot: 50 boots: 0 failed, 50 passed (v4.19.36) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-4.19.y/kernel/v4.19.3… Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.19.y/kernel/v4.19.36/ Tree: stable Branch: linux-4.19.y Git Describe: v4.19.36 Git Commit: c98875d930e915d01e8c40c7d3c16f00b3c8abe1 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 31 unique boards, 15 SoC families, 10 builds out of 206 --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

stable/linux-4.9.y boot: 38 boots: 0 failed, 38 passed (v4.9.170)

by kernelci.org bot

stable/linux-4.9.y boot: 38 boots: 0 failed, 38 passed (v4.9.170) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-4.9.y/kernel/v4.9.170/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.9.y/kernel/v4.9.170/ Tree: stable Branch: linux-4.9.y Git Describe: v4.9.170 Git Commit: ad387ec4bcdf087faaf084a3db8f681295463b01 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 21 unique boards, 12 SoC families, 9 builds out of 197 --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 88 passed with 10 offline (v4.9.170)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 88 passed with 10 offline (v4.9.170) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.170/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.170 Git Commit: ad387ec4bcdf087faaf084a3db8f681295463b01 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 52 unique boards, 22 SoC families, 15 builds out of 197 Offline Platforms: arm: davinci_all_defconfig: gcc-7 da850-lcdk: 1 offline lab imx_v6_v7_defconfig: gcc-7 vf610-colibri-eval-v3: 1 offline lab multi_v7_defconfig: gcc-7 bcm72521-bcm97252sffe: 1 offline lab bcm7445-bcm97445c: 1 offline lab meson8b-odroidc1: 1 offline lab stih410-b2120: 1 offline lab tegra20-iris-512: 1 offline lab vf610-colibri-eval-v3: 1 offline lab tegra_defconfig: gcc-7 tegra20-iris-512: 1 offline lab arm64: defconfig: gcc-7 meson-gxbb-odroidc2: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

[git:media_tree/master] media: seco-cec: fix building with RC_CORE=m

by Mauro Carvalho Chehab

This is an automatic generated email to let you know that the following patch were queued: Subject: media: seco-cec: fix building with RC_CORE=m Author: Arnd Bergmann <arnd(a)arndb.de> Date: Wed Mar 13 17:18:07 2019 -0400 I previously added an RC_CORE dependency here, but missed the corner case of CONFIG_VIDEO_SECO_CEC=y with CONFIG_RC_CORE=m, which still causes a link error: drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_probe': seco-cec.c:(.text+0x1b8): undefined reference to `devm_rc_allocate_device' seco-cec.c:(.text+0x2e8): undefined reference to `devm_rc_register_device' drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_irq_handler': seco-cec.c:(.text+0xa2c): undefined reference to `rc_keydown' Refine the dependency to disallow building the RC subdriver in this case. This is the same logic we apply in other drivers like it. Fixes: f27dd0ad6885 ("media: seco-cec: fix RC_CORE dependency") Cc: <stable(a)vger.kernel.org> # 5.1 Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Signed-off-by: Sean Young <sean(a)mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 1611ec23d733..9908ecde2585 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -649,7 +649,7 @@ config VIDEO_SECO_CEC config VIDEO_SECO_RC bool "SECO Boards IR RC5 support" depends on VIDEO_SECO_CEC - depends on RC_CORE + depends on RC_CORE=y || RC_CORE = VIDEO_SECO_CEC help If you say yes here you will get support for the SECO Boards Consumer-IR in seco-cec driver.

6 years

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror April 2019