Le 25/03/2019 à 01:38, Sasha Levin a écrit :
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v5.0.3, v4.19.30, v4.14.107, v4.9.164, v4.4.176, v3.18.136.
>
> v5.0.3: Build OK!
> v4.19.30: Build OK!
> v4.14.107: Build OK!
> v4.9.164: Build OK!
> v4.4.176: Failed to apply! Possible dependencies:
> 27590dc17b34 ("hrtimer: Convert to hotplug state machine")
> 31487f8328f2 ("smp/cfd: Convert core to hotplug state machine")
> 512089d98457 ("perf/x86/intel/rapl: Clean up the printk output")
> 55f2890f0726 ("perf/x86/intel/rapl: Add proper error handling")
> 57ecde42cc74 ("powerpc/perf: Convert book3s notifier to state machine callbacks")
> 6731d4f12315 ("slab: Convert to hotplug state machine")
> 6b2c28471de5 ("x86/x2apic: Convert to CPU hotplug state machine")
> 7162b8fea630 ("perf/x86/intel/rapl: Refactor the code some more")
> 75c7003fbf41 ("perf/x86/intel/rapl: Calculate timing once")
> 7ee681b25284 ("workqueue: Convert to state machine callbacks")
> 8a6d2f8f73ca ("perf/x86/intel/rapl: Utilize event->pmu_private")
> 8b5b773d6245 ("perf/x86/intel/rapl: Convert to hotplug state machine")
> 9de8d686955b ("perf/x86/intel/rapl: Convert it to a per package facility")
> a208749c6426 ("perf/x86/intel/rapl: Make PMU lock raw")
> a409f5ee2937 ("blackfin/perf: Convert hotplug notifier to state machine")
> b8b3319a471b ("perf/x86/intel/rapl: Sanitize the quirk handling")
> e3cfce17d309 ("sh/perf: Convert the hotplug notifiers to state machine callbacks")
> e6d4989a9ad1 ("relayfs: Convert to hotplug state machine")
> e722d8daafb9 ("profile: Convert to hotplug state machine")
>
> v3.18.136: Failed to apply! Possible dependencies:
> 13ca62b243f6 ("ACPI: Fix minor syntax issues in processor_core.c")
> 27590dc17b34 ("hrtimer: Convert to hotplug state machine")
> 31487f8328f2 ("smp/cfd: Convert core to hotplug state machine")
> 4daa832d9987 ("x86: Drop bogus __ref / __refdata annotations")
> 57ecde42cc74 ("powerpc/perf: Convert book3s notifier to state machine callbacks")
> 645523960102 ("perf/x86/intel/rapl: Fix energy counter measurements but supporing per domain energy units")
> 6731d4f12315 ("slab: Convert to hotplug state machine")
> 6b2c28471de5 ("x86/x2apic: Convert to CPU hotplug state machine")
> 7162b8fea630 ("perf/x86/intel/rapl: Refactor the code some more")
> 7ee681b25284 ("workqueue: Convert to state machine callbacks")
> 828aef376d7a ("ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID")
> 8b5b773d6245 ("perf/x86/intel/rapl: Convert to hotplug state machine")
> 9de8d686955b ("perf/x86/intel/rapl: Convert it to a per package facility")
> a409f5ee2937 ("blackfin/perf: Convert hotplug notifier to state machine")
> af8f3f514d19 ("ACPI / processor: Convert apic_id to phys_id to make it arch agnostic")
> d02dc27db0dc ("ACPI / processor: Rename acpi_(un)map_lsapic() to acpi_(un)map_cpu()")
> d089f8e97d37 ("x86: fix up obsolete cpu function usage.")
> e3cfce17d309 ("sh/perf: Convert the hotplug notifiers to state machine callbacks")
> e6d4989a9ad1 ("relayfs: Convert to hotplug state machine")
> e722d8daafb9 ("profile: Convert to hotplug state machine")
> ecf5636dcd59 ("ACPI: Add interfaces to parse IOAPIC ID for IOAPIC hotplug")
> fdaf3a6539d6 ("x86: fix more deprecated cpu function usage.")
>
>
> How should we proceed with this patch?
Please forget about it.
As reported by Michal, this patch is useless.
Sorry for the noise.
Thanks,
Laurent.
Hi Sasha,
Please consider this patch for stable kernel releases from v4.4.176 onwards, as the support for Intel RAM based Bluetooth products is missing in the v3.18.136.
Thanks,
Raghuram
-----Original Message-----
From: Sasha Levin [mailto:sashal@kernel.org]
Sent: Monday, March 25, 2019 6:09 AM
To: Sasha Levin <sashal(a)kernel.org>; Tumkur Narayan, Chethan <chethan.tumkur.narayan(a)intel.com>; Hegde, Raghuram <raghuram.hegde(a)intel.com>; linux-bluetooth(a)vger.kernel.org
Cc: Hegde, Raghuram <raghuram.hegde(a)intel.com>; stable(a)vger.kernel.org; stable(a)vger.kernel.org
Subject: Re: [PATCH] btusb: Re-program BULK IN URBs once the Intel BT controller is in operational firmware mode.
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.0.3, v4.19.30, v4.14.107, v4.9.164, v4.4.176, v3.18.136.
v5.0.3: Build OK!
v4.19.30: Build OK!
v4.14.107: Build OK!
v4.9.164: Build OK!
v4.4.176: Build OK!
v3.18.136: Failed to apply! Possible dependencies:
17b2772b8fe3 ("Bluetooth: Read Broadcom chip info for Apple Bluetooth devices")
18835dfa3ac5 ("Bluetooth: btusb: Use matching names for Broadcom firmware files")
1df1f5910825 ("Bluetooth: btusb: Use generic functionality by Broadcom module")
213445b2b40e ("Bluetooth: btintel: Enable extra Intel vendor events")
2cbd3f5ccd43 ("Bluetooth: btusb: Add internal callback for USB bulk rx data")
3267c884cefa ("Bluetooth: btusb: Add support for QCA ROME chipset family")
385a768c3be1 ("Bluetooth: btusb: Provide hardware error handler for Intel devices")
4185a0f5d043 ("Bluetooth: btusb: Use generic Intel support for address support")
48f0ed1bb685 ("Bluetooth: btintel: Introduce generic Intel Bluetooth support")
4fba30f07f51 ("Bluetooth: btbcm: Introduce generic Broadcom Bluetooth support")
4fcef8ed75af ("Bluetooth: Fix issue with Roper Class 1 Bluetooth Dongle")
6d2e50d24098 ("Bluetooth: btintel: Add support for enabling tracing functionality")
893ba5440a25 ("Bluetooth: btusb: Add support for USB based AMP controllers")
97307f51d7ce ("Bluetooth: btusb: Add internal recv_event callback for event processing")
973bb97e5aee ("Bluetooth: btintel: Add generic function for handling hardware errors")
bfbd45e9acd2 ("Bluetooth: Add device shutdown routine for Intel Bluetooth device")
cda0dd7809f8 ("Bluetooth: btusb: Add firmware loading for Intel Snowfield Peak devices")
d57dbe779e0e ("Bluetooth: btusb: Set the HCI_QUIRK_BROKEN_LOCAL_COMMANDS quirk")
d8270fbb3ffe ("Bluetooth: btintel: Set quirk for non-persistent diagnostic settings")
eeb6abe97390 ("Bluetooth: btusb: Use hardware error handler from Intel module")
How should we proceed with this patch?
--
Thanks,
Sasha
On 3/24/19 5:38 PM, Sasha Levin wrote:
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 3a0a529971ec block, scsi: Make SCSI quiesce and resume work reliably.
>
> The bot has tested the following trees: v5.0.3, v4.19.30.
>
> v5.0.3: Build OK!
> v4.19.30: Failed to apply! Possible dependencies:
> cd84a62e0078 ("block, scsi: Change the preempt-only flag into a counter")
>
>
> How should we proceed with this patch?
I think if you want to backport that patch that you will also have to
backport commit cd84a62e0078 ("block, scsi: Change the preempt-only flag
into a counter") (kernel v4.20).
Bart.
Complete read error handling paths for all three kinds of
compressed pages:
1) For cache-managed pages, PG_uptodate will be checked since
read_endio will unlock and SetPageUptodate for these pages;
2) For inplaced pages, read_endio cannot SetPageUptodate directly
since it should be used to mark the final decompressed data,
PG_error will be set with page locked for IO error instead;
3) For staging pages, PG_error is used, which is similar to
what we do for inplaced pages.
Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Cc: <stable(a)vger.kernel.org> # 4.19+
Reviewed-by: Chao Yu <yuchao0(a)huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25(a)huawei.com>
---
changelog v2:
- [3/3] wrap bio->bi_private assignment into erofs_grab_bio()
as suggested by Chao;
This series focus on fixing error handling when failed to read
compresssed data due to previous incomplete paths.
In addition, the last 2 patches add IO error fault injection
for reading paths, which I have used to test the first patch as well.
Thanks,
Gao Xiang
drivers/staging/erofs/unzip_vle.c | 41 ++++++++++++++++++++++++++-------------
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
index bfd52ebd0403..45541be12972 100644
--- a/drivers/staging/erofs/unzip_vle.c
+++ b/drivers/staging/erofs/unzip_vle.c
@@ -973,6 +973,7 @@ static int z_erofs_vle_unzip(struct super_block *sb,
overlapped = false;
compressed_pages = grp->compressed_pages;
+ err = 0;
for (i = 0; i < clusterpages; ++i) {
unsigned int pagenr;
@@ -982,26 +983,39 @@ static int z_erofs_vle_unzip(struct super_block *sb,
DBG_BUGON(!page);
DBG_BUGON(!page->mapping);
- if (z_erofs_is_stagingpage(page))
- continue;
+ if (!z_erofs_is_stagingpage(page)) {
#ifdef EROFS_FS_HAS_MANAGED_CACHE
- if (page->mapping == MNGD_MAPPING(sbi)) {
- DBG_BUGON(!PageUptodate(page));
- continue;
- }
+ if (page->mapping == MNGD_MAPPING(sbi)) {
+ if (unlikely(!PageUptodate(page)))
+ err = -EIO;
+ continue;
+ }
#endif
- /* only non-head page could be reused as a compressed page */
- pagenr = z_erofs_onlinepage_index(page);
+ /*
+ * only if non-head page can be selected
+ * for inplace decompression
+ */
+ pagenr = z_erofs_onlinepage_index(page);
- DBG_BUGON(pagenr >= nr_pages);
- DBG_BUGON(pages[pagenr]);
- ++sparsemem_pages;
- pages[pagenr] = page;
+ DBG_BUGON(pagenr >= nr_pages);
+ DBG_BUGON(pages[pagenr]);
+ ++sparsemem_pages;
+ pages[pagenr] = page;
+
+ overlapped = true;
+ }
- overlapped = true;
+ /* PG_error needs checking for inplaced and staging pages */
+ if (unlikely(PageError(page))) {
+ DBG_BUGON(PageUptodate(page));
+ err = -EIO;
+ }
}
+ if (unlikely(err))
+ goto out;
+
llen = (nr_pages << PAGE_SHIFT) - work->pageofs;
if (z_erofs_vle_workgrp_fmt(grp) == Z_EROFS_VLE_WORKGRP_FMT_PLAIN) {
@@ -1195,6 +1209,7 @@ pickup_page_for_submission(struct z_erofs_vle_workgroup *grp,
if (page->mapping == mc) {
WRITE_ONCE(grp->compressed_pages[nr], page);
+ ClearPageError(page);
if (!PagePrivate(page)) {
/*
* impossible to be !PagePrivate(page) for
--
2.12.2
Complete read error handling paths for all three kinds of
compressed pages:
1) For cache-managed pages, PG_uptodate will be checked since
read_endio will unlock and SetPageUptodate for these pages;
2) For inplaced pages, read_endio cannot SetPageUptodate directly
since it should be used to mark the final decompressed data,
PG_error will be set with page locked for IO error instead;
3) For staging pages, PG_error is used, which is similar to
what we do for inplaced pages.
Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Cc: <stable(a)vger.kernel.org> # 4.19+
Signed-off-by: Gao Xiang <gaoxiang25(a)huawei.com>
---
This series focus on fixing error handling when failed to read
compresssed data due to previous incomplete paths.
In addition, the last 2 patches add IO error fault injection
for reading paths, which I have used to test the first patch as well.
Thanks,
Gao Xiang
drivers/staging/erofs/unzip_vle.c | 41 ++++++++++++++++++++++++++-------------
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
index 8715bc50e09c..3416d3f10324 100644
--- a/drivers/staging/erofs/unzip_vle.c
+++ b/drivers/staging/erofs/unzip_vle.c
@@ -972,6 +972,7 @@ static int z_erofs_vle_unzip(struct super_block *sb,
overlapped = false;
compressed_pages = grp->compressed_pages;
+ err = 0;
for (i = 0; i < clusterpages; ++i) {
unsigned int pagenr;
@@ -981,26 +982,39 @@ static int z_erofs_vle_unzip(struct super_block *sb,
DBG_BUGON(!page);
DBG_BUGON(!page->mapping);
- if (z_erofs_is_stagingpage(page))
- continue;
+ if (!z_erofs_is_stagingpage(page)) {
#ifdef EROFS_FS_HAS_MANAGED_CACHE
- if (page->mapping == MNGD_MAPPING(sbi)) {
- DBG_BUGON(!PageUptodate(page));
- continue;
- }
+ if (page->mapping == MNGD_MAPPING(sbi)) {
+ if (unlikely(!PageUptodate(page)))
+ err = -EIO;
+ continue;
+ }
#endif
- /* only non-head page could be reused as a compressed page */
- pagenr = z_erofs_onlinepage_index(page);
+ /*
+ * only if non-head page can be selected
+ * for inplace decompression
+ */
+ pagenr = z_erofs_onlinepage_index(page);
- DBG_BUGON(pagenr >= nr_pages);
- DBG_BUGON(pages[pagenr]);
- ++sparsemem_pages;
- pages[pagenr] = page;
+ DBG_BUGON(pagenr >= nr_pages);
+ DBG_BUGON(pages[pagenr]);
+ ++sparsemem_pages;
+ pages[pagenr] = page;
+
+ overlapped = true;
+ }
- overlapped = true;
+ /* PG_error needs checking for inplaced and staging pages */
+ if (unlikely(PageError(page))) {
+ DBG_BUGON(PageUptodate(page));
+ err = -EIO;
+ }
}
+ if (unlikely(err))
+ goto out;
+
llen = (nr_pages << PAGE_SHIFT) - work->pageofs;
if (z_erofs_vle_workgrp_fmt(grp) == Z_EROFS_VLE_WORKGRP_FMT_PLAIN) {
@@ -1194,6 +1208,7 @@ pickup_page_for_submission(struct z_erofs_vle_workgroup *grp,
if (page->mapping == mc) {
WRITE_ONCE(grp->compressed_pages[nr], page);
+ ClearPageError(page);
if (!PagePrivate(page)) {
/*
* impossible to be !PagePrivate(page) for
--
2.12.2
Hi,
On 2019/3/25 8:38, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 3883a79abd02 staging: erofs: introduce VLE decompression support.
>
> The bot has tested the following trees: v5.0.3, v4.19.30.
>
> v5.0.3: Build OK!
> v4.19.30: Failed to apply! Possible dependencies:
> 390c642e1264 ("staging: erofs: fix integer overflow on 32-bit platform")
> 42d40b4ad840 ("staging: erofs: unzip_vle.c: Replace comparison to NULL.")
> 6e78901a9f23 ("staging: erofs: separate erofs_get_meta_page")
> 7dd68b147d60 ("staging: erofs: use explicit unsigned int type")
> 8be31270362b ("staging: erofs: introduce erofs_grab_bio")
> 9248fce714d5 ("staging: erofs: revisit the page submission flow")
> a07eeddf5b63 ("staging: erofs: clean up z_erofs_map_blocks_iter")
> ab47dd2b0819 ("staging: erofs: cleanup z_erofs_vle_work_{lookup, register}")
> b27661cf99c2 ("staging: erofs: fold in `__update_workgrp_llen'")
> c1448fa88025 ("staging: erofs: introduce MNGD_MAPPING helper")
>
>
> How should we proceed with this patch?
I will do the 4.19 backport patch after get a "Reviewed-by: " tag,
thanks for the reminder.
Thanks,
Gao Xiang
>
> --
> Thanks,
> Sasha
>
After removal of clock_start() from before soc_camera_init_i2c() in
soc_camera_probe() by commit 9aea470b399d ("[media] soc-camera: switch
I2C subdevice drivers to use v4l2-clk") introduced in v3.11, the ov6650
driver could no longer probe the sensor successfully because its clock
was no longer turned on in advance. The issue was initially worked
around by adding that missing clock_start() equivalent to OMAP1 camera
interface driver - the only user of this sensor - but a propoer fix
should be rather implemented in the sensor driver code itself.
Fix the issue by inserting a delay between the clock is turned on and
the sensor I2C registers are read for the first time.
Tested on Amstrad Delta with now out of tree but still locally
maintained omap1_camera host driver.
Fixes: 9aea470b399d ("[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt(a)gmail.com>
Cc: stable(a)vger.kernel.org
---
drivers/media/i2c/ov6650.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
index c33fd584cb44..f9359b11fa5c 100644
--- a/drivers/media/i2c/ov6650.c
+++ b/drivers/media/i2c/ov6650.c
@@ -814,6 +814,8 @@ static int ov6650_video_probe(struct i2c_client *client)
if (ret < 0)
return ret;
+ msleep(20);
+
/*
* check and show product ID and manufacturer ID
*/
--
2.19.2
This is the start of the stable review cycle for the 3.16.64 release.
There are 16 patches in this series, which will be posted as responses
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Mon Mar 25 18:00:00 UTC 2019.
Anything received after that time might be too late.
All the patches have also been committed to the linux-3.16.y-rc branch of
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-stable-rc.git .
A shortlog and diffstat can be found below.
Ben.
-------------
Brian Foster (1):
xfs: don't BUG() on mixed direct and mapped I/O
[04197b341f23b908193308b8d63d17ff23232598]
Christoffer Dall (2):
KVM: PPC: Move xics_debugfs_init out of create
[023e9fddc3616b005c3753fc1bb6526388cd7a30]
KVM: Protect device ops->create and list_add with kvm->lock
[a28ebea2adc4a2bef5989a5a181ec238f59fbcad]
Dan Carpenter (1):
KVM: use after free in kvm_ioctl_create_device()
[a0f1d21c1ccb1da66629627a74059dd7f5ac9c61]
Hui Peng (1):
USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data
[5146f95df782b0ac61abde36567e718692725c89]
Jann Horn (1):
kvm: fix kvm_ioctl_create_device() reference counting (CVE-2019-6974)
[cfa39381173d5f969daf43582c95ad679189cbc9]
Jiri Kosina (1):
HID: debug: fix error handling in hid_debug_events_read()
[8fec02a73e31407e14986fca67dab48d4f777f0e]
Kees Cook (1):
swiotlb: clean up reporting
[7d63fb3af87aa67aa7d24466e792f9d7c57d8e79]
Oliver Hartkopp (1):
can: gw: ensure DLC boundaries after CAN frame modification
[0aaa81377c5a01f686bcdb8c7a6929a7bf330c68]
Paolo Bonzini (1):
KVM: x86: work around leak of uninitialized stack contents (CVE-2019-7222)
[353c0956a618a07ba4bbe7ad00ff29fe70e8412a]
Peter Shier (1):
KVM: nVMX: unconditionally cancel preemption timer in free_nested (CVE-2019-7221)
[ecec76885bcfe3294685dc363fd1273df0d5d65f]
Rasmus Villemoes (1):
HID: debug: improve hid_debug_event()
[92529623d242cea4440958d7bcebdf291f4ab15e]
Rohit Vaswani (1):
mm: cma: fix incorrect type conversion for size during dma allocation
[67a2e213e7e937c41c52ab5bc46bf3f4de469f6e]
Vasily Averin (1):
sunrpc: use-after-free in svc_process_common()
[d4b09acf924b84bae77cad090a9d108e70b43643]
Vladis Dronov (1):
HID: debug: fix the ring buffer implementation
[13054abbaa4f1fd4e6f3b4b63439ec033b4c8035]
Willy Tarreau (1):
net/appletalk: fix minor pointer leak to userspace in SIOCFINDIPDDPRT
[9824dfae5741275473a23a7ed5756c7b6efacc9d]
Makefile | 4 +-
arch/arm/kvm/arm.c | 9 ++--
arch/powerpc/kvm/book3s_xics.c | 12 +++--
arch/x86/kvm/vmx.c | 1 +
arch/x86/kvm/x86.c | 7 +++
drivers/base/dma-contiguous.c | 4 +-
drivers/hid/hid-debug.c | 119 ++++++++++++++++-------------------------
drivers/net/appletalk/ipddp.c | 8 ++-
drivers/net/usb/hso.c | 18 ++++++-
fs/xfs/xfs_aops.c | 21 +++++++-
include/linux/dma-contiguous.h | 4 +-
include/linux/hid-debug.h | 9 ++--
include/linux/kvm_host.h | 12 +++++
include/linux/sunrpc/svc.h | 5 +-
lib/swiotlb.c | 18 +++----
net/can/gw.c | 30 +++++++++--
net/sunrpc/svc.c | 10 ++--
net/sunrpc/svc_xprt.c | 5 +-
net/sunrpc/svcsock.c | 2 +-
virt/kvm/arm/vgic.c | 11 +---
virt/kvm/kvm_main.c | 19 ++++++-
21 files changed, 202 insertions(+), 126 deletions(-)
--
Ben Hutchings
Make three consecutive correct guesses and you will be considered
an expert.