October 2019 - Linux-stable-mirror

[PATCH AUTOSEL 5.2 01/42] MIPS: Ingenic: Disable broken BTB lookup optimization.

by Sasha Levin

From: Zhou Yanjie <zhouyanjie(a)zoho.com> [ Upstream commit 053951dda71ecb4b554a2cdbe26f5f6f9bee9dd2 ] In order to further reduce power consumption, the XBurst core by default attempts to avoid branch target buffer lookups by detecting & special casing loops. This feature will cause BogoMIPS and lpj calculate in error. Set cp0 config7 bit 4 to disable this feature. Signed-off-by: Zhou Yanjie <zhouyanjie(a)zoho.com> Signed-off-by: Paul Burton <paul.burton(a)mips.com> Cc: linux-mips(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: ralf(a)linux-mips.org Cc: paul(a)crapouillou.net Cc: jhogan(a)kernel.org Cc: malat(a)debian.org Cc: gregkh(a)linuxfoundation.org Cc: tglx(a)linutronix.de Cc: allison(a)lohutok.net Cc: syq(a)debian.org Cc: chenhc(a)lemote.com Cc: jiaxun.yang(a)flygoat.com Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/mips/include/asm/mipsregs.h | 4 ++++ arch/mips/kernel/cpu-probe.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h index 1e6966e8527e9..bdbdc19a2b8f8 100644 --- a/arch/mips/include/asm/mipsregs.h +++ b/arch/mips/include/asm/mipsregs.h @@ -689,6 +689,9 @@ #define MIPS_CONF7_IAR (_ULCAST_(1) << 10) #define MIPS_CONF7_AR (_ULCAST_(1) << 16) +/* Ingenic Config7 bits */ +#define MIPS_CONF7_BTB_LOOP_EN (_ULCAST_(1) << 4) + /* Config7 Bits specific to MIPS Technologies. */ /* Performance counters implemented Per TC */ @@ -2813,6 +2816,7 @@ __BUILD_SET_C0(status) __BUILD_SET_C0(cause) __BUILD_SET_C0(config) __BUILD_SET_C0(config5) +__BUILD_SET_C0(config7) __BUILD_SET_C0(intcontrol) __BUILD_SET_C0(intctl) __BUILD_SET_C0(srsmap) diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c index 9635c1db3ae6a..e654ffc1c8a0d 100644 --- a/arch/mips/kernel/cpu-probe.c +++ b/arch/mips/kernel/cpu-probe.c @@ -1964,6 +1964,13 @@ static inline void cpu_probe_ingenic(struct cpuinfo_mips *c, unsigned int cpu) c->cputype = CPU_JZRISC; c->writecombine = _CACHE_UNCACHED_ACCELERATED; __cpu_name[cpu] = "Ingenic JZRISC"; + /* + * The XBurst core by default attempts to avoid branch target + * buffer lookups by detecting & special casing loops. This + * feature will cause BogoMIPS and lpj calculate in error. + * Set cp0 config7 bit 4 to disable this feature. + */ + set_c0_config7(MIPS_CONF7_BTB_LOOP_EN); break; default: panic("Unknown Ingenic Processor ID!"); -- 2.20.1

5 years

2
43
0 0

[PATCH AUTOSEL 5.3 01/49] MIPS: Ingenic: Disable broken BTB lookup optimization.

by Sasha Levin

From: Zhou Yanjie <zhouyanjie(a)zoho.com> [ Upstream commit 053951dda71ecb4b554a2cdbe26f5f6f9bee9dd2 ] In order to further reduce power consumption, the XBurst core by default attempts to avoid branch target buffer lookups by detecting & special casing loops. This feature will cause BogoMIPS and lpj calculate in error. Set cp0 config7 bit 4 to disable this feature. Signed-off-by: Zhou Yanjie <zhouyanjie(a)zoho.com> Signed-off-by: Paul Burton <paul.burton(a)mips.com> Cc: linux-mips(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: ralf(a)linux-mips.org Cc: paul(a)crapouillou.net Cc: jhogan(a)kernel.org Cc: malat(a)debian.org Cc: gregkh(a)linuxfoundation.org Cc: tglx(a)linutronix.de Cc: allison(a)lohutok.net Cc: syq(a)debian.org Cc: chenhc(a)lemote.com Cc: jiaxun.yang(a)flygoat.com Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- arch/mips/include/asm/mipsregs.h | 4 ++++ arch/mips/kernel/cpu-probe.c | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/arch/mips/include/asm/mipsregs.h b/arch/mips/include/asm/mipsregs.h index 1e6966e8527e9..bdbdc19a2b8f8 100644 --- a/arch/mips/include/asm/mipsregs.h +++ b/arch/mips/include/asm/mipsregs.h @@ -689,6 +689,9 @@ #define MIPS_CONF7_IAR (_ULCAST_(1) << 10) #define MIPS_CONF7_AR (_ULCAST_(1) << 16) +/* Ingenic Config7 bits */ +#define MIPS_CONF7_BTB_LOOP_EN (_ULCAST_(1) << 4) + /* Config7 Bits specific to MIPS Technologies. */ /* Performance counters implemented Per TC */ @@ -2813,6 +2816,7 @@ __BUILD_SET_C0(status) __BUILD_SET_C0(cause) __BUILD_SET_C0(config) __BUILD_SET_C0(config5) +__BUILD_SET_C0(config7) __BUILD_SET_C0(intcontrol) __BUILD_SET_C0(intctl) __BUILD_SET_C0(srsmap) diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c index 9635c1db3ae6a..e654ffc1c8a0d 100644 --- a/arch/mips/kernel/cpu-probe.c +++ b/arch/mips/kernel/cpu-probe.c @@ -1964,6 +1964,13 @@ static inline void cpu_probe_ingenic(struct cpuinfo_mips *c, unsigned int cpu) c->cputype = CPU_JZRISC; c->writecombine = _CACHE_UNCACHED_ACCELERATED; __cpu_name[cpu] = "Ingenic JZRISC"; + /* + * The XBurst core by default attempts to avoid branch target + * buffer lookups by detecting & special casing loops. This + * feature will cause BogoMIPS and lpj calculate in error. + * Set cp0 config7 bit 4 to disable this feature. + */ + set_c0_config7(MIPS_CONF7_BTB_LOOP_EN); break; default: panic("Unknown Ingenic Processor ID!"); -- 2.20.1

5 years

2
50
0 0

Linux 3.16.75

by Ben Hutchings

I'm announcing the release of the 3.16.75 kernel. All users of the 3.16 kernel series should upgrade. The updated 3.16.y git tree can be found at: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.16.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git The diff from 3.16.74 is attached to this message. Ben. ------------ Makefile | 2 +- arch/arm64/kvm/guest.c | 49 ++++++++++++--- arch/mips/mm/tlbex.c | 29 ++++++--- arch/powerpc/perf/core-book3s.c | 8 ++- arch/powerpc/perf/power8-pmu.c | 3 + arch/s390/crypto/aes_s390.c | 10 +-- arch/s390/crypto/des_s390.c | 9 +-- arch/x86/kernel/apic/apic.c | 3 +- arch/x86/kernel/cpu/bugs.c | 11 +++- block/blk-mq-tag.c | 2 +- crypto/crypto_user.c | 3 + drivers/ata/libata-core.c | 9 ++- drivers/gpio/Kconfig | 1 + drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 + drivers/gpu/drm/gma500/intel_bios.c | 3 + drivers/gpu/drm/gma500/psb_drv.h | 1 + drivers/hwmon/pmbus/pmbus_core.c | 34 ++++++++-- drivers/i2c/busses/i2c-acorn.c | 1 + drivers/i2c/i2c-dev.c | 1 + drivers/input/misc/uinput.c | 22 ++++++- drivers/md/bcache/bset.c | 16 ++++- drivers/md/bcache/bset.h | 34 +++++----- drivers/misc/genwqe/card_dev.c | 2 + drivers/misc/genwqe/card_utils.c | 4 ++ drivers/net/bonding/bond_main.c | 6 +- drivers/net/can/flexcan.c | 2 +- drivers/net/ethernet/dec/tulip/de4x5.c | 1 - drivers/net/ethernet/emulex/benet/be_ethtool.c | 30 ++++++--- drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 +- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 +- drivers/parisc/ccio-dma.c | 4 +- drivers/parisc/sba_iommu.c | 3 +- drivers/s390/net/qeth_l2_main.c | 2 +- drivers/s390/scsi/zfcp_ext.h | 1 + drivers/s390/scsi/zfcp_scsi.c | 9 +++ drivers/s390/scsi/zfcp_sysfs.c | 55 +++++++++++++++-- drivers/s390/scsi/zfcp_unit.c | 8 ++- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- drivers/scsi/ufs/ufshcd-pltfrm.c | 11 ++-- drivers/scsi/vmw_pvscsi.c | 6 +- drivers/spi/spi-bitbang.c | 2 +- drivers/staging/usbip/stub_dev.c | 75 ++++++++++++++++------- drivers/target/target_core_iblock.c | 2 +- drivers/tty/serial/max310x.c | 2 +- drivers/tty/serial/sh-sci.c | 7 +++ drivers/usb/core/config.c | 4 +- drivers/usb/core/quirks.c | 6 ++ drivers/usb/host/xhci.c | 2 +- drivers/usb/misc/rio500.c | 17 ++++- drivers/usb/serial/pl2303.c | 1 + drivers/usb/serial/pl2303.h | 3 + drivers/usb/storage/unusual_realtek.h | 5 ++ fs/btrfs/file.c | 12 ++++ fs/btrfs/reada.c | 7 +++ fs/cifs/cifsfs.c | 1 + fs/cifs/cifsglob.h | 5 ++ fs/cifs/file.c | 12 +++- fs/cifs/smb2maperror.c | 2 +- fs/configfs/dir.c | 14 ++--- fs/ocfs2/dcache.c | 12 ++++ include/linux/sched.h | 4 ++ kernel/cpu.c | 3 + kernel/cred.c | 9 +++ kernel/events/core.c | 5 +- kernel/events/ring_buffer.c | 33 ++++++++-- kernel/ptrace.c | 20 +++++- kernel/signal.c | 2 + kernel/trace/trace.c | 10 +-- lib/mpi/mpi-pow.c | 6 +- mm/huge_memory.c | 2 + net/can/af_can.c | 24 +++++++- net/core/dev.c | 2 +- net/core/neighbour.c | 7 +++ net/core/pktgen.c | 11 ++++ net/ipv4/igmp.c | 53 +++++++++++----- net/ipv6/ip6_flowlabel.c | 7 ++- net/iucv/af_iucv.c | 33 +++++++--- net/llc/llc_output.c | 2 + net/rds/ib_rdma.c | 10 +-- net/sched/sch_netem.c | 13 ++-- net/sctp/endpointola.c | 8 +-- net/wireless/core.c | 2 +- security/apparmor/policy_unpack.c | 2 +- sound/core/seq/oss/seq_oss_ioctl.c | 2 +- sound/core/seq/oss/seq_oss_rw.c | 2 +- sound/soc/codecs/cs42xx8.c | 1 + 86 files changed, 671 insertions(+), 198 deletions(-) Alan Stern (1): USB: Fix slab-out-of-bounds write in usb_get_bos_descriptor Alejandro Jimenez (1): x86/speculation: Allow guests to use SSBD even if host does not Alexandra Winter (1): s390/qeth: fix VLAN attribute in bridge_hostnotify udev event Andrea Arcangeli (1): coredump: fix race condition between collapse_huge_page() and core dumping Andrea Parri (1): sbitmap: fix improper use of smp_mb__before_atomic() Andrey Smirnov (1): Input: uinput - add compat ioctl number translation for UI_*_FF_UPLOAD Ben Hutchings (1): Linux 3.16.75 Carsten Schmid (1): usb: xhci: avoid null pointer deref when bos field is NULL Chris Packham (1): USB: serial: pl2303: add Allied Telesis VT-Kit3 Colin Ian King (3): scsi: bnx2fc: fix incorrect cast to u64 on shift operation x86/apic: Fix integer overflow on 10 bit left shift of cpu_khz ALSA: seq: fix incorrect order of dest_client/dest_ports arguments Coly Li (1): bcache: fix stack corruption by PRECEDING_KEY() Dan Carpenter (1): genwqe: Prevent an integer overflow in the ioctl Dave Martin (1): KVM: arm64: Filter out invalid core register IDs in KVM_GET_REG_LIST Dmitry Korotin (1): MIPS: Add missing EHB in mtc0 -> mfc0 sequence. Eiichi Tsukata (1): tracing/snapshot: Resize spare buffer if size changed Eric Biggers (2): cfg80211: fix memory leak of wiphy device name crypto: user - prevent operating on larval algorithms Eric Dumazet (6): ipv4/igmp: fix another memory leak in igmpv3_del_delrec() ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST llc: fix skb leak in llc_build_and_send_ui_pkt() net-gro: fix use-after-free read in napi_gro_frags() ipv6: flowlabel: fl6_sock_lookup() must use atomic_inc_not_zero neigh: fix use-after-free read in pneigh_get_next Eric W. Biederman (1): signal/ptrace: Don't leak unitialized kernel memory with PTRACE_PEEK_SIGINFO Filipe Manana (2): Btrfs: fix race between ranged fsync and writeback of adjacent ranges Btrfs: fix race between readahead and device replace/removal Geert Uytterhoeven (1): cpu/speculation: Warn on unsupported mitigations= parameter George G. Davis (1): serial: sh-sci: disable DMA for uart_console Hans de Goede (1): libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk Harald Freudenberger (1): s390/crypto: fix possible sleep during spinlock aquired Herbert Xu (1): lib/mpi: Fix karactx leak in mpi_powm Ivan Vecera (1): be2net: Fix number of Rx queues used for flow hashing Jakub Kicinski (1): net: netem: fix backlog accounting for corrupted GSO frames Jan Kara (1): scsi: vmw_pscsi: Fix use-after-free in pvscsi_queue_lck() Jan Stancek (1): powerpc/perf: add missing put_cpu_var in power_pmu_event_init Jann Horn (2): ptrace: restore smp_rmb() in __ptrace_may_access() apparmor: enforce nullbyte at end of tag string Jisheng Zhang (1): net: stmmac: fix reset gpio free missing Joakim Zhang (1): can: flexcan: fix timeout when set small bitrate Joe Burmeister (1): tty: max310x: Fix external crystal register setup John David Anglin (1): parisc: Use implicit space register selection for loading the coherence index of I/O pdirs Julian Wiedmann (2): net/af_iucv: remove GFP_DMA restriction for HiperTransport net/af_iucv: always register net_device notifier Kai-Heng Feng (1): USB: usb-storage: Add new ID to ums-realtek Kees Cook (1): net: tulip: de4x5: Drop redundant MODULE_DEVICE_TABLE() Marco Zatta (1): USB: Fix chipmunk-like voice when using Logitech C270 for recording audio. Maximilian Luz (1): USB: Add LPM quirk for Surface Dock GigE adapter Naohiro Aota (1): btrfs: start readahead also in seed devices Oliver Neukum (1): USB: rio500: fix memory leak in close after disconnect Paolo Abeni (1): pktgen: do not sleep with the thread lock held. Patrik Jakobsson (1): drm/gma500/cdv: Check vbt config bits when detecting lvds panels Peter Zijlstra (2): perf/ring_buffer: Add ordering to rb->nest increment perf/core: Fix perf_sample_regs_user() mm check Petr Oros (1): be2net: fix link failure after ethtool offline test Randy Dunlap (1): gpio: fix gpio-adp5588 build errors Ravi Bangoria (2): powerpc/perf: Fix MMCRA corruption by bhrb_filter perf/ioctl: Add check for the sample_period value Robert Hancock (1): hwmon: (pmbus/core) Treat parameters as paged if on multiple pages Roberto Bergantinos Corpas (1): CIFS: cifs_read_allocate_pages: don't iterate through whole page array on ENOMEM Roman Bolshakov (1): scsi: target/iblock: Fix overrun in WRITE SAME emulation Ronnie Sahlberg (1): cifs: add spinlock for the openFileList to cifsInodeInfo Russell King (1): i2c: acorn: fix i2c warning S.j. Wang (1): ASoC: cs42xx8: Add regcache mask dirty Sahitya Tummala (1): configfs: Fix use-after-free when accessing sd->s_dentry Shuah Khan (2): usbip: usbip_host: fix BUG: sleeping function called from invalid context usbip: usbip_host: fix stub_dev lock context imbalance regression Stanley Chu (1): scsi: ufs: Avoid runtime suspend possibly being blocked forever Steffen Maier (2): scsi: zfcp: fix missing zfcp_port reference put on -EBUSY from port_remove scsi: zfcp: fix to prevent port_remove with pure auto scan LUNs (only sdevs) Steve French (1): SMB3: retry on STATUS_INSUFFICIENT_RESOURCES instead of failing write WANG Cong (2): igmp: acquire pmc lock for ip_mc_clear_src() igmp: add a missing spin_lock_init() Wengang Wang (1): fs/ocfs2: fix race in ocfs2_dentry_attach_lock() Willem de Bruijn (1): can: purge socket error queue on sock destruct Xin Long (1): sctp: change to hold sk after auth shkey is created successfully Yabin Cui (1): perf/ring_buffer: Fix exposing a temporarily decreased data_head Yingjoe Chen (1): i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr YueHaibing (4): spi: bitbang: Fix NULL pointer dereference in spi_unregister_master can: af_can: Fix error path of can_init() bonding: Always enable vlan tx offload bonding: Add vlan tx offload to hw_enc_features Yunjian Wang (1): net/mlx4_core: Change the error print to info print Zhenliang Wei (1): kernel/signal.c: trace_signal_deliver when signal_group_exit Zhu Yanjun (1): net: rds: fix memory leak in rds_ib_flush_mr_pool -- Ben Hutchings The most exhausting thing in life is being insincere. - Anne Morrow Lindberg

5 years

1
0
0 0

stable/linux-5.3.y boot: 70 boots: 4 failed, 66 passed (v5.3.4)

by kernelci.org bot

stable/linux-5.3.y boot: 70 boots: 4 failed, 66 passed (v5.3.4) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-5.3.y/kernel/v5.3.4/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.3.y/kernel/v5.3.4/ Tree: stable Branch: linux-5.3.y Git Describe: v5.3.4 Git Commit: ed56826f177921da1cc66a927de22ca1666eb78c Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 51 unique boards, 18 SoC families, 13 builds out of 208 Boot Regressions Detected: arm64: defconfig: gcc-8: meson-gxl-s805x-libretech-ac: lab-baylibre: new failure (last pass: v5.3.3) meson-gxm-khadas-vim2: lab-baylibre: new failure (last pass: v5.3.3) i386: i386_defconfig: gcc-8: qemu_i386: lab-baylibre: failing since 1 day (last pass: v5.3.2-1-g9c30694424ee - first fail: v5.3.3) Boot Failures Detected: arm64: defconfig: gcc-8: apq8096-db820c: 1 failed lab meson-gxl-s805x-libretech-ac: 1 failed lab meson-gxm-khadas-vim2: 1 failed lab i386: i386_defconfig: gcc-8: qemu_i386: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

stable-rc/linux-5.3.y boot: 64 boots: 1 failed, 63 passed (v5.3.4)

by kernelci.org bot

stable-rc/linux-5.3.y boot: 64 boots: 1 failed, 63 passed (v5.3.4) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.3.y/kernel/v5.3.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.3.y/kernel/v5.3.4/ Tree: stable-rc Branch: linux-5.3.y Git Describe: v5.3.4 Git Commit: ed56826f177921da1cc66a927de22ca1666eb78c Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 45 unique boards, 17 SoC families, 12 builds out of 208 Boot Regressions Detected: i386: i386_defconfig: gcc-8: qemu_i386: lab-baylibre: failing since 1 day (last pass: v5.3.2-346-gc9adc631ac5f - first fail: v5.3.3) Boot Failure Detected: i386: i386_defconfig: gcc-8: qemu_i386: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

+ mm-slub-fix-a-deadlock-in-show_slab_objects.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm/slub: fix a deadlock in show_slab_objects() has been added to the -mm tree. Its filename is mm-slub-fix-a-deadlock-in-show_slab_objects.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-slub-fix-a-deadlock-in-show_sla… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-fix-a-deadlock-in-show_sla… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Qian Cai <cai(a)lca.pw> Subject: mm/slub: fix a deadlock in show_slab_objects() A long time ago we fixed a similar deadlock in show_slab_objects() [1]. However, it is apparently due to the commits like 01fb58bcba63 ("slab: remove synchronous synchronize_sched() from memcg cache deactivation path") and 03afc0e25f7f ("slab: get_online_mems for kmem_cache_{create,destroy,shrink}"), this kind of deadlock is back by just reading files in /sys/kernel/slab which will generate a lockdep splat below. Since the "mem_hotplug_lock" here is only to obtain a stable online node mask while racing with NUMA node hotplug, in the worst case, the results may me miscalculated while doing NUMA node hotplug, but they shall be corrected by later reads of the same files. WARNING: possible circular locking dependency detected ------------------------------------------------------ cat/5224 is trying to acquire lock: ffff900012ac3120 (mem_hotplug_lock.rw_sem){++++}, at: show_slab_objects+0x94/0x3a8 but task is already holding lock: b8ff009693eee398 (kn->count#45){++++}, at: kernfs_seq_start+0x44/0xf0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (kn->count#45){++++}: lock_acquire+0x31c/0x360 __kernfs_remove+0x290/0x490 kernfs_remove+0x30/0x44 sysfs_remove_dir+0x70/0x88 kobject_del+0x50/0xb0 sysfs_slab_unlink+0x2c/0x38 shutdown_cache+0xa0/0xf0 kmemcg_cache_shutdown_fn+0x1c/0x34 kmemcg_workfn+0x44/0x64 process_one_work+0x4f4/0x950 worker_thread+0x390/0x4bc kthread+0x1cc/0x1e8 ret_from_fork+0x10/0x18 -> #1 (slab_mutex){+.+.}: lock_acquire+0x31c/0x360 __mutex_lock_common+0x16c/0xf78 mutex_lock_nested+0x40/0x50 memcg_create_kmem_cache+0x38/0x16c memcg_kmem_cache_create_func+0x3c/0x70 process_one_work+0x4f4/0x950 worker_thread+0x390/0x4bc kthread+0x1cc/0x1e8 ret_from_fork+0x10/0x18 -> #0 (mem_hotplug_lock.rw_sem){++++}: validate_chain+0xd10/0x2bcc __lock_acquire+0x7f4/0xb8c lock_acquire+0x31c/0x360 get_online_mems+0x54/0x150 show_slab_objects+0x94/0x3a8 total_objects_show+0x28/0x34 slab_attr_show+0x38/0x54 sysfs_kf_seq_show+0x198/0x2d4 kernfs_seq_show+0xa4/0xcc seq_read+0x30c/0x8a8 kernfs_fop_read+0xa8/0x314 __vfs_read+0x88/0x20c vfs_read+0xd8/0x10c ksys_read+0xb0/0x120 __arm64_sys_read+0x54/0x88 el0_svc_handler+0x170/0x240 el0_svc+0x8/0xc other info that might help us debug this: Chain exists of: mem_hotplug_lock.rw_sem --> slab_mutex --> kn->count#45 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(kn->count#45); lock(slab_mutex); lock(kn->count#45); lock(mem_hotplug_lock.rw_sem); *** DEADLOCK *** 3 locks held by cat/5224: #0: 9eff00095b14b2a0 (&p->lock){+.+.}, at: seq_read+0x4c/0x8a8 #1: 0eff008997041480 (&of->mutex){+.+.}, at: kernfs_seq_start+0x34/0xf0 #2: b8ff009693eee398 (kn->count#45){++++}, at: kernfs_seq_start+0x44/0xf0 stack backtrace: Call trace: dump_backtrace+0x0/0x248 show_stack+0x20/0x2c dump_stack+0xd0/0x140 print_circular_bug+0x368/0x380 check_noncircular+0x248/0x250 validate_chain+0xd10/0x2bcc __lock_acquire+0x7f4/0xb8c lock_acquire+0x31c/0x360 get_online_mems+0x54/0x150 show_slab_objects+0x94/0x3a8 total_objects_show+0x28/0x34 slab_attr_show+0x38/0x54 sysfs_kf_seq_show+0x198/0x2d4 kernfs_seq_show+0xa4/0xcc seq_read+0x30c/0x8a8 kernfs_fop_read+0xa8/0x314 __vfs_read+0x88/0x20c vfs_read+0xd8/0x10c ksys_read+0xb0/0x120 __arm64_sys_read+0x54/0x88 el0_svc_handler+0x170/0x240 el0_svc+0x8/0xc [1] http://lkml.iu.edu/hypermail/linux/kernel/1101.0/02850.html Link: http://lkml.kernel.org/r/1570192309-10132-1-git-send-email-cai@lca.pw Fixes: 01fb58bcba63 ("slab: remove synchronous synchronize_sched() from memcg cache deactivation path") Fixes: 03afc0e25f7f ("slab: get_online_mems for kmem_cache_{create,destroy,shrink}") Signed-off-by: Qian Cai <cai(a)lca.pw> Acked-by: Michal Hocko <mhocko(a)suse.com> Cc: Christoph Lameter <cl(a)linux.com> Cc: Pekka Enberg <penberg(a)kernel.org> Cc: David Rientjes <rientjes(a)google.com> Cc: Joonsoo Kim <iamjoonsoo.kim(a)lge.com> Cc: Tejun Heo <tj(a)kernel.org> Cc: Vladimir Davydov <vdavydov.dev(a)gmail.com> Cc: Roman Gushchin <guro(a)fb.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/slub.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- a/mm/slub.c~mm-slub-fix-a-deadlock-in-show_slab_objects +++ a/mm/slub.c @@ -4846,7 +4846,13 @@ static ssize_t show_slab_objects(struct } } - get_online_mems(); + /* + * It is impossible to take "mem_hotplug_lock" here with "kernfs_mutex" + * already held which will conflict with an existing lock order: + * + * mem_hotplug_lock->slab_mutex->kernfs_mutex + */ + #ifdef CONFIG_SLUB_DEBUG if (flags & SO_ALL) { struct kmem_cache_node *n; @@ -4887,7 +4893,6 @@ static ssize_t show_slab_objects(struct x += sprintf(buf + x, " N%d=%lu", node, nodes[node]); #endif - put_online_mems(); kfree(nodes); return x + sprintf(buf + x, "\n"); } _ Patches currently in -mm which might be from cai(a)lca.pw are mm-page_alloc-fix-a-crash-in-free_pages_prepare.patch mm-slub-fix-a-deadlock-in-show_slab_objects.patch

5 years

1
0
0 0

stable-rc/linux-4.9.y boot: 43 boots: 0 failed, 43 passed (v4.9.195)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 43 boots: 0 failed, 43 passed (v4.9.195) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.195/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.195 Git Commit: 6eea609ac3091741dee9080bae6bcf2edc879ca2 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 24 unique boards, 13 SoC families, 10 builds out of 197 --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

stable-rc/linux-5.3.y boot: 64 boots: 2 failed, 61 passed with 1 untried/unknown (v5.3.3)

by kernelci.org bot

stable-rc/linux-5.3.y boot: 64 boots: 2 failed, 61 passed with 1 untried/unknown (v5.3.3) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.3.y/kernel/v5.3.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.3.y/kernel/v5.3.3/ Tree: stable-rc Branch: linux-5.3.y Git Describe: v5.3.3 Git Commit: 5a4dd7cf7b980093d507d55571e342ba702cb336 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 45 unique boards, 17 SoC families, 12 builds out of 208 Boot Regressions Detected: arm64: defconfig: gcc-8: meson-gxl-s805x-libretech-ac: lab-baylibre: new failure (last pass: v5.3.2-346-gc9adc631ac5f) i386: i386_defconfig: gcc-8: qemu_i386: lab-baylibre: new failure (last pass: v5.3.2-346-gc9adc631ac5f) Boot Failures Detected: arm64: defconfig: gcc-8: meson-gxl-s805x-libretech-ac: 1 failed lab i386: i386_defconfig: gcc-8: qemu_i386: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

stable-rc/linux-4.4.y boot: 39 boots: 1 failed, 37 passed with 1 conflict (v4.4.195)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 39 boots: 1 failed, 37 passed with 1 conflict (v4.4.195) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.195/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.195 Git Commit: 5164f0c3740d357ba460b44222bedfa2475ca794 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 21 unique boards, 10 SoC families, 8 builds out of 190 Boot Failure Detected: arm64: defconfig: gcc-8: qcom-qdf2400: 1 failed lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) i386: i386_defconfig: qemu_i386: lab-baylibre: FAIL (gcc-8) lab-linaro-lkft: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

stable/linux-5.3.y boot: 70 boots: 2 failed, 68 passed (v5.3.3)

by kernelci.org bot

stable/linux-5.3.y boot: 70 boots: 2 failed, 68 passed (v5.3.3) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-5.3.y/kernel/v5.3.3/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.3.y/kernel/v5.3.3/ Tree: stable Branch: linux-5.3.y Git Describe: v5.3.3 Git Commit: 5a4dd7cf7b980093d507d55571e342ba702cb336 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 51 unique boards, 18 SoC families, 13 builds out of 208 Boot Regressions Detected: i386: i386_defconfig: gcc-8: qemu_i386: lab-baylibre: new failure (last pass: v5.3.2-1-g9c30694424ee) Boot Failures Detected: arm64: defconfig: gcc-8: apq8096-db820c: 1 failed lab i386: i386_defconfig: gcc-8: qemu_i386: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror October 2019