This is the start of the stable review cycle for the 4.4.171 release.
There are 51 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu Jan 17 15:48:21 UTC 2019.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.171-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.4.171-rc1
Vasily Averin <vvs(a)virtuozzo.com>
sunrpc: use-after-free in svc_process_common()
Theodore Ts'o <tytso(a)mit.edu>
ext4: fix a potential fiemap/page fault deadlock w/ inline_data
Eric Biggers <ebiggers(a)google.com>
crypto: cts - fix crash on short inputs
Yi Zeng <yizeng(a)asrmicro.com>
i2c: dev: prevent adapter retries and timeout being set as minus value
Hans de Goede <hdegoede(a)redhat.com>
ACPI: power: Skip duplicate power resource references in _PRx
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Move retrain from fixup to altera_pcie_host_init()
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Rework config accessors for use without a struct pci_bus
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Poll for link training status after retraining the link
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Poll for link up status after retraining the link
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Check link status before retrain link
Bjorn Helgaas <bhelgaas(a)google.com>
PCI: altera: Reorder read/write functions
Ley Foon Tan <lftan(a)altera.com>
PCI: altera: Fix altera_pcie_link_is_up()
Christoph Lameter <cl(a)linux.com>
slab: alien caches must not be initialized if the allocation of the alien cache failed
Jack Stocker <jackstocker.93(a)gmail.com>
USB: Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
Icenowy Zheng <icenowy(a)aosc.io>
USB: storage: add quirk for SMI SM3350
Icenowy Zheng <icenowy(a)aosc.io>
USB: storage: don't insert sane sense for SPC3+ when bad sense specified
Daniele Palmas <dnlplm(a)gmail.com>
usb: cdc-acm: send ZLP for Telit 3G Intel based modems
Ross Lagerwall <ross.lagerwall(a)citrix.com>
cifs: Fix potential OOB access of lock element array
Pavel Shilovsky <pshilov(a)microsoft.com>
CIFS: Do not hide EINTR after sending network packets
Shaokun Zhang <zhangshaokun(a)hisilicon.com>
btrfs: tree-checker: Fix misleading group system information
Qu Wenruo <wqu(a)suse.com>
btrfs: tree-checker: Check level for leaves and nodes
Qu Wenruo <wqu(a)suse.com>
btrfs: Verify that every chunk has corresponding block group at mount time
Qu Wenruo <wqu(a)suse.com>
btrfs: Check that each block group has corresponding chunk at mount time
Gu Jinxiang <gujx(a)cn.fujitsu.com>
btrfs: validate type when reading a chunk
Qu Wenruo <wqu(a)suse.com>
btrfs: tree-checker: Detect invalid and empty essential trees
Qu Wenruo <wqu(a)suse.com>
btrfs: tree-checker: Verify block_group_item
David Sterba <dsterba(a)suse.com>
btrfs: tree-check: reduce stack consumption in check_dir_item
Arnd Bergmann <arnd(a)arndb.de>
btrfs: tree-checker: use %zu format string for size_t
Qu Wenruo <wqu(a)suse.com>
btrfs: tree-checker: Add checker for dir item
Qu Wenruo <wqu(a)suse.com>
btrfs: tree-checker: Fix false panic for sanity test
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: tree-checker: Enhance btrfs_check_node output
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: Move leaf and node validation checker to tree-checker.c
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: Add checker for EXTENT_CSUM
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: Add sanity check for EXTENT_DATA when reading out leaf
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: Check if item pointer overlaps with the item itself
Qu Wenruo <quwenruo.btrfs(a)gmx.com>
btrfs: Refactor check_leaf function for later expansion
Jeff Mahoney <jeffm(a)suse.com>
btrfs: struct-funcs, constify readers
Filipe Manana <fdmanana(a)suse.com>
Btrfs: fix emptiness check for dirtied extent buffers at check_leaf()
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: memset to avoid stale content in btree leaf
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: kill BUG_ON in run_delayed_tree_ref
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: improve check_node to avoid reading corrupted nodes
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: memset to avoid stale content in btree node block
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: fix BUG_ON in btrfs_mark_buffer_dirty
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: check btree node's nritems
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: detect corruption when non-root leaf has zero item
Josef Bacik <jbacik(a)fb.com>
Btrfs: fix em leak in find_first_block_group
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: check inconsistence between chunk and block group
Liu Bo <bo.li.liu(a)oracle.com>
Btrfs: add validadtion checks for chunk loading
Qu Wenruo <quwenruo(a)cn.fujitsu.com>
btrfs: Enhance chunk validation check
Jeff Mahoney <jeffm(a)suse.com>
btrfs: cleanup, stop casting for extent_map->lookup everywhere
Kailang Yang <kailang(a)realtek.com>
ALSA: hda/realtek - Disable headset Mic VREF for headset mode of ALC225
-------------
Diffstat:
Makefile | 4 +-
crypto/cts.c | 8 +-
drivers/acpi/power.c | 22 ++
drivers/i2c/i2c-dev.c | 6 +
drivers/pci/host/pcie-altera.c | 201 +++++++++---
drivers/usb/class/cdc-acm.c | 7 +
drivers/usb/core/quirks.c | 3 +-
drivers/usb/storage/scsiglue.c | 8 +-
drivers/usb/storage/unusual_devs.h | 12 +
fs/btrfs/Makefile | 2 +-
fs/btrfs/ctree.c | 14 -
fs/btrfs/ctree.h | 141 ++++----
fs/btrfs/dev-replace.c | 2 +-
fs/btrfs/disk-io.c | 80 +----
fs/btrfs/extent-tree.c | 112 ++++++-
fs/btrfs/extent_io.c | 43 ++-
fs/btrfs/extent_io.h | 19 +-
fs/btrfs/extent_map.c | 2 +-
fs/btrfs/extent_map.h | 10 +-
fs/btrfs/scrub.c | 2 +-
fs/btrfs/struct-funcs.c | 9 +-
fs/btrfs/tree-checker.c | 649 +++++++++++++++++++++++++++++++++++++
fs/btrfs/tree-checker.h | 38 +++
fs/btrfs/volumes.c | 139 +++++++-
fs/btrfs/volumes.h | 2 +
fs/cifs/file.c | 8 +-
fs/cifs/smb2file.c | 4 +-
fs/cifs/transport.c | 2 +-
fs/ext4/inline.c | 6 +-
include/linux/sunrpc/svc.h | 5 +-
mm/slab.c | 6 +-
net/sunrpc/svc.c | 10 +-
net/sunrpc/svc_xprt.c | 5 +-
net/sunrpc/svcsock.c | 2 +-
sound/pci/hda/patch_realtek.c | 16 +-
35 files changed, 1324 insertions(+), 275 deletions(-)
power off the phy should be done before populate the phy. Otherwise,
am335x_init() could be called by the phy owner to power on the phy first,
then am335x_phy_probe() turns off the phy again without the caller knowing
it.
Fixes: 2fc711d76352 ("usb: phy: am335x: Enable USB remote wakeup using PHY wakeup")
Cc: stable(a)vger.kernel.org # v3.18+
Signed-off-by: Bin Liu <b-liu(a)ti.com>
---
drivers/usb/phy/phy-am335x.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c
index 27bdb7222527..f5f0568d8533 100644
--- a/drivers/usb/phy/phy-am335x.c
+++ b/drivers/usb/phy/phy-am335x.c
@@ -61,9 +61,6 @@ static int am335x_phy_probe(struct platform_device *pdev)
if (ret)
return ret;
- ret = usb_add_phy_dev(&am_phy->usb_phy_gen.phy);
- if (ret)
- return ret;
am_phy->usb_phy_gen.phy.init = am335x_init;
am_phy->usb_phy_gen.phy.shutdown = am335x_shutdown;
@@ -82,7 +79,7 @@ static int am335x_phy_probe(struct platform_device *pdev)
device_set_wakeup_enable(dev, false);
phy_ctrl_power(am_phy->phy_ctrl, am_phy->id, am_phy->dr_mode, false);
- return 0;
+ return usb_add_phy_dev(&am_phy->usb_phy_gen.phy);
}
static int am335x_phy_remove(struct platform_device *pdev)
--
2.17.1
From: Bartosz Golaszewski <bgolaszewski(a)baylibre.com>
Nested interrupts run inside the calling thread's context and the top
half handler is never called which means that we never read the
timestamp.
This issue came up when trying to read line events from a gpiochip
using regmap_irq_chip for interrupts.
Fix it by reading the timestamp from the irq thread function if it's
still 0 by the time the second handler is called.
Fixes: d58f2bf261fd ("gpio: Timestamp events in hardirq handler")
Cc: stable(a)vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski(a)baylibre.com>
---
Hi Sasha,
this is a backport for v4.19.y series. The original patch didn't apply
due to a conflict.
drivers/gpio/gpiolib.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a8e01d99919c..b3ab6c428423 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -817,7 +817,15 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p)
/* Do not leak kernel stack to userspace */
memset(&ge, 0, sizeof(ge));
- ge.timestamp = le->timestamp;
+ /*
+ * We may be running from a nested threaded interrupt in which case
+ * we didn't get the timestamp from lineevent_irq_handler().
+ */
+ if (!le->timestamp)
+ ge.timestamp = ktime_get_real_ns();
+ else
+ ge.timestamp = le->timestamp;
+
level = gpiod_get_value_cansleep(le->desc);
if (le->eflags & GPIOEVENT_REQUEST_RISING_EDGE
--
2.19.1
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: vim2m: only cancel work if it is for right context
Author: Hans Verkuil <hverkuil(a)xs4all.nl>
Date: Fri Jan 11 07:07:25 2019 -0500
cancel_delayed_work_sync() was called for any queue, but it should only
be called for the queue that is associated with the currently running job.
Otherwise, if two filehandles are streaming at the same time, then closing the
first will cancel the work which might still be running for a job from the
second filehandle. As a result the second filehandle will never be able to
finish the job and an attempt to stop streaming on that second filehandle will
stall.
Fixes: 52117be68b82 ("media: vim2m: use cancel_delayed_work_sync instead of flush_schedule_work")
Signed-off-by: Hans Verkuil <hverkuil-cisco(a)xs4all.nl>
Cc: <stable(a)vger.kernel.org> # for v4.20 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org>
drivers/media/platform/vim2m.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
index d01821a6906a..89d9c4c21037 100644
--- a/drivers/media/platform/vim2m.c
+++ b/drivers/media/platform/vim2m.c
@@ -807,7 +807,9 @@ static void vim2m_stop_streaming(struct vb2_queue *q)
struct vb2_v4l2_buffer *vbuf;
unsigned long flags;
- cancel_delayed_work_sync(&dev->work_run);
+ if (v4l2_m2m_get_curr_priv(dev->m2m_dev) == ctx)
+ cancel_delayed_work_sync(&dev->work_run);
+
for (;;) {
if (V4L2_TYPE_IS_OUTPUT(q->type))
vbuf = v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: v4l: ioctl: Validate num_planes for debug messages
Author: Sakari Ailus <sakari.ailus(a)linux.intel.com>
Date: Thu Jan 10 09:24:26 2019 -0500
The num_planes field in struct v4l2_pix_format_mplane is used in a loop
before validating it. As the use is printing a debug message in this case,
just cap the value to the maximum allowed.
Signed-off-by: Sakari Ailus <sakari.ailus(a)linux.intel.com>
Cc: stable(a)vger.kernel.org
Reviewed-by: Thierry Reding <treding(a)nvidia.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco(a)xs4all.nl>
Cc: <stable(a)vger.kernel.org> # for v4.12 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org>
drivers/media/v4l2-core/v4l2-ioctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 44bc7c4f1c11..90aad465f9ed 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -287,6 +287,7 @@ static void v4l_print_format(const void *arg, bool write_only)
const struct v4l2_window *win;
const struct v4l2_sdr_format *sdr;
const struct v4l2_meta_format *meta;
+ u32 planes;
unsigned i;
pr_cont("type=%s", prt_names(p->type, v4l2_type_names));
@@ -317,7 +318,8 @@ static void v4l_print_format(const void *arg, bool write_only)
prt_names(mp->field, v4l2_field_names),
mp->colorspace, mp->num_planes, mp->flags,
mp->ycbcr_enc, mp->quantization, mp->xfer_func);
- for (i = 0; i < mp->num_planes; i++)
+ planes = min_t(u32, mp->num_planes, VIDEO_MAX_PLANES);
+ for (i = 0; i < planes; i++)
printk(KERN_DEBUG "plane %u: bytesperline=%u sizeimage=%u\n", i,
mp->plane_fmt[i].bytesperline,
mp->plane_fmt[i].sizeimage);
Hi Sasha,
On 1/16/19 2:36 PM, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: 2.6.26+
>
> The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93, v4.9.150, v4.4.170, v3.18.132.
>
> v4.20.2: Build OK!
> v4.19.15: Build OK!
> v4.14.93: Build OK!
> v4.9.150: Build OK!
> v4.4.170: Failed to apply! Possible dependencies:
> 2b5f5f5dc114 ("can: bcm: unify bcm_msg_head handling and prepare function parameters")
> 6f3b911d5f29 ("can: bcm: add support for CAN FD frames")
> 72c8a89ad2e4 ("can: bcm: use CAN frame instead of can_frame in comments")
> 95acb490ec51 ("can: bcm: fix indention and other minor style issues")
>
> v3.18.132: Failed to apply! Possible dependencies:
> 069f8457ae52 ("can: fix spelling errors")
> 2b5f5f5dc114 ("can: bcm: unify bcm_msg_head handling and prepare function parameters")
> 6ce8e9ce5989 ("new helper: memcpy_from_msg()")
> 6f3b911d5f29 ("can: bcm: add support for CAN FD frames")
> 72c8a89ad2e4 ("can: bcm: use CAN frame instead of can_frame in comments")
> 95acb490ec51 ("can: bcm: fix indention and other minor style issues")
> ba61a8d9d780 ("can: avoid using timeval for uapi")
>
>
> How should we proceed with this patch?
Applying the patch on e.g. 3.2.102 also leads to
patching file net/can/bcm.c
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 140.
Hunk #3 succeeded at 847 with fuzz 2 (offset -26 lines).
Hunk #4 succeeded at 1018 with fuzz 2 (offset -39 lines).
2 out of 4 hunks FAILED -- saving rejects to file net/can/bcm.c.rej
The first two hunks just adding a define and and function *somewhere* at
the top of the C file.
I can provide patches for the requested stable kernels once we have a
reference for the upstream commit hash.
Would that be ok for you?
Best regards,
Oliver
śr., 16 sty 2019 o 14:35 Sasha Levin <sashal(a)kernel.org> napisał(a):
>
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: d58f2bf261fd gpio: Timestamp events in hardirq handler.
>
> The bot has tested the following trees: v4.20.2, v4.19.15.
>
> v4.20.2: Build OK!
> v4.19.15: Failed to apply! Possible dependencies:
> Unable to calculate
>
>
> How should we proceed with this patch?
>
I sent a backport of this patch.
Bart
> --
> Thanks,
> Sasha
On 1/16/19 7:35 AM, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93, v4.9.150, v4.4.170, v3.18.132.
I'll pull these into my tree.
It sounds like you want this in ASAP, I can do that, though this
interface is
lower priority, I would think, because it's generally root access only.
-corey
>
> v4.20.2: Build OK!
> v4.19.15: Build OK!
> v4.14.93: Failed to apply! Possible dependencies:
> 1c9f98d1bfbd ("ipmi: Make IPMI panic strings always available")
> 3fd32f9ec84f ("ipmi: Convert IPMI GUID over to Linux guid_t")
> 511d57dc71a2 ("ipmi: Get the device id through a function")
> 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")
> 9ca15af3164f ("ipmi: Fix issues with BMC refcounts")
> a2cb600fa22a ("ipmi: Rework BMC registration")
> a9137c3dfae9 ("ipmi: Add a reference from BMC devices to their interfaces")
> aa9c9ab2443e ("ipmi: allow dynamic BMC version information")
> b2cfd8ab4add ("ipmi: Rework device id and guid handling to catch changing BMCs")
> c0734bd594d4 ("ipmi: Retry BMC registration on a failure")
> f33e4df83e00 ("ipmi: Move bmc find routing to below bmc device type")
>
> v4.9.150: Failed to apply! Possible dependencies:
> 1c9f98d1bfbd ("ipmi: Make IPMI panic strings always available")
> 3fd32f9ec84f ("ipmi: Convert IPMI GUID over to Linux guid_t")
> 511d57dc71a2 ("ipmi: Get the device id through a function")
> 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")
> 9ca15af3164f ("ipmi: Fix issues with BMC refcounts")
> a2cb600fa22a ("ipmi: Rework BMC registration")
> a9137c3dfae9 ("ipmi: Add a reference from BMC devices to their interfaces")
> aa9c9ab2443e ("ipmi: allow dynamic BMC version information")
> b2cfd8ab4add ("ipmi: Rework device id and guid handling to catch changing BMCs")
> c0734bd594d4 ("ipmi: Retry BMC registration on a failure")
> f33e4df83e00 ("ipmi: Move bmc find routing to below bmc device type")
>
> v4.4.170: Failed to apply! Possible dependencies:
> 1c9f98d1bfbd ("ipmi: Make IPMI panic strings always available")
> 3fd32f9ec84f ("ipmi: Convert IPMI GUID over to Linux guid_t")
> 511d57dc71a2 ("ipmi: Get the device id through a function")
> 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name")
> 9ca15af3164f ("ipmi: Fix issues with BMC refcounts")
> a2cb600fa22a ("ipmi: Rework BMC registration")
> a9137c3dfae9 ("ipmi: Add a reference from BMC devices to their interfaces")
> aa9c9ab2443e ("ipmi: allow dynamic BMC version information")
> b2cfd8ab4add ("ipmi: Rework device id and guid handling to catch changing BMCs")
> bd85f4b37ddf ("ipmi: fix crash on reading version from proc after unregisted bmc")
> c0734bd594d4 ("ipmi: Retry BMC registration on a failure")
> f33e4df83e00 ("ipmi: Move bmc find routing to below bmc device type")
>
> v3.18.132: Failed to apply! Possible dependencies:
> 16639eb08a69 ("ipmi: clean up the device handling for the bmc device")
> 1c9f98d1bfbd ("ipmi: Make IPMI panic strings always available")
> 3fd32f9ec84f ("ipmi: Convert IPMI GUID over to Linux guid_t")
> 5a0e10ec4a82 ("ipmi: Remove useless sysfs_name parameters")
> 9ca15af3164f ("ipmi: Fix issues with BMC refcounts")
> a2cb600fa22a ("ipmi: Rework BMC registration")
> a9137c3dfae9 ("ipmi: Add a reference from BMC devices to their interfaces")
> aa9c9ab2443e ("ipmi: allow dynamic BMC version information")
> b2cfd8ab4add ("ipmi: Rework device id and guid handling to catch changing BMCs")
> bd85f4b37ddf ("ipmi: fix crash on reading version from proc after unregisted bmc")
> c0734bd594d4 ("ipmi: Retry BMC registration on a failure")
> f33e4df83e00 ("ipmi: Move bmc find routing to below bmc device type")
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha