January 2019 - Linux-stable-mirror

[PATCH] ipmi_si: fix use-after-free of resource->name

by Yang Yingliang

When we excute the following commands, we got oops rmmod ipmi_si cat /proc/ioports [ 1623.482380] Unable to handle kernel paging request at virtual address ffff00000901d478 [ 1623.482382] Mem abort info: [ 1623.482383] ESR = 0x96000007 [ 1623.482385] Exception class = DABT (current EL), IL = 32 bits [ 1623.482386] SET = 0, FnV = 0 [ 1623.482387] EA = 0, S1PTW = 0 [ 1623.482388] Data abort info: [ 1623.482389] ISV = 0, ISS = 0x00000007 [ 1623.482390] CM = 0, WnR = 0 [ 1623.482393] swapper pgtable: 4k pages, 48-bit VAs, pgdp = 00000000d7d94a66 [ 1623.482395] [ffff00000901d478] pgd=000000dffbfff003, pud=000000dffbffe003, pmd=0000003f5d06e003, pte=0000000000000000 [ 1623.482399] Internal error: Oops: 96000007 [#1] SMP [ 1623.487407] Modules linked in: ipmi_si(E) nls_utf8 isofs rpcrdma ib_iser ib_srpt target_core_mod ib_srp scsi_transport_srp ib_ipoib rdma_ucm ib_umad rdma_cm ib_cm dm_mirror dm_region_hash dm_log iw_cm dm_mod aes_ce_blk crypto_simd cryptd aes_ce_cipher ses ghash_ce sha2_ce enclosure sha256_arm64 sg sha1_ce hisi_sas_v2_hw hibmc_drm sbsa_gwdt hisi_sas_main ip_tables mlx5_ib ib_uverbs marvell ib_core mlx5_core ixgbe mdio hns_dsaf ipmi_devintf hns_enet_drv ipmi_msghandler hns_mdio [last unloaded: ipmi_si] [ 1623.532410] CPU: 30 PID: 11438 Comm: cat Kdump: loaded Tainted: G E 5.0.0-rc3+ #168 [ 1623.541498] Hardware name: Huawei TaiShan 2280 /BC11SPCD, BIOS 1.37 11/21/2017 [ 1623.548822] pstate: a0000005 (NzCv daif -PAN -UAO) [ 1623.553684] pc : string+0x28/0x98 [ 1623.557040] lr : vsnprintf+0x368/0x5e8 [ 1623.560837] sp : ffff000013213a80 [ 1623.564191] x29: ffff000013213a80 x28: ffff00001138abb5 [ 1623.569577] x27: ffff000013213c18 x26: ffff805f67d06049 [ 1623.574963] x25: 0000000000000000 x24: ffff00001138abb5 [ 1623.580349] x23: 0000000000000fb7 x22: ffff0000117ed000 [ 1623.585734] x21: ffff000011188fd8 x20: ffff805f67d07000 [ 1623.591119] x19: ffff805f67d06061 x18: ffffffffffffffff [ 1623.596505] x17: 0000000000000200 x16: 0000000000000000 [ 1623.601890] x15: ffff0000117ed748 x14: ffff805f67d07000 [ 1623.607276] x13: ffff805f67d0605e x12: 0000000000000000 [ 1623.612661] x11: 0000000000000000 x10: 0000000000000000 [ 1623.618046] x9 : 0000000000000000 x8 : 000000000000000f [ 1623.623432] x7 : ffff805f67d06061 x6 : fffffffffffffffe [ 1623.628817] x5 : 0000000000000012 x4 : ffff00000901d478 [ 1623.634203] x3 : ffff0a00ffffff04 x2 : ffff805f67d07000 [ 1623.639588] x1 : ffff805f67d07000 x0 : ffffffffffffffff [ 1623.644974] Process cat (pid: 11438, stack limit = 0x000000008d4cbc10) [ 1623.651592] Call trace: [ 1623.654068] string+0x28/0x98 [ 1623.657071] vsnprintf+0x368/0x5e8 [ 1623.660517] seq_vprintf+0x70/0x98 [ 1623.668009] seq_printf+0x7c/0xa0 [ 1623.675530] r_show+0xc8/0xf8 [ 1623.682558] seq_read+0x330/0x440 [ 1623.689877] proc_reg_read+0x78/0xd0 [ 1623.697346] __vfs_read+0x60/0x1a0 [ 1623.704564] vfs_read+0x94/0x150 [ 1623.711339] ksys_read+0x6c/0xd8 [ 1623.717939] __arm64_sys_read+0x24/0x30 [ 1623.725077] el0_svc_common+0x120/0x148 [ 1623.732035] el0_svc_handler+0x30/0x40 [ 1623.738757] el0_svc+0x8/0xc [ 1623.744520] Code: d1000406 aa0103e2 54000149 b4000080 (39400085) [ 1623.753441] ---[ end trace f91b6a4937de9835 ]--- [ 1623.760871] Kernel panic - not syncing: Fatal exception [ 1623.768935] SMP: stopping secondary CPUs [ 1623.775718] Kernel Offset: disabled [ 1623.781998] CPU features: 0x002,21006008 [ 1623.788777] Memory Limit: none [ 1623.798329] Starting crashdump kernel... [ 1623.805202] Bye! If io_setup is called successful in try_smi_init() but try_smi_init() goes out_err before calling ipmi_register_smi(), so ipmi_unregister_smi() will not be called while removing module. It leads to the resource that allocated in io_setup() can not be freed, but the name(DEVICE_NAME) of resource is freed while removing the module. It causes use-after-free when cat /proc/ioports. Fix this by calling shutdown_smi() while removing the module and don't call release_region() if request_region() is not called to avoid error prints. Fixes: 93c303d2045b ("ipmi_si: Clean up shutdown a bit") Cc: stable(a)vger.kernel.org Reported-by: NuoHan Qiao <qiaonuohan(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- drivers/char/ipmi/ipmi_si_intf.c | 2 ++ drivers/char/ipmi/ipmi_si_port_io.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index dc8603d..635e98a 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -2235,6 +2235,8 @@ static void cleanup_one_si(struct smi_info *smi_info) if (smi_info->intf) ipmi_unregister_smi(smi_info->intf); + else + shutdown_smi(smi_info); if (smi_info->pdev) { if (smi_info->pdev_registered) diff --git a/drivers/char/ipmi/ipmi_si_port_io.c b/drivers/char/ipmi/ipmi_si_port_io.c index ef6dffc..0c46a3f 100644 --- a/drivers/char/ipmi/ipmi_si_port_io.c +++ b/drivers/char/ipmi/ipmi_si_port_io.c @@ -53,6 +53,9 @@ static void port_cleanup(struct si_sm_io *io) unsigned int addr = io->addr_data; int idx; + if (io->regsize != 1 && io->regsize != 2 && io->regsize != 4) + return; + if (addr) { for (idx = 0; idx < io->io_size; idx++) release_region(addr + idx * io->regspacing, -- 1.8.3

5 years, 11 months

2
2
0 0

[PATCH 4.19 000/106] 4.19.18-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.18 release. There are 106 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Jan 26 19:01:18 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.18-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.18-rc1 Corey Minyard <cminyard(a)mvista.com> ipmi: Don't initialize anything in the core until something uses it Corey Minyard <cminyard(a)mvista.com> ipmi:ssif: Fix handling of multi-part return messages Fred Klassen <fklassen(a)appneta.com> ipmi: Prevent use-after-free in deliver_response Gustavo A. R. Silva <gustavo(a)embeddedor.com> ipmi: msghandler: Fix potential Spectre v1 vulnerabilities Yang Yingliang <yangyingliang(a)huawei.com> ipmi: fix use-after-free of user->release_barrier.rda Johan Hedberg <johan.hedberg(a)intel.com> Bluetooth: Fix unnecessary error message for HCI request completion Avraham Stern <avraham.stern(a)intel.com> iwlwifi: mvm: Send LQ command as async when necessary Michal Hocko <mhocko(a)suse.com> mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Peter Xu <peterx(a)redhat.com> userfaultfd: clear flag if remap event not enabled Aaron Lu <aaron.lu(a)intel.com> mm/swap: use nr_node_ids for avail_lists in swap_info_struct Brian Foster <bfoster(a)redhat.com> mm/page-writeback.c: don't break integrity writeback on ->writepage() error Junxiao Bi <junxiao.bi(a)oracle.com> ocfs2: fix panic due to unrecovered local alloc Eric Sandeen <sandeen(a)redhat.com> iomap: don't search past page end in iomap_is_partially_uptodate Qian Cai <cai(a)lca.pw> scsi: megaraid: fix out-of-bound array accesses Yanjiang Jin <yanjiang.jin(a)hxt-semitech.com> scsi: smartpqi: call pqi_free_interrupts() in pqi_shutdown() Zhi Chen <zhichen(a)codeaurora.org> ath10k: fix peer stats null pointer dereference Kevin Barnett <kevin.barnett(a)microsemi.com> scsi: smartpqi: correct lun reset issues Stephan Günther <moepi(a)moepi.net> scsi: mpt3sas: fix memory ordering on 64bit writes Parvi Kaustubhi <pkaustub(a)cisco.com> IB/usnic: Fix potential deadlock Daniel Vetter <daniel.vetter(a)ffwll.ch> sysfs: Disable lockdep for driver bind/unbind files Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: bebob: fix model-id of unit for Apogee Ensemble Raghuram Hegde <raghuram.hegde(a)intel.com> Bluetooth: btusb: Add support for Intel bluetooth device 8087:0029 Milan Broz <gmazyland(a)gmail.com> dm: Check for device sector overflow if CONFIG_LBDAF is not set Yangtao Li <tiny.windzz(a)gmail.com> clocksource/drivers/integrator-ap: Add missing of_node_put() Javier Barrio <javier.barrio.mart(a)gmail.com> quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls. Arnaldo Carvalho de Melo <acme(a)redhat.com> perf tools: Add missing open_memstream() prototype for systems lacking it Arnaldo Carvalho de Melo <acme(a)redhat.com> perf tools: Add missing sigqueue() prototype for systems lacking it Leo Yan <leo.yan(a)linaro.org> perf cs-etm: Correct packets swapping in cs_etm__flush() Nikos Tsironis <ntsironis(a)arrikto.com> dm snapshot: Fix excessive memory usage and workqueue stalls Arnaldo Carvalho de Melo <acme(a)redhat.com> tools lib subcmd: Don't add the kernel sources to the include path Michael Petlan <mpetlan(a)redhat.com> perf stat: Avoid segfaults caused by negated options Nikos Tsironis <ntsironis(a)arrikto.com> dm kcopyd: Fix bug causing workqueue stalls AliOS system security <alios_sys_security(a)linux.alibaba.com> dm crypt: use u64 instead of sector_t to store iv_offset Hui Wang <john.wanghui(a)huawei.com> x86/topology: Use total_cpus for max logical packages calculation Taehee Yoo <ap420073(a)gmail.com> netfilter: ipt_CLUSTERIP: fix deadlock in netns exit routine Taehee Yoo <ap420073(a)gmail.com> netfilter: ipt_CLUSTERIP: remove wrong WARN_ON_ONCE in netns exit routine Taehee Yoo <ap420073(a)gmail.com> netfilter: ipt_CLUSTERIP: check MAC address when duplicate config is set Andi Kleen <ak(a)linux.intel.com> perf vendor events intel: Fix Load_Miss_Real_Latency on SKL/SKX Arnaldo Carvalho de Melo <acme(a)redhat.com> perf parse-events: Fix unchecked usage of strncpy() Arnaldo Carvalho de Melo <acme(a)redhat.com> perf svghelper: Fix unchecked usage of strncpy() Florian Fainelli <f.fainelli(a)gmail.com> perf tests ARM: Disable breakpoint tests 32-bit Adrian Hunter <adrian.hunter(a)intel.com> perf intel-pt: Fix error with config term "pt=0" Sergey Senozhatsky <sergey.senozhatsky.work(a)gmail.com> tty/serial: do not free trasnmit buffer page under port lock Johannes Thumshirn <jthumshirn(a)suse.de> btrfs: improve error handling of btrfs_add_link Anand Jain <anand.jain(a)oracle.com> btrfs: fix use-after-free due to race between replace start and cancel Hans van Kranenburg <hans.van.kranenburg(a)mendix.com> btrfs: alloc_chunk: fix more DUP stripe size handling Qu Wenruo <wqu(a)suse.com> btrfs: volumes: Make sure there is no overlap of dev extents at mount time Jonas Danielsson <jonas(a)orbital-systems.com> mmc: atmel-mci: do not assume idle after atmci_request_end Masahiro Yamada <yamada.masahiro(a)socionext.com> kconfig: fix memory leak when EOF is encountered in quotation Masahiro Yamada <yamada.masahiro(a)socionext.com> kconfig: fix file name and line number of warn_ignored_character() Jiong Wang <jiong.wang(a)netronome.com> bpf: relax verifier restriction on BPF_MOV | BPF_ALU Will Deacon <will.deacon(a)arm.com> arm64: Fix minor issues with the dcache_by_line_op macro Lucas Stach <l.stach(a)pengutronix.de> clk: imx6q: reset exclusive gates on init Qian Cai <cai(a)lca.pw> arm64: kasan: Increase stack size for KASAN_EXTRA Dmitry V. Levin <ldv(a)altlinux.org> selftests: do not macro-expand failed assertion expressions Bart Van Assche <bvanassche(a)acm.org> scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough David Disseldorp <ddiss(a)suse.de> scsi: target: use consistent left-aligned ASCII INQUIRY data yupeng <yupeng0921(a)gmail.com> net: call sk_dst_reset when set SO_DONTROUTE Gao Xiang <gaoxiang25(a)huawei.com> staging: erofs: fix use-after-free of on-stack `z_erofs_vle_unzip_io' Vivek Gautam <vivek.gautam(a)codeaurora.org> media: venus: core: Set dma maximum segment size Yu Zhao <yuzhao(a)google.com> ASoC: use dma_ops of parent device for acp_audio_dma Nathan Chancellor <natechancellor(a)gmail.com> media: firewire: Fix app_info parameter type in avc_ca{,_app}_info Breno Leitao <leitao(a)debian.org> powerpc/pseries/cpuidle: Fix preempt warning Breno Leitao <leitao(a)debian.org> powerpc/xmon: Fix invocation inside lock region Daniel Axtens <dja(a)axtens.net> media: uvcvideo: Refactor teardown of uvc on USB disconnect Joel Fernandes (Google) <joel(a)joelfernandes.org> pstore/ram: Do not treat empty buffers as valid A.s. Dong <aisheng.dong(a)nxp.com> clk: imx: make mux parent strings const Daniel Santos <daniel.santos(a)pobox.com> jffs2: Fix use of uninitialized delayed_work, lockdep breakage Nathan Chancellor <natechancellor(a)gmail.com> efi/libstub: Disable some warnings for x86{,_64} Chuck Lever <chuck.lever(a)oracle.com> rxe: IB_WR_REG_MR does not capture MR's iova field Chris Wilson <chris(a)chris-wilson.co.uk> drm/amdgpu: Reorder uvd ring init before uvd resume Manish Rangankar <manish.rangankar(a)cavium.com> scsi: qedi: Check for session online before getting iSCSI TLV data. Jiada Wang <jiada_wang(a)mentor.com> ASoC: pcm3168a: Don't disable pcm3168a when CONFIG_PM defined Ondrej Mosnacek <omosnace(a)redhat.com> selinux: always allow mounting submounts Anatolij Gustschin <agust(a)denx.de> fpga: altera-cvp: fix probing for multiple FPGAs on the bus Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> usb: gadget: udc: renesas_usb3: add a safety connection way for forced_b_device Daniel T. Lee <danieltimlee(a)gmail.com> samples: bpf: fix: error handling regarding kprobe_events Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> clk: meson: meson8b: fix incorrect divider mapping in cpu_scale_table Ville Syrjälä <ville.syrjala(a)linux.intel.com> drm/atomic-helper: Complete fake_commit->flip_done potentially earlier Anders Roxell <anders.roxell(a)linaro.org> arm64: perf: set suppress_bind_attrs flag to true Vitaly Chikunov <vt(a)altlinux.org> crypto: ecc - regularize scalar for scalar multiplication Maciej W. Rozycki <macro(a)linux-mips.org> MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur Borislav Petkov <bp(a)suse.de> x86/mce: Fix -Wmissing-prototypes warnings Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: oxfw: add support for APOGEE duet FireWire Andrey Ignatov <rdna(a)fb.com> bpf: Allow narrow loads with offset > 0 Anders Roxell <anders.roxell(a)linaro.org> serial: set suppress_bind_attrs flag only if builtin Anders Roxell <anders.roxell(a)linaro.org> writeback: don't decrement wb->refcnt if !wb->bdi Frank Rowand <frank.rowand(a)sony.com> of: overlay: add missing of_node_put() after add new node to changeset Quentin Monnet <quentin.monnet(a)netronome.com> selftests/bpf: enable (uncomment) all tests in test_libbpf.sh Badhri Jagan Sridharan <badhri(a)google.com> usb: typec: tcpm: Do not disconnect link for self powered devices Miroslav Lichvar <mlichvar(a)redhat.com> e1000e: allow non-monotonic SYSTIM readings João Paulo Rechi Vita <jprvita(a)gmail.com> platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey Shannon Nelson <shannon.nelson(a)oracle.com> ixgbe: allow IPsec Tx offload in VEPA mode Christian König <christian.koenig(a)amd.com> drm/amdkfd: fix interrupt spin lock Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> drm/amd/display: Guard against null stream_state in set_crc_source Manivannan Sadhasivam <manivannan.sadhasivam(a)linaro.org> gpio: pl061: Move irq_chip definition inside struct pl061 Stefano Brivio <sbrivio(a)redhat.com> netfilter: ipset: Allow matching on destination MAC address for mac and ipmac sets Paolo Abeni <pabeni(a)redhat.com> net: clear skb->tstamp in bridge forwarding path David Ahern <dsahern(a)gmail.com> ipv6: Take rcu_read_lock in __inet6_bind for mapped addresses Kai-Heng Feng <kai.heng.feng(a)canonical.com> r8169: Add support for new Realtek Ethernet Daniele Palmas <dnlplm(a)gmail.com> qmi_wwan: add MTU default to qmap network interface David Rientjes <rientjes(a)google.com> net, skbuff: do not prefer skb allocation fails early Andrew Lunn <andrew(a)lunn.ch> net: dsa: mv88x6xxx: mv88e6390 errata Ido Schimmel <idosch(a)mellanox.com> mlxsw: spectrum_switchdev: Set PVID correctly during VLAN deletion Jiri Pirko <jiri(a)mellanox.com> mlxsw: spectrum: Disable lag port TX before removing it David Ahern <dsahern(a)gmail.com> ipv6: Consider sk_bound_dev_if when binding a socket to a v4 mapped address ------------- Diffstat: Documentation/filesystems/proc.txt | 4 +- Makefile | 4 +- arch/arm64/include/asm/assembler.h | 30 ++-- arch/arm64/include/asm/memory.h | 7 +- arch/arm64/kernel/perf_event.c | 1 + arch/arm64/mm/cache.S | 3 + arch/mips/Kconfig | 3 + arch/mips/sibyte/common/Makefile | 1 + arch/mips/sibyte/common/dma.c | 14 ++ arch/powerpc/xmon/xmon.c | 18 ++- arch/x86/include/asm/traps.h | 6 +- arch/x86/kernel/cpu/mcheck/mce_amd.c | 5 +- arch/x86/kernel/cpu/mcheck/therm_throt.c | 3 +- arch/x86/kernel/cpu/mcheck/threshold.c | 3 +- arch/x86/kernel/smpboot.c | 2 +- crypto/ecc.c | 16 +- drivers/base/bus.c | 7 +- drivers/bluetooth/btusb.c | 72 +++++---- drivers/char/ipmi/ipmi_msghandler.c | 178 ++++++++++++--------- drivers/char/ipmi/ipmi_ssif.c | 25 ++- drivers/clk/imx/clk-busy.c | 2 +- drivers/clk/imx/clk-fixup-mux.c | 2 +- drivers/clk/imx/clk-imx6q.c | 6 +- drivers/clk/imx/clk.h | 18 ++- drivers/clk/meson/meson8b.c | 15 +- drivers/clocksource/timer-integrator-ap.c | 25 +-- drivers/cpuidle/cpuidle-pseries.c | 8 +- drivers/firmware/efi/libstub/Makefile | 5 +- drivers/fpga/altera-cvp.c | 34 ++-- drivers/gpio/gpio-pl061.c | 21 ++- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 8 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 8 +- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 5 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 5 + drivers/gpu/drm/drm_atomic_helper.c | 3 + drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 11 +- drivers/infiniband/sw/rxe/rxe_req.c | 1 + drivers/md/dm-crypt.c | 8 +- drivers/md/dm-delay.c | 2 +- drivers/md/dm-flakey.c | 2 +- drivers/md/dm-kcopyd.c | 19 ++- drivers/md/dm-linear.c | 2 +- drivers/md/dm-raid1.c | 3 +- drivers/md/dm-snap.c | 22 +++ drivers/md/dm-unstripe.c | 2 +- drivers/media/firewire/firedtv-avc.c | 6 +- drivers/media/firewire/firedtv.h | 6 +- drivers/media/platform/qcom/venus/core.c | 8 + drivers/media/usb/uvc/uvc_driver.c | 13 +- drivers/media/usb/uvc/uvc_status.c | 12 +- drivers/media/usb/uvc/uvcvideo.h | 1 + drivers/mmc/host/atmel-mci.c | 3 +- drivers/net/dsa/mv88e6xxx/chip.c | 113 +++++++++++++ drivers/net/dsa/mv88e6xxx/chip.h | 5 + drivers/net/dsa/mv88e6xxx/port.h | 10 ++ drivers/net/ethernet/intel/e1000e/ptp.c | 13 +- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 4 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 7 +- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- drivers/net/ethernet/realtek/r8169.c | 2 + drivers/net/usb/qmi_wwan.c | 1 + drivers/net/wireless/ath/ath10k/debugfs_sta.c | 2 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 4 +- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 6 +- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 18 +-- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/utils.c | 7 +- drivers/of/overlay.c | 4 +- drivers/platform/x86/asus-wmi.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +- drivers/scsi/qedi/qedi_main.c | 3 + drivers/scsi/smartpqi/smartpqi_init.c | 4 + drivers/staging/erofs/unzip_vle.c | 13 +- drivers/target/target_core_spc.c | 17 +- drivers/target/target_core_transport.c | 35 ++-- drivers/target/target_core_xcopy.c | 6 +- drivers/tty/serial/amba-pl011.c | 2 + drivers/tty/serial/pic32_uart.c | 1 + drivers/tty/serial/serial_core.c | 22 ++- drivers/tty/serial/xilinx_uartps.c | 1 + drivers/usb/gadget/udc/renesas_usb3.c | 15 +- drivers/usb/typec/tcpm.c | 12 +- fs/btrfs/dev-replace.c | 63 +++++--- fs/btrfs/inode.c | 7 +- fs/btrfs/volumes.c | 30 ++-- fs/iomap.c | 17 +- fs/jffs2/super.c | 3 +- fs/ocfs2/localalloc.c | 9 +- fs/pstore/ram_core.c | 5 + fs/quota/quota.c | 3 +- fs/userfaultfd.c | 10 +- include/linux/backing-dev-defs.h | 8 + include/linux/filter.h | 16 +- include/linux/swap.h | 11 +- include/linux/usb/tcpm.h | 1 + include/target/target_core_base.h | 1 + include/target/target_core_fabric.h | 2 +- kernel/bpf/verifier.c | 37 +++-- mm/page-writeback.c | 35 ++-- mm/swapfile.c | 3 +- net/bluetooth/hci_event.c | 6 + net/bridge/br_forward.c | 1 + net/core/skbuff.c | 7 +- net/core/sock.c | 1 + net/ipv4/netfilter/ipt_CLUSTERIP.c | 159 ++++++++++-------- net/ipv6/af_inet6.c | 14 +- net/netfilter/ipset/ip_set_bitmap_ipmac.c | 10 +- net/netfilter/ipset/ip_set_hash_ipmac.c | 16 +- net/netfilter/ipset/ip_set_hash_mac.c | 10 +- samples/bpf/bpf_load.c | 33 ++-- scripts/kconfig/zconf.l | 4 +- security/selinux/hooks.c | 2 +- sound/firewire/Kconfig | 1 + sound/firewire/bebob/bebob.c | 2 +- sound/firewire/oxfw/oxfw.c | 8 + sound/soc/amd/acp-pcm-dma.c | 7 +- sound/soc/codecs/pcm3168a.c | 18 ++- tools/lib/subcmd/Makefile | 2 - tools/perf/Makefile.config | 2 + tools/perf/arch/x86/util/intel-pt.c | 11 ++ tools/perf/builtin-stat.c | 8 +- tools/perf/builtin-timechart.c | 4 + .../pmu-events/arch/x86/skylake/skl-metrics.json | 2 +- .../pmu-events/arch/x86/skylakex/skx-metrics.json | 2 +- tools/perf/tests/bp_signal.c | 20 ++- tools/perf/util/cs-etm.c | 2 +- tools/perf/util/evlist.c | 4 + tools/perf/util/parse-events.c | 2 +- tools/perf/util/svghelper.c | 2 +- tools/testing/selftests/bpf/Makefile | 10 ++ tools/testing/selftests/bpf/test_libbpf.sh | 14 +- tools/testing/selftests/bpf/test_verifier.c | 13 ++ tools/testing/selftests/kselftest_harness.h | 42 ++--- 138 files changed, 1191 insertions(+), 556 deletions(-)

5 years, 11 months

4
109
0 0

[PATCH 3.18 00/52] 3.18.133-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 3.18.133 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Jan 26 19:01:07 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.18.133-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 3.18.133-rc1 Michal Hocko <mhocko(a)suse.com> mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Junxiao Bi <junxiao.bi(a)oracle.com> ocfs2: fix panic due to unrecovered local alloc Daniel Vetter <daniel.vetter(a)ffwll.ch> sysfs: Disable lockdep for driver bind/unbind files Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: bebob: fix model-id of unit for Apogee Ensemble Nikos Tsironis <ntsironis(a)arrikto.com> dm snapshot: Fix excessive memory usage and workqueue stalls Nikos Tsironis <ntsironis(a)arrikto.com> dm kcopyd: Fix bug causing workqueue stalls Arnaldo Carvalho de Melo <acme(a)redhat.com> perf parse-events: Fix unchecked usage of strncpy() Arnaldo Carvalho de Melo <acme(a)redhat.com> perf svghelper: Fix unchecked usage of strncpy() Jonas Danielsson <jonas(a)orbital-systems.com> mmc: atmel-mci: do not assume idle after atmci_request_end Masahiro Yamada <yamada.masahiro(a)socionext.com> kconfig: fix memory leak when EOF is encountered in quotation Lucas Stach <l.stach(a)pengutronix.de> clk: imx6q: reset exclusive gates on init David Disseldorp <ddiss(a)suse.de> scsi: target: use consistent left-aligned ASCII INQUIRY data yupeng <yupeng0921(a)gmail.com> net: call sk_dst_reset when set SO_DONTROUTE Nathan Chancellor <natechancellor(a)gmail.com> media: firewire: Fix app_info parameter type in avc_ca{,_app}_info Breno Leitao <leitao(a)debian.org> powerpc/pseries/cpuidle: Fix preempt warning Joel Fernandes (Google) <joel(a)joelfernandes.org> pstore/ram: Do not treat empty buffers as valid Daniel Santos <daniel.santos(a)pobox.com> jffs2: Fix use of uninitialized delayed_work, lockdep breakage Maciej W. Rozycki <macro(a)linux-mips.org> MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur Kai-Heng Feng <kai.heng.feng(a)canonical.com> r8169: Add support for new Realtek Ethernet Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> media: vb2: be sure to unlock mutex on errors Ivan Mironov <mironov.ivan(a)gmail.com> drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> block/loop: Use global lock for ioctl() operation. Xin Long <lucien.xin(a)gmail.com> sctp: allocate sctp_sockaddr_entry with kzalloc Stephen Smalley <sds(a)tycho.nsa.gov> selinux: fix GPF on invalid policy J. Bruce Fields <bfields(a)redhat.com> sunrpc: handle ENOMEM in rpcb_getport_async Hans Verkuil <hverkuil(a)xs4all.nl> media: vb2: vb2_mmap: move lock up Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: vivid: set min width/height to a value > 0 Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: vivid: fix error handling of kthread_run Vlad Tsyrklevich <vlad(a)tsyrklevich.net> omap2fb: Fix stack memory disclosure YunQiang Su <ysu(a)wavecomp.com> Disable MSI also when pcie-octeon.pcie_disable on Jonathan Hunter <jonathanh(a)nvidia.com> mfd: tps6586x: Handle interrupts on suspend Ivan Mironov <mironov.ivan(a)gmail.com> scsi: sd: Fix cache_type_store() Kees Cook <keescook(a)chromium.org> Yama: Check for pid death before checking ancestry Josef Bacik <josef(a)toxicpanda.com> btrfs: wait on ordered extents on abort cleanup Eric Biggers <ebiggers(a)google.com> crypto: authenc - fix parsing key with misaligned rta_len JianJhen Chen <kchen(a)synology.com> net: bridge: fix a bug on using a neighbour cache entry without checking its state Jason Gunthorpe <jgg(a)mellanox.com> packet: Do not leak dev refcounts on error exit Eric Dumazet <edumazet(a)google.com> ipv6: fix kernel-infoleak in ipv6_local_error() Ben Hutchings <ben(a)decadent.org.uk> media: em28xx: Fix misplaced reset of dev->v4l::field_count Oliver Hartkopp <socketcan(a)hartkopp.net> can: gw: ensure DLC boundaries after CAN frame modification Dmitry Safonov <dima(a)arista.com> tty/ldsem: Wake up readers after timed out down_write() Vasily Averin <vvs(a)virtuozzo.com> sunrpc: use-after-free in svc_process_common() Eric Biggers <ebiggers(a)google.com> crypto: cts - fix crash on short inputs Yi Zeng <yizeng(a)asrmicro.com> i2c: dev: prevent adapter retries and timeout being set as minus value Hans de Goede <hdegoede(a)redhat.com> ACPI: power: Skip duplicate power resource references in _PRx Christoph Lameter <cl(a)linux.com> slab: alien caches must not be initialized if the allocation of the alien cache failed Icenowy Zheng <icenowy(a)aosc.io> USB: storage: add quirk for SMI SM3350 Icenowy Zheng <icenowy(a)aosc.io> USB: storage: don't insert sane sense for SPC3+ when bad sense specified Daniele Palmas <dnlplm(a)gmail.com> usb: cdc-acm: send ZLP for Telit 3G Intel based modems Ross Lagerwall <ross.lagerwall(a)citrix.com> cifs: Fix potential OOB access of lock element array Pavel Shilovsky <pshilov(a)microsoft.com> CIFS: Do not hide EINTR after sending network packets Andreas Larsson <andreas(a)gaisler.com> sparc32: Fix inverted invalid_frame_pointer checks on sigreturns ------------- Diffstat: Documentation/filesystems/proc.txt | 4 +- Makefile | 4 +- arch/arm/mach-imx/clk-imx6q.c | 6 ++- arch/mips/Kconfig | 3 ++ arch/mips/pci/msi-octeon.c | 4 +- arch/mips/sibyte/common/Makefile | 1 + arch/mips/sibyte/common/dma.c | 14 +++++++ arch/sparc/kernel/signal_32.c | 4 +- crypto/authenc.c | 14 +++++-- crypto/cts.c | 8 ++-- drivers/acpi/power.c | 22 +++++++++++ drivers/base/bus.c | 7 +++- drivers/block/loop.c | 47 ++++++++++++------------ drivers/block/loop.h | 1 - drivers/cpuidle/cpuidle-pseries.c | 8 +++- drivers/gpu/drm/drm_fb_helper.c | 7 +++- drivers/i2c/i2c-dev.c | 6 +++ drivers/md/dm-kcopyd.c | 19 +++++++--- drivers/md/dm-snap.c | 22 +++++++++++ drivers/media/firewire/firedtv-avc.c | 6 ++- drivers/media/firewire/firedtv.h | 6 ++- drivers/media/platform/vivid/vivid-kthread-cap.c | 5 ++- drivers/media/platform/vivid/vivid-kthread-out.c | 5 ++- drivers/media/platform/vivid/vivid-vid-common.c | 2 +- drivers/media/usb/em28xx/em28xx-video.c | 4 +- drivers/media/v4l2-core/videobuf2-core.c | 14 +++++-- drivers/mfd/tps6586x.c | 24 ++++++++++++ drivers/mmc/host/atmel-mci.c | 3 +- drivers/net/ethernet/realtek/r8169.c | 2 + drivers/scsi/sd.c | 6 +++ drivers/target/target_core_spc.c | 17 ++++++--- drivers/tty/tty_ldsem.c | 10 +++++ drivers/usb/class/cdc-acm.c | 7 ++++ drivers/usb/storage/scsiglue.c | 8 +++- drivers/usb/storage/unusual_devs.h | 12 ++++++ drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 2 + fs/btrfs/disk-io.c | 8 ++++ fs/cifs/file.c | 8 ++-- fs/cifs/smb2file.c | 4 +- fs/cifs/transport.c | 2 +- fs/jffs2/super.c | 3 +- fs/ocfs2/localalloc.c | 9 ++++- fs/pstore/ram_core.c | 5 +++ include/linux/sunrpc/svc.h | 5 ++- mm/slab.c | 6 ++- net/bridge/br_netfilter.c | 2 +- net/can/gw.c | 30 +++++++++++++-- net/core/sock.c | 1 + net/ipv6/datagram.c | 1 + net/packet/af_packet.c | 4 +- net/sctp/ipv6.c | 5 +-- net/sctp/protocol.c | 4 +- net/sunrpc/rpcb_clnt.c | 8 ++++ net/sunrpc/svc.c | 10 +++-- net/sunrpc/svc_xprt.c | 5 ++- net/sunrpc/svcsock.c | 2 +- scripts/kconfig/zconf.l | 2 + security/selinux/ss/policydb.c | 3 +- security/yama/yama_lsm.c | 4 +- sound/firewire/bebob/bebob.c | 2 +- tools/perf/util/parse-events.c | 2 +- tools/perf/util/svghelper.c | 2 +- 62 files changed, 366 insertions(+), 105 deletions(-)

5 years, 11 months

3
54
0 0

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

by Pierre-Louis Bossart

>>> The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel log when audio is played on the system: >>> writing to lpe: 00000000: 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00 ............U... >>> writing to lpe: 00000000: 01 01 01 01 00 00 1a 00 ff ff ff ff 75 00 12 00 ............u... >>> ... >> That's enabled via dynamic debug so that's rather a configuration issue >> than a kernel problem? > Do you have any suggestions on how to disable it? > > My kernel is compiled without DYNAMIC_DEBUG, DEBUG_FS and other debug features, so I don't understand why all this debug output is flooding the kernel log. > > It's a minor issue, but it would be nice to get rid of it. I can confirm that this happens without DYNAMIC_DEBUG, and somehow changing the log level doesn't seem to matter. I tried changing the console log as a kernel parameter or with playing /proc/sys/kernel/printk, no luck. weird.

5 years, 11 months

2
1
0 0

[PATCH 14/16] target/iscsi: Avoid that iscsit_release_commands_from_conn() triggers a deadlock

by Bart Van Assche

When using SCSI passthrough in combination with the iSCSI target driver then cmd->t_state_lock may be obtained from interrupt context. Hence, all code that obtains cmd->t_state_lock from thread context must disable interrupts first. This patch avoids that lockdep reports the following: WARNING: inconsistent lock state 4.18.0-dbg+ #1 Not tainted -------------------------------- inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. iscsi_ttx/1800 [HC1[1]:SC0[2]:HE0:SE0] takes: 000000006e7b0ceb (&(&cmd->t_state_lock)->rlock){?...}, at: target_complete_cmd+0x47/0x2c0 [target_core_mod] {HARDIRQ-ON-W} state was registered at: lock_acquire+0xd2/0x260 _raw_spin_lock+0x32/0x50 iscsit_close_connection+0x97e/0x1020 [iscsi_target_mod] iscsit_take_action_for_connection_exit+0x108/0x200 [iscsi_target_mod] iscsi_target_rx_thread+0x180/0x190 [iscsi_target_mod] kthread+0x1cf/0x1f0 ret_from_fork+0x24/0x30 irq event stamp: 1281 hardirqs last enabled at (1279): [<ffffffff970ade79>] __local_bh_enable_ip+0xa9/0x160 hardirqs last disabled at (1281): [<ffffffff97a008a5>] interrupt_entry+0xb5/0xd0 softirqs last enabled at (1278): [<ffffffff977cd9a1>] lock_sock_nested+0x51/0xc0 softirqs last disabled at (1280): [<ffffffffc07a6e04>] ip6_finish_output2+0x124/0xe40 [ipv6] other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&(&cmd->t_state_lock)->rlock); <Interrupt> lock(&(&cmd->t_state_lock)->rlock); *** DEADLOCK *** 3 locks held by iscsi_ttx/1800: *0: 00000000c3b711b7 (sk_lock-AF_INET6){+.+.}, at: tcp_sendmsg+0x1e/0x50 *1: 00000000fa81046f (rcu_read_lock){....}, at: inet6_csk_xmit+0xc7/0x2e0 [ipv6] *2: 00000000c091d70d (rcu_read_lock_bh){....}, at: ip6_finish_output2+0x124/0xe40 [ipv6] stack backtrace: CPU: 0 PID: 1800 Comm: iscsi_ttx Not tainted 4.18.0-dbg+ #1 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 Call Trace: <IRQ> dump_stack+0xa4/0xf5 print_usage_bug+0x25b/0x27b mark_lock+0x70f/0x7b0 __lock_acquire+0xbc2/0x1b50 lock_acquire+0xd2/0x260 _raw_spin_lock_irqsave+0x4a/0x60 target_complete_cmd+0x47/0x2c0 [target_core_mod] target_complete_cmd_with_length+0x70/0xa0 [target_core_mod] pscsi_req_done+0x335/0x530 [target_core_pscsi] __blk_mq_end_request+0xa5/0x140 scsi_end_request+0x112/0x320 [scsi_mod] scsi_io_completion+0x183/0xa30 [scsi_mod] scsi_finish_command+0x1c0/0x280 [scsi_mod] scsi_softirq_done+0x19a/0x230 [scsi_mod] __blk_mq_complete_request_remote+0x2f/0x40 flush_smp_call_function_queue+0x12a/0x220 generic_smp_call_function_single_interrupt+0x13/0x30 smp_call_function_single_interrupt+0x7a/0x350 call_function_single_interrupt+0xf/0x20 </IRQ> RIP: 0010:__asan_load4+0x1e/0x80 debug_lockdep_rcu_enabled+0x26/0x40 ip6_finish_output2+0x15a/0xe40 [ipv6] ip6_finish_output+0x308/0x440 [ipv6] ip6_output+0x11d/0x3b0 [ipv6] ip6_xmit+0x639/0xc50 [ipv6] inet6_csk_xmit+0x198/0x2e0 [ipv6] __tcp_transmit_skb+0xc1b/0x15b0 tcp_write_xmit+0x42e/0x1f20 __tcp_push_pending_frames+0x59/0x150 tcp_push+0x189/0x270 tcp_sendmsg_locked+0x7b9/0x1680 tcp_sendmsg+0x2c/0x50 inet_sendmsg+0x71/0x250 sock_sendmsg+0x4c/0x60 tx_data+0x12b/0x1f0 [iscsi_target_mod] iscsit_send_tx_data+0x77/0xe0 [iscsi_target_mod] iscsit_xmit_pdu+0x2c5/0x740 [iscsi_target_mod] iscsit_response_queue+0x941/0xd40 [iscsi_target_mod] iscsi_target_tx_thread+0x23b/0x350 [iscsi_target_mod] kthread+0x1cf/0x1f0 ret_from_fork+0x24/0x30 Fixes: 064cdd2d91c2 ("target: Fix race between iscsi-target connection shutdown + ABORT_TASK") Cc: Nicholas Bellinger <nab(a)linux-iscsi.org> Cc: Mike Christie <mchristi(a)redhat.com> Cc: Christoph Hellwig <hch(a)lst.de> Cc: Hannes Reinecke <hare(a)suse.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Bart Van Assche <bvanassche(a)acm.org> --- drivers/target/iscsi/iscsi_target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 7059ffdb0c20..408d77eb717c 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4038,9 +4038,9 @@ static void iscsit_release_commands_from_conn(struct iscsi_conn *conn) struct se_cmd *se_cmd = &cmd->se_cmd; if (se_cmd->se_tfo != NULL) { - spin_lock(&se_cmd->t_state_lock); + spin_lock_irq(&se_cmd->t_state_lock); se_cmd->transport_state |= CMD_T_FABRIC_STOP; - spin_unlock(&se_cmd->t_state_lock); + spin_unlock_irq(&se_cmd->t_state_lock); } } spin_unlock_bh(&conn->cmd_lock); -- 2.20.1.495.gaa96b0ce6b-goog

5 years, 11 months

1
0
0 0

Stable queue: queue-4.20

by CKI

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 3d4332cd8258 Linux 4.20.4 The results of these automated tests are provided below. Overall result: PASSED Patch merge: OK Compile: OK Kernel tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out a ref: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Ref: 3d4332cd8258 Linux 4.20.4 We then merged the following patches with `git am`: ipv6-consider-sk_bound_dev_if-when-binding-a-socket-to-a-v4-mapped-address.patch mlxsw-spectrum-disable-lag-port-tx-before-removing-it.patch mlxsw-spectrum_switchdev-set-pvid-correctly-during-vlan-deletion.patch net-dsa-mv88x6xxx-mv88e6390-errata.patch net-skbuff-do-not-prefer-skb-allocation-fails-early.patch qmi_wwan-add-mtu-default-to-qmap-network-interface.patch r8169-add-support-for-new-realtek-ethernet.patch ipv6-take-rcu_read_lock-in-__inet6_bind-for-mapped-addresses.patch ipv6-fix-dump-of-specific-table-with-strict-checking.patch netlink-fixup-regression-in-rtm_getaddr.patch octeontx2-af-fix-a-resource-leak-in-an-error-handling-path-in-cgx_probe.patch openvswitch-fix-ipv6-later-frags-parsing.patch net-clear-skb-tstamp-in-bridge-forwarding-path.patch netfilter-ipset-allow-matching-on-destination-mac-ad.patch gpio-pl061-move-irq_chip-definition-inside-struct-pl.patch asoc-wm97xx-fix-uninitialized-regmap-pointer-problem.patch drm-amd-display-guard-against-null-stream_state-in-s.patch drm-amdkfd-fix-interrupt-spin-lock.patch qtnfmac-fix-error-handling-in-control-path.patch ixgbe-allow-ipsec-tx-offload-in-vepa-mode.patch platform-x86-asus-wmi-tell-the-ec-the-os-will-handle.patch e1000e-allow-non-monotonic-systim-readings.patch usb-typec-tcpm-do-not-disconnect-link-for-self-power.patch selftests-bpf-enable-uncomment-all-tests-in-test_lib.patch of-overlay-add-missing-of_node_put-after-add-new-nod.patch writeback-don-t-decrement-wb-refcnt-if-wb-bdi.patch serial-set-suppress_bind_attrs-flag-only-if-builtin.patch bpf-allow-narrow-loads-with-offset-0.patch alsa-oxfw-add-support-for-apogee-duet-firewire.patch x86-mce-fix-wmissing-prototypes-warnings.patch mips-sibyte-enable-swiotlb-for-swarm-littlesur-and-b.patch crypto-ecc-regularize-scalar-for-scalar-multiplicati.patch drm-scheduler-fix-bad-job-be-re-processed-in-tdr.patch arm64-perf-set-suppress_bind_attrs-flag-to-true.patch mips-loongson-add-loongson-3a-r2.1-basic-support.patch drm-atomic-helper-complete-fake_commit-flip_done-pot.patch clk-meson-meson8b-add-support-for-more-m-n-values-in.patch clk-meson-meson8b-fix-incorrect-divider-mapping-in-c.patch samples-bpf-fix-error-handling-regarding-kprobe_even.patch usb-gadget-udc-renesas_usb3-add-a-safety-connection-.patch fpga-altera-cvp-fix-probing-for-multiple-fpgas-on-th.patch selinux-always-allow-mounting-submounts.patch arm64-use-a-raw-spinlock-in-__install_bp_hardening_c.patch asoc-pcm3168a-don-t-disable-pcm3168a-when-config_pm-.patch scsi-qedi-check-for-session-online-before-getting-is.patch net-ethernet-ave-set-initial-wol-state-to-disabled.patch drm-amdgpu-reorder-uvd-ring-init-before-uvd-resume.patch rxe-ib_wr_reg_mr-does-not-capture-mr-s-iova-field.patch efi-libstub-disable-some-warnings-for-x86-_64.patch jffs2-fix-use-of-uninitialized-delayed_work-lockdep-.patch kbuild-let-fixdep-directly-write-to-.-.cmd-files.patch clk-imx-make-mux-parent-strings-const.patch pstore-ram-do-not-treat-empty-buffers-as-valid.patch media-uvcvideo-refactor-teardown-of-uvc-on-usb-disco.patch powerpc-xmon-fix-invocation-inside-lock-region.patch powerpc-pseries-cpuidle-fix-preempt-warning.patch arm64-relocatable-fix-inconsistencies-in-linker-scri.patch media-firewire-fix-app_info-parameter-type-in-avc_ca.patch asoc-use-dma_ops-of-parent-device-for-acp_audio_dma.patch coresight-tmc-fix-bad-register-address-for-claim.patch media-venus-core-set-dma-maximum-segment-size.patch staging-erofs-fix-use-after-free-of-on-stack-z_erofs.patch net-call-sk_dst_reset-when-set-so_dontroute.patch scsi-target-use-consistent-left-aligned-ascii-inquir.patch scsi-target-core-make-sure-that-target_wait_for_sess.patch selftests-do-not-macro-expand-failed-assertion-expre.patch arm64-kasan-increase-stack-size-for-kasan_extra.patch clk-imx6q-reset-exclusive-gates-on-init.patch arm64-fix-minor-issues-with-the-dcache_by_line_op-ma.patch bpf-relax-verifier-restriction-on-bpf_mov-bpf_alu.patch usb-dwc2-fix-disable-all-ep-s-on-disconnect.patch x86-resctrl-fix-rdt_find_domain-return-value-and-che.patch kconfig-fix-file-name-and-line-number-of-warn_ignore.patch kconfig-fix-memory-leak-when-eof-is-encountered-in-q.patch mmc-atmel-mci-do-not-assume-idle-after-atmci_request.patch btrfs-volumes-make-sure-there-is-no-overlap-of-dev-e.patch btrfs-alloc_chunk-fix-more-dup-stripe-size-handling.patch btrfs-fix-use-after-free-due-to-race-between-replace.patch btrfs-improve-error-handling-of-btrfs_add_link.patch tty-serial-do-not-free-trasnmit-buffer-page-under-po.patch tools-lib-traceevent-fix-compile-warnings-in-tools-l.patch perf-intel-pt-fix-error-with-config-term-pt-0.patch perf-tests-arm-disable-breakpoint-tests-32-bit.patch perf-svghelper-fix-unchecked-usage-of-strncpy.patch perf-parse-events-fix-unchecked-usage-of-strncpy.patch perf-vendor-events-intel-fix-load_miss_real_latency-.patch netfilter-ipt_clusterip-check-mac-address-when-dupli.patch netfilter-ipt_clusterip-remove-wrong-warn_on_once-in.patch netfilter-ipt_clusterip-fix-deadlock-in-netns-exit-r.patch x86-topology-use-total_cpus-for-max-logical-packages.patch dm-crypt-use-u64-instead-of-sector_t-to-store-iv_off.patch dm-kcopyd-fix-bug-causing-workqueue-stalls.patch perf-stat-avoid-segfaults-caused-by-negated-options.patch tools-lib-subcmd-don-t-add-the-kernel-sources-to-the.patch dm-snapshot-fix-excessive-memory-usage-and-workqueue.patch perf-cs-etm-correct-packets-swapping-in-cs_etm__flus.patch perf-tools-add-missing-sigqueue-prototype-for-system.patch perf-tools-add-missing-open_memstream-prototype-for-.patch quota-lock-s_umount-in-exclusive-mode-for-q_xquota-o.patch clocksource-drivers-integrator-ap-add-missing-of_nod.patch dm-check-for-device-sector-overflow-if-config_lbdaf-.patch bluetooth-btusb-add-support-for-intel-bluetooth-devi.patch alsa-bebob-fix-model-id-of-unit-for-apogee-ensemble.patch sysfs-disable-lockdep-for-driver-bind-unbind-files.patch ib-usnic-fix-potential-deadlock.patch scsi-mpt3sas-fix-memory-ordering-on-64bit-writes.patch scsi-smartpqi-correct-lun-reset-issues.patch ath10k-fix-peer-stats-null-pointer-dereference.patch scsi-smartpqi-call-pqi_free_interrupts-in-pqi_shutdo.patch kvm-ppc-book3s-hv-align-gfn-to-l1-page-size-when-ins.patch kvm-ppc-book3s-hv-apply-combination-of-host-and-l1-p.patch scsi-megaraid-fix-out-of-bound-array-accesses.patch iomap-don-t-search-past-page-end-in-iomap_is_partial.patch ocfs2-fix-panic-due-to-unrecovered-local-alloc.patch mm-page-writeback.c-don-t-break-integrity-writeback-.patch mm-swap-use-nr_node_ids-for-avail_lists-in-swap_info.patch userfaultfd-clear-flag-if-remap-event-not-enabled.patch mm-proc-be-more-verbose-about-unstable-vma-flags-in-.patch mm-memblock.c-skip-kmemleak-for-kasan_init.patch drm-amd-display-fix-disabled-cursor-on-top-screen-edge.patch bluetooth-fix-unnecessary-error-message-for-hci-request-completion.patch ipmi-fix-use-after-free-of-user-release_barrier.rda.patch ipmi-don-t-initialize-anything-in-the-core-until-something-uses-it.patch ipmi-msghandler-fix-potential-spectre-v1-vulnerabilities.patch ipmi-prevent-use-after-free-in-deliver_response.patch ipmi-ssif-fix-handling-of-multi-part-return-messages.patch Compile testing --------------- We compiled the kernel for 4 architectures: s390x: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/s390x/b0930fcadcbf20a82939a67fdb81… powerpc64le: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/ppc64le/fda403caa92b09e962585d95cc… aarch64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/aarch64/2009c1eafcc39ba48451065c61… x86_64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/x86_64/3b0102664f9096b474df9f3ec12… Hardware testing ---------------- We booted each kernel and ran the following tests: s390: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu powerpc: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… arm64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… x86_64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us…

5 years, 11 months

1
0
0 0

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

by Pierre-Louis Bossart

On 1/24/19 11:16 PM, Mogens Jensen wrote: > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Tuesday, January 22, 2019 7:27 PM, Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> wrote: > >> On 1/20/19 11:55 PM, Mogens Jensen wrote: >> >>> The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel log when audio is played on the system: >>> writing to lpe: 00000000: 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00 ............U... >>> writing to lpe: 00000000: 01 01 01 01 00 00 1a 00 ff ff ff ff 75 00 12 00 ............u... >>> ... >> That's enabled via dynamic debug so that's rather a configuration issue >> than a kernel problem? > Do you have any suggestions on how to disable it? > > My kernel is compiled without DYNAMIC_DEBUG, DEBUG_FS and other debug features, so I don't understand why all this debug output is flooding the kernel log. > > It's a minor issue, but it would be nice to get rid of it. I don't see it so it's definitively a config issue. I use make defconfig scripts/kconfig/merge_config.sh .config base-defconfig sst-defconfig hdaudio-codecs-defconfig with all 3 defconfigs fetched from https://github.com/thesofproject/kconfig

5 years, 11 months

1
0
0 0

PASS: Test report for kernel 4.20.5-rc1.cki+ (linux-stable-rc)

by CKI

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: c3515872cb7f Linux 4.20.5-rc1 The results of these automated tests are provided below. Overall result: PASSED Patch merge: OK Compile: OK Kernel tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: s390x: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/s390x/c3515872cb7fee25e684c686581b… powerpc64le: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/ppc64le/c3515872cb7fee25e684c68658… aarch64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/aarch64/c3515872cb7fee25e684c68658… x86_64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/x86_64/c3515872cb7fee25e684c686581… Hardware testing ---------------- We booted each kernel and ran the following tests: s390: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… powerpc: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… arm64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… x86_64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us…

5 years, 11 months

1
0
0 0

[PATCH v5 1/5] clk: samsung: exynos5433: fix typo in imem divider

by Kamil Konieczny

Fix typo in imem clock divider 200 switched with 266. Reviewed-by: Chanwoo Choi <cw00.choi(a)samsung.com> Signed-off-by: Kamil Konieczny <k.konieczny(a)partner.samsung.com> --- drivers/clk/samsung/clk-exynos5433.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 751e2c4fb65b..ea47f49abc7f 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -568,10 +568,10 @@ static const struct samsung_gate_clock top_gate_clks[] __initconst = { GATE(CLK_ACLK_BUS1_400, "aclk_bus1_400", "div_aclk_bus1_400", ENABLE_ACLK_TOP, 25, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), - GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_266", + GATE(CLK_ACLK_IMEM_200, "aclk_imem_200", "div_aclk_imem_200", ENABLE_ACLK_TOP, 24, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), - GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_200", + GATE(CLK_ACLK_IMEM_266, "aclk_imem_266", "div_aclk_imem_266", ENABLE_ACLK_TOP, 23, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), GATE(CLK_ACLK_PERIC_66, "aclk_peric_66", "div_aclk_peric_66_b", -- 2.20.0

5 years, 11 months

2
2
0 0

patch "debugfs: fix debugfs_rename parameter checking" added to driver-core-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled debugfs: fix debugfs_rename parameter checking to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From d88c93f090f708c18195553b352b9f205e65418f Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Date: Wed, 23 Jan 2019 11:27:02 +0100 Subject: debugfs: fix debugfs_rename parameter checking debugfs_rename() needs to check that the dentries passed into it really are valid, as sometimes they are not (i.e. if the return value of another debugfs call is passed into this one.) So fix this up by properly checking if the two parent directories are errors (they are allowed to be NULL), and if the dentry to rename is not NULL or an error. Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- fs/debugfs/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 13b01351dd1c..41ef452c1fcf 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -787,6 +787,13 @@ struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, struct dentry *dentry = NULL, *trap; struct name_snapshot old_name; + if (IS_ERR(old_dir)) + return old_dir; + if (IS_ERR(new_dir)) + return new_dir; + if (IS_ERR_OR_NULL(old_dentry)) + return old_dentry; + trap = lock_rename(new_dir, old_dir); /* Source or destination directories don't exist? */ if (d_really_is_negative(old_dir) || d_really_is_negative(new_dir)) -- 2.20.1

5 years, 11 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2019