January 2019 - Linux-stable-mirror

[PATCH] staging: speakup: fix tty-operation NULL derefs

by Johan Hovold

The send_xchar() and tiocmset() tty operations are optional. Add the missing sanity checks to prevent user-space triggerable NULL-pointer dereferences. Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty") Cc: stable <stable(a)vger.kernel.org> # 4.13 Cc: Okash Khawaja <okash.khawaja(a)gmail.com> Cc: Samuel Thibault <samuel.thibault(a)ens-lyon.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/staging/speakup/spk_ttyio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c index c92bbd05516e..005de0024dd4 100644 --- a/drivers/staging/speakup/spk_ttyio.c +++ b/drivers/staging/speakup/spk_ttyio.c @@ -265,7 +265,8 @@ static void spk_ttyio_send_xchar(char ch) return; } - speakup_tty->ops->send_xchar(speakup_tty, ch); + if (speakup_tty->ops->send_xchar) + speakup_tty->ops->send_xchar(speakup_tty, ch); mutex_unlock(&speakup_tty_mutex); } @@ -277,7 +278,8 @@ static void spk_ttyio_tiocmset(unsigned int set, unsigned int clear) return; } - speakup_tty->ops->tiocmset(speakup_tty, set, clear); + if (speakup_tty->ops->tiocmset) + speakup_tty->ops->tiocmset(speakup_tty, set, clear); mutex_unlock(&speakup_tty_mutex); } -- 2.20.1

5 years, 8 months

2
1
0 0

Stable queue: queue-4.20

by CKI

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9f1a389a0b5b Linux 4.20.5 The results of these automated tests are provided below. Overall result: FAILED (see details below) Patch merge: OK Compile: OK Kernel tests: FAILED One or more kernel tests failed: aarch64: PASSED s390x: PASSED powerpc64le: PASSED x86_64: PASSED We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out a ref: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Ref: 9f1a389a0b5b Linux 4.20.5 We then merged the following patches with `git am`: amd-xgbe-fix-mdio-access-for-non-zero-ports-and-clause-45-phys.patch net-bridge-fix-ethernet-header-pointer-before-check-skb-forwardable.patch net-fix-usage-of-pskb_trim_rcsum.patch net-phy-marvell-errata-for-mv88e6390-internal-phys.patch net-phy-mdio_bus-add-missing-device_del-in-mdiobus_register-error-handling.patch net-phy-phy-driver-features-are-mandatory.patch net-sched-act_tunnel_key-fix-memory-leak-in-case-of-action-replace.patch net_sched-refetch-skb-protocol-for-each-filter.patch openvswitch-avoid-oob-read-when-parsing-flow-nlattrs.patch vhost-log-dirty-page-correctly.patch mlxsw-pci-increase-pci-sw-reset-timeout.patch net-ipv4-fix-memory-leak-in-network-namespace-dismantle.patch mlxsw-spectrum_fid-update-dummy-fid-index.patch mlxsw-pci-ring-cq-s-doorbell-before-rdq-s.patch net-sched-cls_flower-allocate-mask-dynamically-in-fl_change.patch udp-with-udp_segment-release-on-error-path.patch ip6_gre-fix-tunnel-list-corruption-for-x-netns.patch erspan-build-the-header-with-the-right-proto-according-to-erspan_ver.patch net-phy-marvell-fix-deadlock-from-wrong-locking.patch ip6_gre-update-version-related-info-when-changing-link.patch tcp-allow-msg_zerocopy-transmission-also-in-close_wait-state.patch arm-fix-the-cockup-in-the-previous-patch.patch sunrpc-address-kerberos-performance-behavior-regress.patch mei-me-mark-lbg-devices-as-having-dma-support.patch mei-me-add-denverton-innovation-engine-device-ids.patch usb-leds-fix-regression-in-usbport-led-trigger.patch usb-ehci-ehci-mv-add-module_device_table.patch usb-serial-ftdi_sio-fix-gpio-not-working-in-autosuspend.patch usb-serial-simple-add-motorola-tetra-tpg2200-device-id.patch usb-serial-pl2303-add-new-pid-to-support-pl2303tb.patch ceph-clear-inode-pointer-when-snap-realm-gets-dropped-by-its-inode.patch asoc-atom-fix-a-missing-check-of-snd_pcm_lib_malloc_pages.patch asoc-rt5514-spi-fix-potential-null-pointer-dereference.patch asoc-tlv320aic32x4-kernel-oops-while-entering-dapm-standby-mode.patch clk-zynqmp-fix-memory-allocation-in-zynqmp_clk_setup.patch clk-socfpga-stratix10-fix-rate-calculation-for-pll-clocks.patch clk-socfpga-stratix10-fix-naming-convention-for-the-fixed-clocks.patch inotify-fix-fd-refcount-leak-in-inotify_add_watch.patch alsa-hda-realtek-fix-typo-for-alc225-model.patch alsa-hda-add-mute-led-support-for-hp-probook-470-g5.patch arcv2-lib-memeset-fix-doing-prefetchw-outside-of-buffer.patch arc-adjust-memblock_reserve-of-kernel-memory.patch arc-perf-map-generic-branches-to-correct-hardware-condition.patch s390-vdso-correct-vdso-mapping-for-compat-tasks.patch s390-mm-always-force-a-load-of-the-primary-asce-on-context-switch.patch s390-early-improve-machine-detection.patch s390-smp-fix-cpu-hotplug-deadlock-with-cpu-rescan.patch s390-smp-fix-calling-smp_call_ipl_cpu-from-ipl-cpu.patch misc-ibmvsm-fix-potential-null-pointer-dereference.patch char-mwave-fix-potential-spectre-v1-vulnerability.patch mmc-sdhci-iproc-handle-mmc_of_parse-errors-during-probe.patch mmc-dw_mmc-bluefield-fix-the-license-information.patch mmc-meson-gx-free-irq-in-release-callback.patch staging-rtl8188eu-add-device-code-for-d-link-dwa-121-rev-b1.patch tty-handle-problem-if-line-discipline-does-not-have-receive_buf.patch uart-fix-crash-in-uart_write-and-uart_put_char.patch tty-n_hdlc-fix-__might_sleep-warning.patch hv_balloon-avoid-touching-uninitialized-struct-page-during-tail-onlining.patch drivers-hv-vmbus-check-for-ring-when-getting-debug-info.patch vgacon-unconfuse-vc_origin-when-using-soft-scrollback.patch cifs-fix-possible-hang-during-async-mtu-reads-and-writes.patch cifs-fix-credits-calculations-for-reads-with-errors.patch cifs-fix-credit-calculation-for-encrypted-reads-with-errors.patch cifs-do-not-reconnect-tcp-session-in-add_credits.patch smb3-add-credits-we-receive-from-oplock-break-pdus.patch input-xpad-add-support-for-steelseries-stratus-duo.patch input-input_event-provide-override-for-sparc64.patch input-uinput-fix-undefined-behavior-in-uinput_validate_absinfo.patch acpi-nfit-block-function-zero-dsms.patch acpi-nfit-fix-command-supported-detection.patch scsi-ufs-use-explicit-access-size-in-ufshcd_dump_regs.patch dm-thin-fix-passdown_double_checking_shared_status.patch dm-crypt-fix-parsing-of-extended-iv-arguments.patch drm-amdgpu-add-aptx-quirk-for-lenovo-laptop.patch edac-altera-fix-s10-persistent-register-offset.patch kvm-x86-fix-single-step-debugging.patch kvm-x86-fix-pv-ipis-for-32-bit-kvm-host.patch kvm-x86-warn_once-if-sending-a-pv-ipi-returns-a-fatal-error.patch kvm-x86-vmx-use-kzalloc-for-cached_vmcs12.patch x86-pkeys-properly-copy-pkey-state-at-fork.patch x86-selftests-pkeys-fork-to-check-for-state-being-preserved.patch x86-kaslr-fix-incorrect-i8254-outb-parameters.patch x86-entry-64-compat-fix-stack-switching-for-xen-pv.patch posix-cpu-timers-unbreak-timer-rearming.patch net-sun-cassini-cleanup-license-conflict.patch irqchip-gic-v3-its-align-pci-multi-msi-allocation-on-their-size.patch can-dev-__can_get_echo_skb-fix-bogous-check-for-non-existing-skb-by-removing-it.patch can-bcm-check-timer-values-before-ktime-conversion.patch can-flexcan-fix-null-pointer-exception-during-bringup.patch vt-make-vt_console_print-compatible-with-the-unicode-screen-buffer.patch vt-always-call-notifier-with-the-console-lock-held.patch vt-invoke-notifier-on-screen-size-change.patch drm-meson-fix-atomic-mode-switching-regression.patch bpf-move-prev_-insn_idx-into-verifier-env.patch bpf-move-tmp-variable-into-ax-register-in-interprete.patch nvmet-rdma-add-unlikely-for-response-allocated-check.patch nvmet-rdma-fix-null-dereference-under-heavy-load.patch bpf-enable-access-to-ax-register-also-from-verifier-.patch bpf-restrict-map-value-pointer-arithmetic-for-unpriv.patch bpf-restrict-stack-pointer-arithmetic-for-unprivileg.patch bpf-restrict-unknown-scalars-of-mixed-signed-bounds-.patch bpf-fix-check_map_access-smin_value-test-when-pointe.patch bpf-prevent-out-of-bounds-speculation-on-pointer-ari.patch bpf-fix-sanitation-of-alu-op-with-pointer-scalar-typ.patch bpf-fix-inner-map-masking-to-prevent-oob-under-specu.patch drivers-hv-vmbus-remove-the-useless-api-vmbus_get_ou.patch vmbus-fix-subchannel-removal.patch revert-mm-memory_hotplug-initialize-struct-pages-for-the-full-memory-section.patch usb-dwc3-gadget-clear-req-needs_extra_trb-flag-on-cleanup.patch mt76x0-do-not-overwrite-other-mt_bbp-agc-8-fields.patch mt76x0-use-band-parameter-for-lc-calibration.patch mt76x02-run-calibration-after-scanning.patch mt76x02-assure-we-update-gain-after-scan.patch mt76x0-do-not-perform-mcu-calibration-for-mt7630.patch mt76x0-antenna-select-corrections.patch mt76x0-phy-unify-calibration-between-mt76x0u-and-mt76x0e.patch ide-fix-a-typo-in-the-settings-proc-file-name.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/aarch64/f69dc101d09505361cf9397fb4… s390x: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/s390x/1233ae6f1231470c40d701bb96bf… powerpc64le: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/ppc64le/5fb4530fd36d52d329930dd56c… x86_64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/x86_64/26643eb24ea65bdb5be58f873a6… Hardware testing ---------------- We booted each kernel and ran the following tests: arm64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… s390: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu powerpc: x86_64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us…

5 years, 8 months

3
2
0 0

patch "serial: 8250_pci: Make PCI class test non fatal" added to tty-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serial: 8250_pci: Make PCI class test non fatal to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 824d17c57b0abbcb9128fb3f7327fae14761914b Mon Sep 17 00:00:00 2001 From: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Date: Thu, 24 Jan 2019 23:51:21 +0200 Subject: serial: 8250_pci: Make PCI class test non fatal As has been reported the National Instruments serial cards have broken PCI class. The commit 7d8905d06405 ("serial: 8250_pci: Enable device after we check black list") made the PCI class check mandatory for the case when device is listed in a quirk list. Make PCI class test non fatal to allow broken card be enumerated. Fixes: 7d8905d06405 ("serial: 8250_pci: Enable device after we check black list") Cc: stable <stable(a)vger.kernel.org> Reported-by: Guan Yung Tseng <guan.yung.tseng(a)ni.com> Tested-by: Guan Yung Tseng <guan.yung.tseng(a)ni.com> Tested-by: KHUENY.Gerhard <Gerhard.KHUENY(a)bachmann.info> Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/8250/8250_pci.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index f80a300b5d68..48bd694a5fa1 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -3420,6 +3420,11 @@ static int serial_pci_guess_board(struct pci_dev *dev, struct pciserial_board *board) { int num_iomem, num_port, first_port = -1, i; + int rc; + + rc = serial_pci_is_class_communication(dev); + if (rc) + return rc; /* * Should we try to make guesses for multiport serial devices later? @@ -3647,10 +3652,6 @@ pciserial_init_one(struct pci_dev *dev, const struct pci_device_id *ent) board = &pci_boards[ent->driver_data]; - rc = serial_pci_is_class_communication(dev); - if (rc) - return rc; - rc = serial_pci_is_blacklisted(dev); if (rc) return rc; -- 2.20.1

5 years, 8 months

1
0
0 0

patch "serial: sh-sci: Do not free irqs that have already been freed" added to tty-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled serial: sh-sci: Do not free irqs that have already been freed to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 4d95987a32db53f3beca76f8c4c8309ef6a5f192 Mon Sep 17 00:00:00 2001 From: Chris Brandt <chris.brandt(a)renesas.com> Date: Mon, 28 Jan 2019 13:25:56 -0500 Subject: serial: sh-sci: Do not free irqs that have already been freed Since IRQs might be muxed on some parts, we need to pay attention when we are freeing them. Otherwise we get the ugly WARNING "Trying to free already-free IRQ 20". Fixes: 628c534ae735 ("serial: sh-sci: Improve support for separate TEI and DRI interrupts") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Chris Brandt <chris.brandt(a)renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/tty/serial/sh-sci.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 8df0fd824520..64bbeb7d7e0c 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1921,7 +1921,7 @@ static int sci_request_irq(struct sci_port *port) static void sci_free_irq(struct sci_port *port) { - int i; + int i, j; /* * Intentionally in reverse order so we iterate over the muxed @@ -1937,6 +1937,13 @@ static void sci_free_irq(struct sci_port *port) if (unlikely(irq < 0)) continue; + /* Check if already freed (irq was muxed) */ + for (j = 0; j < i; j++) + if (port->irqs[j] == irq) + j = i + 1; + if (j > i) + continue; + free_irq(port->irqs[i], port); kfree(port->irqstr[i]); -- 2.20.1

5 years, 8 months

1
0
0 0

[PATCH 4.4 000/104] 4.4.172-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.4.172 release. There are 104 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Jan 26 19:01:09 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.172-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.4.172-rc1 Corey Minyard <cminyard(a)mvista.com> ipmi:ssif: Fix handling of multi-part return messages Eric Dumazet <edumazet(a)google.com> net: speed up skb_rbtree_purge() Michal Hocko <mhocko(a)suse.com> mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps Brian Foster <bfoster(a)redhat.com> mm/page-writeback.c: don't break integrity writeback on ->writepage() error Junxiao Bi <junxiao.bi(a)oracle.com> ocfs2: fix panic due to unrecovered local alloc Qian Cai <cai(a)lca.pw> scsi: megaraid: fix out-of-bound array accesses Daniel Vetter <daniel.vetter(a)ffwll.ch> sysfs: Disable lockdep for driver bind/unbind files Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: bebob: fix model-id of unit for Apogee Ensemble Nikos Tsironis <ntsironis(a)arrikto.com> dm snapshot: Fix excessive memory usage and workqueue stalls Nikos Tsironis <ntsironis(a)arrikto.com> dm kcopyd: Fix bug causing workqueue stalls Arnaldo Carvalho de Melo <acme(a)redhat.com> perf parse-events: Fix unchecked usage of strncpy() Arnaldo Carvalho de Melo <acme(a)redhat.com> perf svghelper: Fix unchecked usage of strncpy() Adrian Hunter <adrian.hunter(a)intel.com> perf intel-pt: Fix error with config term "pt=0" Jonas Danielsson <jonas(a)orbital-systems.com> mmc: atmel-mci: do not assume idle after atmci_request_end Masahiro Yamada <yamada.masahiro(a)socionext.com> kconfig: fix memory leak when EOF is encountered in quotation Masahiro Yamada <yamada.masahiro(a)socionext.com> kconfig: fix file name and line number of warn_ignored_character() Lucas Stach <l.stach(a)pengutronix.de> clk: imx6q: reset exclusive gates on init David Disseldorp <ddiss(a)suse.de> scsi: target: use consistent left-aligned ASCII INQUIRY data yupeng <yupeng0921(a)gmail.com> net: call sk_dst_reset when set SO_DONTROUTE Nathan Chancellor <natechancellor(a)gmail.com> media: firewire: Fix app_info parameter type in avc_ca{,_app}_info Breno Leitao <leitao(a)debian.org> powerpc/pseries/cpuidle: Fix preempt warning Joel Fernandes (Google) <joel(a)joelfernandes.org> pstore/ram: Do not treat empty buffers as valid Daniel Santos <daniel.santos(a)pobox.com> jffs2: Fix use of uninitialized delayed_work, lockdep breakage Anders Roxell <anders.roxell(a)linaro.org> arm64: perf: set suppress_bind_attrs flag to true Maciej W. Rozycki <macro(a)linux-mips.org> MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur Anders Roxell <anders.roxell(a)linaro.org> writeback: don't decrement wb->refcnt if !wb->bdi Miroslav Lichvar <mlichvar(a)redhat.com> e1000e: allow non-monotonic SYSTIM readings João Paulo Rechi Vita <jprvita(a)gmail.com> platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey Darrick J. Wong <darrick.wong(a)oracle.com> xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE David Ahern <dsahern(a)gmail.com> ipv6: Take rcu_read_lock in __inet6_bind for mapped addresses David Ahern <dsahern(a)gmail.com> ipv6: Consider sk_bound_dev_if when binding a socket to a v4 mapped address Kai-Heng Feng <kai.heng.feng(a)canonical.com> r8169: Add support for new Realtek Ethernet Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> media: vb2: be sure to unlock mutex on errors Ivan Mironov <mironov.ivan(a)gmail.com> drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> loop: Fix double mutex_unlock(&loop_ctl_mutex) in loop_control_ioctl() Jan Kara <jack(a)suse.cz> loop: Get rid of loop_index_mutex Jan Kara <jack(a)suse.cz> loop: Fold __loop_release into loop_release Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> block/loop: Use global lock for ioctl() operation. Ying Xue <ying.xue(a)windriver.com> tipc: fix uninit-value in tipc_nl_compat_doit Ying Xue <ying.xue(a)windriver.com> tipc: fix uninit-value in tipc_nl_compat_name_table_dump Ying Xue <ying.xue(a)windriver.com> tipc: fix uninit-value in tipc_nl_compat_link_set Ying Xue <ying.xue(a)windriver.com> tipc: fix uninit-value in tipc_nl_compat_bearer_enable Ying Xue <ying.xue(a)windriver.com> tipc: fix uninit-value in tipc_nl_compat_link_reset_stats Xin Long <lucien.xin(a)gmail.com> sctp: allocate sctp_sockaddr_entry with kzalloc Stephen Smalley <sds(a)tycho.nsa.gov> selinux: fix GPF on invalid policy J. Bruce Fields <bfields(a)redhat.com> sunrpc: handle ENOMEM in rpcb_getport_async Hans Verkuil <hverkuil(a)xs4all.nl> media: vb2: vb2_mmap: move lock up James Morris <james.morris(a)microsoft.com> LSM: Check for NULL cred-security on free Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: vivid: set min width/height to a value > 0 Hans Verkuil <hverkuil-cisco(a)xs4all.nl> media: vivid: fix error handling of kthread_run Vlad Tsyrklevich <vlad(a)tsyrklevich.net> omap2fb: Fix stack memory disclosure YunQiang Su <ysu(a)wavecomp.com> Disable MSI also when pcie-octeon.pcie_disable on Jonathan Hunter <jonathanh(a)nvidia.com> mfd: tps6586x: Handle interrupts on suspend Arnd Bergmann <arnd(a)arndb.de> mips: fix n32 compat_ipc_parse_version Ivan Mironov <mironov.ivan(a)gmail.com> scsi: sd: Fix cache_type_store() Kees Cook <keescook(a)chromium.org> Yama: Check for pid death before checking ancestry Josef Bacik <josef(a)toxicpanda.com> btrfs: wait on ordered extents on abort cleanup Eric Biggers <ebiggers(a)google.com> crypto: authenc - fix parsing key with misaligned rta_len Harsh Jain <harsh(a)chelsio.com> crypto: authencesn - Avoid twice completion call in decrypt path Willem de Bruijn <willemb(a)google.com> ip: on queued skb use skb_header_pointer instead of pskb_may_pull Jason Gunthorpe <jgg(a)mellanox.com> packet: Do not leak dev refcounts on error exit JianJhen Chen <kchen(a)synology.com> net: bridge: fix a bug on using a neighbour cache entry without checking its state Eric Dumazet <edumazet(a)google.com> ipv6: fix kernel-infoleak in ipv6_local_error() Mark Rutland <mark.rutland(a)arm.com> arm64: Don't trap host pointer auth use to EL2 Mark Rutland <mark.rutland(a)arm.com> arm64/kvm: consistently handle host HCR_EL2 flags Gwendal Grignou <gwendal(a)chromium.org> proc: Remove empty line in /proc/self/status Ben Hutchings <ben(a)decadent.org.uk> media: em28xx: Fix misplaced reset of dev->v4l::field_count Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> f2fs: fix validation of the block count in sanity_check_raw_super Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: fix missing up_read Chao Yu <yuchao0(a)huawei.com> f2fs: fix invalid memory access Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with cp_pack_start_sum Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with block address in main area v2 Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with block address in main area Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with reserved blkaddr of inline inode Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with node footer and iblocks Ben Hutchings <ben.hutchings(a)codethink.co.uk> f2fs: Add sanity_check_inode() function Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with user_block_count Chao Yu <yuchao0(a)huawei.com> f2fs: fix to do sanity check with secs_per_zone Chao Yu <yuchao0(a)huawei.com> f2fs: introduce and spread verify_blkaddr Chao Yu <yuchao0(a)huawei.com> f2fs: clean up with is_valid_blkaddr() Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: enhance sanity_check_raw_super() to avoid potential overflow Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: sanity check on sit entry Yunlei He <heyunlei(a)huawei.com> f2fs: check blkaddr more accuratly before issue a bio Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: return error during fill_super Chao Yu <yuchao0(a)huawei.com> f2fs: fix race condition in between free nid allocator/initializer Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: free meta pages if sanity check for ckpt is failed Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: detect wrong layout Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: fix to determine start_cp_addr by sbi->cur_cp_pack Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: put directory inodes before checkpoint in roll-forward recovery Tiezhu Yang <kernelpatch(a)126.com> f2fs: introduce get_checkpoint_version for cleanup Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: use crc and cp version to determine roll-forward recovery Chao Yu <yuchao0(a)huawei.com> f2fs: avoid unneeded loop in build_sit_entries Yunlei He <heyunlei(a)huawei.com> f2fs: not allow to write illegal blkaddr Chao Yu <yuchao0(a)huawei.com> f2fs: fix to avoid reading out encrypted data in page cache Chao Yu <yuchao0(a)huawei.com> f2fs: fix inode cache leak Chao Yu <yuchao0(a)huawei.com> f2fs: factor out fsync inode entry operations Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: remove an obsolete variable Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: give -EINVAL for norecovery and rw mount Chao Yu <chao2.yu(a)samsung.com> f2fs: fix to convert inline directory correctly Shawn Lin <shawn.lin(a)rock-chips.com> f2fs: move sanity checking of cp into get_valid_checkpoint Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: cover more area with nat_tree_lock Chao Yu <chao2.yu(a)samsung.com> f2fs: clean up argument of recover_data Oliver Hartkopp <socketcan(a)hartkopp.net> can: gw: ensure DLC boundaries after CAN frame modification Dmitry Safonov <dima(a)arista.com> tty/ldsem: Wake up readers after timed out down_write() ------------- Diffstat: Documentation/filesystems/proc.txt | 4 +- Makefile | 4 +- arch/arm64/include/asm/kvm_arm.h | 3 + arch/arm64/kernel/head.S | 3 +- arch/arm64/kernel/perf_event.c | 1 + arch/arm64/kvm/hyp.S | 2 +- arch/mips/Kconfig | 4 + arch/mips/pci/msi-octeon.c | 4 +- arch/mips/sibyte/common/Makefile | 1 + arch/mips/sibyte/common/dma.c | 14 ++ crypto/authenc.c | 14 +- crypto/authencesn.c | 2 +- drivers/base/bus.c | 7 +- drivers/block/loop.c | 79 +++++------ drivers/block/loop.h | 1 - drivers/char/ipmi/ipmi_ssif.c | 25 ++-- drivers/clk/imx/clk-imx6q.c | 6 +- drivers/cpuidle/cpuidle-pseries.c | 8 +- drivers/gpu/drm/drm_fb_helper.c | 7 +- drivers/md/dm-kcopyd.c | 19 ++- drivers/md/dm-snap.c | 22 +++ drivers/media/firewire/firedtv-avc.c | 6 +- drivers/media/firewire/firedtv.h | 6 +- drivers/media/platform/vivid/vivid-kthread-cap.c | 5 +- drivers/media/platform/vivid/vivid-kthread-out.c | 5 +- drivers/media/platform/vivid/vivid-vid-common.c | 2 +- drivers/media/usb/em28xx/em28xx-video.c | 4 +- drivers/media/v4l2-core/videobuf2-core.c | 14 +- drivers/mfd/tps6586x.c | 24 ++++ drivers/mmc/host/atmel-mci.c | 3 +- drivers/net/ethernet/intel/e1000e/ptp.c | 13 +- drivers/net/ethernet/realtek/r8169.c | 2 + drivers/platform/x86/asus-wmi.c | 3 +- drivers/scsi/megaraid/megaraid_sas_fp.c | 2 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +- drivers/scsi/sd.c | 6 + drivers/target/target_core_spc.c | 17 ++- drivers/tty/tty_ldsem.c | 10 ++ drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 2 + fs/btrfs/disk-io.c | 8 ++ fs/f2fs/checkpoint.c | 168 ++++++++++++----------- fs/f2fs/data.c | 118 ++++++++++------ fs/f2fs/dir.c | 87 ++++++------ fs/f2fs/f2fs.h | 77 ++++++++--- fs/f2fs/file.c | 21 ++- fs/f2fs/inline.c | 115 +++++++++++++++- fs/f2fs/inode.c | 68 ++++++++- fs/f2fs/node.c | 103 ++++++++------ fs/f2fs/node.h | 77 +++++++---- fs/f2fs/recovery.c | 165 +++++++++++----------- fs/f2fs/segment.c | 93 +++++++------ fs/f2fs/segment.h | 48 +++++-- fs/f2fs/super.c | 134 +++++++++++++++--- fs/jffs2/super.c | 3 +- fs/ocfs2/localalloc.c | 9 +- fs/proc/array.c | 2 +- fs/pstore/ram_core.c | 5 + fs/xfs/libxfs/xfs_attr.c | 9 +- include/linux/backing-dev-defs.h | 8 ++ include/linux/f2fs_fs.h | 3 + mm/page-writeback.c | 35 +++-- net/bridge/br_netfilter_hooks.c | 2 +- net/can/gw.c | 30 +++- net/core/skbuff.c | 11 +- net/core/sock.c | 1 + net/ipv4/ip_sockglue.c | 12 +- net/ipv6/af_inet6.c | 14 +- net/ipv6/datagram.c | 11 +- net/packet/af_packet.c | 4 +- net/sctp/ipv6.c | 5 +- net/sctp/protocol.c | 4 +- net/sunrpc/rpcb_clnt.c | 8 ++ net/tipc/netlink_compat.c | 50 ++++++- scripts/kconfig/zconf.l | 4 +- security/security.c | 7 + security/selinux/ss/policydb.c | 3 +- security/yama/yama_lsm.c | 4 +- sound/firewire/bebob/bebob.c | 2 +- tools/perf/arch/x86/util/intel-pt.c | 11 ++ tools/perf/util/parse-events.c | 2 +- tools/perf/util/svghelper.c | 2 +- 81 files changed, 1335 insertions(+), 564 deletions(-)

5 years, 8 months

6
110
0 0

Will the recent memory leak fixes be backported to longterm kernels?

by Dexuan Cui

Hi all, When debugging a memory leak issue (https://github.com/coreos/bugs/issues/2516) with v4.14.11-coreos, we noticed the same issue may have been fixed recently by Roman in the latest mainline (i.e. Linus's master branch) according to comment #7 of https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1792349, which lists these patches (I'm not sure if the 5-patch list is complete): 010cb21d4ede math64: prevent double calculation of DIV64_U64_ROUND_UP() arguments f77d7a05670d mm: don't miss the last page because of round-off error d18bf0af683e mm: drain memcg stocks on css offlining 71cd51b2e1ca mm: rework memcg kernel stack accounting f3a2fccbce15 mm: slowly shrink slabs with a relatively small number of objects Obviously at least some of the fixes are also needed in the longterm kernels like v4.14.y, but none of the 5 patches has the "Cc: stable(a)vger.kernel.org" tag? I'm wondering if these patches will be backported to the longterm kernels. BTW, the patches are not in v4.19, but I suppose they will be in v4.19.1-rc1? Thanks, -- Dexuan

5 years, 8 months

6
18
0 0

+ revert-mm-slowly-shrink-slabs-with-a-relatively-small-number-of-objects.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: Revert "mm: slowly shrink slabs with a relatively small number of objects" has been added to the -mm tree. Its filename is revert-mm-slowly-shrink-slabs-with-a-relatively-small-number-of-objects.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/revert-mm-slowly-shrink-slabs-with… and later at http://ozlabs.org/~akpm/mmotm/broken-out/revert-mm-slowly-shrink-slabs-with… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Dave Chinner <dchinner(a)redhat.com> Subject: Revert "mm: slowly shrink slabs with a relatively small number of objects" This reverts commit 172b06c32b949759fe6313abec514bc4f15014f4. This change changes the agressiveness of shrinker reclaim, causing small cache and low priority reclaim to greatly increase scanning pressure on small caches. As a result, light memory pressure has a disproportionate affect on small caches, and causes large caches to be reclaimed much faster than previously. As a result, it greatly perturbs the delicate balance of the VFS caches (dentry/inode vs file page cache) such that the inode/dentry caches are reclaimed much, much faster than the page cache and this drives us into several other caching imbalance related problems. As such, this is a bad change and needs to be reverted. [Needs some massaging to retain the later seekless shrinker modifications.] Link: http://lkml.kernel.org/r/20190130041707.27750-3-david@fromorbit.com Signed-off-by: Dave Chinner <dchinner(a)redhat.com> Cc: Roman Gushchin <guro(a)fb.com> Cc: Spock <dairinin(a)gmail.com> Cc: Rik van Riel <riel(a)surriel.com> Cc: Michal Hocko <mhocko(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- --- a/mm/vmscan.c~revert-mm-slowly-shrink-slabs-with-a-relatively-small-number-of-objects +++ a/mm/vmscan.c @@ -491,16 +491,6 @@ static unsigned long do_shrink_slab(stru delta = freeable / 2; } - /* - * Make sure we apply some minimal pressure on default priority - * even on small cgroups. Stale objects are not only consuming memory - * by themselves, but can also hold a reference to a dying cgroup, - * preventing it from being reclaimed. A dying cgroup with all - * corresponding structures like per-cpu stats and kmem caches - * can be really big, so it may lead to a significant waste of memory. - */ - delta = max_t(unsigned long long, delta, min(freeable, batch_size)); - total_scan += delta; if (total_scan < 0) { pr_err("shrink_slab: %pF negative objects to delete nr=%ld\n", _ Patches currently in -mm which might be from dchinner(a)redhat.com are revert-mm-dont-reclaim-inodes-with-many-attached-pages.patch revert-mm-slowly-shrink-slabs-with-a-relatively-small-number-of-objects.patch

5 years, 8 months

1
0
0 0

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153-43-g6674590d15d2)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153-43-g6674590d15d2) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.153-43-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.153-43-g6674590d15d2 Git Commit: 6674590d15d227f4096f193f8e6fb737ef41e89f Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 48 unique boards, 21 SoC families, 13 builds out of 193 Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

+ mm-migrate-dont-rely-on-__pagemovable-of-newpage-after-unlocking-it.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: migrate: don't rely on __PageMovable() of newpage after unlocking it has been added to the -mm tree. Its filename is mm-migrate-dont-rely-on-__pagemovable-of-newpage-after-unlocking-it.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-migrate-dont-rely-on-__pagemova… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-migrate-dont-rely-on-__pagemova… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: David Hildenbrand <david(a)redhat.com> Subject: mm: migrate: don't rely on __PageMovable() of newpage after unlocking it We had a race in the old balloon compaction code before b1123ea6d3b3 ("mm: balloon: use general non-lru movable page feature") refactored it that became visible after backporting 195a8c43e93d ("virtio-balloon: deflate via a page list") without the refactoring. The bug existed from commit d6d86c0a7f8d ("mm/balloon_compaction: redesign ballooned pages management") till b1123ea6d3b3 ("mm: balloon: use general non-lru movable page feature"). d6d86c0a7f8d ("mm/balloon_compaction: redesign ballooned pages management") was backported to 3.12, so the broken kernels are stable kernels [3.12 - 4.7]. There was a subtle race between dropping the page lock of the newpage in __unmap_and_move() and checking for __is_movable_balloon_page(newpage). Just after dropping this page lock, virtio-balloon could go ahead and deflate the newpage, effectively dequeueing it and clearing PageBalloon, in turn making __is_movable_balloon_page(newpage) fail. This resulted in dropping the reference of the newpage via putback_lru_page(newpage) instead of put_page(newpage), leading to page->lru getting modified and a !LRU page ending up in the LRU lists. With 195a8c43e93d ("virtio-balloon: deflate via a page list") backported, one would suddenly get corrupted lists in release_pages_balloon(): - WARNING: CPU: 13 PID: 6586 at lib/list_debug.c:59 __list_del_entry+0xa1/0xd0 - list_del corruption. prev->next should be ffffe253961090a0, but was dead000000000100 Nowadays this race is no longer possible, but it is hidden behind very ugly handling of __ClearPageMovable() and __PageMovable(). __ClearPageMovable() will not make __PageMovable() fail, only PageMovable(). So the new check (__PageMovable(newpage)) will still hold even after newpage was dequeued by virtio-balloon. If anybody would ever change that special handling, the BUG would be introduced again. So instead, make it explicit and use the information of the original isolated page before migration. This patch can be backported fairly easy to stable kernels (in contrast to the refactoring). Link: http://lkml.kernel.org/r/20190129233217.10747-1-david@redhat.com Fixes: d6d86c0a7f8d ("mm/balloon_compaction: redesign ballooned pages management") Signed-off-by: David Hildenbrand <david(a)redhat.com> Reported-by: Vratislav Bendel <vbendel(a)redhat.com> Acked-by: Michal Hocko <mhocko(a)suse.com> Acked-by: Rafael Aquini <aquini(a)redhat.com> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: "Kirill A. Shutemov" <kirill.shutemov(a)linux.intel.com> Cc: Michal Hocko <mhocko(a)suse.com> Cc: Naoya Horiguchi <n-horiguchi(a)ah.jp.nec.com> Cc: Jan Kara <jack(a)suse.cz> Cc: Andrea Arcangeli <aarcange(a)redhat.com> Cc: Dominik Brodowski <linux(a)dominikbrodowski.net> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: Vratislav Bendel <vbendel(a)redhat.com> Cc: Rafael Aquini <aquini(a)redhat.com> Cc: Konstantin Khlebnikov <k.khlebnikov(a)samsung.com> Cc: Minchan Kim <minchan(a)kernel.org> Cc: <stable(a)vger.kernel.org> [3.12 - 4.7] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/migrate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/mm/migrate.c~mm-migrate-dont-rely-on-__pagemovable-of-newpage-after-unlocking-it +++ a/mm/migrate.c @@ -1130,10 +1130,13 @@ out: * If migration is successful, decrease refcount of the newpage * which will not free the page because new page owner increased * refcounter. As well, if it is LRU page, add the page to LRU - * list in here. + * list in here. Use the old state of the isolated source page to + * determine if we migrated a LRU page. newpage was already unlocked + * and possibly modified by its owner - don't rely on the page + * state. */ if (rc == MIGRATEPAGE_SUCCESS) { - if (unlikely(__PageMovable(newpage))) + if (unlikely(!is_lru)) put_page(newpage); else putback_lru_page(newpage); _ Patches currently in -mm which might be from david(a)redhat.com are mm-migrate-dont-rely-on-__pagemovable-of-newpage-after-unlocking-it.patch mm-balloon-update-comment-about-isolation-migration-compaction.patch mm-convert-pg_balloon-to-pg_offline.patch kexec-export-pg_offline-to-vmcoreinfo.patch xen-balloon-mark-inflated-pages-pg_offline.patch hv_balloon-mark-inflated-pages-pg_offline.patch vmw_balloon-mark-inflated-pages-pg_offline.patch vmw_balloon-mark-inflated-pages-pg_offline-v2.patch pm-hibernate-use-pfn_to_online_page.patch pm-hibernate-exclude-all-pageoffline-pages.patch pm-hibernate-exclude-all-pageoffline-pages-v2.patch agp-efficeon-no-need-to-set-pg_reserved-on-gatt-tables.patch s390-vdso-dont-clear-pg_reserved.patch powerpc-vdso-dont-clear-pg_reserved.patch riscv-vdso-dont-clear-pg_reserved.patch m68k-mm-use-__clearpagereserved.patch arm64-kexec-no-need-to-clearpagereserved.patch arm64-kdump-no-need-to-mark-crashkernel-pages-manually-pg_reserved.patch ia64-perfmon-dont-mark-buffer-pages-as-pg_reserved.patch mm-better-document-pg_reserved.patch

5 years, 8 months

1
0
0 0

stable-rc/linux-4.19.y boot: 115 boots: 0 failed, 112 passed with 2 offline, 1 untried/unknown (v4.19.18-104-gd0a51a4dd99a)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 115 boots: 0 failed, 112 passed with 2 offline, 1 untried/unknown (v4.19.18-104-gd0a51a4dd99a) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.18-10… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.18-104-gd0a51a4dd99a Git Commit: d0a51a4dd99af17e1f6a0d3758b9c2a7a6c0014a Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 63 unique boards, 23 SoC families, 12 builds out of 202 Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2019