Linux-stable-mirror May 2018

linux-stable-mirror@lists.linaro.org

304 participants
616 discussions

[PATCH 4.14 00/91] 4.14.39-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.39 release. There are 91 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed May 2 18:39:37 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.39-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.39-rc1 Nicolas Dichtel <nicolas.dichtel(a)6wind.com> net: don't call update_pmtu unconditionally Michael Neuling <mikey(a)neuling.org> powerpc/eeh: Fix race with driver un/bind Marc Zyngier <marc.zyngier(a)arm.com> arm/arm64: KVM: Add PSCI version selection API Thomas Gleixner <tglx(a)linutronix.de> tick/sched: Do not mess with an enqueued hrtimer Borislav Petkov <bp(a)suse.de> x86/microcode: Do not exit early from __reload_late() Borislav Petkov <bp(a)suse.de> x86/microcode/intel: Save microcode patch unconditionally Yazen Ghannam <yazen.ghannam(a)amd.com> x86/smpboot: Don't use mwait_play_dead() on AMD systems Arnd Bergmann <arnd(a)arndb.de> x86/ipc: Fix x32 version of shmid64_ds and msqid64_ds Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> tools/lib/subcmd/pager.c: do not alias select() params Josh Poimboeuf <jpoimboe(a)redhat.com> objtool, perf: Fix GCC 8 -Wrestrict error Imre Deak <imre.deak(a)intel.com> drm/i915: Enable display WA#1183 from its correct spot Nicolai Hähnle <nicolai.haehnle(a)amd.com> drm/amdgpu: set COMPUTE_PGM_RSRC1 for SGPR/VGPR clearing shaders Nicholas Piggin <npiggin(a)gmail.com> rtc: opal: Fix OPAL RTC driver OPAL_BUSY loops Shilpasri G Bhat <shilpa.bhat(a)linux.vnet.ibm.com> cpufreq: powernv: Fix hardlockup due to synchronous smp_call in timer interrupt Daniel Kurtz <djkurtz(a)chromium.org> earlycon: Use a pointer table to fix __earlycon_table stride Anatolij Gustschin <agust(a)denx.de> fpga-manager: altera-ps-spi: preserve nCONFIG state Ilya Dryomov <idryomov(a)gmail.com> libceph: validate con->state at the top of try_write() Ilya Dryomov <idryomov(a)gmail.com> libceph: reschedule a tick in finish_hunting() Ilya Dryomov <idryomov(a)gmail.com> libceph: un-backoff on tick when we have a authenticated session Nicolin Chen <nicoleotsuka(a)gmail.com> ASoC: fsl_esai: Fix divisor calculation failure at lower ratio Stephan Mueller <smueller(a)chronox.de> crypto: drbg - set freed buffers to NULL Alistair Popple <alistair(a)popple.id.au> powerpc/powernv/npu: Do a PID GPU TLB flush when invalidating a large address range Balbir Singh <bsingharora(a)gmail.com> powerpc/mm: Flush cache on memory hot(un)plug Marc Zyngier <marc.zyngier(a)arm.com> KVM: arm/arm64: Close VMID generation race Thor Thayer <thor.thayer(a)linux.intel.com> ARM: socfpga_defconfig: Remove QSPI Sector 4K size force Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: amba: Don't read past the end of sysfs "driver_override" buffer Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: amba: Fix race condition with driver_override Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: amba: Make driver_override output consistent with other buses Evan Wang <xswang(a)marvell.com> PCI: aardvark: Fix PCIe Max Read Request Size setting Victor Gu <xigu(a)marvell.com> PCI: aardvark: Use ISR1 instead of ISR0 interrupt in legacy irq mode Victor Gu <xigu(a)marvell.com> PCI: aardvark: Set PIO_ADDR_LS correctly in advk_pcie_rd_conf() Victor Gu <xigu(a)marvell.com> PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf() Martijn Coenen <maco(a)android.com> ANDROID: binder: prevent transactions into own process. Cornelia Huck <cohuck(a)redhat.com> vfio: ccw: process ssch with interrupts disabled Jens Axboe <axboe(a)kernel.dk> bfq-iosched: ensure to clear bic/bfqq pointers when preparing request Mahesh Rajashekhara <mahesh.rajashekhara(a)microsemi.com> scsi: sd: Defer spinning up drive while SANITIZE is in progress Dmitry Vyukov <dvyukov(a)google.com> kobject: don't use WARN for registration failures Marc Gonzalez <marc_gonzalez(a)sigmadesigns.com> mtd: rawnand: tango: Fix struct clk memory leak Joakim Tjernlund <joakim.tjernlund(a)infinera.com> mtd: cfi: cmdset_0002: Do not allow read/write to suspend erase block. Joakim Tjernlund <joakim.tjernlund(a)transmode.se> mtd: cfi: cmdset_0001: Workaround Micron Erase suspend bug. Joakim Tjernlund <joakim.tjernlund(a)transmode.se> mtd: cfi: cmdset_0001: Do not allow read/write to suspend erase block. Thor Thayer <thor.thayer(a)linux.intel.com> mtd: spi-nor: cadence-quadspi: Fix page fault kernel panic Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - change the location for one of two front mics Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Update ALC255 depop optimize Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Add some fixes for ALC233 Takashi Iwai <tiwai(a)suse.de> ALSA: hda: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: seq: oss: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device David Henningsson <diwic(a)ubuntu.com> ALSA: core: Report audio_tstamp in snd_pcm_sync_ptr Jeffery Miller <jmiller(a)neverware.com> ALSA: pcm: Return negative delays from SNDRV_PCM_IOCTL_DELAY. Takashi Iwai <tiwai(a)suse.de> ALSA: control: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: rme9652: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: hdspm: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: asihpi: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: opl3: Hardening for potential Spectre v1 Takashi Iwai <tiwai(a)suse.de> ALSA: hda - Skip jack and others for non-existing PCM streams Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: dice: fix error path to destroy initialized stream data Takashi Sakamoto <o-takashi(a)sakamocchi.jp> ALSA: dice: fix OUI for TC group Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> tty: Use __GFP_NOFAIL for tty_ldisc_get() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> tty: Avoid possible error pointer dereference at tty_ldisc_restore(). Tony Lindgren <tony(a)atomide.com> tty: n_gsm: Fix DLCI handling for ADM mode if debug & 2 is not set Tony Lindgren <tony(a)atomide.com> tty: n_gsm: Fix long delays with control frame timeouts in ADM mode Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> tty: Don't call panic() at tty_ldisc_init() Gerd Hoffmann <kraxel(a)redhat.com> drm/virtio: fix vq wait_event condition Michael S. Tsirkin <mst(a)redhat.com> virtio_console: reset on out of memory Michael S. Tsirkin <mst(a)redhat.com> virtio_console: move removal code Michael S. Tsirkin <mst(a)redhat.com> virtio_console: drop custom control queue cleanup Michael S. Tsirkin <mst(a)redhat.com> virtio_console: free buffers after reset Michael S. Tsirkin <mst(a)redhat.com> virtio_console: don't tie bufs to a vq Michael S. Tsirkin <mst(a)redhat.com> virtio: add ability to iterate over vqs Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Skip broken EU on Dell dock USB-audio Ravi Chandra Sadineni <ravisadineni(a)chromium.org> USB: Increment wakeup count on remote wakeup. Kamil Lulko <kamilx.lulko(a)intel.com> usb: core: Add quirk for HP v222w 16GB Mini Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: typec: ucsi: Increase command completion timeout value Kyle Roeschley <kyle.roeschley(a)ni.com> USB: serial: cp210x: add ID for NI USB serial console Vasyl Vavrychuk <vvavrychuk(a)gmail.com> USB: serial: ftdi_sio: use jtag quirk for Arrow USB Blaster Collin May <collin(a)collinswebsite.com> USB: serial: simple: add libtransistor console Kai-Heng Feng <kai.heng.feng(a)canonical.com> xhci: Fix USB ports for Dell Inspiron 5775 Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "xhci: plat: Register shutdown for xhci_plat" Shuah Khan <shuah(a)kernel.org> usbip: vhci_hcd: check rhport before using in vhci_hub_control() Shuah Khan <shuah(a)kernel.org> usbip: vhci_hcd: Fix usb device and sockfd leaks Shuah Khan <shuah(a)kernel.org> usbip: usbip_host: fix to hold parent lock for device_attach() calls Shuah Khan <shuah(a)kernel.org> usbip: usbip_event: fix to not print kernel pointer address Theodore Ts'o <tytso(a)mit.edu> random: rate limit unseeded randomness warnings Theodore Ts'o <tytso(a)mit.edu> random: fix possible sleeping allocation from irq context Theodore Ts'o <tytso(a)mit.edu> random: set up the NUMA crng instances after the CRNG is fully initialized Lukas Czerner <lczerner(a)redhat.com> ext4: fix bitmap position validation Theodore Ts'o <tytso(a)mit.edu> ext4: add validity checks for bitmap block numbers Theodore Ts'o <tytso(a)mit.edu> ext4: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs Theodore Ts'o <tytso(a)mit.edu> ext4: set h_journal if there is a failure starting a reserved handle Eric Biggers <ebiggers(a)google.com> ext4: prevent right-shifting extents beyond EXT_MAX_BLOCKS ------------- Diffstat: Documentation/virtual/kvm/api.txt | 9 +- Documentation/virtual/kvm/arm/psci.txt | 30 ++++++ Makefile | 4 +- arch/arm/configs/socfpga_defconfig | 1 + arch/arm/include/asm/kvm_host.h | 3 + arch/arm/include/uapi/asm/kvm.h | 6 ++ arch/arm/kvm/guest.c | 13 +++ arch/arm64/include/asm/kvm_host.h | 3 + arch/arm64/include/uapi/asm/kvm.h | 6 ++ arch/arm64/kvm/guest.c | 14 ++- arch/powerpc/kernel/eeh_driver.c | 61 +++++++----- arch/powerpc/mm/mem.c | 2 + arch/powerpc/platforms/powernv/npu-dma.c | 23 ++++- arch/powerpc/platforms/powernv/opal-rtc.c | 8 +- arch/x86/include/uapi/asm/msgbuf.h | 31 ++++++ arch/x86/include/uapi/asm/shmbuf.h | 42 ++++++++ arch/x86/kernel/cpu/microcode/core.c | 6 +- arch/x86/kernel/cpu/microcode/intel.c | 2 - arch/x86/kernel/smpboot.c | 2 + block/bfq-iosched.c | 10 +- crypto/drbg.c | 2 + drivers/amba/bus.c | 17 ++-- drivers/android/binder.c | 8 ++ drivers/char/random.c | 90 ++++++++++++----- drivers/char/virtio_console.c | 157 ++++++++++++++---------------- drivers/cpufreq/powernv-cpufreq.c | 14 ++- drivers/fpga/altera-ps-spi.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 7 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 11 +-- drivers/gpu/drm/virtio/virtgpu_vq.c | 4 +- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 3 +- drivers/mtd/chips/cfi_cmdset_0001.c | 33 ++++++- drivers/mtd/chips/cfi_cmdset_0002.c | 9 +- drivers/mtd/nand/tango_nand.c | 2 +- drivers/mtd/spi-nor/cadence-quadspi.c | 19 +++- drivers/net/vxlan.c | 6 +- drivers/of/fdt.c | 7 +- drivers/pci/host/pci-aardvark.c | 53 +++++----- drivers/rtc/rtc-opal.c | 37 ++++--- drivers/s390/cio/vfio_ccw_fsm.c | 19 ++-- drivers/scsi/sd.c | 2 + drivers/tty/n_gsm.c | 23 ++++- drivers/tty/serial/earlycon.c | 6 +- drivers/tty/tty_io.c | 5 +- drivers/tty/tty_ldisc.c | 29 +++--- drivers/usb/core/hcd.c | 1 + drivers/usb/core/hub.c | 10 +- drivers/usb/core/quirks.c | 3 + drivers/usb/host/xhci-pci.c | 5 +- drivers/usb/host/xhci-plat.c | 1 - drivers/usb/serial/Kconfig | 1 + drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/ftdi_sio.c | 3 +- drivers/usb/serial/usb-serial-simple.c | 7 ++ drivers/usb/typec/ucsi/ucsi.c | 2 +- drivers/usb/usbip/stub_main.c | 5 + drivers/usb/usbip/usbip_common.h | 2 +- drivers/usb/usbip/usbip_event.c | 4 - drivers/usb/usbip/vhci_hcd.c | 13 +++ fs/ext4/balloc.c | 17 +++- fs/ext4/extents.c | 16 ++- fs/ext4/ialloc.c | 7 ++ fs/ext4/super.c | 1 + fs/jbd2/transaction.c | 1 + include/asm-generic/vmlinux.lds.h | 2 +- include/kvm/arm_psci.h | 16 ++- include/linux/mtd/flashchip.h | 1 + include/linux/serial_core.h | 21 ++-- include/linux/tty.h | 2 +- include/linux/virtio.h | 3 + include/net/dst.h | 8 ++ include/sound/control.h | 7 +- kernel/time/tick-sched.c | 11 ++- lib/kobject.c | 12 +-- net/ceph/messenger.c | 7 ++ net/ceph/mon_client.c | 14 ++- net/ipv4/ip_tunnel.c | 3 +- net/ipv4/ip_vti.c | 2 +- net/ipv6/ip6_tunnel.c | 5 +- net/ipv6/ip6_vti.c | 2 +- net/ipv6/sit.c | 4 +- sound/core/pcm_compat.c | 7 +- sound/core/pcm_native.c | 24 ++--- sound/core/seq/oss/seq_oss_event.c | 15 +-- sound/core/seq/oss/seq_oss_midi.c | 2 + sound/core/seq/oss/seq_oss_synth.c | 85 +++++++++------- sound/core/seq/oss/seq_oss_synth.h | 3 +- sound/drivers/opl3/opl3_synth.c | 7 +- sound/firewire/dice/dice-stream.c | 2 +- sound/firewire/dice/dice.c | 2 +- sound/pci/asihpi/hpimsginit.c | 13 ++- sound/pci/asihpi/hpioctl.c | 4 +- sound/pci/hda/hda_hwdep.c | 12 ++- sound/pci/hda/patch_hdmi.c | 9 +- sound/pci/hda/patch_realtek.c | 5 + sound/pci/rme9652/hdspm.c | 24 +++-- sound/pci/rme9652/rme9652.c | 6 +- sound/soc/fsl/fsl_esai.c | 7 ++ sound/usb/mixer_maps.c | 3 + tools/lib/str_error_r.c | 2 +- tools/lib/subcmd/pager.c | 5 +- virt/kvm/arm/arm.c | 15 ++- virt/kvm/arm/psci.c | 60 ++++++++++++ 103 files changed, 978 insertions(+), 395 deletions(-)

6 years, 7 months

[PATCH 3.18 00/25] 3.18.108-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 3.18.108 release. There are 25 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed May 2 18:39:02 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.18.108-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 3.18.108-rc1 Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "perf tests: Decompress kernel module before objdump" Ilya Dryomov <idryomov(a)gmail.com> libceph: validate con->state at the top of try_write() Nicolin Chen <nicoleotsuka(a)gmail.com> ASoC: fsl_esai: Fix divisor calculation failure at lower ratio Mahesh Rajashekhara <mahesh.rajashekhara(a)microsemi.com> scsi: sd: Defer spinning up drive while SANITIZE is in progress Dmitry Vyukov <dvyukov(a)google.com> kobject: don't use WARN for registration failures Joakim Tjernlund <joakim.tjernlund(a)infinera.com> mtd: cfi: cmdset_0002: Do not allow read/write to suspend erase block. Joakim Tjernlund <joakim.tjernlund(a)transmode.se> mtd: cfi: cmdset_0001: Workaround Micron Erase suspend bug. Joakim Tjernlund <joakim.tjernlund(a)transmode.se> mtd: cfi: cmdset_0001: Do not allow read/write to suspend erase block. Takashi Iwai <tiwai(a)suse.de> ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device David Henningsson <diwic(a)ubuntu.com> ALSA: core: Report audio_tstamp in snd_pcm_sync_ptr Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> tty: Use __GFP_NOFAIL for tty_ldisc_get() Tony Lindgren <tony(a)atomide.com> tty: n_gsm: Fix DLCI handling for ADM mode if debug & 2 is not set Tony Lindgren <tony(a)atomide.com> tty: n_gsm: Fix long delays with control frame timeouts in ADM mode Michael S. Tsirkin <mst(a)redhat.com> virtio_console: free buffers after reset Michael S. Tsirkin <mst(a)redhat.com> virtio: add ability to iterate over vqs Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Skip broken EU on Dell dock USB-audio Ravi Chandra Sadineni <ravisadineni(a)chromium.org> USB: Increment wakeup count on remote wakeup. Kamil Lulko <kamilx.lulko(a)intel.com> usb: core: Add quirk for HP v222w 16GB Mini Kyle Roeschley <kyle.roeschley(a)ni.com> USB: serial: cp210x: add ID for NI USB serial console Vasyl Vavrychuk <vvavrychuk(a)gmail.com> USB: serial: ftdi_sio: use jtag quirk for Arrow USB Blaster Shuah Khan <shuahkh(a)osg.samsung.com> usbip: vhci_hcd: Fix usb device and sockfd leaks Shuah Khan <shuahkh(a)osg.samsung.com> usbip: usbip_host: fix to hold parent lock for device_attach() calls Lukas Czerner <lczerner(a)redhat.com> ext4: fix bitmap position validation Theodore Ts'o <tytso(a)mit.edu> ext4: add validity checks for bitmap block numbers Theodore Ts'o <tytso(a)mit.edu> ext4: set h_journal if there is a failure starting a reserved handle ------------- Diffstat: Makefile | 4 +-- drivers/char/virtio_console.c | 49 ++++++++++++++++++------------------- drivers/mtd/chips/cfi_cmdset_0001.c | 33 +++++++++++++++++++++---- drivers/mtd/chips/cfi_cmdset_0002.c | 9 ++++--- drivers/scsi/sd.c | 2 ++ drivers/tty/n_gsm.c | 23 ++++++++++++++++- drivers/tty/tty_ldisc.c | 11 ++++----- drivers/usb/core/hcd.c | 1 + drivers/usb/core/hub.c | 10 +++++++- drivers/usb/core/quirks.c | 3 +++ drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/ftdi_sio.c | 3 ++- drivers/usb/usbip/stub_main.c | 5 ++++ drivers/usb/usbip/usbip_common.h | 2 +- fs/ext4/balloc.c | 17 +++++++++++-- fs/ext4/ialloc.c | 8 +++++- fs/jbd2/transaction.c | 1 + include/linux/mtd/flashchip.h | 1 + include/linux/virtio.h | 3 +++ lib/kobject.c | 12 ++++----- net/ceph/messenger.c | 7 ++++++ sound/core/pcm_native.c | 1 + sound/core/seq/oss/seq_oss_synth.c | 12 ++++++--- sound/soc/fsl/fsl_esai.c | 7 ++++++ sound/usb/mixer_maps.c | 3 +++ tools/perf/tests/code-reading.c | 20 +-------------- 26 files changed, 170 insertions(+), 78 deletions(-)

6 years, 7 months

[PATCH v4.4 0/2] serial: mctrl_gpio: export mctrl_gpio_disable_ms and mctrl_gpio_init

by Daniel Wagner

Hi Greg, These two patches should probably be part of the 4.4 because ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") backport. 4.9, 4.14 and 4.16 have these patches already in it. Romain Izard (1): serial: mctrl_gpio: Add missing module license Uwe Kleine-König (1): serial: mctrl_gpio: export mctrl_gpio_disable_ms and mctrl_gpio_init drivers/tty/serial/serial_mctrl_gpio.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.14.3

6 years, 7 months

Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

by Thomas Deutschmann

Hi, please add > From f15ca723c1ebe6c1a06bc95fda6b62cd87b44559 Mon Sep 17 00:00:00 2001 > From: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> > Date: Thu, 25 Jan 2018 19:03:03 +0100 > Subject: net: don't call update_pmtu unconditionally > > Some dst_ops (e.g. md_dst_ops)) doesn't set this handler. It may result to: > "BUG: unable to handle kernel NULL pointer dereference at (null)" > > Let's add a helper to check if update_pmtu is available before calling it. > > Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path") > Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path") > CC: Roman Kapl <code(a)rkapl.cz> > CC: Xin Long <lucien.xin(a)gmail.com> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel(a)6wind.com> > Signed-off-by: David S. Miller <davem(a)davemloft.net> to 4.14.x. This fixes NULL derefs caused by a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path"), which was backported to 4.14.24. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

6 years, 7 months

FAILED: patch "[PATCH] tpm: self test failure should not cause suspend to fail" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 0803d7befa15cab5717d667a97a66214d2a4c083 Mon Sep 17 00:00:00 2001 From: Chris Chiu <chiu(a)endlessm.com> Date: Tue, 20 Mar 2018 15:36:40 +0800 Subject: [PATCH] tpm: self test failure should not cause suspend to fail The Acer Acer Veriton X4110G has a TPM device detected as: tpm_tis 00:0b: 1.2 TPM (device-id 0xFE, rev-id 71) After the first S3 suspend, the following error appears during resume: tpm tpm0: A TPM error(38) occurred continue selftest Any following S3 suspend attempts will now fail with this error: tpm tpm0: Error (38) sending savestate before suspend PM: Device 00:0b failed to suspend: error 38 Error 38 is TPM_ERR_INVALID_POSTINIT which means the TPM is not in the correct state. This indicates that the platform BIOS is not sending the usual TPM_Startup command during S3 resume. >From this point onwards, all TPM commands will fail. The same issue was previously reported on Foxconn 6150BK8MC and Sony Vaio TX3. The platform behaviour seems broken here, but we should not break suspend/resume because of this. When the unexpected TPM state is encountered, set a flag to skip the affected TPM_SaveState command on later suspends. Cc: stable(a)vger.kernel.org Signed-off-by: Chris Chiu <chiu(a)endlessm.com> Signed-off-by: Daniel Drake <drake(a)endlessm.com> Link: http://lkml.kernel.org/r/CAB4CAwfSCvj1cudi+MWaB5g2Z67d9DwY1o475YOZD64ma23Ui… Link: https://lkml.org/lkml/2011/3/28/192 Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591031 Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index 47aacecdc85c..22288ff70a0b 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -1002,6 +1002,10 @@ int tpm_do_selftest(struct tpm_chip *chip) loops = jiffies_to_msecs(duration) / delay_msec; rc = tpm_continue_selftest(chip); + if (rc == TPM_ERR_INVALID_POSTINIT) { + chip->flags |= TPM_CHIP_FLAG_ALWAYS_POWERED; + dev_info(&chip->dev, "TPM not ready (%d)\n", rc); + } /* This may fail if there was no TPM driver during a suspend/resume * cycle; some may return 10 (BAD_ORDINAL), others 28 (FAILEDSELFTEST) */

6 years, 7 months

[PATCH 0/3] v4.16 tpmdd backports

by Jarkko Sakkinen

"tpm: add retry logic" caused merge conflicts so I picked couple of other fixes in order to get it apply cleanly. James Bottomley (1): tpm: add retry logic Tomas Winkler (1): tpm: cmd_ready command can be issued only after granting locality Winkler, Tomas (1): tpm: tpm-interface: fix tpm_transmit/_cmd kdoc drivers/char/tpm/tpm-interface.c | 131 ++++++++++++++++++++++++------- drivers/char/tpm/tpm.h | 1 + drivers/char/tpm/tpm_crb.c | 108 +++++++++++++++++-------- drivers/char/tpm/tpm_tis_core.c | 4 +- include/linux/tpm.h | 2 +- 5 files changed, 183 insertions(+), 63 deletions(-) -- 2.17.0

6 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2018