December 2018 - Linux-stable-mirror

[PATCH] block/bio: Do not zero user pages

by Keith Busch

We don't need to zero fill the bio if not using kernel allocated pages. Fixes: f3587d76da05 ("block: Clear kernel memory before copying to user") # v4.20-rc2 Reported-by: Todd Aiken <taiken(a)mvtech.ca> Cc: Laurence Oberman <loberman(a)redhat.com> Cc: stable(a)vger.kernel.org Cc: Bart Van Assche <bvanassche(a)acm.org> Signed-off-by: Keith Busch <keith.busch(a)intel.com> --- block/bio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/bio.c b/block/bio.c index c4ef8aa46452..55a5386fd431 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1262,7 +1262,8 @@ struct bio *bio_copy_user_iov(struct request_queue *q, if (ret) goto cleanup; } else { - zero_fill_bio(bio); + if (bmd->is_our_pages) + zero_fill_bio(bio); iov_iter_advance(iter, bio->bi_iter.bi_size); } -- 2.13.6

6 years

2
1
0 0

[PATCH 1/1] usb: dwc2: disable power_down on Amlogic devices

by Martin Blumenstingl

Disable power_down by setting the parameter to DWC2_POWER_DOWN_PARAM_NONE. This fixes a problem on various Amlogic Meson SoCs where USB devices are only recognized when plugged in before booting Linux. A hot-plugged USB device was not detected even though the device got power (my USB thumb drive for example has an LED which lit up). A similar fix was implemented for Rockchip SoCs in commit c216765d3a1def ("usb: dwc2: disable power_down on rockchip devices"). That commit suggests that a change in the dwc2 driver is the cause because the default value for the "hibernate" parameter (which then got renamed to "power_down" to support other modes) was changed in the v4.17 merge window with: commit 6d23ee9caa6790 ("Merge tag 'usb-for-v4.17' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-testing"). Cc: <stable(a)vger.kernel.org> # 4.19 Suggested-by: Christian Hewitt <christianshewitt(a)gmail.com> Signed-off-by: Martin Blumenstingl <martin.blumenstingl(a)googlemail.com> --- drivers/usb/dwc2/params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 7c1b6938f212..38c813b1d203 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -111,6 +111,7 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg) p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; + p->power_down = DWC2_POWER_DOWN_PARAM_NONE; } static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg) -- 2.19.2

6 years

3
2
0 0

PASS: Test report for kernel 4.19.9-rc1.skt+ (linux-stable-rc)

by CKI

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 131702ed5d98 Linux 4.19.9-rc1 The results of these automated tests are provided below. Overall result: PASSED Patch merge: OK Compile: OK Kernel tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 3 architectures: powerpc64: make options: make INSTALL_MOD_STRIP=1 -j56 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/131702ed5d9845c0caa329f263… aarch64: make options: make INSTALL_MOD_STRIP=1 -j56 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/131702ed5d9845c0caa329f263… x86_64: make options: make INSTALL_MOD_STRIP=1 -j56 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/131702ed5d9845c0caa329f2632… Hardware testing ---------------- We booted each kernel and ran the following tests: powerpc: Boot test - URL: https://github.com/RH-FMK/tests-beaker/archive/production.zip#distribution/… LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#distribu… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… /kernel/misc/amtu - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#misc/amtu arm64: Boot test - URL: https://github.com/RH-FMK/tests-beaker/archive/production.zip#distribution/… LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#distribu… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… /kernel/misc/amtu - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#misc/amtu x86_64: Boot test - URL: https://github.com/RH-FMK/tests-beaker/archive/production.zip#distribution/… LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#distribu… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#/filesys… /kernel/misc/amtu - URL: https://github.com/CKI-project/tests-beaker/archive/production.zip#misc/amtu

6 years

1
0
0 0

[PATCH] ARC: [zebu] Remove CONFIG_INITRAMFS_SOURCE from defconfigs

by Alexey Brodkin

Zebu boards were added in v4.9 and then renamed to "haps" in v4.10. Thus backporting commit 64234961c145 (ARC: configs: Remove CONFIG_INITRAMFS_SOURCE from defconfigs) we missed "zebu" defconfigs in v4.9. Note this is only applicable to "linux-4.9.y"! Spotted by KerneCI, see [1]. [1] https://storage.kernelci.org/stable/linux-4.9.y/v4.9.144/arc/zebu_hs_smp_de… Signed-off-by: Alexey Brodkin <abrodkin(a)synopsys.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Kevin Hilman <khilman(a)baylibre.com> --- arch/arc/configs/zebu_hs_defconfig | 1 - arch/arc/configs/zebu_hs_smp_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/arc/configs/zebu_hs_defconfig b/arch/arc/configs/zebu_hs_defconfig index 9f6166be7145..3346829b02bb 100644 --- a/arch/arc/configs/zebu_hs_defconfig +++ b/arch/arc/configs/zebu_hs_defconfig @@ -11,7 +11,6 @@ CONFIG_NAMESPACES=y # CONFIG_UTS_NS is not set # CONFIG_PID_NS is not set CONFIG_BLK_DEV_INITRD=y -CONFIG_INITRAMFS_SOURCE="../../arc_initramfs_hs/" CONFIG_EXPERT=y CONFIG_PERF_EVENTS=y # CONFIG_COMPAT_BRK is not set diff --git a/arch/arc/configs/zebu_hs_smp_defconfig b/arch/arc/configs/zebu_hs_smp_defconfig index 44e9693f4257..4471f9c37d7e 100644 --- a/arch/arc/configs/zebu_hs_smp_defconfig +++ b/arch/arc/configs/zebu_hs_smp_defconfig @@ -11,7 +11,6 @@ CONFIG_NAMESPACES=y # CONFIG_UTS_NS is not set # CONFIG_PID_NS is not set CONFIG_BLK_DEV_INITRD=y -CONFIG_INITRAMFS_SOURCE="../../arc_initramfs_hs/" CONFIG_EMBEDDED=y CONFIG_PERF_EVENTS=y # CONFIG_VM_EVENT_COUNTERS is not set -- 2.16.2

6 years

2
1
0 0

Re: Process for severe early stable bugs?

by Greg KH

On Sun, Dec 09, 2018 at 11:44:19AM -0500, Theodore Y. Ts'o wrote: > On Sun, Dec 09, 2018 at 12:30:39PM +0100, Greg KH wrote: > > > P.P.P.S. If I were king, I'd be asking for a huge number of kunit > > > tests for block-mq to be developed, and then running them under a > > > Thread Sanitizer. > > > > Isn't that what xfs and fio is? Aren't we running this all the time and > > reporting those issues? How did this bug not show up on those tests, is > > it just because they didn't run long enough? > > > > Because of those test suites, I was thinking that the block and > > filesystem paths were one of the more well-tested things we had at the > > moment, is this not true? > > I'm pretty confident about the file system paths, and the "happy > paths" for the block layer. > > But with Kernel Bugzilla #201685, despite huge amounts both before and > after 4.19-rc1, nothing picked it up. It turned out to be very > configuration specific, *and* only happened when you were under heavy > memory pressure and/or I/O pressure. > > I'm starting to try to use blktests, but it's not as mature as > xfstests. It has portability issues, as it assumes a much newer > userspace. So I can't even run it under some environments at all. > The test coverage just isn't as broad. Compare: > > ext4/4k: 441 tests, 1 failures, 42 skipped, 4387 seconds > Failures: generic/388 > > Versus: > > Run: block/001 block/002 block/003 block/004 block/005 block/006 > block/009 block/010 block/012 block/013 block/014 block/015 > block/016 block/017 block/018 block/020 block/021 block/023 > block/024 loop/001 loop/002 loop/003 loop/004 loop/005 loop/006 > nvme/002 nvme/003 nvme/004 nvme/006 nvme/007 nvme/008 nvme/009 > nvme/010 nvme/011 nvme/012 nvme/013 nvme/014 nvme/015 nvme/016 > nvme/017 nvme/019 nvme/020 nvme/021 nvme/022 nvme/023 nvme/024 > nvme/025 nvme/026 nvme/027 nvme/028 scsi/001 scsi/002 scsi/003 > scsi/004 scsi/005 scsi/006 srp/001 srp/002 srp/003 srp/004 > srp/005 srp/006 srp/007 srp/008 srp/009 srp/010 srp/011 srp/012 srp/013 > Failures: block/017 block/024 nvme/002 nvme/003 nvme/008 nvme/009 > nvme/010 nvme/011 nvme/012 nvme/013 nvme/014 nvme/015 nvme/016 > nvme/019 nvme/020 nvme/021 nvme/022 nvme/023 nvme/024 nvme/025 > nvme/026 nvme/027 nvme/028 scsi/006 srp/001 srp/002 srp/003 srp/004 > srp/005 srp/006 srp/007 srp/008 srp/009 srp/010 srp/011 srp/012 srp/013 > Failed 37 of 69 tests > > (Most of the failures are test portability issues that I still need to > work through, not real failures. But just look at the number of > tests....) So you are saying quantity rules over quantity? :) It's really hard to judge this, given that xfstests are testing a whole range of other things (POSIX compliance and stressing the vfs api), while blktests are there to stress the block i/o api/interface. So both would be best to run as we know xfstests also hits the block layer... thanks, greg k-h

6 years

1
0
0 0

[PATCH] USB: serial: option: add HP lt4132

by Tore Anderson

The HP lt4132 is a rebranded Huawei ME906s-158 LTE modem. The interface with protocol 0x16 is "CDC ECM & NCM" according to the *.inf files included with the Windows driver. Attaching the option driver to it doesn't result in a /dev/ttyUSB* device being created, so I've excluded it. Note that it is also excluded for corresponding Huawei-branded devices, cf. commit d544db293a44a. T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=06 Prot=10 Driver=option I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=13 Driver=option I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=12 Driver=option I: If#=0x3 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=06 Prot=16 Driver=(none) I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=1b Driver=option T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 7 Cfg#= 2 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether I: If#=0x1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=06 Prot=00 Driver=cdc_ether I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=06 Prot=10 Driver=option I: If#=0x3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=13 Driver=option I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=12 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option I: If#=0x6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=1b Driver=option T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 3 Cfg#= 3 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option Signed-off-by: Tore Anderson <tore(a)fud.no> Cc: stable(a)vger.kernel.org --- drivers/usb/serial/option.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index e24ff16d4147..1a6fa4726def 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -552,6 +552,10 @@ static void option_instat_callback(struct urb *urb); #define WETELECOM_PRODUCT_6802 0x6802 #define WETELECOM_PRODUCT_WMD300 0x6803 +/* HP products */ +#define HP_VENDOR_ID 0x03f0 +#define HP_PRODUCT_LT4132 0xa31d /* Huawei ME906s-158 */ + /* Device flags */ @@ -1941,6 +1945,11 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x10) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x12) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x13) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x14) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x1b) }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids); -- 2.19.2

6 years

2
1
0 0

Fwd:Payment Swift $128.905.05

by Stephanie Nicholl

Good day! Kindly see attached T/T payment copy for your reference and kind confirmation.Details of paid Invoice are as follows; 1)inv no.AMB -129st =$21,742.41 2)inv no.AMB -130st =$26,607.14 3)inv no.AMB-131st =$27,614.74 4)inv no. AMB-132st =$33,782.26 5)inv no.AMB-133st =$19,158.50 ============= Total amt us$128,905.05 ============= Please confirm receipt of payment by a return mail. Regards, Chuck Coote Accounting Services Crate Designs Ltd. chuck(a)crate.ca P.O Box 460 87 7th St. S. W.Chesley, Ontario N0G 1L0 Tel: 519 363 3221 Fax 519 363 2509

6 years

1
0
0 0

stable-rc/linux-4.19.y boot: 116 boots: 1 failed, 106 passed with 8 offline, 1 untried/unknown (v4.19.8-57-g131702ed5d98)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 116 boots: 1 failed, 106 passed with 8 offline, 1 untried/unknown (v4.19.8-57-g131702ed5d98) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.8-57-… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.8-57-g131702ed5d98 Git Commit: 131702ed5d9845c0caa329f263246f00b71e3bb9 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 62 unique boards, 23 SoC families, 12 builds out of 202 Boot Regressions Detected: arm64: defconfig: rk3399-firefly: lab-baylibre-seattle: failing since 1 day (last pass: v4.19.7-42-g62b84b3cf313 - first fail: v4.19.8) Boot Failure Detected: arm64: defconfig rk3399-firefly: 1 failed lab Offline Platforms: arm: imx_v6_v7_defconfig: vf610-colibri-eval-v3: 1 offline lab mvebu_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab multi_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab stih410-b2120: 1 offline lab tegra30-beaver: 1 offline lab vf610-colibri-eval-v3: 1 offline lab zynq-zc702: 1 offline lab tegra_defconfig: tegra30-beaver: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

stable-rc/linux-3.18.y boot: 53 boots: 1 failed, 47 passed with 5 offline (v3.18.128-41-g5c19427b8dec)

by kernelci.org bot

stable-rc/linux-3.18.y boot: 53 boots: 1 failed, 47 passed with 5 offline (v3.18.128-41-g5c19427b8dec) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-3.18.y/kernel/v3.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-3.18.y/kernel/v3.18.128-4… Tree: stable-rc Branch: linux-3.18.y Git Describe: v3.18.128-41-g5c19427b8dec Git Commit: 5c19427b8dec43f611737e157ffe5266e799d9a7 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 22 unique boards, 11 SoC families, 11 builds out of 185 Boot Failure Detected: arm: exynos_defconfig exynos4412-odroidx2: 1 failed lab Offline Platforms: arm: mvebu_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab multi_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab tegra30-beaver: 1 offline lab zynq-zc702: 1 offline lab tegra_defconfig: tegra30-beaver: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

stable-rc/linux-4.14.y boot: 115 boots: 1 failed, 106 passed with 8 offline (v4.14.87-32-g821c2828db01)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 115 boots: 1 failed, 106 passed with 8 offline (v4.14.87-32-g821c2828db01) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.87-32… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.87-32-g821c2828db01 Git Commit: 821c2828db01d33b7c45774e0cb6942c0d27e6de Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 60 unique boards, 23 SoC families, 12 builds out of 197 Boot Regressions Detected: arm64: defconfig: rk3399-firefly: lab-baylibre-seattle: failing since 1 day (last pass: v4.14.86-56-g555f40d53cca - first fail: v4.14.87) Boot Failure Detected: arm64: defconfig rk3399-firefly: 1 failed lab Offline Platforms: arm: imx_v6_v7_defconfig: vf610-colibri-eval-v3: 1 offline lab mvebu_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab multi_v7_defconfig: armada-xp-openblocks-ax3-4: 1 offline lab stih410-b2120: 1 offline lab tegra30-beaver: 1 offline lab vf610-colibri-eval-v3: 1 offline lab zynq-zc702: 1 offline lab tegra_defconfig: tegra30-beaver: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror December 2018