November 2018 - Linux-stable-mirror

Re: [alsa-devel] [PATCH 2/2] ALSA: sparc: Fix invalid snd_free_pages() at error path

by Takashi Sakamoto

On Fri, Nov 23, 2018 at 06:19:56PM +0100, Takashi Iwai wrote: > Some spurious calls of snd_free_pages() have been overlooked and > remain in the error paths of sparc cs4231 driver code. Since > runtime->dma_area is managed by the PCM core helper, we shouldn't > release manually. > > Drop the superfluous calls. > > Cc: <stable(a)vger.kernel.org> > Signed-off-by: Takashi Iwai <tiwai(a)suse.de> > --- > sound/sparc/cs4231.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/sound/sparc/cs4231.c b/sound/sparc/cs4231.c > index e73c962590eb..079063d8038d 100644 > --- a/sound/sparc/cs4231.c > +++ b/sound/sparc/cs4231.c > @@ -1146,10 +1146,8 @@ static int snd_cs4231_playback_open(struct snd_pcm_substream *substream) > runtime->hw = snd_cs4231_playback; > > err = snd_cs4231_open(chip, CS4231_MODE_PLAY); > - if (err < 0) { > - snd_free_pages(runtime->dma_area, runtime->dma_bytes); > + if (err < 0) > return err; > - } > chip->playback_substream = substream; > chip->p_periods_sent = 0; > snd_pcm_set_sync(substream); > @@ -1167,10 +1165,8 @@ static int snd_cs4231_capture_open(struct snd_pcm_substream *substream) > runtime->hw = snd_cs4231_capture; > > err = snd_cs4231_open(chip, CS4231_MODE_RECORD); > - if (err < 0) { > - snd_free_pages(runtime->dma_area, runtime->dma_bytes); > + if (err < 0) > return err; > - } > chip->capture_substream = substream; > chip->c_periods_sent = 0; > snd_pcm_set_sync(substream); > -- > 2.19.1 Reviewed-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> Regards Takashi Sakamoto > _______________________________________________ > Alsa-devel mailing list > Alsa-devel(a)alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

6 years, 1 month

1
0
0 0

stable/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.140)

by kernelci.org bot

stable/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.140) Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.9.y/kernel/v4.9.140/ Tree: stable Branch: linux-4.9.y Git Describe: v4.9.140 Git Commit: e186413178a3d6a4d5c92ef5bced2e0b589a4649 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 5 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL zebu_hs_defconfig: FAIL zebu_hs_smp_defconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

stable-rc/linux-4.9.y build: 117 builds: 4 failed, 113 passed (v4.9.140)

by kernelci.org bot

stable-rc/linux-4.9.y build: 117 builds: 4 failed, 113 passed (v4.9.140) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.140/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.140 Git Commit: e186413178a3d6a4d5c92ef5bced2e0b589a4649 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 3 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL zebu_hs_defconfig: FAIL zebu_hs_smp_defconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

v4.19.4 build: 0 failures 4 warnings (v4.19.4)

by Build bot for Mark Brown

Tree/Branch: v4.19.4 Git describe: v4.19.4 Commit: 98a661ea85 Linux 4.19.4 Build Time: 124 min 20 sec Passed: 11 / 11 (100.00 %) Failed: 0 / 11 ( 0.00 %) Errors: 0 Warnings: 4 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : x86_64-allmodconfig 1 warnings 0 mismatches : arm64-allmodconfig 1 warnings 0 mismatches : arm-allmodconfig 1 warnings 0 mismatches : arm-multi_v5_defconfig 1 warnings 0 mismatches : x86_64-defconfig ------------------------------------------------------------------------------- Warnings Summary: 4 2 ../drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=] 1 ../drivers/staging/erofs/unzip_vle.c:186:29: warning: array subscript is above array bounds [-Warray-bounds] 1 ../drivers/isdn/hardware/eicon/message.c:5985:1: warning: the frame size of 2064 bytes is larger than 2048 bytes [-Wframe-larger-than=] 1 ../drivers/i2c/busses/i2c-aspeed.c:567:1: warning: label 'out' defined but not used [-Wunused-label] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- x86_64-allmodconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=] ------------------------------------------------------------------------------- arm64-allmodconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/isdn/hardware/eicon/message.c:5985:1: warning: the frame size of 2064 bytes is larger than 2048 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- arm-allmodconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/staging/erofs/unzip_vle.c:186:29: warning: array subscript is above array bounds [-Warray-bounds] ------------------------------------------------------------------------------- arm-multi_v5_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/i2c/busses/i2c-aspeed.c:567:1: warning: label 'out' defined but not used [-Wunused-label] ------------------------------------------------------------------------------- x86_64-defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm-multi_v7_defconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig

6 years, 1 month

1
0
0 0

[PATCH] test_kmod: fix rmmod double free

by Luis Chamberlain

We double free the misc device string twice on rmmod, fix this. Without this we cannot remove the module without crashing. Cc: <stable(a)vger.kernel.org> # for v4.12 and up Reported-by: Randy Dunlap <rdunlap(a)infradead.org> Signed-off-by: Luis Chamberlain <mcgrof(a)kernel.org> --- lib/test_kmod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/test_kmod.c b/lib/test_kmod.c index e3ddd836491f..d82d022111e0 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -1214,7 +1214,6 @@ void unregister_test_dev_kmod(struct kmod_test_device *test_dev) dev_info(test_dev->dev, "removing interface\n"); misc_deregister(&test_dev->misc_dev); - kfree(&test_dev->misc_dev.name); mutex_unlock(&test_dev->config_mutex); mutex_unlock(&test_dev->trigger_mutex); -- 2.19.1

6 years, 1 month

1
0
0 0

stable/linux-4.14.y build: 197 builds: 2 failed, 195 passed (v4.14.83)

by kernelci.org bot

stable/linux-4.14.y build: 197 builds: 2 failed, 195 passed (v4.14.83) Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.14.y/kernel/v4.14.83/ Tree: stable Branch: linux-4.14.y Git Describe: v4.14.83 Git Commit: 1d4bd2e4e1d26c5384d52ca4a1953cb0cfc934f1 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 5 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

stable-rc/linux-4.14.y build: 197 builds: 2 failed, 195 passed (v4.14.83)

by kernelci.org bot

stable-rc/linux-4.14.y build: 197 builds: 2 failed, 195 passed (v4.14.83) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.83/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.83 Git Commit: 1d4bd2e4e1d26c5384d52ca4a1953cb0cfc934f1 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 5 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

stable-rc/linux-4.19.y build: 202 builds: 2 failed, 200 passed (v4.19.4)

by kernelci.org bot

stable-rc/linux-4.19.y build: 202 builds: 2 failed, 200 passed (v4.19.4) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.4/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.4 Git Commit: 98a661ea85a8b46aa3e4bff1d900e289011e2d2a Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 6 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

stable/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.139)

by kernelci.org bot

stable/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.139) Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.9.y/kernel/v4.9.139/ Tree: stable Branch: linux-4.9.y Git Describe: v4.9.139 Git Commit: 44caf8b34625267f5b7227391551a4064e5fa0f7 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Built: 5 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL zebu_hs_defconfig: FAIL zebu_hs_smp_defconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

stable-rc/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.139)

by kernelci.org bot

stable-rc/linux-4.9.y build: 193 builds: 4 failed, 189 passed (v4.9.139) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.139/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.139 Git Commit: 44caf8b34625267f5b7227391551a4064e5fa0f7 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 5 unique architectures Build Failures Detected: arc: gcc version 7.1.1 20170710 (ARCv2 ISA Linux uClibc toolchain 2017.09) allnoconfig: FAIL tinyconfig: FAIL zebu_hs_defconfig: FAIL zebu_hs_smp_defconfig: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 1 month

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror November 2018