December 2017 - Linux-stable-mirror

[Linux-stable-mirror] v3.18.86 build: 0 failures 1 warnings (v3.18.86)

by Build bot for Mark Brown

Tree/Branch: v3.18.86 Git describe: v3.18.86 Commit: 1d2acf22c2 Linux 3.18.86 Build Time: 67 min 20 sec Passed: 9 / 9 (100.00 %) Failed: 0 / 9 ( 0.00 %) Errors: 0 Warnings: 1 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 2 warnings 0 mismatches : x86_64-defconfig ------------------------------------------------------------------------------- Warnings Summary: 1 2 ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- x86_64-defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] ../include/linux/ftrace.h:632:36: warning: calling '__builtin_return_address' with a nonzero argument is unsafe [-Wframe-address] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

6 years, 11 months

3
4
0 0

[Linux-stable-mirror] [PATCH] rpmsg: virtio_rpmsg_bus: fix rpmsg_probe() for virtio-mmio transport

by Anup Patel

When virtio-rpmsg device is provided via virtio-mmio transport, the dma_alloc_coherent() (called by rpmsg_probe()) fails on ARM/ARM64 systems because "vdev->dev.parent->parent" device is used as parameter to dma_alloc_coherent(). The "vdev->dev.parent->parent" device represents underlying remoteproc platform device when virtio-rpmsg device is provided via virtio-remoteproc transport. When virtio-rpmsg device is provided via virtio-mmio transport, the "vdev->dev.parent->parent" device represents the parent device of virtio-mmio platform device and dma_alloc_coherent() fails for this device because generally there is no corresponding platform device and dma_ops are not setup for "vdev->dev.parent->parent". This patch fixes dma_alloc_coherent() usage in rpmsg_probe() by trying dma_alloc_coherent() with "vdev->dev.parent" device when it fails with "vdev->dev.parent->parent" device. Fixes: b5ab5e24e960 ("remoteproc: maintain a generic child device for each rproc") Signed-off-by: Anup Patel <anup(a)brainfault.org> Cc: stable(a)vger.kernel.org --- drivers/rpmsg/virtio_rpmsg_bus.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 82b8300..7f8710a 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -64,6 +64,7 @@ struct virtproc_info { struct virtio_device *vdev; struct virtqueue *rvq, *svq; + struct device *bufs_dev; void *rbufs, *sbufs; unsigned int num_bufs; unsigned int buf_size; @@ -924,9 +925,16 @@ static int rpmsg_probe(struct virtio_device *vdev) total_buf_space, &vrp->bufs_dma, GFP_KERNEL); if (!bufs_va) { - err = -ENOMEM; - goto vqs_del; - } + bufs_va = dma_alloc_coherent(vdev->dev.parent, + total_buf_space, &vrp->bufs_dma, + GFP_KERNEL); + if (!bufs_va) { + err = -ENOMEM; + goto vqs_del; + } else + vrp->bufs_dev = vdev->dev.parent; + } else + vrp->bufs_dev = vdev->dev.parent->parent; dev_dbg(&vdev->dev, "buffers: va %p, dma %pad\n", bufs_va, &vrp->bufs_dma); @@ -988,7 +996,7 @@ static int rpmsg_probe(struct virtio_device *vdev) return 0; free_coherent: - dma_free_coherent(vdev->dev.parent->parent, total_buf_space, + dma_free_coherent(vrp->bufs_dev, total_buf_space, bufs_va, vrp->bufs_dma); vqs_del: vdev->config->del_vqs(vrp->vdev); @@ -1023,7 +1031,7 @@ static void rpmsg_remove(struct virtio_device *vdev) vdev->config->del_vqs(vrp->vdev); - dma_free_coherent(vdev->dev.parent->parent, total_buf_space, + dma_free_coherent(vrp->bufs_dev, total_buf_space, vrp->rbufs, vrp->bufs_dma); kfree(vrp); -- 2.7.4

6 years, 11 months

1
1
0 0

[Linux-stable-mirror] [PATCH 1/3] x86/tsc: Future-proof native_calibrate_tsc()

by Len Brown

From: Len Brown <len.brown(a)intel.com> If native_calibrate_tsc() can not discover the TSC frequency, via CPUID or via built-in table, it must return without setting X86_FEATURE_TSC_KNOWN_FREQ. Otherwise, X86_FEATURE_TSC_KNOWN_FREQ will prevent TSC refined calibration. This patch allows Linux to correctly support future Intel hardware, that has (cpu_khz != tsc_khz), and support for CPUID.15 without support for CPUID.15.crystal_khz. This patch is needed since X86_FEATURE_TSC_KNOWN_FREQ was added in Linux-4.10: commit 4ca4df0b7eb0 ("x86/tsc: Mark TSC frequency determined by CPUID as known") If not applied, such systems will run with tsc_khz = cpu_khz, which may result in under-stated TSC rate, and time-of-day drift. Signed-off-by: Len Brown <len.brown(a)intel.com> Cc: Bin Gao <bin.gao(a)intel.com> Cc: <stable(a)vger.kernel.org> # v4.10+ --- arch/x86/kernel/tsc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 8ea117f8142e..ce4b71119c36 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -612,6 +612,8 @@ unsigned long native_calibrate_tsc(void) } } + if (crystal_khz == 0) + return 0; /* * TSC frequency determined by CPUID is a "hardware reported" * frequency and is the most accurate one so far we have. This -- 2.14.0-rc0

6 years, 11 months

2
3
0 0

[Linux-stable-mirror] [PATCH 2/3] x86/tsc: Fix erroneous TSC rate on Skylake Xeon

by Len Brown

From: Len Brown <len.brown(a)intel.com> Linux-4.9 added INTEL_FAM6_SKYLAKE_X to native_calibrate_tsc(), allowing the kernel to calculate the TSC frequency, instead of calibrating: commit 6baf3d61821f ("x86/tsc: Add additional Intel CPU models to the crystal quirk list") There are several problems with doing this. The first is that while SKX servers use a 25 MHz crystal, SKX workstations (with same model #) use a 24 MHz crystal. This results in a -4.0% time drift rate on SKX workstations. But even SKX servers have a problem. SKX subjects the crystal to an EMI reduction circuit that reduces its actual value by (approximately) -0.25%. This results in -1 second per 10 minute time drift as compared to network time on SKX servers. This also results in an even more subtle symptom on systems that use the LAPIC timer (versus the TSC deadline timer). Clock ticks scheduled with the LAPIC timer arrive a few usec before the time they are expected (according to the slow TSC). This causes Linux to poll-idle, when it should be in an idle power saving state. The idle and clock code do not graciously recover from this error, sometimes resulting in significant polling and significant power impact. So stop using native_calibrate_tsc() for INTEL_FAM6_SKYLAKE_X. native_calibrate_tsc() will return 0, boot will run with tsc_khz = cpu_khz, and the TSC refined calibration will update tsc_khz to correct for the difference. Yes, a future patch can detect 24 vs 25 MHz crystals, and it can estimate a correction for the EMI circuit impact. However, that would effect boot-time only, as we'd probably choose to keep the refined TSC calibration, because the EMI correction estimate may not be precise. Signed-off-by: Len Brown <len.brown(a)intel.com> Cc: Prarit Bhargava <prarit(a)redhat.com> Cc: <stable(a)vger.kernel.org> # v4.9+ --- arch/x86/kernel/tsc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index 49d772672367..19ca0004caf6 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -602,7 +602,6 @@ unsigned long native_calibrate_tsc(void) case INTEL_FAM6_KABYLAKE_DESKTOP: crystal_khz = 24000; /* 24.0 MHz */ break; - case INTEL_FAM6_SKYLAKE_X: case INTEL_FAM6_ATOM_DENVERTON: crystal_khz = 25000; /* 25.0 MHz */ break; -- 2.14.0-rc0

6 years, 11 months

2
1
0 0

[Linux-stable-mirror] [PATCH 4.14 00/74] 4.14.10-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.10 release. There are 74 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri Dec 29 16:45:52 UTC 2017. Anything received after that time might be too late. The whole patch series can be found in one patch at: kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.10-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.14.10-rc1 John Einar Reitan <john.einar(a)gmail.com> Revert "ipmi_si: fix memory leak on new_smi" Yelena Krivosheev <yelena(a)marvell.com> net: mvneta: eliminate wrong call to handle rx descriptor error Yelena Krivosheev <yelena(a)marvell.com> net: mvneta: use proper rxq_number in loop on rx queues Yelena Krivosheev <yelena(a)marvell.com> net: mvneta: clear interface link status on port disable Dan Williams <dan.j.williams(a)intel.com> libnvdimm, pfn: fix start_pad handling for aligned namespaces Vishal Verma <vishal.l.verma(a)intel.com> libnvdimm, btt: Fix an incompatibility in the log layout Dan Williams <dan.j.williams(a)intel.com> libnvdimm, dax: fix 1GB-aligned namespaces vs physical misalignment Maxime Ripard <maxime.ripard(a)free-electrons.com> drm/sun4i: Fix error path handling Chris Wilson <chris(a)chris-wilson.co.uk> drm/i915: Flush pending GTT writes before unbinding Ravi Bangoria <ravi.bangoria(a)linux.vnet.ibm.com> powerpc/perf: Dereference BHRB entries safely Chen-Yu Tsai <wens(a)csie.org> clk: sunxi: sun9i-mmc: Implement reset callback for reset controls Paolo Bonzini <pbonzini(a)redhat.com> kvm: x86: fix RSM when PCID is non-zero Wanpeng Li <wanpeng.li(a)hotmail.com> KVM: X86: Fix load RFLAGS w/o the fixed bit Wanpeng Li <wanpeng.li(a)hotmail.com> KVM: MMU: Fix infinite loop when there is no available mmu page Laurent Vivier <lvivier(a)redhat.com> KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp() Cédric Le Goater <clg(a)kaod.org> KVM: PPC: Book3S: fix XIVE migration of pending interrupts Marc Zyngier <marc.zyngier(a)arm.com> KVM: arm/arm64: Fix HYP unmapping going off limits Julien Thierry <julien.thierry(a)arm.com> arm64: kvm: Prevent restoring stale PMSCR_EL1 for vcpu Mika Westerberg <mika.westerberg(a)linux.intel.com> pinctrl: cherryview: Mask all interrupts on Intel_Strago based systems Maxime Chevallier <maxime.chevallier(a)smile.fr> spi: a3700: Fix clk prescaling for coefficient over 15 Ricardo Ribalda Delgado <ricardo.ribalda(a)gmail.com> spi: xilinx: Detect stall with Unknown commands John David Anglin <dave.anglin(a)bell.net> Revert "parisc: Re-enable interrupts early" Helge Deller <deller(a)gmx.de> parisc: Hide Diva-built-in serial aux and graphics card Helge Deller <deller(a)gmx.de> parisc: Fix indenting in puts() Helge Deller <deller(a)gmx.de> parisc: Align os_hpmc_size on word boundary Shaohua Li <shli(a)fb.com> block-throttle: avoid double charge Jens Axboe <axboe(a)kernel.dk> block: unalign call_single_data in struct request Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> PCI / PM: Force devices to D0 in pci_pm_thaw_noirq() Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Fix the missing ctl name suffix at parsing SU Jussi Laako <jussi(a)sonarnerd.net> ALSA: usb-audio: Add native DSD support for Esoteric D-05X Guneshwor Singh <guneshwor.o.singh(a)intel.com> ALSA: hda - Add vendor id for Cannonlake HDMI codec Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Fix Dell AIO LineOut issue Takashi Iwai <tiwai(a)suse.de> ALSA: rawmidi: Avoid racy info ioctl via ctl device Johan Hovold <johan(a)kernel.org> mfd: twl6040: Fix child-node lookup Johan Hovold <johan(a)kernel.org> mfd: twl4030-audio: Fix sibling-node lookup Jon Hunter <jonathanh(a)nvidia.com> mfd: cros ec: spi: Don't send first message too soon Stephan Mueller <smueller(a)chronox.de> crypto: af_alg - fix race accessing cipher request Stephan Mueller <smueller(a)chronox.de> crypto: af_alg - wait for data at beginning of recvmsg Sebastian Andrzej Siewior <bigeasy(a)linutronix.de> crypto: mcryptd - protect the per-CPU queue with a lock Eric Biggers <ebiggers(a)google.com> crypto: skcipher - set walk.iv for zero-length inputs Dan Williams <dan.j.williams(a)intel.com> acpi, nfit: fix health event notification Takashi Iwai <tiwai(a)suse.de> ACPI: APEI / ERST: Fix missing error handling in erst_reader() Thomas Gleixner <tglx(a)linutronix.de> x86/cpu_entry_area: Prevent wraparound in setup_cpu_entry_area_ptes() on 32bit Thomas Gleixner <tglx(a)linutronix.de> init: Invoke init_espfix_bsp() from mm_init() Thomas Gleixner <tglx(a)linutronix.de> x86/cpu_entry_area: Move it out of the fixmap Thomas Gleixner <tglx(a)linutronix.de> x86/cpu_entry_area: Move it to a separate unit Peter Zijlstra <peterz(a)infradead.org> x86/mm: Create asm/invpcid.h Dave Hansen <dave.hansen(a)linux.intel.com> x86/mm: Put MMU to hardware ASID translation in one place Dave Hansen <dave.hansen(a)linux.intel.com> x86/mm: Remove hard-coded ASID limit checks Dave Hansen <dave.hansen(a)linux.intel.com> x86/mm: Move the CR3 construction functions to tlbflush.h Peter Zijlstra <peterz(a)infradead.org> x86/mm: Add comments to clarify which TLB-flush functions are supposed to flush what Peter Zijlstra <peterz(a)infradead.org> x86/mm: Remove superfluous barriers Peter Zijlstra <peterz(a)infradead.org> x86/mm: Use __flush_tlb_one() for kernel memory Peter Zijlstra <peterz(a)infradead.org> x86/microcode: Dont abuse the TLB-flush interface Peter Zijlstra <peterz(a)infradead.org> x86/uv: Use the right TLB-flush API Dave Hansen <dave.hansen(a)linux.intel.com> x86/entry: Rename SYSENTER_stack to CPU_ENTRY_AREA_entry_stack Peter Zijlstra <peterz(a)infradead.org> x86/doc: Remove obvious weirdnesses from the x86 MM layout documentation Andy Lutomirski <luto(a)kernel.org> x86/mm/64: Improve the memory map documentation Thomas Gleixner <tglx(a)linutronix.de> x86/ldt: Prevent LDT inheritance on exec Peter Zijlstra <peterz(a)infradead.org> x86/ldt: Rework locking Thomas Gleixner <tglx(a)linutronix.de> arch, mm: Allow arch_dup_mmap() to fail Andy Lutomirski <luto(a)kernel.org> x86/vsyscall/64: Warn and fail vsyscall emulation in NATIVE mode Andy Lutomirski <luto(a)kernel.org> x86/vsyscall/64: Explicitly set _PAGE_USER in the pagetable hierarchy Thomas Gleixner <tglx(a)linutronix.de> x86/mm/dump_pagetables: Make the address hints correct and readable Thomas Gleixner <tglx(a)linutronix.de> x86/mm/dump_pagetables: Check PAGE_PRESENT for real Thomas Gleixner <tglx(a)linutronix.de> x86/Kconfig: Limit NR_CPUS on 32-bit to a sane amount Ricardo Neri <ricardo.neri-calderon(a)linux.intel.com> x86/insn-eval: Add utility functions to get segment selector Randy Dunlap <rdunlap(a)infradead.org> x86/decoder: Fix and update the opcodes map Mikulas Patocka <mpatocka(a)redhat.com> objtool: Fix 64-bit build on 32-bit host Ingo Molnar <mingo(a)kernel.org> tools/headers: Sync objtool UAPI header Josh Poimboeuf <jpoimboe(a)redhat.com> objtool: Fix cross-build Josh Poimboeuf <jpoimboe(a)redhat.com> objtool: Move kernel headers/code sync check to a script Josh Poimboeuf <jpoimboe(a)redhat.com> objtool: Move synced files to their original relative locations Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "ipv6: grab rt->rt6i_ref before allocating pcpu rt" ------------- Diffstat: Documentation/x86/x86_64/mm.txt | 24 ++- Makefile | 4 +- arch/arm64/kvm/hyp/debug-sr.c | 3 + arch/parisc/boot/compressed/misc.c | 4 +- arch/parisc/kernel/entry.S | 12 +- arch/parisc/kernel/hpmc.S | 1 + arch/powerpc/include/asm/mmu_context.h | 5 +- arch/powerpc/kvm/book3s_xive.c | 7 +- arch/powerpc/perf/core-book3s.c | 8 +- arch/um/include/asm/mmu_context.h | 3 +- arch/unicore32/include/asm/mmu_context.h | 5 +- arch/x86/Kconfig | 3 +- arch/x86/entry/entry_32.S | 12 +- arch/x86/entry/entry_64.S | 4 +- arch/x86/entry/vsyscall/vsyscall_64.c | 38 +++- arch/x86/include/asm/cpu_entry_area.h | 68 +++++++ arch/x86/include/asm/desc.h | 1 + arch/x86/include/asm/espfix.h | 7 +- arch/x86/include/asm/fixmap.h | 71 +------- arch/x86/include/asm/inat.h | 10 + arch/x86/include/asm/invpcid.h | 53 ++++++ arch/x86/include/asm/mmu.h | 4 +- arch/x86/include/asm/mmu_context.h | 54 ++---- arch/x86/include/asm/pgtable_32_types.h | 15 +- arch/x86/include/asm/pgtable_64_types.h | 47 +++-- arch/x86/include/asm/processor.h | 6 +- arch/x86/include/asm/stacktrace.h | 4 +- arch/x86/include/asm/tlbflush.h | 136 +++++++------- arch/x86/kernel/asm-offsets.c | 4 +- arch/x86/kernel/asm-offsets_32.c | 2 +- arch/x86/kernel/cpu/common.c | 100 +--------- arch/x86/kernel/cpu/microcode/intel.c | 13 -- arch/x86/kernel/dumpstack.c | 11 +- arch/x86/kernel/dumpstack_32.c | 6 +- arch/x86/kernel/dumpstack_64.c | 12 +- arch/x86/kernel/ldt.c | 47 ++--- arch/x86/kernel/smpboot.c | 6 +- arch/x86/kernel/traps.c | 6 +- arch/x86/kvm/emulate.c | 32 +++- arch/x86/kvm/mmu.c | 8 +- arch/x86/kvm/x86.c | 2 +- arch/x86/lib/x86-opcode-map.txt | 13 +- arch/x86/mm/Makefile | 2 +- arch/x86/mm/cpu_entry_area.c | 139 ++++++++++++++ arch/x86/mm/dump_pagetables.c | 98 ++++++---- arch/x86/mm/init_32.c | 6 + arch/x86/mm/kasan_init_64.c | 29 +-- arch/x86/mm/pgtable_32.c | 1 + arch/x86/mm/tlb.c | 10 +- arch/x86/platform/uv/tlb_uv.c | 2 +- arch/x86/xen/mmu_pv.c | 2 - block/bio.c | 2 + block/blk-throttle.c | 8 +- crypto/af_alg.c | 6 - crypto/algif_aead.c | 16 +- crypto/algif_skcipher.c | 16 +- crypto/mcryptd.c | 23 +-- crypto/skcipher.c | 10 +- drivers/acpi/apei/erst.c | 2 +- drivers/acpi/nfit/core.c | 9 +- drivers/char/ipmi/ipmi_si_intf.c | 1 - drivers/clk/sunxi/clk-sun9i-mmc.c | 12 ++ drivers/gpu/drm/i915/i915_gem.c | 9 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +- drivers/mfd/cros_ec_spi.c | 1 + drivers/mfd/twl4030-audio.c | 9 +- drivers/mfd/twl6040.c | 12 +- drivers/net/ethernet/marvell/mvneta.c | 8 +- drivers/nvdimm/btt.c | 201 +++++++++++++++++---- drivers/nvdimm/btt.h | 45 ++++- drivers/nvdimm/pfn_devs.c | 20 +- drivers/parisc/lba_pci.c | 33 ++++ drivers/pci/pci-driver.c | 7 +- drivers/pinctrl/intel/pinctrl-cherryview.c | 16 ++ drivers/spi/spi-armada-3700.c | 8 + drivers/spi/spi-xilinx.c | 11 ++ include/asm-generic/mm_hooks.h | 5 +- include/asm-generic/pgtable.h | 5 + include/crypto/mcryptd.h | 1 + include/linux/bio.h | 2 + include/linux/blk_types.h | 9 +- include/linux/blkdev.h | 2 +- init/main.c | 6 +- kernel/fork.c | 3 +- net/ipv6/route.c | 58 +++--- sound/core/rawmidi.c | 15 +- sound/pci/hda/patch_hdmi.c | 6 +- sound/pci/hda/patch_realtek.c | 35 +++- sound/usb/mixer.c | 27 +-- sound/usb/quirks.c | 7 +- tools/objtool/.gitignore | 2 +- tools/objtool/Makefile | 30 +-- tools/objtool/arch/x86/Build | 10 +- tools/objtool/arch/x86/decode.c | 6 +- .../objtool/arch/x86/{insn => include/asm}/inat.h | 12 +- .../arch/x86/{insn => include/asm}/inat_types.h | 0 .../objtool/arch/x86/{insn => include/asm}/insn.h | 2 +- .../objtool/{ => arch/x86/include/asm}/orc_types.h | 0 tools/objtool/arch/x86/{insn => lib}/inat.c | 2 +- tools/objtool/arch/x86/{insn => lib}/insn.c | 4 +- .../arch/x86/{insn => lib}/x86-opcode-map.txt | 15 +- .../arch/x86/{insn => tools}/gen-insn-attr-x86.awk | 0 tools/objtool/orc.h | 2 +- tools/objtool/orc_dump.c | 7 +- tools/objtool/sync-check.sh | 29 +++ .../perf/util/intel-pt-decoder/x86-opcode-map.txt | 15 +- tools/testing/selftests/x86/ldt_gdt.c | 9 +- virt/kvm/arm/mmu.c | 10 +- 108 files changed, 1292 insertions(+), 693 deletions(-)

6 years, 11 months

4
78
0 0

[Linux-stable-mirror] [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"

by Kai-Heng Feng

This reverts commit fd865802c66bc451dc515ed89360f84376ce1a56. This commit causes a regression on some QCA ROME chips. The USB device reset happens in btusb_open(), hence firmware loading gets interrupted. Furthermore, this commit stops working after commit ("a0085f2510e8976614ad8f766b209448b385492f Bluetooth: btusb: driver to enable the usb-wakeup feature"). Reset-resume quirk only gets enabled in btusb_suspend() when it's not a wakeup source. If we really want to reset the USB device, we need to do it before btusb_open(). Let's handle it in drivers/usb/core/quirks.c. Cc: stable(a)vger.kernel.org Cc: Leif Liddy <leif.linux(a)gmail.com> Cc: Matthias Kaehlcke <mka(a)chromium.org> Cc: Brian Norris <briannorris(a)chromium.org> Cc: Daniel Drake <drake(a)endlessm.com> Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- Daniel, Cc you because this also affects your original quirk patch for Realtek btusb. drivers/bluetooth/btusb.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index f7120c9eb9bd..da353c4acdc7 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3117,12 +3117,6 @@ static int btusb_probe(struct usb_interface *intf, if (id->driver_info & BTUSB_QCA_ROME) { data->setup_on_usb = btusb_setup_qca; hdev->set_bdaddr = btusb_set_bdaddr_ath3012; - - /* QCA Rome devices lose their updated firmware over suspend, - * but the USB hub doesn't notice any status change. - * Explicitly request a device reset on resume. - */ - set_bit(BTUSB_RESET_RESUME, &data->flags); } #ifdef CONFIG_BT_HCIBTUSB_RTL -- 2.14.1

6 years, 11 months

7
10
0 0

[Linux-stable-mirror] [PATCH] watchdog: imx2_wdt: restore previous timeout after suspend+resume

by Martin Kaiser

When the watchdog device is suspended, its timeout is set to the maximum value. During resume, the previously set timeout should be restored. This does not work at the moment. The suspend function calls imx2_wdt_set_timeout(wdog, IMX2_WDT_MAX_TIME); and resume reverts this by calling imx2_wdt_set_timeout(wdog, wdog->timeout); However, imx2_wdt_set_timeout() updates wdog->timeout. Therefore, wdog->timeout is set to IMX2_WDT_MAX_TIME when we enter the resume function. Fix this by setting wdog->timeout to the previous value at the end of the suspend function. This manual update makes wdog->timeout different from the actual setting in the hardware. This should be ok in our case as kernel code is not running while we're suspended. Signed-off-by: Martin Kaiser <martin(a)kaiser.cx> Cc: stable(a)vger.kernel.org --- drivers/watchdog/imx2_wdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 4874b0f..66efcc0 100644 --- a/drivers/watchdog/imx2_wdt.c +++ b/drivers/watchdog/imx2_wdt.c @@ -368,6 +368,7 @@ static int imx2_wdt_suspend(struct device *dev) { struct watchdog_device *wdog = dev_get_drvdata(dev); struct imx2_wdt_device *wdev = watchdog_get_drvdata(wdog); + unsigned int resume_timeout = wdog->timeout; /* The watchdog IP block is running */ if (imx2_wdt_is_running(wdev)) { @@ -377,6 +378,7 @@ static int imx2_wdt_suspend(struct device *dev) clk_disable_unprepare(wdev->clk); + wdog->timeout = resume_timeout; return 0; } -- 2.1.4

6 years, 11 months

2
5
0 0

[Linux-stable-mirror] [PATCH] usb: quirks: Add reset-resume quirk for QCA6174 Rome Bluetooth

by Leif Liddy

This is a rework of reverted commit fd865802c66bc451dc515ed89360f84376ce1a56 The issue is that some QCA Rome bluetooth controllers stop functioning upon resume from suspend. These devices seem to be losing power during suspend. This patch will enable reset_resume in usb core (instead of btusb) and will target the specific device 0x0cf3:0xe300 Signed-off-by: Leif Liddy <leif.linux(a)gmail.com> --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index a10b346b9777..d94e6658d054 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -248,6 +248,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* QCA Rome Bluetooth in QCA6174 wireless module */ + { USB_DEVICE(0x0cf3, 0xe300), .driver_info = USB_QUIRK_RESET_RESUME }, + { } /* terminating entry must be last */ }; -- 2.14.3

6 years, 11 months

3
2
0 0

Re: [Linux-stable-mirror] How to report regression in stable tree?

by Ian Pilcher

On 12/30/2017 04:41 PM, Ben Hutchings wrote: > For i915, I think you should either: > - open a bug at bugs.freedesktop.org (under DRI, DRM/Intel) > - mail intel-gfx(a)lists.freedesktop.org and cc stable Done. https://bugs.freedesktop.org/show_bug.cgi?id=104425 -- ======================================================================== Ian Pilcher arequipeno(a)gmail.com -------- "I grew up before Mark Zuckerberg invented friendship" -------- ========================================================================

6 years, 11 months

1
0
0 0

[Linux-stable-mirror] [PATCH 2/2] x86/dumpstack: Print registers for first stack frame

by Josh Poimboeuf

In the stack dump code, if the frame after the starting pt_regs is also a regs frame, the registers don't get printed. Fix that. Reported-by: Andy Lutomirski <luto(a)amacapital.net> Tested-by: Alexander Tsoy <alexander(a)tsoy.me> Fixes: 3b3fa11bc700 ("x86/dumpstack: Print any pt_regs found on the stack") Cc: stable(a)vger.kernel.org Signed-off-by: Josh Poimboeuf <jpoimboe(a)redhat.com> --- arch/x86/kernel/dumpstack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index e4c2c73bd99e..0c2f29e8a5a2 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -115,6 +115,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs, unwind_start(&state, task, regs, stack); stack = stack ? : get_stack_pointer(task, regs); + regs = unwind_get_entry_regs(&state, &partial); /* * Iterate through the stacks, starting with the current stack pointer. @@ -132,7 +133,7 @@ void show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs, * - hardirq stack * - entry stack */ - for (regs = NULL; stack; stack = PTR_ALIGN(stack_info.next_sp, sizeof(long))) { + for ( ; stack; stack = PTR_ALIGN(stack_info.next_sp, sizeof(long))) { const char *stack_name; if (get_stack_info(stack, task, &stack_info, &visit_mask)) { -- 2.13.6

6 years, 11 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror December 2017