Re: [PATCH net-next v5 8/8] net: pktgen: use defines for the various dec/hex number parsing digits lengths

On Thu, 13 Feb 2025 12:00:25 +0100 Peter Seiderer wrote:

Use defines for the various dec/hex number parsing digits lengths (hex32_arg/num_arg calls).

I don't understand the value of this patch, TBH.

Example:

+#define HEX_2_DIGITS 2

- len = hex32_arg(&user_buffer[i], 2, &tmp_value); + len = hex32_arg(&user_buffer[i], HEX_2_DIGITS, &tmp_value);

The word hex is already there. There is still a two. I don't think the new define has any explanatory power?

Previous 7 patches look ready indeed.