Re: [PATCH v2 3/3] selftests/resctrl: Fix non-contiguous CBM check for Hygon

Hi Fenghua,

On 12/6/2025 3:39 AM, Fenghua Yu wrote:

...

static bool arch_supports_noncont_cat(const struct resctrl_test *test)   { -    /* AMD always supports non-contiguous CBM. */ -    if (get_vendor() == ARCH_AMD) +    /* AMD and Hygon always supports non-contiguous CBM. */ +    if (get_vendor() == ARCH_AMD || get_vendor() == ARCH_HYGON)

nit. Better to avoid call get_vendor() twice (or even more in the future)?

unsigned int vendor_id = get_vendor();

if (vendor_id == ARCH_AMD || vendor_id == ARCH_HYGON)

Thank you! I will update the code as you suggested.

...

return true;     #if defined(__i386__) || defined(__x86_64__) /* arch */

Reviewed-by: Fenghua Yu fenghuay@nvidia.com

Thank you!

Thanks.

-Fenghua

Best regards, Xiaochen Shen