On Sun, Nov 16, 2025 at 05:14:04PM +0000, Andre Carvalho wrote:
/* Handle network interface device notifications */ static int netconsole_netdev_event(struct notifier_block *this, unsigned long event, void *ptr) {
- unsigned long flags;
- struct netconsole_target *nt, *tmp; struct net_device *dev = netdev_notifier_info_to_dev(ptr);
- struct netconsole_target *nt, *tmp;
- LIST_HEAD(resume_list); bool stopped = false;
- unsigned long flags;
if (!(event == NETDEV_CHANGENAME || event == NETDEV_UNREGISTER ||
event == NETDEV_RELEASE || event == NETDEV_JOIN))
event == NETDEV_RELEASE || event == NETDEV_JOIN ||event == NETDEV_UP))mutex_lock(&target_cleanup_list_lock); @@ -1475,6 +1537,11 @@ static int netconsole_netdev_event(struct notifier_block *this, stopped = true; } }
if (event == NETDEV_UP && deactivated_target_match(nt, dev))/* maybe_resume_target is IRQ unsafe, remove target from* target_list in order to resume it with IRQ enabled.*/list_move(&nt->list, &resume_list);
I've noticed the test failure in CI (test #4 in netcons-over-bonding-sh) and I'm able to reproduce it locally. I was only running 'drivers/net' and missed 'drivers/net/bonding' netconsole tests locally - will adjust my tests to always include those. They are certainly related to this changes.
Looking at logs, it seems like we re-enable the target before the interface is enslaved:
[ 28.707460] netconsole: netconsole: local port 6665 [ 28.707472] netconsole: netconsole: local IPv4 address 192.0.2.1 [ 28.707479] netconsole: netconsole: interface name 'nsim950' [ 28.707483] netconsole: netconsole: local ethernet address '00:00:00:00:00:00' [ 28.707487] netconsole: netconsole: remote port 6666 [ 28.707490] netconsole: netconsole: remote IPv4 address 192.0.2.2 [ 28.707494] netconsole: netconsole: remote ethernet address 4a:00:f1:39:50:c4 [ 28.707502] netpoll: netconsole: device nsim950 not up yet, forcing it [ 28.717516] netconsole: network logging started [ 28.740938] netconsole: network logging stopped on interface nsim950 as it is joining a master device [ 28.741034] netconsole: network logging resumed on interface nsim950 [ 28.741076] bond_tx_25: (slave nsim950): Enslaving as an active interface with an up link [ 28.752003] printk: legacy console [netcon_ext0] disabled
I'll debug some more to understand this a bit better and think how to address it. Perhaps the target needs to be DISABLED instead of DEACTIVATED when handling NETDEV_JOIN.