Thanks for catching these, I'll remember to do that the next time.
On 2023-09-27 at 15:16:18 -0700, Reinette Chatre wrote:
Hi Maciej,
On 9/22/2023 1:09 AM, Maciej Wieczor-Retman wrote:
The resctrlfs.c file defines functions that interact with the resctrl FS while resctrl_val.c file defines functions that perform measurements on the cache. Run_benchmark() fits logically into the second file before resctrl_val() function that uses it.
nitpick ... if there are comments in one patch of the series please consider if it applies to other places in the series.
Move run_benchmark() from resctrlfs.c to resctrl_val.c and remove redundant part of the kernel-doc comment. Make run_benchmark() static and remove it from the header file.
Patch series is based on [1] which is based on [2] which are based on ksefltest next branch.
ksefltest -> kselftest
Reinette