Re: [PATCH v6 02/14] riscv: sbi: remove useless parenthesis

On Thu, Apr 24, 2025 at 07:31:49PM +0200, Clément Léger wrote:

A few parenthesis in check for SBI version/extension were useless, remove them.

Signed-off-by: Clément Léger cleger@rivosinc.com

arch/riscv/kernel/sbi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c index 1989b8cade1b..1d44c35305a9 100644 --- a/arch/riscv/kernel/sbi.c +++ b/arch/riscv/kernel/sbi.c @@ -609,7 +609,7 @@ void __init sbi_init(void) } else { __sbi_rfence = __sbi_rfence_v01; }

• if ((sbi_spec_version >= sbi_mk_version(0, 3)) &&
  

• if (sbi_spec_version >= sbi_mk_version(0, 3) &&
  

  sbi_probe_extension(SBI_EXT_SRST)) { pr_info("SBI SRST extension detected\n"); pm_power_off = sbi_srst_power_off;

@@ -617,8 +617,8 @@ void __init sbi_init(void) sbi_srst_reboot_nb.priority = 192; register_restart_handler(&sbi_srst_reboot_nb); }

• if ((sbi_spec_version >= sbi_mk_version(2, 0)) &&
  

•     (sbi_probe_extension(SBI_EXT_DBCN) > 0)) {
  

• if (sbi_spec_version >= sbi_mk_version(2, 0) &&
  

•     sbi_probe_extension(SBI_EXT_DBCN) > 0) {
  pr_info("SBI DBCN extension detected\n");
  sbi_debug_console_available = true;
  

  }

-- 2.49.0

Reviewed-by: Andrew Jones ajones@ventanamicro.com