Re: [PATCH bpf-next v1 3/3] selftests/bpf: Add edge case tests for sockmap

On 2025-02-26 21:22:42, Jiayuan Chen wrote:

Add edge case tests for sockmap.

Signed-off-by: Jiayuan Chen jiayuan.chen@linux.dev

Reviewed-by: John Fastabend john.fastabend@gmail.com

.../selftests/bpf/prog_tests/sockmap_basic.c | 57> + void test_sockmap_basic(void) { if (test__start_subtest("sockmap create_update_free")) @@ -1108,4 +1163,6 @@ void test_sockmap_basic(void) test_sockmap_skb_verdict_vsock_poll(); if (test__start_subtest("sockmap vsock unconnected")) test_sockmap_vsock_unconnected();

• if (test__start_subtest("sockmap with unix and close"))

• test_sockmap_with_close_on_write(AF_UNIX, SOCK_STREAM);
  

Might also be worth running these with other types? No bug was fixed there but still testing close while writing is useful for testing RCU paths in TCP/UDP.

Fine as a follow up patch IMO.