10 Nov
2025
10 Nov
'25
5:25 p.m.
On Fri, Nov 07, 2025 at 05:55:36AM -0800, Breno Leitao wrote:
Hello Simon,
On Fri, Nov 07, 2025 at 10:07:01AM +0000, Simon Horman wrote:
On Thu, Nov 06, 2025 at 07:56:50AM -0800, Breno Leitao wrote:
function create_dynamic_target() { local FORMAT=${1:-"extended"} local NCPATH=${2:-"$NETCONS_PATH"}
- _create_dynamic_target "${FORMAT}" "${NCPATH}"
- create_and_enable_dynamic_target "${FORMAT}" "${NCPATH}"
Sorry for not noticing this when I looked over v8. It's not that important and I don't think it should block progress.
create_and_enable_dynamic_target() seems to only be used here. If so, perhaps the 'enabled' line could simply be added to create_dynamic_target() instead of creating adding create_and_enable_dynamic_target().
This is a good catch. I _think_ it is worth fixing, in fact.
I will send a v10 with this additional change.
Thanks, LGTM.