Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl

On Tue, Dec 16, 2025 at 02:26:33PM +0000, Kevin Brodsky wrote:

pagemap_ioctl always reports success, whether the tests succeeded or not. Call ksft_finished() to report the right status.

While at it also fix the exit code in unexpected situations:

This is a general sign that you should have muliple patches...

• Report FAIL if we failed to open /proc/self/pagemap (returning -EINVAL from main() is meaningless)

If you do a new version it's probably worth noting that this is a non-optional feature introduced a long time ago so the open should never fail.

Reviewed-by: Mark Brown broonie@kernel.org