On Mon, Jun 09, 2025 at 05:34:33PM +0200, Thomas Weißschuh wrote:
On 2025-06-09 16:08:56+0100, Mark Brown wrote:
+#ifndef sys_vfork
This ifndef is not necessary here. No architecture has a special version.
Ah, I was adding it defensively in case it was needed in future.
+static __attribute__((unused)) +pid_t sys_vfork(void) +{ +#ifdef __NR_vfork
For consistency: #if defined(__NR_vfork)
Are you sure? I'm seeing an awful lot of #ifdef __NR_foo instances in sys.h - it looks like the idiom is to use that unless it either needs an additional condition (with || or &&) or is an elif.