Re: [PATCH v11 6/8] iommufd/selftest: Add coverage for IOMMU_HWPT_INVALIDATE ioctl

On Wed, Jan 10, 2024 at 08:10:13PM -0800, Yi Liu wrote:

+#define test_cmd_hwpt_invalidate(hwpt_id, reqs, data_type, lreq, nreqs) \

•   ({                                                                    \
  

•           ASSERT_EQ(0,                                                  \
  

•                     _test_cmd_hwpt_invalidate(self->fd, hwpt_id, reqs,  \
  

•                                               data_type,                 \
  

•                                               lreq, nreqs));            \
  

•   })
  

+#define test_err_hwpt_invalidate(_errno, hwpt_id, reqs, data_type, lreq, \

•                            nreqs)                                    \
  

•   ({                                                                 \
  

•           EXPECT_ERRNO(_errno,                                       \
  

•                        _test_cmd_hwpt_invalidate(self->fd, hwpt_id,  \
  

•                                                  reqs, data_type,     \
  

•                                                  lreq, nreqs));      \
  

•   })
  

Nit: spaces at the end of the four lines above that have string "data_type" are all misaligned, probably because of the previous replacement of "req_type".