Re: [PATCH 08/10] KVM: x86: Remove periodic global clock updates

On 18/04/2024 20:34, David Woodhouse wrote:

From: David Woodhouse dwmw@amazon.co.uk

This effectively reverts commit 332967a3eac0 ("x86: kvm: introduce periodic global clock updates"). The periodic update was introduced to propagate NTP corrections to the guest KVM clock, when the KVM clock was based on CLOCK_MONOTONIC.

However, commit 53fafdbb8b21 ("KVM: x86: switch KVMCLOCK base to monotonic raw clock") switched to using CLOCK_MONOTONIC_RAW as the basis for the KVM clock, avoiding the NTP frequency skew altogether.

So the periodic update serves no purpose. Remove it.

Signed-off-by: David Woodhouse dwmw@amazon.co.uk

arch/x86/kvm/x86.c | 25 ------------------------- 1 file changed, 25 deletions(-)

Reviewed-by: Paul Durrant paul@xen.org