On 22 Aug 2025, at 4:20, Muhammad Usama Anjum wrote:
Enable -Wunreachable-code flag to catch dead code and fix them.
- Remove the dead code and write a comment instead:
hmm-tests.c:2033:3: warning: code will never be executed [-Wunreachable-code] perror("Should not reach this\n"); ^~~~~~
- ksft_exit_fail_msg() calls exit(). Remove the dead code.
split_huge_page_test.c:301:3: warning: code will never be executed [-Wunreachable-code] goto cleanup; ^~~~~~~~~~~~
- Remove duplicate inline.
pkey_sighandler_tests.c:44:15: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] static inline __always_inline
Reviewed-by: Sidhartha Kumar sidhartha.kumar@oracle.com Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com
Changes since v2:
- In split_huge_page_test.c, print error message and then go to cleanup tag for cleanup instead of just exiting without cleanup
tools/testing/selftests/mm/Makefile | 1 + tools/testing/selftests/mm/hmm-tests.c | 5 ++--- tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
LGTM. Reviewed-by: Zi Yan ziy@nvidia.com
-- Best Regards, Yan, Zi