Hello Maíra,
Thanks a lot for your patch.
On 6/30/22 02:46, Maíra Canal wrote:
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API.
Acked-by: Daniel Latypov dlatypov@google.com Tested-by: David Gow davidgow@google.com Co-developed-by: Arthur Grillo arthur.grillo@usp.br Signed-off-by: Arthur Grillo arthur.grillo@usp.br Signed-off-by: Maíra Canal maira.canal@usp.br
I believe the order of the tags should be chronological. That is, Daniel and David tags should be after your Co-developed-by and Signed-off-by tags.
[...]
+++ b/drivers/gpu/drm/tests/drm_damage_helper_test.c @@ -0,0 +1,634 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Test case for drm_damage_helper functions
- */
+#include <kunit/test.h>
Please add a blank line here to separate non-DRM headers include from DRM headers.
+#include <drm/drm_damage_helper.h> +#include <drm/drm_framebuffer.h> +#include <drm/drm_plane.h> +#include <drm/drm_drv.h>
I haven't looked at the KUnits tests in detail since Daniel and David already reviewed them. But from a quick glance, the tests look good to me as well.
Reviewed-by: Javier Martinez Canillas javierm@redhat.com