On 2/4/25 18:36, Jakub Kicinski wrote:
Hi!
The Cirrus tests keep failing for me when run on x86
./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64
https://netdev-3.bots.linux.dev/kunit/results/60103/stdout
It seems like new cases continue to appear and we have to keep adding them to the local ignored list. Is it possible to get these fixed or can we exclude the cirrus tests from KUNIT_ALL_TESTS?
Please report the errors so we can investigate. "tests keep failing" isn't telling me anything I need to know to be able to investigate what the problem is. They all pass for me on x86_64. I ran them a few days ago when I submitted a fix for a bug that the test had found.
Have you got the latest bugfixes?
https://lore.kernel.org/all/20250211-cs_dsp-kunit-strings-v1-1- d9bc2035d154@linutronix.de/
https://lore.kernel.org/all/174291786934.56229.8841259212687977896.b4-ty@ker...
If you haven't got the bugfixes, then it's expected that the test fails, because it's telling you there is a bug.
If you just add failures to a ignore list instead of reporting them, you might just be helping to ensure real bugs in production code don't get fixed.