21 Aug
2021
21 Aug
'21
7:12 a.m.
On Sat, 2021-08-21 at 09:47 +0300, Denis Efremov wrote:
On 8/20/21 1:17 AM, Joe Perches wrote:
And I'm not sure if this particular ERROR is that useful overall.
I find it useful to check commit-id and that it matches a title. It's easy to make a typo in commit-id and get an invalid one.
That's true, but I meant requiring the sha1 hash to contain both the word "commit" and use ("title").
Looking at checkpatch's errors produced by this GIT_COMMIT_ID test makes the required form seem a bit too inflexible to me.
For instance: a sha1 hash may be repeated in a commit message where the first instance has the correct form but the second use is just the hash and the warning is still produced.