Re: [PATCH v2] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

On Sat, Nov 28, 2020 at 9:48 AM Masahiro Yamada masahiroy@kernel.org wrote:

Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK").

A lot of warn_unused_result wearings existed in 2006, but until now they have been fixed thanks to people doing allmodconfig tests.

Our goal is to always enable __must_check where appropriate, so this CONFIG option is no longer needed.

I see a lot of defconfig (arch/*/configs/*_defconfig) files having:

# CONFIG_ENABLE_MUST_CHECK is not set

I did not touch them for now since it would be a big churn. If arch maintainers want to clean them up, please go ahead.

While I was here, I also moved __must_check to compiler_attributes.h from compiler_types.h

For the wireguard test harness change:

Acked-by: Jason A. Donenfeld Jason@zx2c4.com