Re: [PATCH 05/19] riscv: Fix extension subset checking

On Thu, Apr 11, 2024 at 09:11:11PM -0700, Charlie Jenkins wrote:

This loop is supposed to check if ext->subset_ext_ids[j] is valid, rather than if ext->subset_ext_ids[i] is valid, before setting the extension id ext->subset_ext_ids[j] in isainfo->isa.

Signed-off-by: Charlie Jenkins charlie@rivosinc.com Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypto")

Reviewed-by: Conor Dooley conor.dooley@microchip.com

Thanks, Conor.

---

arch/riscv/kernel/cpufeature.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index cd156adbeb66..5eb52d270a9a 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -617,7 +617,7 @@ static int __init riscv_fill_hwcap_from_ext_list(unsigned long *isa2hwcap) if (ext->subset_ext_size) { for (int j = 0; j < ext->subset_ext_size; j++) {

• 			if (riscv_isa_extension_check(ext->subset_ext_ids[i]))
  

• 			if (riscv_isa_extension_check(ext->subset_ext_ids[j]))
  			set_bit(ext->subset_ext_ids[j], isainfo->isa);
  	}
  }
  
  

-- 2.44.0