On Wed, Jun 20, 2018 at 08:16:44AM -0700, Dave Hansen wrote:
On 06/13/2018 05:45 PM, Ram Pai wrote:
+void test_read_of_access_disabled_region_with_page_already_mapped(int *ptr,
u16 pkey)+{
- int ptr_contents;
- dprintf1("disabling access to PKEY[%02d], doing read @ %p\n",
pkey, ptr);- ptr_contents = read_ptr(ptr);
- dprintf1("reading ptr before disabling the read : %d\n",
ptr_contents);- read_pkey_reg();
- pkey_access_deny(pkey);
- ptr_contents = read_ptr(ptr);
- dprintf1("*ptr: %d\n", ptr_contents);
- expected_pkey_fault(pkey);
+}
Looks fine to me. I'm a bit surprised we didn't do this already, which is a good thing for this patch.
FWIW, if you took patches like this and put them first, you could probably get it merged now. Yes, I know it would mean redoing some of the later code move and rename ones.
I have incorporated almost all of your comments. But there are some comments that take some effort to implement. Shall we get the patches merged in the current form? This code has been sitting out for a while.
In the current form its tested and works on powerpc and on x86, and incorporates about 95% of your suggestions. The rest I will take care as we go.