On Wed, Apr 15, 2020 at 09:44:31AM -0700, Kees Cook wrote:
On Wed, Apr 15, 2020 at 09:28:18AM -0700, Scott Branden wrote:
Hi Kees,
On 2020-04-14 8:10 p.m., Kees Cook wrote:
On Tue, Apr 14, 2020 at 05:25:17PM -0700, Scott Branden wrote:
Remove unnecessary use of test_fw_mutex in test_dev_config_show_xxx functions that show simple bool, int, and u8.
I would expect at least a READ_ONCE(), yes?
I don't understand why you need a READ_ONCE when removing a mutex around an assignment of a parameter passed into a function being assigned to a local variable.
Could you please explain your expectations.
Oops, yes, you're right. I misread and was thinking this was reading from a global. This looks fine.
Reviewed-by: Kees Cook keescook@chromium.org
Reviewed-by: Luis Chamberlain mcgrof@kernel.org
Luis