Re: [PATCH v4 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit

Quoting Alan Maguire (2019-11-15 02:16:07)

string-stream interfaces are not intended for external use; move them from include/kunit to lib/kunit accordingly.

Signed-off-by: Alan Maguire alan.maguire@oracle.com Signed-off-by: Knut Omang knut.omang@oracle.com

The sign off chain is incorrect here. Is Knut tag supposed to be Co-developed-by?

diff --git a/include/kunit/assert.h b/include/kunit/assert.h index db6a0fc..ad889b5 100644 --- a/include/kunit/assert.h +++ b/include/kunit/assert.h @@ -9,10 +9,11 @@ #ifndef _KUNIT_ASSERT_H #define _KUNIT_ASSERT_H -#include <kunit/string-stream.h> #include <linux/err.h> +#include <linux/kernel.h>

Why is this included now?

struct kunit; +struct string_stream; /**

• enum kunit_assert_type - Type of expectation/assertion.