Re: [PATCH v5 04/16] RISC-V: KVM: Allow Zimop extension for Guest/VM

On Fri, May 17, 2024 at 8:23 PM Clément Léger cleger@rivosinc.com wrote:

Extend the KVM ISA extension ONE_REG interface to allow KVM user space to detect and enable Zimop extension for Guest/VM.

Signed-off-by: Clément Léger cleger@rivosinc.com

LGTM.

Reviewed-by: Anup Patel anup@brainfault.org Acked-by: Anup Patel anup@brainfault.org

Regards, Anup

---

arch/riscv/include/uapi/asm/kvm.h | 1 + arch/riscv/kvm/vcpu_onereg.c | 2 ++ 2 files changed, 3 insertions(+)

diff --git a/arch/riscv/include/uapi/asm/kvm.h b/arch/riscv/include/uapi/asm/kvm.h index b1c503c2959c..35a12aa1953e 100644 --- a/arch/riscv/include/uapi/asm/kvm.h +++ b/arch/riscv/include/uapi/asm/kvm.h @@ -167,6 +167,7 @@ enum KVM_RISCV_ISA_EXT_ID { KVM_RISCV_ISA_EXT_ZFA, KVM_RISCV_ISA_EXT_ZTSO, KVM_RISCV_ISA_EXT_ZACAS,

•   KVM_RISCV_ISA_EXT_ZIMOP,
    KVM_RISCV_ISA_EXT_MAX,
  

};

diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c index f4a6124d25c9..c6ee763422f2 100644 --- a/arch/riscv/kvm/vcpu_onereg.c +++ b/arch/riscv/kvm/vcpu_onereg.c @@ -60,6 +60,7 @@ static const unsigned long kvm_isa_ext_arr[] = { KVM_ISA_EXT_ARR(ZIHINTNTL), KVM_ISA_EXT_ARR(ZIHINTPAUSE), KVM_ISA_EXT_ARR(ZIHPM),

•   KVM_ISA_EXT_ARR(ZIMOP),
    KVM_ISA_EXT_ARR(ZKND),
    KVM_ISA_EXT_ARR(ZKNE),
    KVM_ISA_EXT_ARR(ZKNH),
  

@@ -137,6 +138,7 @@ static bool kvm_riscv_vcpu_isa_disable_allowed(unsigned long ext) case KVM_RISCV_ISA_EXT_ZIHINTNTL: case KVM_RISCV_ISA_EXT_ZIHINTPAUSE: case KVM_RISCV_ISA_EXT_ZIHPM:

•   case KVM_RISCV_ISA_EXT_ZIMOP:
    case KVM_RISCV_ISA_EXT_ZKND:
    case KVM_RISCV_ISA_EXT_ZKNE:
    case KVM_RISCV_ISA_EXT_ZKNH:
  

-- 2.43.0