Re: [PATCH bpf-next v3 4/5] bpf: Add helpers to issue and check SYN cookies in XDP

On Thu, Feb 24, 2022 at 05:11:44PM +0200, Maxim Mikityanskiy wrote:

@@ -7798,6 +7916,14 @@ xdp_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) return &bpf_tcp_check_syncookie_proto; case BPF_FUNC_tcp_gen_syncookie: return &bpf_tcp_gen_syncookie_proto;

• case BPF_FUNC_tcp_raw_gen_syncookie_ipv4:

• return &bpf_tcp_raw_gen_syncookie_ipv4_proto;
  

• case BPF_FUNC_tcp_raw_gen_syncookie_ipv6:

• return &bpf_tcp_raw_gen_syncookie_ipv6_proto;
  

• case BPF_FUNC_tcp_raw_check_syncookie_ipv4:

• return &bpf_tcp_raw_check_syncookie_ipv4_proto;
  

• case BPF_FUNC_tcp_raw_check_syncookie_ipv6:

• return &bpf_tcp_raw_check_syncookie_ipv6_proto;
  

#endif

I understand that the main use case for new helpers is XDP specific, but why limit them to XDP? The feature looks generic and applicable to skb too.