Re: [PATCH v5 net-next 05/15] tcp: accecn: add AccECN rx byte counters

On 4/22/25 5:35 PM, chia-yu.chang@nokia-bell-labs.com wrote:

diff --git a/include/linux/tcp.h b/include/linux/tcp.h index af38fff24aa4..9cbfefd693e3 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -303,6 +303,7 @@ struct tcp_sock { u32 delivered; /* Total data packets delivered incl. rexmits */ u32 delivered_ce; /* Like the above but only ECE marked packets */ u32 received_ce; /* Like the above but for rcvd CE marked pkts */

• u32 received_ecn_bytes[3];

I'm unsure if this should belong to the fast-path area. In any case AFAICS this is the wrong location, as the fields are only written and only in the rx path, while the above chunk belongs to the tcp_sock_write_txrx group.

/P