On 9/18/24 02:58, John Stultz wrote:
On Wed, Sep 18, 2024 at 2:47 AM Khem Raj raj.khem@gmail.com wrote:
Newer 32-bit architectures e.g. riscv32 are using 64-bit time_t from get go, they have not wired __NR_clock_adjtime at all valid-adjtimex testcase fails to compile on such architectures. if this condition is found then use 64-bit adjtime syscall
No major objections here. Though I'm feeling a little forgetful as to why the test is calling the syscall directly instead of going through libc. I suspect it's likely due to the test being written prior to the libc implementation being common?
So I wonder if a better fix would be just to drop the local clock_adjtime implementation here, as I'm sure the libc has similar logic to what's being added here?
The proposed solution works better than adding local clock_adjtime implementation here.
thanks, -- Shuah