Re: [PATCH v5 6/7] misc: bcm-vk: add Broadcom VK driver

On Thu, May 07, 2020 at 05:27:38PM -0700, Scott Branden wrote:

+#if defined(CONFIG_REQ_FW_INTO_BUF_PRIV)

+#define KERNEL_PREAD_FLAG_PART 0x0001 /* Allow reading part of file */ +#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf_priv +int request_firmware_into_buf_priv(const struct firmware **firmware_p,

• 		   const char *name, struct device *device,
  

• 		   void *buf, size_t size,
  

• 		   size_t offset, unsigned int pread_flags);
  

+#else

+#define REQUEST_FIRMWARE_INTO_BUF request_firmware_into_buf

+#endif

+#endif

Please clean this up, the code must reflect only the code upstream. No config stuff like this should be used on the driver. I had to stop my review here.

Luis