On Wed, Sep 17, 2025 at 04:00:22PM +0200, Thomas Weißschuh wrote:
Upcoming changes to the generic vDSO library will mean that the vDSO datapage will not yet be usable during time_early_init().
Move the initialization to time_init() which is called later. This is valid as the value of tod_clock_base.tod does not change during the lifetime of the machine and the vDSO datapage is only used much later.
This is not true; tod_clock_base is a union and the tod member is changed implicitly within clock_sync_global():
tod_clock_base.eitod += delta;
However that happens only in stop_machine() context. Therefore moving the initialization to time_init() is indeed ok, since it is called very early when even preemption is still disabled.
I would appreciate if you would change the commit message a bit.
In any case: Acked-by: Heiko Carstens hca@linux.ibm.com