Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

On 10/11/2024 20:52, Sergey Ryazanov wrote:

On 29.10.2024 12:47, Antonio Quartulli wrote:

[...]

...

+static void ovpn_peer_release(struct ovpn_peer *peer) +{ +    ovpn_bind_reset(peer, NULL);

nit: this empty line after ovpn_bind_reset() is removed in the 'implement basic TX path (UDP)' patch. What tricks git and it produces a sensless diff with 'ovpn_bind_reset(...)' line beeing removed and then introduced again. If you do not like this empty line then remove it here, please :)

Thanks! will make sure it won't be introduced at all.

Regards,

...

+    dst_cache_destroy(&peer->dst_cache); +    netdev_put(peer->ovpn->dev, &peer->ovpn->dev_tracker); +    kfree_rcu(peer, rcu); +}

-- Sergey