Re: [PATCH] kunit: tool: misc cleanups

On Mon, May 9, 2022 at 4:49 PM Daniel Latypov dlatypov@google.com wrote:

This primarily comes from running pylint over kunit tool code and ignoring some warnings we don't care about. If we ever got a fully clean setup, we could add this to run_checks.py, but we're not there yet.

Fix things like

• Drop unused imports
• check `is None`, not `== None` (see PEP 8)
• remove redundant parens around returns
• remove redundant `else` / convert `elif` to `if` where appropriate
• rename make_arch_qemuconfig() param to base_kunitconfig (this is the name used in the subclass, and it's a better one)
• kunit_tool_test: check the exit code for SystemExit (could be 0)

Signed-off-by: Daniel Latypov dlatypov@google.com

Reviewed-by: Brendan Higgins brendanhiggins@google.com