Re: [PATCH 2/2] selftests/damon: make selftests executable

On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote:

Hello Yuanchu,

Thank you for this patch!

On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie yuanchu@google.com wrote:

...

The damon selftests do not have the executable bit on. We fix that by setting the x bits on the .sh files similar to other existing shell selftests.

Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") Signed-off-by: Yuanchu Xie yuanchu@google.com

Reviewed-by: SeongJae Park sj@kernel.org

This type of change does not work outside of git, so why not just make the tool that calls these scripts not care about the executable bit like we do for other scripts?

thanks,

greg k-h