On Tue, 30 Apr 2024 at 21:58, Scott Mayhew smayhew@redhat.com wrote:
On Sat, 23 Mar 2024, David Gow wrote:
On Thu, 21 Mar 2024 at 22:32, Scott Mayhew smayhew@redhat.com wrote:
Commit c72a870926c2 added a mutex to prevent kunit tests from running concurrently. Unfortunately that mutex gets locked during module load regardless of whether the module actually has any kunit tests. This causes a problem for kunit tests that might need to load other kernel modules (e.g. gss_krb5_test loading the camellia module).
So check to see if there are actually any tests to run before locking the kunit_run_lock mutex.
Fixes: c72a870926c2 ("kunit: add ability to run tests after boot using debugfs") Reported-by: Nico Pache npache@redhat.com Signed-off-by: Scott Mayhew smayhew@redhat.com
Thanks, this works well here, and is a good idea anyway.
Reviewed-by: David Gow davidgow@google.com
Brendan, David,
Is there a reason this patch hasn't been merged?
-Scott
Sorry: it totally slipped through the net. Thanks for the reminder, it's merged now: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/co...
Cheers, -- David