On Fri, Mar 25, 2022 at 11:27 PM David Gow davidgow@google.com wrote:
On Sat, Mar 26, 2022 at 8:20 AM Daniel Latypov dlatypov@google.com wrote:
We've split out the declarations from include/kunit/test.h into resource.h. This patch splits out the definitions as well for consistency.
A side effect of this is git blame won't properly track history by default, users need to run $ git blame -L ,1 -C13 lib/kunit/resource.c
Signed-off-by: Daniel Latypov dlatypov@google.com
Looks good and works fine here. I'm going to try to rebase most of the other resource system stuff I'm working on on top of these (which will likely end up moving a bunch of code _again_, but is probably the least terrible of all the available options).
One nitpick (newline at end of file) below, otherwise this is good.
Huh, I had thought checkpatch --strict would catch this. I guess not.
Fixing this and sending out a v3.
Reviewed-by: David Gow davidgow@google.com