On Mon, Jun 13, 2022 at 03:31:02PM -0700, Mehta, Sohil wrote:
On 6/10/2022 4:35 PM, ira.weiny@intel.com wrote:
Add command line options for debug level and number of iterations.
$ ./protection_keys_64 -h Usage: ./protection_keys_64 [-h,-d,-i <iter>] --help,-h This help --debug,-d Increase debug level for each -d
Is this mechanism (of counting d's) commonplace in other selftests as well? Looking at the test code for pkeys the debug levels run from 1-5. That feels like quite a few d's to input :)
I've seen (and used) it before yes. See ibnetdiscover.
... # Debugging flags -d raise the IB debugging level. May be used several times (-ddd or -d -d -d). ... -v increase the application verbosity level. May be used several times (-vv or -v -v -v) ... - https://linux.die.net/man/8/ibnetdiscover
But a much more mainstream example I can think of is verbosity level with lspci.
16:29:12 > lspci -h ... Display options: -v Be verbose (-vv or -vvv for higher verbosity) ...
Would it be easier to input the number in the command line directly?
Either way it would be useful to know the debug range in the help. Maybe something like: --debug,-d Increase debug level for each -d (1-5)
I'm inclined not to do this because it would encode the max debug level. On the other hand I'm not sure why there are 5 levels now. ;-)
Having the multiple options specified was an easy way to maintain the large number of levels.
Ira
The patch seems fine to me otherwise.
--iterations,-i <iter> repeate test <iter> times default: 22
Thanks, Sohil