On Thu, Jan 7, 2021 at 3:48 PM Daniel Latypov dlatypov@google.com wrote:
LinuxSourceTree will unceremoniously crash if the user doesn't call read_kunitconfig() first in a number of functions.
And currently every place we create an instance, the caller also calls create_kunitconfig() and read_kunitconfig(). Move these instead into __init__() so they can't be forgotten and to reduce copy-paste.
The https://github.com/google/pytype type-checker complained that _config wasn't initialized. With this, kunit_tool now type checks under both pytype and mypy.
Add an optional boolean that can be used to disable this for use cases in the future where we might not need/want to load the config.
Signed-off-by: Daniel Latypov dlatypov@google.com
Very nice! This makes the code much more readable!
Reviewed-by: Brendan Higgins brendanhiggins@google.com