On Thu, 3 Apr 2025 at 01:55, 'Mark Brown' via KUnit Development kunit-dev@googlegroups.com wrote:
On Wed, Apr 02, 2025 at 10:36:55AM -0700, Jakub Kicinski wrote:
The Cirrus tests keep failing for me when run on x86
./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64
You've not said what tree you're testing there but everything is fine in -next AFAICT, and there is one fix for cs_dsp on it's way to Linus at the minute specifically for KUnit.
FWIW, I can reproduce the issue in the current torvalds/master, but not in linux-next, so I assume this[1] fixed it. (Which looks at a glance like it's fixing an uninitialised variable, so that fits.)
That being said, there are a _lot_ of Cirrus FW tests (over 5000 by my count when all of the parameterised ones are taken into account), so this can still trigger the default 5-minute kunit.py timeout. And because its split up over a lot of smaller suites, it doesn't really make sense to mark all of those tests/suites as slow (though some of them might merit it). If that's causing issues for people, maybe that could be a good reason to remove them from KUNIT_ALL_TESTS, though personally, I suspect the better answer might be to move it behind a config option which can then be excluded from the default .kunitconfig if necessary, as in [2]. (Or just increase the default timeut.)
Cheers, -- David
[1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/comm... [2]: https://lore.kernel.org/linux-kselftest/20250319230539.140869-1-npache@redha...