Re: [PATCH v6 01/15] lib: Add TLV parser

Hi--

On 11/19/24 2:49 AM, Roberto Sassu wrote:

+/**

• • typedef callback - Callback after parsing TLV entry

Same as my other naming comment -- too generic. Maybe tlv_callback...

Thanks.

• • @callback_data: Opaque data to supply to the callback function
• • @field: Field identifier
• • @field_data: Field data
• • @field_len: Length of @field_data
• • This callback is invoked after a TLV entry is parsed.
• • Return: Zero on success, a negative value on error.
• */

+typedef int (*callback)(void *callback_data, __u16 field,

• 	const __u8 *field_data, __u32 field_len);