8 Apr
2022
8 Apr
'22
2:11 p.m.
On Fri 08-04-22 09:43:03, Dan Schatzberg wrote:
On Fri, Apr 08, 2022 at 04:57:40AM +0000, Yosry Ahmed wrote:
+static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf,
size_t nbytes, loff_t off)+{
- struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of));
- unsigned int nr_retries = MAX_RECLAIM_RETRIES;
- unsigned long nr_to_reclaim, nr_reclaimed = 0;
- int err;
- buf = strstrip(buf);
- err = page_counter_memparse(buf, "", &nr_to_reclaim);
Is there a reason not to support "max"? Empty string seems odd to me here.
I have to say I have missed the special meaning of the empty string here and I agree this would indeed really weird. Does cgroup core even call here? cgroup_file_write seems to drop !nbytes input.
Regarding "max" as a possible input. I am not really sure to be honest. I can imagine that it could be legit to simply reclaim all the charges (e.g. before removing the memcg) which should be achieveable by reclaiming the reported consumption. Or what exactly should be the semantic?
--
Michal Hocko
SUSE Labs